Alexandru Dima
a3099a85bc
Merge pull request #67947 from Microsoft/alex/gulp4
...
Upgrade to gulp4
2019-02-07 11:43:01 +01:00
Joao Moreno
021e796ee6
fixes #68028
2019-02-07 11:37:23 +01:00
Benjamin Pasero
b5c90cab8e
debt - increase timeout for some storage tests
2019-02-07 11:12:27 +01:00
Joao Moreno
45c7f29565
fixes #68050
2019-02-07 10:25:53 +01:00
Christof Marti
6f76a3b0fa
Strict null check 'vs/workbench/browser/parts/quickinput/*' ( fixes #68000 )
2019-02-07 10:09:10 +01:00
Johannes Rieken
8d9b6ed5ef
Merge pull request #67060 from gangachris/fix/snippet_template_type_naming
...
correct message for global and snippet templates
2019-02-07 09:59:28 +01:00
Alex Dima
f15a6faaca
Try to fix Markdown
2019-02-07 09:53:52 +01:00
Martin Aeschlimann
f7c65e6349
Merge pull request #68026 from mjbvz/getColor-ret-undefined
...
Change `ITheme.getColor` to returned `Color | undefined`
2019-02-07 09:19:30 +01:00
Benjamin Pasero
bfa8c3d00b
debt - properly disable-color-correct-rendering
2019-02-07 09:13:07 +01:00
Benjamin Pasero
e2d1fd06d1
debt - update extensions node dependency to 10.x
2019-02-07 08:49:36 +01:00
Matt Bierner
05c58615e8
Change ITheme.getColor(...) to returned Color | undefined
...
**Problem**
`ITheme.getColor` is one of the major users of the type `null` in our codebase. However this function is used in many places that expected an `undefined` type instead. With the strict null work, this means that we have to write code such as `theme.getColor(...) || undefined` in some cases or have to work with `Color | null | undefined` types.
**Fix**
`undefined` is generally better supported by TypeScript and more natural in JavaScript. This change makes `ITheme.getColor` return `Color | undefined` instead of `Color | null`.
2019-02-06 18:44:54 -08:00
Matt Bierner
ea577a79e4
Strict null check more mainThread and extHost files
2019-02-06 18:22:33 -08:00
Matt Bierner
96e13e6cbf
Unblock mainThread and extHost files from being strict null checked
2019-02-06 17:54:31 -08:00
Matt Bierner
946a8750e6
Move more sections to include globs instead of listing individual files
2019-02-06 17:54:31 -08:00
Matt Bierner
3711d0fc67
Strict null work on workbenchTestServices
...
Throw not implemented instead of returning null results for most methods
2019-02-06 17:54:31 -08:00
Matt Bierner
3f9e857483
Strict null work
2019-02-06 17:54:31 -08:00
Matt Bierner
2135dbb273
Strict null work in task.contribution
2019-02-06 17:54:31 -08:00
Matt Bierner
7ab3fd10e4
Strict null work in mockDebug
...
throw not implemented errors instead of returning null results
2019-02-06 17:54:31 -08:00
Rachel Macfarlane
e20970ce05
Some strict null checking in comments, #68012
2019-02-06 17:00:02 -08:00
Bowden Kelly
df906502ad
Merge pull request #67269 from bowdenk7/wilkelly/workspaceTagging
...
Added event for use in better workspace tagging
2019-02-06 16:46:38 -08:00
Matt Bierner
9b45cbe5ea
Trying to get rid of some cases where we use types of T | null | undefined in findWidget
2019-02-06 16:23:50 -08:00
Bowden Kelly
51ea6111d8
review feedback
2019-02-06 16:17:19 -08:00
Bowden Kelly
78fbb8d5f6
Added telemetry event to look at fileTypes and config files in project folder for use in better workspace tagging.
2019-02-06 16:17:19 -08:00
Matt Bierner
539c6cc4e1
Marking more emitters as readonly
2019-02-06 15:07:20 -08:00
Matt Bierner
3586808377
More work strict null checking workbenchTestService
2019-02-06 15:00:00 -08:00
Matt Bierner
3e246720db
Return result directly instead of assigning to var to return
2019-02-06 14:44:52 -08:00
Matt Bierner
0b2d6226b1
Strict null check work for workbenchServiceTest
2019-02-06 14:39:46 -08:00
Matt Bierner
4e05377403
Strict null work in debug
2019-02-06 14:27:00 -08:00
Matt Bierner
453c77ec21
Strict null work in workbench
2019-02-06 14:07:47 -08:00
Matt Bierner
61fc467ad7
Strict null check vs/code/**
...
Fixing errors and adding some null supressions in code/windows
2019-02-06 14:04:25 -08:00
Matt Bierner
eef33ddf1a
Strict null check quickOpen.contribution
2019-02-06 14:04:25 -08:00
Matt Bierner
6ca137730b
Extract
2019-02-06 14:04:24 -08:00
Matt Bierner
198e6a55e7
Make sure we dispose of event emitters properly
2019-02-06 14:04:24 -08:00
Matt Bierner
6b8b1b7bea
Improve naming
2019-02-06 14:04:24 -08:00
Sandeep Somavarapu
984a3a17a7
Fix #67983
2019-02-06 22:13:44 +01:00
Joao Moreno
d9f81c831c
fix datatree tests
2019-02-06 21:39:44 +01:00
Alex Dima
9dc75e92e7
Remove no longer used static method
2019-02-06 21:26:32 +01:00
Alex Dima
64c6cb2174
Update dependencies, remove workaround
2019-02-06 21:23:33 +01:00
Rob Lourens
7211af2004
#66884 - add setting to prevent shutting down the searchService
2019-02-06 10:58:40 -08:00
Pine
32b0eb569b
Merge pull request #66244 from Microsoft/octref/no-ionic-angular
...
Remove outdated ionic/angular support in HTML
2019-02-06 10:57:47 -08:00
Pine
dc5bb48efe
Merge branch 'master' into octref/no-ionic-angular
2019-02-06 10:57:08 -08:00
Joao Moreno
6d35d18ea1
fixes #67912
2019-02-06 17:46:30 +01:00
SteVen Batten
f5dacc5bf3
remove duplicate font declarations for menu ( #67942 )
...
* remove font declarations from menu.css
* remove decalarations from shell.css
2019-02-06 08:42:10 -08:00
Alex Ross
58a4013f82
Empty string task pick inputs should resolve to empty string value
...
Fixes #67927
2019-02-06 16:57:27 +01:00
Joao Moreno
4172bc6a89
fixes #67936
2019-02-06 16:36:45 +01:00
Joao Moreno
159617a378
fixes #67938
2019-02-06 16:13:34 +01:00
gangachris
aa6bae2a1a
localize snippet scope names
2019-02-06 16:03:33 +01:00
Alex Ross
da82ae40c8
Merge pull request #67921 from fadeevab/makefile-update
...
Makefile colorizing tests - handling variable expansion in a variable name
2019-02-06 15:54:55 +01:00
Alex Ross
b0b6dc6c2e
Update grammars to pick up make changes
...
and fix hashes.
2019-02-06 15:16:49 +01:00
Benjamin Pasero
13e506e5d5
debt - group extension service related things in one place
2019-02-06 12:39:41 +01:00
