Commit graph

9970 commits

Author SHA1 Message Date
Matt Bierner c38a12c26c Quote jsconfig and tsconfig in setting 2020-11-04 14:33:24 -08:00
Matt Bierner 8141dcf29a Extract adjustFoldingEnd 2020-11-04 13:19:38 -08:00
Matt Bierner 97db458fa4 Show closing ) while folding JS/TS
Fixes #109854
2020-11-04 13:19:38 -08:00
Matt Bierner 0608e3f5bd Pick up TS 4.1-rc for insiders 2020-11-04 13:19:38 -08:00
meganrogge 08e556dc5d fix #109486 and #109489 2020-11-04 10:16:06 -08:00
Alex Ross f5f4af6db3 Update C++ grammar 2020-11-04 16:57:02 +01:00
Benjamin Pasero ea84245395 Lint Sprüngli 2020-11-04 16:04:59 +01:00
Martin Aeschlimann e3a79e9e44 [css/html/json] Randomize inspect ports to avoid conflicts 2020-11-04 16:03:27 +01:00
João Moreno e5285908ca
💄 2020-11-04 15:42:40 +01:00
João Moreno 90aa30e660
Merge branch 'master' into pr/89249 2020-11-04 15:38:53 +01:00
João Moreno 4f038dba60
💄 2020-11-04 15:25:52 +01:00
João Moreno e61be087c6
Merge branch 'master' into pr/88772 2020-11-04 15:06:31 +01:00
Martin Aeschlimann 1c2005331c [json] use links for $ref, not goto definition (fixes #101474) 2020-11-03 22:30:39 +01:00
Connor Peet ab9bb823ea
debug: allow serverReadyAction to run a launch config by name
https://github.com/microsoft/vscode/issues/109931
2020-11-03 10:00:54 -08:00
Martin Aeschlimann e01e0ebe39 [theme] Git:Input Validation Subject Length - not working on Monokai Theme.Fixes #101081 2020-11-03 16:30:29 +01:00
João Moreno 7936093c33
git: merge resources should return undefined original resource
related to #109022
2020-11-03 14:33:18 +01:00
João Moreno 1703e7e71e
fix bad JSON 2020-11-03 11:06:53 +01:00
Martin Aeschlimann 183b2a2892 [themes] theme names are all not localized. Fixes #109840 2020-11-03 09:46:34 +01:00
Matt Bierner 90b17ed115 Make it easier to override markdown table stylings
Fixes #105796

This makes the markdown preview's default css for tables less specific. This should make it easier to user or extensions to override it
2020-11-02 13:53:26 -08:00
Alex Ross a5d719c570
Try new Rust grammar (#108254)
Part of #64488
2020-11-02 15:52:57 +01:00
Alex Ross bea76730f1 feat: Autodetect npm.packageManager #102050 (#102494)
Detects the preferred  package manager
and if multiple are present, warns and uses
in priority order: npm => yarn => pnpm
Fixes #102050
Co-authored-by: Alex Ross <alros@microsoft.com>
2020-11-02 14:48:11 +01:00
Johannes Rieken 0729278ad1 use label2 when CompletionEntry#source is a path inside the workspace 2020-11-02 13:22:12 +01:00
Alex Ross 04863391e9
Fix scope checking mismatch (#109665) 2020-10-29 17:05:21 -07:00
Alex Dima 7b40975fd7
Allow a resolver to provide the remote connection token 2020-10-29 21:28:04 +01:00
Raymond Zhao e94a1bd7ef Bump vscode-emmet-helper to 2.0.8 2020-10-28 17:14:33 +00:00
João Moreno d2f51a9839
fixes #108444 2020-10-28 14:21:56 +01:00
Fons van der Plas b6a02bb4e2
message "Would you like to stage all chages?" (#109272)
The old message,
```
Would you like to automatically stage all your changes and commit them directly?
```
sounds like clicking _Yes_ will do this _automatically_ from now on, which is not the case. I removed _automatically_.
2020-10-28 11:05:07 +01:00
Alex Ross 8d0ca78841 Revert "feat: Autodetect npm.packageManager #102050 (#102494)"
This reverts commit f8c0e3b612.
2020-10-27 10:07:45 +01:00
Jackson Kearl e3db76ab7f Update import 2020-10-26 19:04:26 -07:00
Jackson Kearl 74654f3c35
Use find-yarn-workspace-root over find-yarn-workspace-root2 (#109429) 2020-10-26 18:38:27 -07:00
Rachel Macfarlane 928e79f838 Verify GitHub tokens on auth provider start, fixes #108680 2020-10-26 16:01:58 -07:00
Megan Rogge 5d4df8273e
markdown smart select (#108818)
smart select
2020-10-26 15:33:48 -07:00
Martin Aeschlimann 2f22788b6c
pack emmet including the vscode-emmet-helper (#109257) 2020-10-26 10:37:18 -07:00
Martin Aeschlimann 29f2a4aa58 [html] update service 2020-10-26 18:02:24 +01:00
João Moreno f50ee04ed9 fix git submenus order
fixes #109286
2020-10-26 15:06:53 +01:00
Takanori Oishi 86e1d0744f
Git: Add tags to '...' menu (#109282)
* Git: Add tags to '...' menu
Closes #109281

* Git: Add tags to '...' menu
Closes #109281
2020-10-26 14:44:28 +01:00
Eric Amodio 16f4a29aa0 Changes URI -> Uri 2020-10-25 22:50:25 -04:00
Matt Bierner 8a5ffbb044
Mark DocumentSelector as readonly (#109212)
This change:

- Make  `DocumentSelector` use a readonly array
- Updates all properties of `DocumentFilter` to be readonly

`DocumentSelector` is used as a parameter in our provider APIs and does not need to be mutable. This change lets extensions pass in readonly values for the selector
2020-10-23 18:37:39 -07:00
Rachel Macfarlane 102e0e6d84 Handle incomplete login requests gracefully, fixes #109102 2020-10-23 09:45:50 -07:00
João Moreno c781e1f4ff
💄 2020-10-23 14:45:41 +02:00
João Moreno 42e920a18a
Merge branch 'master' into pr/108913 2020-10-23 14:32:22 +02:00
Matt Bierner dc9c7fae94 Remove readonly
This change was mistakenly checked in
2020-10-22 23:51:27 -07:00
Matt Bierner aabcbd5ef8 Also enable errors and warnings in interactive playground
For #83025
2020-10-22 22:42:55 -07:00
Matt Bierner 40fc0b1789 Enable semantic features in interactive playground
Fixes #109190
2020-10-22 22:36:08 -07:00
Matt Bierner 16075cc22a Add insertSpaceAfterOpeningAndBeforeClosingEmptyBrackets formatting setting
Fixes #109190
2020-10-22 22:36:08 -07:00
tomerstav 039f26db56 Highlight branchs upstream if defined by placing item first in picker 2020-10-23 04:36:17 +00:00
tomerstav 7b936983f6 Renamed rebaseOnto to rebase 2020-10-23 03:35:27 +00:00
João Moreno 0f1904834b
💄 2020-10-22 21:12:13 +02:00
João Moreno 990c0284db
Merge branch 'master' into pr/109133 2020-10-22 21:03:56 +02:00
Alex Dima 3725ff44d5
Fixes #109131: Do not fail if an undo stop is inserted in between the two consecutive edits 2020-10-22 09:59:35 +02:00
Jordan Bayles 3082f63523 Add Git: Clone Recursively option
This patch adds a new command, Git: Clone Recursively, that adds the
--recursive option to git clone in order to also check out git
submodules.

Bug: 108381
2020-10-21 23:05:48 -07:00
João Moreno a27961d843
git: improve status bar message 2020-10-21 16:37:49 +02:00
Alex Ross 0b148e83db Provide command to get package manager
Fixes #109071
2020-10-21 15:27:18 +02:00
Matt Bierner 37c63d6ae5 Don't show loading and project loading status for in-memory JS/TS files
Fixes #108454
2020-10-19 17:18:49 -07:00
tomerstav 5a76fea0a8 Rewrote logic 2020-10-19 23:24:48 +00:00
Raymond Zhao d10e2fc0e6 Use new helper extractAbbreviation function 2020-10-19 11:27:17 -07:00
Raymond Zhao 0c50806e8c Refactor Emmet abbrevationAction files 2020-10-19 11:27:16 -07:00
Christof Marti bfe35d4427 Settings copied only once (microsoft/vscode-remote-release#484) 2020-10-19 17:50:43 +02:00
Christof Marti dbc90498b4 Add hint (fixes microsoft/vscode-remote-release#486) 2020-10-19 17:50:43 +02:00
Ladislau Szomoru e1692b33b1
Abort rebase command polish (#108919)
* Abort rebase command polish
2020-10-19 10:59:36 +02:00
Martin Aeschlimann 845d014429 [scss] Normalise SCSS attributes with CSS/LESS/SASS. Fixes #108840 2020-10-19 09:55:57 +02:00
tomerstav 741925db11 Implemented rebase onto 2020-10-19 04:13:52 +00:00
Rachel Macfarlane 74ef0a92fe Update callback url for ms authentication when not using local server 2020-10-17 09:45:19 -07:00
Matt Bierner dd124a5cae Cleaning up code
- Use more explicit names
- extract
- Use `??`
2020-10-16 17:18:44 -07:00
Raymond Zhao fbc4c87523 Bump vscode emmet helper to 2.0.5 2020-10-16 10:42:36 -07:00
João Moreno b9115b8b9c
fixes #108714 2020-10-16 16:58:25 +02:00
Andrey Sinitsyn b71ede64c1
fix(git): fatal when adding, reverting files or cleaning repo on win32 (#108691)
Fixes issue #108690
2020-10-16 15:26:15 +02:00
Martin Aeschlimann 0211038211 [json] increase rangeFormatting editLimit to 10000 (for #97138) 2020-10-15 15:37:51 +02:00
Raymond Zhao f87d1f4609 Add force refresh case for #108670 2020-10-14 14:07:40 -07:00
Martin Aeschlimann 59f4562c66 [json] update service. Fixes #97843 2020-10-14 22:20:05 +02:00
Raymond Zhao 0fc17285e1 Update Emmet on save of snippets file #108670 2020-10-14 12:32:20 -07:00
Matt Bierner f564bbd517 Restore injection grammar for multiline jsdoc types
For #108237

This only fixes the basic case of making sure multiline types in jsdoc do not capture the leading `*`
2020-10-13 16:51:58 -07:00
Raymond Zhao 2dbd0ae6a4 Bump vscode-emmet-helper to 2.0.4 2020-10-13 15:10:55 -07:00
Martin Aeschlimann 01eb77a598 [html] update services (for #108016) 2020-10-13 21:52:25 +02:00
Raymond Zhao 197b9ffeb4 Update vscode-emmet-helper to fix #104962 2020-10-13 09:42:52 -07:00
Martin Aeschlimann 8d29dde51c package.json dependency completion: npm command not used on windows. Fixes #108605 2020-10-13 17:05:57 +02:00
Martin Aeschlimann 362da0a14d [css] update service 2020-10-13 16:55:48 +02:00
Martin Aeschlimann 42ddf0fd65 fix isValidNPMName 2020-10-13 09:57:28 +02:00
Eric Amodio 0ac9d25b81 Closes #91695 - adds emoji support 2020-10-12 14:38:07 -04:00
Rachel Macfarlane 31419adc34 Polish onDidChangePassword changes 2020-10-12 10:31:16 -07:00
Eric Amodio 9910c38005 Fixes #108530 2020-10-12 11:08:13 -04:00
Martin Aeschlimann 588b6cc57d update seti theme (fixes https://github.com/microsoft/vscode/issues/108185) 2020-10-12 15:34:05 +02:00
Alex Ross 5742413347 Fix preffered pm when pm can't be determined 2020-10-12 15:25:05 +02:00
Martin Aeschlimann 0dfa897c22 JSON Language Server 1.3.1 2020-10-12 13:25:05 +02:00
Martin Aeschlimann 256d3ad405 vscode-json-languageserver crashes on start: Cannot find module '../out/jsonServerMain' . Fixes #107949 2020-10-12 13:25:05 +02:00
João Moreno 47116a8acd fixes #108371 2020-10-12 11:04:30 +02:00
Rachel Macfarlane 4c0811c9c2 Removing polling from auth extensions, fixes #107480 2020-10-09 16:33:53 -07:00
Sebastian Andil 6f4409deae
Fix typo (#108329) 2020-10-09 16:28:58 +02:00
João Moreno 7cb2f56439
more uppercase
fixes #108348
2020-10-09 16:24:11 +02:00
Shivang Tripathi f8c0e3b612
feat: Autodetect npm.packageManager #102050 (#102494)
Detects the preferred  package manager
and if multiple are present, warns and uses
in priority order: npm => yarn => pnpm
Fixes #102050
Co-authored-by: Alex Ross <alros@microsoft.com>
2020-10-09 11:01:47 +02:00
Eric Amodio d8b1776ccb Closes #97407, #93405 2020-10-09 02:31:48 -04:00
Nafana df59ceb026
Markdown reference links starting with ^ should not be clickable (#108015)
Co-authored-by: mmacovei <mmacovei@sfu.ca>
2020-10-08 00:38:17 -06:00
Eric Amodio 937b30edf2 Fixes #100610 2020-10-07 16:00:07 -04:00
Miguel Solorio 83ecd5b6e1
Update default color tokens for last pinned tab border (#108207) 2020-10-07 07:59:01 +02:00
Benjamin Pasero 13ccfeb2cd test - check for dirty flag too (#107739) 2020-10-07 07:53:09 +02:00
Rachel Macfarlane 64d64c70ff Check token scopes for manually provided tokens 2020-10-06 16:16:57 -07:00
Rachel Macfarlane dafce599a6
Add getPassword, setPassword, and deletePassword APIs, #95475
Co-authored-by: SteVen Batten <sbatten@microsoft.com>
2020-10-06 14:57:16 -07:00
Alex Dima 1a9e0af641
Fixes #107815: Remove save RenameOperation 2020-10-06 22:53:57 +02:00
Alex Dima ca01c69720
Finalize test for #107739 2020-10-06 22:45:46 +02:00
Alex Dima 443508c4c9
Add test for #107739 2020-10-06 22:18:30 +02:00
Peng Lyu 2d6d4a328a
Merge pull request #108144 from microsoft/rebornix/notebookEditorDebt
Move acitve/visible notebook editors to window namespace.
2020-10-06 12:52:03 -07:00
rebornix 9ba85c3d66 💄 2020-10-06 11:18:52 -07:00
rebornix ac85c3ca2c fix notebook extension compile errors. 2020-10-06 11:06:12 -07:00
Alex Ross 8d2621e952 Update grammars 2020-10-06 11:20:42 +02:00
Benjamin Pasero cc594b88d8 themes - add last pinned tab color to default themes 2020-10-06 07:59:56 +02:00
Jackson Kearl f88b86d714 vscode.Uri.joinPath instead of Node's path.join
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/1280
2020-10-05 08:52:44 -07:00
Connor Peet 916de64d89
fix: debug buttons in a nested package.json
Fixes #108000
2020-10-02 14:17:17 -07:00
Martin Aeschlimann 7c91cee267
Merge branch 'master' into bugfix/fix_CVE-2020-16881_bypass 2020-10-02 17:05:36 +02:00
Rares Folea 247e5dc148
Fix typo extensions/search-result/README.md (#107961) 2020-10-02 07:42:47 -07:00
Hung-Wei Hung 02cfa0b9a8 Create empty commit with changed files #107753 2020-10-02 16:37:01 +08:00
Martin Aeschlimann cc2a8dc177 JSON Language Server 1.3.0 2020-10-02 09:43:16 +02:00
Justin Steven e8ceafb07a
Fix a bypass for CVE-2020-16881
Fixes #107951

Uses child_process.execFile() rather than child_process.exec() to more
effectively resolve the command injection vulnerability.
2020-10-02 17:21:51 +10:00
anoyes b9b6241354 Merge remote-tracking branch 'upstream/master'
Merging bug fix with original VSCode repo
2020-10-01 14:36:32 -06:00
anoyes ff2a9a476e Fixed issue 104346 2020-10-01 14:31:07 -06:00
Martin Aeschlimann 1b960248d6 document ISchemaAssociation.schema 2020-10-01 21:08:26 +02:00
olegoid f19ccd13c2 Made id_token optional in ITokenResponse
According to:
https://docs.microsoft.com/en-us/azure/active-directory/develop/v2-oauth2-auth-code-flow#successful-response-1
2020-10-01 21:01:29 +02:00
olegoid c98463a24c Add support for opaque AAD access tokens 2020-10-01 21:01:29 +02:00
Connor Peet c17be01663
debug: recover gracefully from a stuck auto attach pipe 2020-09-30 16:33:06 -07:00
Alex Dima 296147c88e
Fix integration tests 2020-09-30 20:58:26 +02:00
gjsjohnmurray ceeb974856 Wire up preconditions for viewsWelcome buttons, and use it 2020-09-30 13:01:46 +01:00
Martin Aeschlimann 7c9a6e92c7 test-resolver fix prepublish 2020-09-30 13:46:48 +02:00
Cameron Little 7cf15b2d31 Fix crash in LSP servers when initializationOptions are not provided 2020-09-30 09:01:49 +02:00
gjsjohnmurray af4fb00687 Initial 'Git extension is activating...' in SCM view 2020-09-30 06:49:32 +01:00
Matt Bierner 706857dfa5 Pass executingFilePath to TS server 2020-09-29 17:59:29 -07:00
Matt Bierner 6ef40a891b Disable TS plugins on web 2020-09-29 17:59:29 -07:00
Matt Bierner ee536909df Enable logging for TS Server on web
The web server does not have a log file
2020-09-29 17:59:29 -07:00
gjsjohnmurray 4e00a9b1a5 fix #106487 Contribute an "activating" placeholder message and button 2020-09-29 15:23:07 +01:00
Martin Aeschlimann 2ef6c258b0
Merge pull request #107215 from microsoft/aeschli/welcomeViewGroups
groups for viewsWelcome
2020-09-28 14:10:06 -07:00
João Moreno 0f540688f4
Merge branch 'pr/107318' 2020-09-28 16:33:45 +02:00
João Moreno 5a18ae699c
💄 2020-09-28 16:33:29 +02:00
Johannes Rieken 6a9500f040 Merge branch 'master' into joh/cell-output 2020-09-28 09:08:53 +02:00
Michael Wood b8c953da4b
Merge branch 'master' into 99129-theme-colour-git-staged 2020-09-28 08:02:47 +02:00
Matt Bierner f1e631ab83 Update ts server web build 2020-09-25 16:22:05 -07:00
Johannes Rieken 1e7454f72a renames 2020-09-25 18:04:10 +02:00
Johannes Rieken 08695ede81 adopt changes after feedback round one 2020-09-25 18:00:11 +02:00
Johannes Rieken 611bbad868 Merge branch 'master' into joh/cell-output 2020-09-25 17:44:13 +02:00
Johannes Rieken b241d4cd1f fix typo, https://github.com/microsoft/vscode/issues/54938 2020-09-25 16:26:52 +02:00
Johannes Rieken 0a914e0e61 remove priority all togther, maybe add something like severity in the future, https://github.com/microsoft/vscode/issues/54938 2020-09-25 16:13:26 +02:00
Johannes Rieken 8932f62afa adress API feedback https://github.com/microsoft/vscode/issues/54938 2020-09-25 16:13:26 +02:00
Johannes Rieken b297be52ca new proposal for NotebookCellOutput, partial implementation 2020-09-25 11:44:23 +02:00
Martin Aeschlimann 80718e85da Merge branch 'master' into aeschli/welcomeViewGroups 2020-09-24 14:12:27 +02:00
Rob Lourens 0405841876 Tweak coloring and spacing in new settings editor #106897 2020-09-23 17:28:04 -05:00
Jackson Kearl d4ae4a64ec Enable search editor in non-HOME envs 2020-09-23 11:36:35 -07:00
michaelwood@onetrail.com 536652aab5 added additional colour options for differing git staging statuses 2020-09-23 20:31:30 +02:00
rebornix 71630dd5ff Revert "disable failing notebook tests, https://github.com/microsoft/vscode/issues/107210"
This reverts commit 6f41bfa822.
2020-09-22 08:46:43 -07:00
Martin Aeschlimann 99c8d615c1 groups for viewsWelcome 2020-09-22 12:04:53 +02:00
Johannes Rieken 6f41bfa822 disable failing notebook tests, https://github.com/microsoft/vscode/issues/107210 2020-09-22 11:17:34 +02:00
Matt Bierner 5a7d0a1ed2 Adopt resolveCodeAction for JS/TS refactorings 2020-09-18 18:17:31 -07:00
Matt Bierner 5b4350943e Remove custom typings for refactor trigger reason
This property has been finalized
2020-09-18 18:17:31 -07:00
Matt Bierner b255097c33 null -> undefined 2020-09-18 18:17:31 -07:00
Matt Bierner bd54e5f5cc Simplify showQuickPick 2020-09-18 18:17:31 -07:00
Matt Bierner 84dbc21783 Pick up TS 4.0.3 2020-09-18 16:36:13 -07:00
Matt Bierner f26d81979f Extend disposable 2020-09-18 16:27:21 -07:00
Matt Bierner f8f2538d20 Move exists to own file 2020-09-18 16:26:04 -07:00
Matt Bierner c3651027ba Use enum 2020-09-18 16:23:49 -07:00
Matt Bierner 017a42552b Use Promise.all to perform config finding in parallel instead of sequentially
For #87494
2020-09-18 16:15:50 -07:00
Matt Bierner bf2448549d Make getTsConfigsInWorkspace observe the TaskProvider cancellation 2020-09-18 16:15:50 -07:00
Matt Bierner d1510288f0 Add timeout for vscode.workspace.findFiles
For #87494
2020-09-18 16:15:50 -07:00
Matt Bierner 6932306e4d Add (get) and (set) prefixes to JS/TS getters and setters in the outline
Fixes #106935
2020-09-18 11:06:32 -07:00
Rachel Macfarlane 403a6895f4 #106321, Don't retry token refresh if the response was not ok 2020-09-17 19:39:09 -07:00
Martin Aeschlimann b03e0cb72f revert line deletion in json CONTRIBUTING 2020-09-17 13:06:17 +02:00
ChaseKnowlden 8c91bd8278 Fix Unnecessary change 2020-09-17 11:43:03 +02:00
ChaseKnowlden e8760a5d6c Fix capitalization of GitHub org 2020-09-17 11:43:03 +02:00
Alex Ross 66c63c5d70 Update npm tasks when npm refresh is run
Fixes #106780
2020-09-17 11:30:24 +02:00
Matt Bierner d19c4ec92c Fix TS 4.1 error 2020-09-16 19:58:09 -07:00
Connor Peet 923189c75a
Merge branch 'connor4312/auto-attach-js-debug' 2020-09-16 15:41:22 -07:00
Rachel Macfarlane 2e10ab2a95 Possibly improve logging on token refresh fail 2020-09-16 15:39:43 -07:00
Connor Peet 480b18a8d3
debug: apply polish to auto attach switcher 2020-09-16 15:36:14 -07:00
Matt Bierner 4799714403 Remove extra awaits
These functions return void so we don't need to await them
2020-09-16 15:11:21 -07:00
Matt Bierner 50cc1d0e97 Update to use TS 4.1 for building VS Code 2020-09-16 11:58:01 -07:00
Matt Bierner d1b49cd8b9 Adding more explicit typings for TS 4.1 new Promise logic 2020-09-16 11:58:01 -07:00
Matt Bierner 240afbde58 Use array.equals 2020-09-16 11:58:01 -07:00
Martin Aeschlimann 78bad9989e
Merge pull request #106813 from joshbolduc/jenkinsfile-groovy
Detect Jenkinsfile as groovy
2020-09-16 06:42:29 -07:00
Alex Ross 032e9a33ba Update go grammar and fix update script
Fixes #106798
2020-09-16 15:24:28 +02:00
Nicholas Rayburn 1562816430
Replace 'master' with branch head when publishing to github (#105878) 2020-09-16 11:02:03 +02:00
Martin Aeschlimann 795b0dba8d [css/json/html] update service (use vscode-nls@5.0) 2020-09-16 10:32:40 +02:00
MoQ93 17cdb69891
Allow empty tag message in git (#106751) 2020-09-16 10:22:19 +02:00
joshbolduc 19ba387b58
Detect Jenkinsfile as groovy
Fixes #106812
2020-09-15 21:31:36 -04:00
Johannes Rieken f096f59404 refine test for https://github.com/microsoft/vscode/issues/106657 and document issue with fragments and the editor opener 2020-09-14 16:58:37 +02:00
Johannes Rieken a6ae00a384 add regression test for https://github.com/microsoft/vscode/issues/106657 2020-09-14 16:42:56 +02:00
Johannes Rieken b9291026a6 adopt notebook integration tests, https://github.com/microsoft/vscode/issues/105283 2020-09-14 10:23:53 +02:00
Connor Peet cda3fbe7f8
debug: use only js-debug auto attach, collapse settings
This PR removes the hook in node-debug's auto attach, and uses only
js-debug auto attach. As referenced in the linked issues, this involves
removing `debug.javascript.usePreviewAutoAttach` and collapsing
`debug.node.autoAttach` into `debug.javascript.autoAttachFilter`. The
latter option gains a new state: `disabled`. Since there's no runtime
cost to having auto attach around, there is now no distinct off versus
disabled state.

The status bar item and the `Debug: Toggle Auto Attach` command now
open a quickpick, which looks like this:

![](https://memes.peet.io/img/20-09-9d2b6c0a-8b3f-4481-b2df-0753c54ee02b.png)

The current setting value is selected in the quickpick. If there is a
workspace setting for auto attach, the quickpick toggle the setting
there by default. Otherwise (as in the image) it will target the user
settings. The targeting is more explicit and defaults to the user
instead of the workspace, which should help reduce confusion (#97087).
Selecting the "scope change" item will reopen the quickpick in that
location.

Aside from the extra options for the `disabled` state in js-debug's
contributions, there's no changes required to it or its interaction
with debug-auto-launch.

Side note: I really wanted a separator between the states and the
scope change item, but this is not possible from an extension #74967.

Fixes https://github.com/microsoft/vscode/issues/105883
Fixes https://github.com/microsoft/vscode-js-debug/issues/732 (the rest of it)
Fixes https://github.com/microsoft/vscode/issues/105963
Fixes https://github.com/microsoft/vscode/issues/97087
2020-09-11 16:33:06 -07:00
Oleg Demchenko 352a390251
Add preferred_username to the list of msft token claims (#106511) 2020-09-11 12:38:03 -07:00
Martin Aeschlimann 2309414153
Merge branch 'master' into dependabot/npm_and_yarn/extensions/css-language-features/server/yargs-parser-13.1.2 2020-09-11 01:16:24 -07:00
Jason Wang 3cc907a220
Fix return 2020-09-10 14:02:42 -07:00
rebornix b37c4b08e9 re #105735. batch apply edits. 2020-09-10 14:02:16 -07:00
Matt Bierner eba1cc8de3 Remove arrays.findIndex
For #103454

This should be a direct map to the `.findIndex` mathod
2020-09-10 10:22:08 -07:00
dependabot[bot] 9d87cd68ea
Bump yargs-parser in /extensions/css-language-features/server
Bumps [yargs-parser](https://github.com/yargs/yargs-parser) from 13.1.1 to 13.1.2.
- [Release notes](https://github.com/yargs/yargs-parser/releases)
- [Changelog](https://github.com/yargs/yargs-parser/blob/master/docs/CHANGELOG-full.md)
- [Commits](https://github.com/yargs/yargs-parser/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-10 16:34:59 +00:00
dependabot[bot] a9a7cf18f3
Bump yargs-parser in /extensions/markdown-language-features (#106373)
Bumps [yargs-parser](https://github.com/yargs/yargs-parser) from 13.1.1 to 13.1.2.
- [Release notes](https://github.com/yargs/yargs-parser/releases)
- [Changelog](https://github.com/yargs/yargs-parser/blob/master/docs/CHANGELOG-full.md)
- [Commits](https://github.com/yargs/yargs-parser/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-09-10 09:34:00 -07:00
Johannes Rieken 7fdda46e16 some integration tests for notebook editing, https://github.com/microsoft/vscode/issues/105283 2020-09-10 18:21:24 +02:00
WhizSid c334da1952
Multi git executable paths (#85954)
* Multi git executable path

* update `git.path` setting description

* 💄

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
2020-09-10 15:02:37 +02:00
Vyacheslav Pukhanov 663810e275
Adds commands for --no-verify commit variants (#106335)
* add `{allow,confirm}NoVerifyCommit`  options

* adds commit comands with no verify

* handles no verify command variants

* handle no verify commit option

* only display no verify variants when option is set
2020-09-10 11:14:28 +02:00
Benjamin Pasero 82d953a731 pinned tabs - add a tab.lastPinnedBorder color 2020-09-10 10:51:31 +02:00
rebornix 03960a5aa1 re #105735. no more udpateMetadata api. 2020-09-09 16:45:00 -07:00
rebornix 73a3c9ded3 re #105735. 2020-09-09 16:45:00 -07:00
Jason Wang 3890d7fba9
Formatting 2020-09-09 14:31:22 -07:00
Jason Wang 22ca0c1e8a
Add providerName option to git.api.getRemoteSources 2020-09-09 14:09:04 -07:00
Daniel Imms 6821292b4b Fix ts 4.1 issues in terminal api tests 2020-09-09 12:43:25 -07:00
rebornix deaf9f2689 💂 polish nb tests. 2020-09-09 12:04:20 -07:00
Matt Bierner 2a954244f0 Only allow configurePlugin against main TS Server
Fixes #106346

Looks like the TS Server doesn't support this in partial mode at the moment
2020-09-09 09:21:56 -07:00
João Moreno f41efe546c
Merge branch 'master' into pr/85074 2020-09-09 16:35:26 +02:00
João Moreno d9d314e8c6
Update extensions/git/src/commands.ts 2020-09-09 16:30:24 +02:00
João Moreno bec65e80de
Update extensions/git/src/commands.ts 2020-09-09 16:30:18 +02:00
João Moreno 9ff783bdd6
Update extensions/git/src/commands.ts 2020-09-09 16:29:53 +02:00
Vyacheslav Pukhanov 7792c61393
Update gitignore decorations when .git/info/exclude file is edited (#106270)
* detect local `exclude` file edits

* use `uri.path` to detect exclude file edits

`uri.path` uses forward slash as a path separator indepentent of
the host system, which makes it easier to use with regex
2020-09-09 09:37:56 +02:00
Jean Pierre a6833ed841
proper fix for #105202 (#106293) 2020-09-08 14:46:43 -07:00
Matt Bierner e969bc18a1 Disable errors in non-semantic supported files
Fixes #106299
Fixes #106314

Also enables js/ts features on the right side of PRs and in search results
2020-09-08 14:39:58 -07:00
Connor Peet 76e45c2b69
debug: make serverReadyAction play nicely with js-debug
Fixes https://github.com/microsoft/vscode/issues/86035
Fixes https://github.com/microsoft/vscode-js-debug/issues/440
2020-09-08 11:54:31 -07:00
Christof Marti fc4163ea01 Add loginShell (microsoft/vscode-remote-release#3593) 2020-09-08 16:32:04 +02:00
Martin Aeschlimann 849acd83eb Treat SConstruct/SConscript files as python automatically. Fixes #105623 2020-09-08 14:33:06 +02:00
Martin Aeschlimann c255e914cd [bat] change comment token to @rem. Fixes #105896 2020-09-08 14:31:00 +02:00
NicolasVuillamy 1dab4e6979 Add .nf file extension for groovy files 2020-09-08 14:11:03 +02:00
João Moreno 82aa8fc425
better git and github docs 2020-09-08 09:55:07 +02:00
Alex Ross 5cd1eff604 Update grammars 2020-09-07 16:47:30 +02:00
João Moreno d93e07f5d4
Merge pull request #104339 from amazingcaio/master
associate *.c++ & *.h++ files with c++
2020-09-07 15:05:20 +02:00
Martin Aeschlimann f0dea5ec85 improvements 2020-09-07 10:09:15 +02:00
Rafał Chłodnicki 896dc31762 [json-language-features] Fix json/schemaAssociations parameters documentation
The `json/schemaAssociations` documentation is not accurate in stating
that the only supported parameter is an object in `{ pattern: uri }`
format. It also supports the structure defined by `SchemaConfiguration`
interface from "vscode-json-languageservice".

Also updated the server code to match that.

Resolves #106060
2020-09-03 19:57:02 +02:00
Sandeep Somavarapu 23c359da9c Fix #105414 2020-09-03 17:26:59 +02:00
João Moreno f06943f3cd
fixes #105708 2020-09-03 11:27:42 +02:00
Nicolas Vuillamy 602baedf1c
Add .nf extension to Groovy file extensions
Closes #106017 : https://github.com/microsoft/vscode/issues/106017
2020-09-03 10:25:57 +02:00
Martin Aeschlimann 8aa9dbc29b Rename on Type: linked edit mode is terminated when the tag becomes empty. Fixes #105860 2020-09-02 23:20:10 +02:00
Rachel Macfarlane 8eb9cdaba9 Fix #105955, make sure auth provider registration completes when getSession is called 2020-09-02 11:51:59 -07:00
Matt Bierner 3dc43cb7b3 Exclude pr schemed files from js/ts language features
Fixes #105842
2020-09-02 10:36:24 -07:00
João Moreno ab8a3f3c44
fixes #105129 2020-09-02 14:42:16 +02:00
Rachel Macfarlane c7c6c5cde1 Fix #105503 2020-09-01 17:31:05 -07:00
Matt Bierner b8e4718a12 Disable js/ts features for the private scheme
This scheme is used internally by VS Code for features such as search/replace preview
2020-09-01 15:07:05 -07:00
Matt Bierner e6b0f45556 Use containerName if it exists 2020-09-01 14:10:15 -07:00
Matt Bierner 5e9a412cd9 Remove experimental typings
These typings are now in TS 4.0
2020-09-01 14:02:58 -07:00
Connor Peet fef3e22ca7
fix: refresh env vars when auto attach settings change
Fixes https://github.com/microsoft/vscode-js-debug/issues/731
2020-09-01 08:54:50 -07:00
Pranav Senthilnathan fb80351278
prune the refactor not applicable reasons if there are too many (#103203)
* prune the refactor not applicable reasons if there are too many

* Add in appendInvalidActions for older TS versions

Co-authored-by: Matt Bierner <matb@microsoft.com>
2020-08-31 15:37:02 -07:00
Jean Pierre 8b1aca7255
Fixes #105202 (#105664) 2020-08-31 14:54:51 -07:00
Martin Aeschlimann 1cf826c7f6
Merge branch 'master' into master 2020-08-31 13:32:36 -07:00
Martin Aeschlimann bdcf7e10cd update seti theme 2020-08-31 22:25:47 +02:00
Martin Aeschlimann 9b6d13d298 update services 2020-08-31 22:18:06 +02:00
rebornix d3cfbddde1 fix tests. 2020-08-31 12:16:35 -07:00
Martin Aeschlimann 747d667946 add file associations for ".c++" and ".h++" file extensions. Fixes #104320 2020-08-31 20:09:27 +02:00
João Moreno b6071d2204
Merge pull request #105228 from marvinruder/master
Changed description of “Commit Signing” configuration label to include X.509.
2020-08-31 16:52:42 +02:00
Christof Marti d08e158b8d Investigate #104554 2020-08-31 16:30:58 +02:00
João Moreno 6aafc4b7aa
fixes #104762 2020-08-31 15:21:15 +02:00
Johannes Rieken f1e7a02f8a
Merge pull request #105585 from microsoft/joh/useExtUri
Use extensionUri and joinPath instead of asAbsolutePath
2020-08-31 09:51:28 +02:00
Johannes Rieken 807eb37826 make sure replaceOutput updates the extension host side, update tests https://github.com/microsoft/vscode/issues/105283 2020-08-28 17:59:10 +02:00
Johannes Rieken a3f414cf5a add some integration tests for notebook editing, https://github.com/microsoft/vscode/issues/105283 2020-08-28 17:59:10 +02:00
Sandeep Somavarapu a8603d43ac Fix #102823 2020-08-28 16:40:55 +02:00
Johannes Rieken 5b8aeeb1f0 copy paste is hard... 2020-08-28 15:00:52 +02:00
Johannes Rieken bc3b0defe0 use extensionUri and joinPath instead of asAbsolutePath 2020-08-28 14:57:20 +02:00
Rachel Macfarlane 650197b991 Add authentication contribution point, #103507 2020-08-27 11:51:18 -07:00
rebornix 883749806b support revert notebook cell metadata in diff view. 2020-08-27 11:26:01 -07:00
Alex Ross 0de8d51904 Finalize task detail API
Fixes #69785
2020-08-27 11:08:48 +02:00
Rachel Macfarlane a6103e8faa Fix Buffer reference in browser for ms auth 2020-08-26 15:20:45 -07:00
Rachel Macfarlane 8871a28963 Make github-authentication a UI extension again 2020-08-26 09:01:42 -07:00