Connor Peet
cda3fbe7f8
debug: use only js-debug auto attach, collapse settings
...
This PR removes the hook in node-debug's auto attach, and uses only
js-debug auto attach. As referenced in the linked issues, this involves
removing `debug.javascript.usePreviewAutoAttach` and collapsing
`debug.node.autoAttach` into `debug.javascript.autoAttachFilter`. The
latter option gains a new state: `disabled`. Since there's no runtime
cost to having auto attach around, there is now no distinct off versus
disabled state.
The status bar item and the `Debug: Toggle Auto Attach` command now
open a quickpick, which looks like this:
![](https://memes.peet.io/img/20-09-9d2b6c0a-8b3f-4481-b2df-0753c54ee02b.png )
The current setting value is selected in the quickpick. If there is a
workspace setting for auto attach, the quickpick toggle the setting
there by default. Otherwise (as in the image) it will target the user
settings. The targeting is more explicit and defaults to the user
instead of the workspace, which should help reduce confusion (#97087 ).
Selecting the "scope change" item will reopen the quickpick in that
location.
Aside from the extra options for the `disabled` state in js-debug's
contributions, there's no changes required to it or its interaction
with debug-auto-launch.
Side note: I really wanted a separator between the states and the
scope change item, but this is not possible from an extension #74967 .
Fixes https://github.com/microsoft/vscode/issues/105883
Fixes https://github.com/microsoft/vscode-js-debug/issues/732 (the rest of it)
Fixes https://github.com/microsoft/vscode/issues/105963
Fixes https://github.com/microsoft/vscode/issues/97087
2020-09-11 16:33:06 -07:00
Connor Peet
122fc9a1b8
debug: update js-debug
2020-09-11 12:54:43 -07:00
Oleg Demchenko
352a390251
Add preferred_username to the list of msft token claims ( #106511 )
2020-09-11 12:38:03 -07:00
rebornix
c53524a198
cell language should not be freezed.
2020-09-11 11:59:36 -07:00
rebornix
59dcc5c912
notebook document data loss.
2020-09-11 10:57:47 -07:00
Rachel Macfarlane
07ad5d6f18
Remove unused 'SettingSearch' issue type
2020-09-11 10:21:13 -07:00
Miguel Solorio
5c76fc51e0
Update Codicons: add 'magnet' icon
...
4c6115529d
2020-09-11 09:52:37 -07:00
isidor
b0a913b761
explorer: Should maintain row focus after deleting a file
...
fixes #71315
2020-09-11 18:02:51 +02:00
Johannes Rieken
133d95e618
adopt new amd loader with support for TrustedScriptURL, add typings for TrustedTypesFactory et al, https://github.com/microsoft/vscode/issues/106396
2020-09-11 17:59:23 +02:00
isidor
c2da75080d
do not use deprecated dom helper methods
...
#103454
2020-09-11 17:34:48 +02:00
isidor
93c96b63c0
debug and explroer: do not use dom.addClass, dom.toggleClass
2020-09-11 17:20:16 +02:00
isidor
292001621a
do not use hasClass and first
...
#103454
2020-09-11 17:01:45 +02:00
Benjamin Pasero
1fccb9e58c
proxy authentication does not work on 1.49 ( #106434 )
2020-09-11 14:54:03 +02:00
João Moreno
bc38b0accb
argh
2020-09-11 13:55:29 +02:00
João Moreno
bea7a2334e
fix linux build
2020-09-11 13:13:08 +02:00
João Moreno
1f1ac9a2a3
update distro
2020-09-11 12:45:54 +02:00
João Moreno
e75b1a6dcd
Merge branch 'joao/linux-arm'
2020-09-11 12:45:08 +02:00
Benjamin Pasero
13aca0a170
debt - remove some any casts from window
2020-09-11 11:40:05 +02:00
Alex Ross
8e12a92976
Remove Schemas.vscodeRemote from simple file dialog
2020-09-11 10:33:33 +02:00
Johannes Rieken
3994ae4c9e
Trusted types - don't use innerHTML for rapid render, https://github.com/microsoft/vscode/issues/106395
2020-09-11 10:29:39 +02:00
Benjamin Pasero
a46ba1f84c
🆙 web playground
2020-09-11 10:26:43 +02:00
Martin Aeschlimann
7c20c3f8b9
Merge pull request #106374 from microsoft/dependabot/npm_and_yarn/extensions/css-language-features/server/yargs-parser-13.1.2
...
Bump yargs-parser from 13.1.1 to 13.1.2 in /extensions/css-language-features/server
2020-09-11 01:16:59 -07:00
Martin Aeschlimann
2309414153
Merge branch 'master' into dependabot/npm_and_yarn/extensions/css-language-features/server/yargs-parser-13.1.2
2020-09-11 01:16:24 -07:00
Johannes Rieken
55a7f0aa48
update search file, https://github.com/microsoft/vscode/issues/106395
2020-09-11 10:10:35 +02:00
Benjamin Pasero
87847325a6
electron - set spellcheck: false again for windows
2020-09-11 09:49:18 +02:00
Benjamin Pasero
37a11b4314
try to fix build (linux)
2020-09-11 09:46:20 +02:00
Johannes Rieken
2e2d14cb13
some jsdoc for https://github.com/microsoft/vscode/issues/54938
2020-09-11 09:41:31 +02:00
João Moreno
8684731436
update distro
2020-09-11 07:57:46 +02:00
SteVen Batten
40827f365c
fix fonts in monaco menu
2020-09-10 21:58:00 -07:00
Rachel Macfarlane
2c1dd109d6
Fix some trusted type violations, #106395
2020-09-10 18:55:17 -07:00
deepak1556
62b70e6bb5
update exploration branch
2020-09-10 18:29:41 -07:00
rebornix
4aefd4390f
remove spliceNotebook api from textmodel.
2020-09-10 18:13:30 -07:00
rebornix
58d9622c42
unit tests for batched edits.
2020-09-10 18:13:30 -07:00
Jackson Kearl
ee11170fef
Pin blob storage dep
...
see Azure/azure-sdk-for-js#11187
2020-09-10 15:34:40 -07:00
Matt Bierner
310e5a9057
Replace our arrays.find with stdlib find
...
For #103454
2020-09-10 14:33:35 -07:00
Matt Bierner
d82bb0ec77
Improve views contribution point
...
- add required properties
- add default snippet
- use `markdownDescription` for markdown string
2020-09-10 14:33:35 -07:00
Matt Bierner
f731c6f2db
Document view.type contribution
...
Fixes #105821
2020-09-10 14:33:35 -07:00
rebornix
7daf6e1e81
fix build.
2020-09-10 14:09:38 -07:00
rebornix
5ae0dc07e3
💄
2020-09-10 14:05:11 -07:00
rebornix
f3c42d8057
do not copy execution related metadata
2020-09-10 14:03:27 -07:00
rebornix
ea02bca1e0
replace insertCell with applyEdit.
2020-09-10 14:03:27 -07:00
rebornix
f88fca5038
applyEdit supports begin/end selections.
2020-09-10 14:03:27 -07:00
rebornix
2103630537
private outputs slice and unknown change.
2020-09-10 14:02:16 -07:00
rebornix
f0426274b4
notebook text model initialization does not increment version
2020-09-10 14:02:16 -07:00
rebornix
b37c4b08e9
re #105735 . batch apply edits.
2020-09-10 14:02:16 -07:00
Sandeep Somavarapu
c59d5dd63d
- reload only local user configuration after initi
...
- add perf mark up and logs
2020-09-10 22:49:45 +02:00
Matt Bierner
a45fa6ed50
Use @example
tags in vscode.d.ts ( #106352 )
...
`@example` is the standard way to document code examples. This also gets us syntax highlighting of code examples in hovers
2020-09-10 11:28:53 -07:00
Rob Lourens
ad451c4586
Fix one innerHTML usage #106395
2020-09-10 12:28:10 -05:00
SteVen Batten
2e56d31a72
use textcontent in menu css
...
refs #106395
2020-09-10 10:25:32 -07:00
Matt Bierner
70a3975a15
Use textContnet for style element
...
For #106395
2020-09-10 10:22:08 -07:00