Commit graph

55384 commits

Author SHA1 Message Date
Benjamin Pasero
d9a639a06b fix hygiene 2019-10-08 15:00:26 +02:00
Benjamin Pasero
e4a66a8698 strict null 2019-10-08 14:57:57 +02:00
Benjamin Pasero
5cd301d403 🆙 distro 2019-10-08 14:36:13 +02:00
Benjamin Pasero
c3e1bcc67b 🆙 distro 2019-10-08 14:16:27 +02:00
Johannes Rieken
0fc92f222f fix tests 2019-10-08 14:13:14 +02:00
Alexandru Dima
b24844ce9d
Fixes #72823: Do not compute char changes for huge chunks 2019-10-08 13:57:27 +02:00
Alexandru Dima
e57a82771b
Pass the elements to the diff algorithm directly 2019-10-08 13:57:27 +02:00
Alexandru Dima
84167ad509
Add ISequence.elementsAreEqual 2019-10-08 13:57:27 +02:00
Alexandru Dima
c4821bf4a0
Use Int32Array 2019-10-08 13:57:26 +02:00
Alexandru Dima
55610696fe
Avoid allocations for ISequence.getElementAtIndex 2019-10-08 13:57:26 +02:00
Alexandru Dima
e80b0f53fa
💄 2019-10-08 13:57:26 +02:00
Johannes Rieken
807a126a6a remove pseudo breadcrumbs in call hierarchy peek, #81859 2019-10-08 12:52:57 +02:00
Johannes Rieken
46be30ef9a renames: source -> from, target -> to, #81746 2019-10-08 12:44:25 +02:00
Johannes Rieken
178b598c82
Merge pull request #82062 from kondratyev-nv/master
Render Octicons in CodeLens
2019-10-08 12:13:43 +02:00
Alex Ross
c270a67615 Terminal should scroll to bottom on reused task terminals
fixes #72503
2019-10-08 11:35:33 +02:00
Benjamin Pasero
b8a26a0139
debt - tweak proposed API check (#82089) 2019-10-08 11:21:43 +02:00
Benjamin Pasero
b78fe0cc1e 🆙 distro 2019-10-08 11:16:21 +02:00
Benjamin Pasero
42ebd1036f build - use enable-proposed-api in tests 2019-10-08 11:13:18 +02:00
Johannes Rieken
bcaa2be1b5 outline progress bar delay is average respone time, some minor polish, fixes #63400 2019-10-08 11:03:30 +02:00
isidor
a6ac3e5634 Revert "fixes #77837"
This reverts commit a8a448d166.
2019-10-08 10:57:58 +02:00
Johannes Rieken
e9cc9c7847 debt - make debugging lazy services simpler 2019-10-08 10:25:04 +02:00
Benjamin Pasero
79722879ba debt - less null in workbench 2019-10-08 09:53:53 +02:00
Matt Bierner
4a79a0ba40 Fixing a few more strict init errors in panelViewlet
#78168Ï
2019-10-07 16:41:39 -07:00
Matt Bierner
6fdd8d10dc Fixing strict init errors in webview code
#78168
2019-10-07 16:38:17 -07:00
Matt Bierner
4388300e89 Cache webview web contents
Fixes #81780
2019-10-07 16:25:24 -07:00
Matt Bierner
953d193378 Removing zoomFactor logic for webviews
Fixes #81783

This code was added to workaround bug in electron. It looks like it has since been fixed
2019-10-07 15:53:40 -07:00
Matt Bierner
b0dccbcf75 Marking a bunch of static variables as readonly
Readonly helps out with TS's type guards and is also a good best practice. Specifically, readonly strings/numbers have their literal type instead of a generic `string` | `number` type, which can help catch dead code and some common programming mistakes
2019-10-07 15:40:02 -07:00
Matt Bierner
90f33ddc6d Use DisposableStore in a few more places
- Also switches a few places that re-implemented Disposable with calls to `_register` instead
2019-10-07 15:40:01 -07:00
U-ways
095358e3b2 fix image preview to show correct canvas size when editor is scaled down vertically (#82027)
See issue #81878
2019-10-07 14:48:49 -07:00
Matt Bierner
2719c1ddc0 Replacing more for loops with .every/.some or arrays.equals 2019-10-07 14:43:53 -07:00
Matt Bierner
4e2caaa646 Use array.find in more places of re-implementing it with for loops 2019-10-07 14:43:53 -07:00
Rachel Macfarlane
d1b81e23db Remove applicationinsights-web dependency 2019-10-07 14:34:21 -07:00
Matt Bierner
99dc069a0c Remove another duplicated array equals helper function 2019-10-07 14:18:58 -07:00
Matt Bierner
30dc021bf7 null -> undefined 2019-10-07 14:18:58 -07:00
Matt Bierner
40e0f496f9 Use equals helper function instead of re-implementing it so many places 2019-10-07 14:18:58 -07:00
Matt Bierner
6e593ab812 Converting some search for loops to use .some/.every instead
Prefer using these predicates as they are shorter and make the code easier to understand
2019-10-07 14:18:58 -07:00
Matt Bierner
4a461d267f Converting a few functions in ITokenizationRegistry to return undefined instead of null 2019-10-07 14:18:58 -07:00
Matt Bierner
948af79e49 Markding results from panelService as readonly 2019-10-07 14:18:58 -07:00
Matt Bierner
de9a8a67b3 Converting some parts of panel service to return undefined instead of null 2019-10-07 14:18:58 -07:00
Matt Bierner
ab3f2e6180 Use find instead of for loop 2019-10-07 14:18:58 -07:00
Matt Bierner
02ae385856 Convert getPanel to return undefined instead of null 2019-10-07 14:18:58 -07:00
Matt Bierner
a660620e88 Convert null -> undefined 2019-10-07 14:18:58 -07:00
Rachel Macfarlane
73d2f81d13 Mark that pendingComment can be null, #81574 2019-10-07 13:33:35 -07:00
Benjamin Pasero
3c70da4c8c
🆙 graceful-fs@4.2.2 (#82058) 2019-10-07 20:33:35 +02:00
Benjamin Pasero
6869239fd8
🆙 terser@4.3.8 (#82057) 2019-10-07 20:33:16 +02:00
Matt Bierner
4c4edcefeb Fixing more TS 3.7 related compile errors
- Import aliasing symbol in file
- Missing function calls in conditional
- Missing return statement
2019-10-07 11:04:31 -07:00
Matt Bierner
2b4638e1ac Fix missing function calls in condition 2019-10-07 11:04:31 -07:00
Matt Bierner
9f90a1d69c Fix more TS 3.7 dom typings errors
Use an empty string instead of null for reseting styles
2019-10-07 11:04:31 -07:00
Matt Bierner
1f7e445625 Fixing more issues related to TS 3.7 dom typings changes
Fixes cases where styles value can no longer be null
2019-10-07 11:03:44 -07:00
Matt Bierner
e4ec151881 Fixes more issues related to strictFunctionTypes
For #81574
2019-10-07 11:02:28 -07:00