Commit graph

98 commits

Author SHA1 Message Date
João Moreno e7ea07d358
docs(sash): 📝 add documentation for the Sash widget
Related-to: #124652
2021-11-10 12:17:03 +01:00
João Moreno 7a938550cf
refactor: ⚰️ remove dead code 2021-11-09 15:37:12 +01:00
Matt Bierner 494cbbd02d
Organize imports in vs/base 2021-08-04 12:28:27 -07:00
Benjamin Pasero d0df79be50
webview - remove more traces (#128128)
* webview - remove more traces

* more removal
2021-07-07 18:28:53 +02:00
João Moreno fe160b35e5
fix orthogonal sash hover feedback 2021-06-18 11:20:26 +02:00
João Moreno 0bf73ff15a
make sash work better on ios
fixes #125285
fixes #125105
fixes #120937
2021-06-02 16:10:36 +02:00
João Moreno 9764a02c5d
sash: use DomEmitter 2021-06-02 16:10:36 +02:00
João Moreno 3d6f88eb92
fixes #120828 2021-04-29 16:33:01 +02:00
Matt Bierner e1f0f8f513
Add override keyword in codebase (#120755)
For #120675

This uses a script to add the override keyword to places that need it in the codebase

Note that we can't enable the --noImplicitOverride setting yet since there are still around 200 errors that require further attention
2021-04-08 10:05:20 -07:00
Benjamin Pasero 7031abadea
debt - less explicit any 2021-03-29 10:30:03 +02:00
João Moreno 244428dfa7
sash: workbench.sash.hoverDelay setting
fixes #118158
2021-03-11 15:36:02 +01:00
Alex Dima 49cad9a1c0
Fixes microsoft/monaco-editor#2382
Unhandled rejected promises are logged by default to the browser console. In the monaco editor case, we cannot register the global unhandled error handler and filter out cancellation errors because we cannot assume we own the entire page. So the strategy (used also in all other places that ship with the standalone editor and cause cancellation errors) is to just "handle" the rejected promise locally by adding an onerror handler to the promise.
2021-03-11 13:46:11 +01:00
João Moreno 57c6bad938
fix #117549 2021-02-24 14:32:03 +01:00
João Moreno c9886c3946
missing recursion break 2021-02-15 13:40:42 +01:00
João Moreno 965518f9a9
fixes #116558 2021-02-15 13:39:41 +01:00
João Moreno ea185a2bbb
sash: add hover feedback delay 2021-02-10 10:41:38 +01:00
João Moreno 34adb67513
improve hover feedback for sash corners 2021-02-09 12:35:41 +01:00
João Moreno 60c625e9f0
fixes #110768 2020-11-17 11:05:51 +01:00
ChaseKnowlden e8760a5d6c Fix capitalization of GitHub org 2020-09-17 11:43:03 +02:00
João Moreno 883da596a4
remove deprecated function calls
related to #103454
2020-09-14 15:32:47 +02:00
João Moreno 8b993b8d30
trusted types
related to #106285
2020-09-09 13:51:46 +02:00
João Moreno 7ddf7a951c fix find widget sash 2020-05-12 21:49:28 +02:00
João Moreno 7a3d2652d6 💄 2020-05-12 11:41:03 +02:00
Ladislau Szomoru 2681b9de5b update variable name to be more descriptive 2020-05-12 09:38:59 +02:00
Ladislau Szomoru 88440bdcdf Fixed issue with creating a new sash 2020-05-11 12:50:24 +02:00
Ladislau Szomoru 2f9ac60b17 Pull request feedback 2020-05-11 09:51:08 +02:00
Ladislau Szomoru d357d0283e Add setting to control the sash size 2020-05-08 16:59:25 +02:00
isidor c2997da2ac Gesture.addTarget returns an IDisposable
fixes #81630
2019-09-30 14:42:58 +02:00
Christian Oliff 13b681eee0 HTTPS link to ux.stackexchange.com (#80255)
saves a HTTP redirect
2019-09-03 20:44:19 +02:00
Joao Moreno e354c8d921 remove all StrictNullOverride
related to #78168
2019-08-30 16:42:37 +02:00
Joao Moreno 6d624ae2a4 fixes #79068 2019-08-29 11:41:05 +02:00
Joao Moreno 3015179c04 strictPropertyInitialization
related to #78168
2019-08-05 15:38:13 +02:00
Matt Bierner 4eb2bf393b Use DisposableStore 2019-07-15 15:03:54 -07:00
Joao Moreno 80d1a9fc6b sash: debug false 2019-07-15 15:36:42 +02:00
Joao Moreno 3437dd1dd0 Merge branch 'joao/splitview' 2019-07-15 13:06:52 +02:00
Connor Peet 8c7a0098db
fixup! make sure to remove all listeners appropriately 2019-07-11 11:32:25 -07:00
Joao Moreno bd087c156a sash: debug 2019-07-11 08:06:31 +02:00
Connor Peet 557a38f352
fix(sash): dragging being difficult with iframe-containing extensions
It appears that (running querySelector, getElementByTagName) that the
contents of electron's `<webviews>`, which contain the iframe, are
inaccessible. We were already disabling pointer events on iframes, this PR
makes sure we do so on webviews as well.
2019-07-10 10:35:14 -07:00
Matt Bierner 806ac7c39b Fix more instances of using push instead of add 2019-05-28 10:32:14 -07:00
Matt Bierner 30d1114535 Replacing a few instances of IDisposable[] 2019-05-28 10:16:34 -07:00
Matt Bierner 2f3fc3f6bb Strongly type some event types in addDisposableListener 2018-11-30 17:15:28 -08:00
Matt Bierner 46d8bb8033 Strict null errors
#60656
2018-10-16 17:10:43 -07:00
Matt Bierner c63c97c128 Remove use strict directives in main vs code ts files
We compile using the alwaysStrict flag so these directives are not needed
2018-10-02 16:05:44 -07:00
Alex Dima c36258d23f Use const enums (to inline their values in JS) 2018-09-06 20:39:19 +02:00
Benjamin Pasero 55d89a747d debt - make sure to dispose Emitter 2018-09-04 08:08:03 +02:00
Joao Moreno 050971da15 Merge branch 'master' into remove-vsash 2018-06-13 08:18:35 +02:00
Joao Moreno ea1f6acc2c remove v-sash, use splitview instead 2018-06-11 15:46:35 +02:00
Joao Moreno 24da1f0814 wip: 2x2 grid 2018-06-08 18:31:05 +02:00
Joao Moreno 4beda835f1 Revert "sash: use linked sashes as arrays"
This reverts commit 4f5c928f75.
2018-06-08 18:23:32 +02:00
Joao Moreno 4eb0c3832e Revert "sash: rename"
This reverts commit 19dcc2d869.
2018-06-08 18:23:31 +02:00