Commit graph

77990 commits

Author SHA1 Message Date
Rob Lourens
5f17dc2a59 Ensure that PrefService calls openEditor with a proper options object and add tests
Better fix for #117952
2021-03-03 18:36:55 -08:00
Rob Lourens
54758b7e16 Revert "Ensure that PrefService calls openEditor with a proper options object and add tests"
This reverts commit 2ae55bc716.
2021-03-03 18:35:25 -08:00
Rob Lourens
2ae55bc716 Ensure that PrefService calls openEditor with a proper options object and add tests
Better fix for #117952
2021-03-03 18:33:46 -08:00
Matt Bierner
16c94f1825 Remove incorrect command
For #117675
2021-03-03 18:22:35 -08:00
Matt Bierner
a4b2541e37 Mark disposableStore property readonly 2021-03-03 18:17:09 -08:00
Matt Bierner
584d233887 Use _register for disposable
This class already extends `Disposable` so we should just use `_register` insteaed of reimplementing `dispose`
2021-03-03 18:16:47 -08:00
Matt Bierner
538931e790 Make sure context key listeners are disposed of
Fixes #118090
2021-03-03 18:11:32 -08:00
Matt Bierner
49d05f998f Add CodeActionTriggerKind api proposal
For #118084
Fixes #118087
2021-03-03 17:36:07 -08:00
Matt Bierner
20f06e0444 Clarify docs on CodeAction return type 2021-03-03 17:36:07 -08:00
Matt Bierner
7e18b7006d Use generic type for CodeActionProvider
This enforces that a CodeActionProvider for a given type returns actions of that type
2021-03-03 17:36:07 -08:00
meganrogge
ba117e60c2 fix #118043 2021-03-03 16:49:38 -08:00
Matt Bierner
4bd99a42df Fix old markdown preview not being removed on drag 2021-03-03 15:43:08 -08:00
Matt Bierner
4371e72fb6 Fix potential null exception while dragging cells 2021-03-03 15:43:08 -08:00
Raymond Zhao
abf99de040 💄 2021-03-03 23:18:17 +00:00
Raymond Zhao
aaf70523a8 Bump vscode-emmet-helper, fixes #118008 2021-03-03 23:18:17 +00:00
Matt Bierner
828f99eff5 Update diff editor with new webview options 2021-03-03 13:40:48 -08:00
Matt Bierner
e56182e67f
Make the backlayer webview span the full width of the notebook editor (#117948)
Fixes #117489

With the new markdown renders, we are relying more on the back layer webview. This means that we need to do things like make sure the entire markdown cell inside the webview is draggable.

Currently this is not possible since the webview has a large left margin. This change makes the webview span the entire notebook editor and instead moves the margin into the individual norebook cells
2021-03-03 13:37:58 -08:00
Maksym Taran
bfa7822f70 Fix typo in IWorkbenchExtensioManagementService 2021-03-03 13:39:36 -07:00
SteVen Batten
e9533c22fe add basic workspace trust unit test 2021-03-03 12:35:05 -08:00
Andrew Scott
19b7444ccf fixup! fix microsoft/vscode#117095 de-duplicate location results 2021-03-03 11:30:37 -08:00
Connor Peet
17f63a649e
testing: update to more proper provider api 2021-03-03 11:04:02 -08:00
Matt Bierner
2f7438f492 Fix spelling for type 2021-03-03 10:57:24 -08:00
Matt Bierner
5d5b9dd0a8 Don't label non-editable custom editors as readonly
We should only use the readonly label when an editable custom editor is on a readonly resource
2021-03-03 10:57:24 -08:00
Matt Bierner
5f24ec84ac Use correct new context name 2021-03-03 10:57:24 -08:00
Alex Ross
6949fed6ed Update grammars and fix julia update script for Windows 2021-03-03 17:26:09 +01:00
Johannes Rieken
0e94794c9d debt - remove unneccessary indirections from notebook service 2021-03-03 16:49:33 +01:00
Daniel Imms
09149ac093 Avoid double dispose of pty host client
No need to register the client as it's disposed via _disposePtyHost

Fixes #117012
2021-03-03 07:28:34 -08:00
Alex Ross
f80f0d7074 More forwarded ports trace logging 2021-03-03 15:40:43 +01:00
isidor
65c0eeb03d fixes #118006 2021-03-03 15:01:48 +01:00
isidor
a24cb4615a debug debt: remove unneneded check 2021-03-03 14:11:32 +01:00
isidor
341c130b0e call stack: get rid of actions, menus everywhere 2021-03-03 14:06:46 +01:00
isidor
fd94882799 Deprecate editor.accessibilityPageSize setting
fixes #118037
2021-03-03 14:06:45 +01:00
Ladislau Szomoru
79cf4e92ce Use Promise instead of event 2021-03-03 12:41:22 +01:00
Ladislau Szomoru
14fd07d57a Workspace trust api feedback 2021-03-03 12:41:22 +01:00
Jackson Kearl
65a9aa1776 Use "(Settings) " as a prefix for userdata paaths in web
Closes #114979
2021-03-03 03:19:31 -08:00
Jackson Kearl
c3d7bd2269 Reserve space for recent list to prevent shifting when it loads
Fixes #117628
2021-03-03 03:02:56 -08:00
Jackson Kearl
e21f3916af Focus first uncompleted category rather than whole document on start
Closes #117540
2021-03-03 03:02:55 -08:00
isidor
09dae2618a Disconnect in debug toolbar should dispatch to root session
fixes #117975
2021-03-03 11:41:28 +01:00
isidor
8c13b01113 debug: simplify registration 2021-03-03 11:36:45 +01:00
Benjamin Pasero
b6f8790593 💄 comment 2021-03-03 11:22:34 +01:00
Johannes Rieken
4def740615 wrap perf stuff in iife, https://github.com/microsoft/vscode/issues/116546 2021-03-03 10:45:29 +01:00
Sandeep Somavarapu
bc444ac379 Fix #117869 2021-03-03 10:11:00 +01:00
Martin Aeschlimann
bede292add Error on remoteAuthority in Local Workspace File. Fixes #118023 2021-03-03 09:47:05 +01:00
Johannes Rieken
6b3313141d make sure local dispoables are disposed and cleared, https://github.com/microsoft/vscode/issues/117675 2021-03-03 09:00:53 +01:00
Johannes Rieken
d13b7ff364 one class, one variable style, https://github.com/microsoft/vscode/issues/117675 2021-03-03 08:29:34 +01:00
Johannes Rieken
2e9fde23fd add todo-tag for InlineHint, https://github.com/microsoft/vscode/issues/105690 2021-03-03 08:10:19 +01:00
Raymond Zhao
0a49559a44 Mitigates #118008, better fix TBD 2021-03-03 04:49:37 +00:00
rebornix
a795f49b09 more enforcement of readonly nb doc. 2021-03-02 18:18:19 -08:00
SteVen Batten
62cfd68c77 absolutely no polish POC feature list 2021-03-02 17:56:44 -08:00
SteVen Batten
d82bb46c44 do not prompt for confirmation in editor 2021-03-02 17:18:48 -08:00