yueh
e94a0cfccf
Reduces visibility of internal fields/methods
...
Reduces the visibility of all fields to private and create setters/getters
when necessary. Exceptions are fields with GuiSync as these need to be
public.
Reduces the visibility of internal methods to private/protected/default when possible.
2015-12-24 01:59:13 +01:00
thatsIch
8b3a954f73
final variables and parameters
2015-09-30 14:24:44 +02:00
thatsIch
059523f543
Reduce scope of variables
2015-09-30 14:22:21 +02:00
thatsIch
430b33b7a3
Replace with array initializer
...
this can be done through http://docs.oracle.com/javase/specs/jls/se6/html/arrays.html#10.6
2015-09-30 14:15:53 +02:00
yueh
621952e37d
Closes #1283 : Add custom Callable to prevent memory leaks
2015-09-30 13:37:35 +02:00
thatsIch
59dbfb1452
Fixed stairs
2015-09-30 11:34:16 +02:00
AlgorithmX2
38afde724b
Most of the 1.8 Port.
2015-06-15 19:44:59 -05:00
yueh
ecf2f3fdaf
Merge pull request #1478 from yueh/fix-1465
...
Fixes #1465 faulty item comparison
2015-05-19 00:53:53 +02:00
yueh
7fa7502770
Fixes #1465 faulty item comparison
2015-05-18 19:31:18 +02:00
thatsIch
72195ea784
Unused imports
2015-05-18 00:12:01 +02:00
thatsIch
192848e383
Uses an instance factory access for AE2
...
Removes the improper way to set itself into a public static non-final variable.
Removes the direct access to the IntegrationRegistry from AppEng. Will be added at some later point somewhere else for non-singleton access.
Constructor is set to package private to enable possible construction from unit tests. Are current not runnable sind it is currently tied to the FML Loader instance.
2015-05-16 20:48:32 +02:00
thatsIch
71569cadb5
Merge pull request #1424 from thatsIch/e-simplified-bitwise-operations
...
Simplified bitwise operation
2015-05-09 15:58:04 +02:00
thatsIch
168038c595
Merge pull request #1426 from thatsIch/e-overly-strong-cast
...
reduces overly strong type cast
2015-05-09 15:57:47 +02:00
yueh
b6b76d145b
Organize imports
2015-05-09 13:06:09 +02:00
thatsIch
7c9b734948
reduces overly strong type cast
2015-05-09 12:45:46 +02:00
thatsIch
513292cd08
Replaces all local variables regarding their naming conventions
2015-05-08 23:50:36 +02:00
thatsIch
8dd0991a7d
Merge pull request #1422 from thatsIch/e-constant-naming-convention
...
Replaces all constants regarding their naming conventions
2015-05-08 23:45:44 +02:00
thatsIch
42c7cca64f
Simplified bitwise operation
2015-05-08 23:44:07 +02:00
thatsIch
7f14faeaa3
Replaces all constants regarding their naming conventions
2015-05-08 23:37:09 +02:00
thatsIch
f193c2adc4
Replaces all method parameter regarding their naming conventions
2015-05-08 23:25:19 +02:00
thatsIch
64ed05a1b4
Puts everywhere brackets
2015-04-29 18:38:24 +02:00
thatsIch
3783ae8619
Improved exceptions
...
Many exceptions got an improvement due to changed class or description or details it is providing.
Is not complete, needs to be done in patches in the regions, where it is needed, since some are just
swallowed.
Removed total usage of pure RuntimeExceptions to 0.
2015-04-21 17:43:24 +02:00
yueh
80f56d4359
Changed the order as WATs are special and needing a position
...
Fixes #1222
2015-04-07 00:17:55 +02:00
yueh
788de6d432
Merge pull request #964 from yueh/fix-889
...
Fixes #889 possible dupe bug
2015-04-06 15:54:23 +02:00
thatsIch
06bca227d0
Closes #1054 : Adds an Inscriber API for Developers
2015-04-06 13:45:27 +02:00
yueh
eaf57bedf6
Modifier are now using a consistent order based on the java conventions
2015-04-06 00:35:42 +02:00
yueh
5416ea2365
Fixes 889 possible dupe bug
...
Adds a hotfix to prevent duping with portable cells.
Should possibly fix the NPE crash with switching slots on laggy servers.
2015-04-03 17:23:17 +02:00
thatsIch
d34c988c88
Basic reformat, hit once, hope never again
2015-04-03 15:07:13 +02:00
thatsIch
9986ffc458
Fixes #675 No disabled feature should log spam or crash anymore.
...
Deprecates the old usage of the AEItemDefinitions via the direct method access of
* blocks()
* parts()
* items()
* materials()
and thus use the new re-direct via definitions().
All definitions are now initialized, no matter what. But SubItems, Items and Blocks are not registered, if by chance are disabled.
2015-03-28 16:21:37 +01:00
thatsIch
81c32d5181
Multiple variables in one declaration
2015-03-26 12:13:34 +01:00
thatsIch
9bf8b4388f
Extract ++ and -- from expressions
2015-03-26 11:07:26 +01:00
yueh
b18addbf37
remove trailing whitespaces
2015-02-03 12:04:13 +01:00
thatsIch
52c512635d
Renamed constants
2015-01-01 22:13:10 +01:00
thatsIch
8179259afa
Replaced C-style array instantiation with Java-Style
2015-01-01 21:15:03 +01:00
thatsIch
2243c5a188
Refactoring
...
Type-safety
Minor performance improvements
2014-12-02 22:55:39 +01:00
thatsIch
7505f9b66a
Added copyright to all java files
2014-11-14 12:03:00 +01:00
thatsIch
011ff54224
Simplified some control flow statements
2014-10-09 21:33:31 +02:00
thatsIch
c074280b68
Temporary set of catch to ignored if they are ignored
2014-10-01 15:20:42 +02:00
thatsIch
474596f095
Make fields final if possible to ensure immutability
2014-09-30 09:52:57 +02:00
thatsIch
3db2d4960b
Replaced normal for loops with foreach loops which is less error prone when just iterating over collection/array
2014-09-29 23:48:25 +02:00
Chris
87126e1f11
Merge pull request #185 from thatsIch/Cast
...
Removes not needed casts
2014-09-29 14:14:25 -07:00
Chris
1404a2fe97
Merge pull request #183 from thatsIch/Equals
...
Replaces String == comparison with .equals()
2014-09-29 14:10:39 -07:00
Chris
7b3bde7906
Merge pull request #182 from thatsIch/While
...
Replaces while iterators with foreach call
2014-09-29 14:10:03 -07:00
thatsIch
3ce47a167f
Removes not needed casts
2014-09-29 09:42:50 +02:00
thatsIch
1d1ea7a03e
Replaces String == comparison with .equals()
2014-09-29 09:28:58 +02:00
thatsIch
b6ec21c70a
Replaces while iterators with foreach call
2014-09-29 09:26:35 +02:00
Andrew
5c5aaa21ee
Merge remote-tracking branch 'upstream/rv2' into rv2
...
Conflicts:
src/main/java/appeng/items/tools/powered/ToolMassCannon.java
2014-09-29 00:26:15 -07:00
thatsIch
f1ffbf08a2
Resolved some unchecked Types
2014-09-28 22:20:14 +02:00
Andrew
da63aca95c
Deleted unnecessary casts with Eclipse
2014-09-28 11:56:16 -07:00
Andrew
d75a60cbaa
Deleted unused imports
2014-09-28 11:36:14 -07:00
