2018-07-16 12:38:45 +02:00
|
|
|
# Copyright 2018 New Vector Ltd
|
|
|
|
#
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
#
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
#
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
# limitations under the License.
|
|
|
|
import logging
|
2021-04-08 23:38:54 +02:00
|
|
|
from typing import Optional
|
2021-04-09 19:44:38 +02:00
|
|
|
from unittest.mock import Mock
|
2019-10-23 18:25:54 +02:00
|
|
|
|
2018-07-16 12:38:45 +02:00
|
|
|
from twisted.internet import defer
|
2018-07-16 15:05:31 +02:00
|
|
|
from twisted.internet.defer import succeed
|
2018-07-16 12:38:45 +02:00
|
|
|
|
2019-04-01 11:24:38 +02:00
|
|
|
from synapse.api.room_versions import RoomVersions
|
2018-07-16 15:05:31 +02:00
|
|
|
from synapse.events import FrozenEvent
|
2018-07-16 12:38:45 +02:00
|
|
|
from synapse.visibility import filter_events_for_server
|
2018-07-17 12:51:26 +02:00
|
|
|
|
2018-07-16 15:05:31 +02:00
|
|
|
import tests.unittest
|
2018-08-09 15:33:49 +02:00
|
|
|
from tests.utils import create_room, setup_test_homeserver
|
2018-07-16 12:38:45 +02:00
|
|
|
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
|
|
TEST_ROOM_ID = "!TEST:ROOM"
|
|
|
|
|
|
|
|
|
2018-07-16 15:05:31 +02:00
|
|
|
class FilterEventsForServerTestCase(tests.unittest.TestCase):
|
2018-07-16 12:38:45 +02:00
|
|
|
@defer.inlineCallbacks
|
|
|
|
def setUp(self):
|
2018-08-13 08:47:46 +02:00
|
|
|
self.hs = yield setup_test_homeserver(self.addCleanup)
|
2018-07-16 12:38:45 +02:00
|
|
|
self.event_creation_handler = self.hs.get_event_creation_handler()
|
|
|
|
self.event_builder_factory = self.hs.get_event_builder_factory()
|
2019-10-23 13:02:36 +02:00
|
|
|
self.storage = self.hs.get_storage()
|
2018-07-16 12:38:45 +02:00
|
|
|
|
2020-07-28 22:09:53 +02:00
|
|
|
yield defer.ensureDeferred(create_room(self.hs, TEST_ROOM_ID, "@someone:ROOM"))
|
2018-08-09 15:33:49 +02:00
|
|
|
|
2018-07-16 12:38:45 +02:00
|
|
|
@defer.inlineCallbacks
|
|
|
|
def test_filtering(self):
|
|
|
|
#
|
|
|
|
# The events to be filtered consist of 10 membership events (it doesn't
|
|
|
|
# really matter if they are joins or leaves, so let's make them joins).
|
|
|
|
# One of those membership events is going to be for a user on the
|
|
|
|
# server we are filtering for (so we can check the filtering is doing
|
|
|
|
# the right thing).
|
|
|
|
#
|
|
|
|
|
|
|
|
# before we do that, we persist some other events to act as state.
|
2020-07-22 18:29:15 +02:00
|
|
|
yield self.inject_visibility("@admin:hs", "joined")
|
2018-07-16 12:38:45 +02:00
|
|
|
for i in range(0, 10):
|
|
|
|
yield self.inject_room_member("@resident%i:hs" % i)
|
|
|
|
|
|
|
|
events_to_filter = []
|
|
|
|
|
|
|
|
for i in range(0, 10):
|
2018-08-10 15:54:09 +02:00
|
|
|
user = "@user%i:%s" % (i, "test_server" if i == 5 else "other_server")
|
2018-07-16 12:38:45 +02:00
|
|
|
evt = yield self.inject_room_member(user, extra_content={"a": "b"})
|
|
|
|
events_to_filter.append(evt)
|
|
|
|
|
2020-07-27 18:32:08 +02:00
|
|
|
filtered = yield defer.ensureDeferred(
|
|
|
|
filter_events_for_server(self.storage, "test_server", events_to_filter)
|
2018-07-16 12:38:45 +02:00
|
|
|
)
|
|
|
|
|
|
|
|
# the result should be 5 redacted events, and 5 unredacted events.
|
|
|
|
for i in range(0, 5):
|
|
|
|
self.assertEqual(events_to_filter[i].event_id, filtered[i].event_id)
|
|
|
|
self.assertNotIn("a", filtered[i].content)
|
|
|
|
|
|
|
|
for i in range(5, 10):
|
|
|
|
self.assertEqual(events_to_filter[i].event_id, filtered[i].event_id)
|
|
|
|
self.assertEqual(filtered[i].content["a"], "b")
|
|
|
|
|
2018-07-16 16:22:27 +02:00
|
|
|
@defer.inlineCallbacks
|
|
|
|
def test_erased_user(self):
|
|
|
|
# 4 message events, from erased and unerased users, with a membership
|
|
|
|
# change in the middle of them.
|
|
|
|
events_to_filter = []
|
|
|
|
|
|
|
|
evt = yield self.inject_message("@unerased:local_hs")
|
|
|
|
events_to_filter.append(evt)
|
|
|
|
|
|
|
|
evt = yield self.inject_message("@erased:local_hs")
|
|
|
|
events_to_filter.append(evt)
|
|
|
|
|
|
|
|
evt = yield self.inject_room_member("@joiner:remote_hs")
|
|
|
|
events_to_filter.append(evt)
|
|
|
|
|
|
|
|
evt = yield self.inject_message("@unerased:local_hs")
|
|
|
|
events_to_filter.append(evt)
|
|
|
|
|
|
|
|
evt = yield self.inject_message("@erased:local_hs")
|
|
|
|
events_to_filter.append(evt)
|
|
|
|
|
|
|
|
# the erasey user gets erased
|
2020-08-27 23:24:46 +02:00
|
|
|
yield defer.ensureDeferred(
|
|
|
|
self.hs.get_datastore().mark_user_erased("@erased:local_hs")
|
|
|
|
)
|
2018-07-16 16:22:27 +02:00
|
|
|
|
|
|
|
# ... and the filtering happens.
|
2020-07-27 18:32:08 +02:00
|
|
|
filtered = yield defer.ensureDeferred(
|
|
|
|
filter_events_for_server(self.storage, "test_server", events_to_filter)
|
2018-07-16 16:22:27 +02:00
|
|
|
)
|
|
|
|
|
|
|
|
for i in range(0, len(events_to_filter)):
|
|
|
|
self.assertEqual(
|
2018-08-10 15:54:09 +02:00
|
|
|
events_to_filter[i].event_id,
|
|
|
|
filtered[i].event_id,
|
|
|
|
"Unexpected event at result position %i" % (i,),
|
2018-07-16 16:22:27 +02:00
|
|
|
)
|
|
|
|
|
|
|
|
for i in (0, 3):
|
|
|
|
self.assertEqual(
|
2018-08-10 15:54:09 +02:00
|
|
|
events_to_filter[i].content["body"],
|
|
|
|
filtered[i].content["body"],
|
|
|
|
"Unexpected event content at result position %i" % (i,),
|
2018-07-16 16:22:27 +02:00
|
|
|
)
|
|
|
|
|
|
|
|
for i in (1, 4):
|
|
|
|
self.assertNotIn("body", filtered[i].content)
|
|
|
|
|
2018-07-16 12:38:45 +02:00
|
|
|
@defer.inlineCallbacks
|
|
|
|
def inject_visibility(self, user_id, visibility):
|
|
|
|
content = {"history_visibility": visibility}
|
2019-04-01 11:24:38 +02:00
|
|
|
builder = self.event_builder_factory.for_room_version(
|
2019-01-24 10:28:16 +01:00
|
|
|
RoomVersions.V1,
|
2018-08-10 15:54:09 +02:00
|
|
|
{
|
|
|
|
"type": "m.room.history_visibility",
|
|
|
|
"sender": user_id,
|
|
|
|
"state_key": "",
|
|
|
|
"room_id": TEST_ROOM_ID,
|
|
|
|
"content": content,
|
2019-05-10 07:12:11 +02:00
|
|
|
},
|
2018-08-10 15:54:09 +02:00
|
|
|
)
|
2018-07-16 12:38:45 +02:00
|
|
|
|
2020-07-22 18:29:15 +02:00
|
|
|
event, context = yield defer.ensureDeferred(
|
|
|
|
self.event_creation_handler.create_new_client_event(builder)
|
2018-07-16 12:38:45 +02:00
|
|
|
)
|
2020-07-28 22:09:53 +02:00
|
|
|
yield defer.ensureDeferred(
|
|
|
|
self.storage.persistence.persist_event(event, context)
|
|
|
|
)
|
2019-07-23 15:00:55 +02:00
|
|
|
return event
|
2018-07-16 12:38:45 +02:00
|
|
|
|
|
|
|
@defer.inlineCallbacks
|
2021-04-08 23:38:54 +02:00
|
|
|
def inject_room_member(
|
|
|
|
self, user_id, membership="join", extra_content: Optional[dict] = None
|
|
|
|
):
|
2018-07-16 12:38:45 +02:00
|
|
|
content = {"membership": membership}
|
2021-04-08 23:38:54 +02:00
|
|
|
content.update(extra_content or {})
|
2019-04-01 11:24:38 +02:00
|
|
|
builder = self.event_builder_factory.for_room_version(
|
2019-01-24 10:28:16 +01:00
|
|
|
RoomVersions.V1,
|
2018-08-10 15:54:09 +02:00
|
|
|
{
|
|
|
|
"type": "m.room.member",
|
|
|
|
"sender": user_id,
|
|
|
|
"state_key": user_id,
|
|
|
|
"room_id": TEST_ROOM_ID,
|
|
|
|
"content": content,
|
2019-05-10 07:12:11 +02:00
|
|
|
},
|
2018-08-10 15:54:09 +02:00
|
|
|
)
|
2018-07-16 12:38:45 +02:00
|
|
|
|
2020-07-22 18:29:15 +02:00
|
|
|
event, context = yield defer.ensureDeferred(
|
|
|
|
self.event_creation_handler.create_new_client_event(builder)
|
2018-07-16 12:38:45 +02:00
|
|
|
)
|
|
|
|
|
2020-07-28 22:09:53 +02:00
|
|
|
yield defer.ensureDeferred(
|
|
|
|
self.storage.persistence.persist_event(event, context)
|
|
|
|
)
|
2019-07-23 15:00:55 +02:00
|
|
|
return event
|
2018-07-16 15:05:31 +02:00
|
|
|
|
|
|
|
@defer.inlineCallbacks
|
2018-07-16 16:22:27 +02:00
|
|
|
def inject_message(self, user_id, content=None):
|
|
|
|
if content is None:
|
2019-01-29 12:19:50 +01:00
|
|
|
content = {"body": "testytest", "msgtype": "m.text"}
|
2019-04-01 11:24:38 +02:00
|
|
|
builder = self.event_builder_factory.for_room_version(
|
2019-01-24 10:28:16 +01:00
|
|
|
RoomVersions.V1,
|
2018-08-10 15:54:09 +02:00
|
|
|
{
|
|
|
|
"type": "m.room.message",
|
|
|
|
"sender": user_id,
|
|
|
|
"room_id": TEST_ROOM_ID,
|
|
|
|
"content": content,
|
2019-05-10 07:12:11 +02:00
|
|
|
},
|
2018-08-10 15:54:09 +02:00
|
|
|
)
|
2018-07-16 16:22:27 +02:00
|
|
|
|
2020-07-22 18:29:15 +02:00
|
|
|
event, context = yield defer.ensureDeferred(
|
|
|
|
self.event_creation_handler.create_new_client_event(builder)
|
2018-07-16 16:22:27 +02:00
|
|
|
)
|
|
|
|
|
2020-07-28 22:09:53 +02:00
|
|
|
yield defer.ensureDeferred(
|
|
|
|
self.storage.persistence.persist_event(event, context)
|
|
|
|
)
|
2019-07-23 15:00:55 +02:00
|
|
|
return event
|
2018-07-16 16:22:27 +02:00
|
|
|
|
|
|
|
@defer.inlineCallbacks
|
2018-07-16 15:05:31 +02:00
|
|
|
def test_large_room(self):
|
|
|
|
# see what happens when we have a large room with hundreds of thousands
|
|
|
|
# of membership events
|
|
|
|
|
|
|
|
# As above, the events to be filtered consist of 10 membership events,
|
|
|
|
# where one of them is for a user on the server we are filtering for.
|
|
|
|
|
|
|
|
import cProfile
|
|
|
|
import pstats
|
|
|
|
import time
|
|
|
|
|
|
|
|
# we stub out the store, because building up all that state the normal
|
|
|
|
# way is very slow.
|
|
|
|
test_store = _TestStore()
|
|
|
|
|
|
|
|
# our initial state is 100000 membership events and one
|
|
|
|
# history_visibility event.
|
|
|
|
room_state = []
|
|
|
|
|
2018-08-10 15:54:09 +02:00
|
|
|
history_visibility_evt = FrozenEvent(
|
|
|
|
{
|
|
|
|
"event_id": "$history_vis",
|
|
|
|
"type": "m.room.history_visibility",
|
|
|
|
"sender": "@resident_user_0:test.com",
|
|
|
|
"state_key": "",
|
|
|
|
"room_id": TEST_ROOM_ID,
|
|
|
|
"content": {"history_visibility": "joined"},
|
|
|
|
}
|
|
|
|
)
|
2018-07-16 15:05:31 +02:00
|
|
|
room_state.append(history_visibility_evt)
|
|
|
|
test_store.add_event(history_visibility_evt)
|
|
|
|
|
|
|
|
for i in range(0, 100000):
|
2018-08-10 15:54:09 +02:00
|
|
|
user = "@resident_user_%i:test.com" % (i,)
|
|
|
|
evt = FrozenEvent(
|
|
|
|
{
|
|
|
|
"event_id": "$res_event_%i" % (i,),
|
|
|
|
"type": "m.room.member",
|
|
|
|
"state_key": user,
|
|
|
|
"sender": user,
|
|
|
|
"room_id": TEST_ROOM_ID,
|
|
|
|
"content": {"membership": "join", "extra": "zzz,"},
|
|
|
|
}
|
|
|
|
)
|
2018-07-16 15:05:31 +02:00
|
|
|
room_state.append(evt)
|
|
|
|
test_store.add_event(evt)
|
|
|
|
|
|
|
|
events_to_filter = []
|
|
|
|
for i in range(0, 10):
|
2018-08-10 15:54:09 +02:00
|
|
|
user = "@user%i:%s" % (i, "test_server" if i == 5 else "other_server")
|
|
|
|
evt = FrozenEvent(
|
|
|
|
{
|
|
|
|
"event_id": "$evt%i" % (i,),
|
|
|
|
"type": "m.room.member",
|
|
|
|
"state_key": user,
|
|
|
|
"sender": user,
|
|
|
|
"room_id": TEST_ROOM_ID,
|
|
|
|
"content": {"membership": "join", "extra": "zzz"},
|
|
|
|
}
|
2018-07-16 15:05:31 +02:00
|
|
|
)
|
|
|
|
events_to_filter.append(evt)
|
|
|
|
room_state.append(evt)
|
|
|
|
|
|
|
|
test_store.add_event(evt)
|
2018-08-10 15:54:09 +02:00
|
|
|
test_store.set_state_ids_for_event(
|
|
|
|
evt, {(e.type, e.state_key): e.event_id for e in room_state}
|
|
|
|
)
|
2018-07-16 15:05:31 +02:00
|
|
|
|
|
|
|
pr = cProfile.Profile()
|
|
|
|
pr.enable()
|
|
|
|
|
|
|
|
logger.info("Starting filtering")
|
|
|
|
start = time.time()
|
2019-10-23 18:25:54 +02:00
|
|
|
|
|
|
|
storage = Mock()
|
|
|
|
storage.main = test_store
|
|
|
|
storage.state = test_store
|
|
|
|
|
2020-07-27 18:32:08 +02:00
|
|
|
filtered = yield defer.ensureDeferred(
|
|
|
|
filter_events_for_server(test_store, "test_server", events_to_filter)
|
2018-07-16 15:05:31 +02:00
|
|
|
)
|
|
|
|
logger.info("Filtering took %f seconds", time.time() - start)
|
|
|
|
|
|
|
|
pr.disable()
|
|
|
|
with open("filter_events_for_server.profile", "w+") as f:
|
|
|
|
ps = pstats.Stats(pr, stream=f).sort_stats("cumulative")
|
|
|
|
ps.print_stats()
|
|
|
|
|
|
|
|
# the result should be 5 redacted events, and 5 unredacted events.
|
|
|
|
for i in range(0, 5):
|
|
|
|
self.assertEqual(events_to_filter[i].event_id, filtered[i].event_id)
|
|
|
|
self.assertNotIn("extra", filtered[i].content)
|
|
|
|
|
|
|
|
for i in range(5, 10):
|
|
|
|
self.assertEqual(events_to_filter[i].event_id, filtered[i].event_id)
|
|
|
|
self.assertEqual(filtered[i].content["extra"], "zzz")
|
|
|
|
|
|
|
|
test_large_room.skip = "Disabled by default because it's slow"
|
|
|
|
|
|
|
|
|
2020-09-04 12:54:56 +02:00
|
|
|
class _TestStore:
|
2018-07-16 15:05:31 +02:00
|
|
|
"""Implements a few methods of the DataStore, so that we can test
|
|
|
|
filter_events_for_server
|
|
|
|
|
|
|
|
"""
|
2018-08-10 15:54:09 +02:00
|
|
|
|
2018-07-16 15:05:31 +02:00
|
|
|
def __init__(self):
|
|
|
|
# data for get_events: a map from event_id to event
|
|
|
|
self.events = {}
|
|
|
|
|
|
|
|
# data for get_state_ids_for_events mock: a map from event_id to
|
|
|
|
# a map from (type_state_key) -> event_id for the state at that
|
|
|
|
# event
|
|
|
|
self.state_ids_for_events = {}
|
|
|
|
|
|
|
|
def add_event(self, event):
|
|
|
|
self.events[event.event_id] = event
|
|
|
|
|
|
|
|
def set_state_ids_for_event(self, event, state):
|
|
|
|
self.state_ids_for_events[event.event_id] = state
|
|
|
|
|
|
|
|
def get_state_ids_for_events(self, events, types):
|
|
|
|
res = {}
|
|
|
|
include_memberships = False
|
|
|
|
for (type, state_key) in types:
|
|
|
|
if type == "m.room.history_visibility":
|
|
|
|
continue
|
|
|
|
if type != "m.room.member" or state_key is not None:
|
|
|
|
raise RuntimeError(
|
2018-08-10 15:54:09 +02:00
|
|
|
"Unimplemented: get_state_ids with type (%s, %s)"
|
|
|
|
% (type, state_key)
|
2018-07-16 15:05:31 +02:00
|
|
|
)
|
|
|
|
include_memberships = True
|
|
|
|
|
|
|
|
if include_memberships:
|
|
|
|
for event_id in events:
|
|
|
|
res[event_id] = self.state_ids_for_events[event_id]
|
|
|
|
|
|
|
|
else:
|
|
|
|
k = ("m.room.history_visibility", "")
|
|
|
|
for event_id in events:
|
|
|
|
hve = self.state_ids_for_events[event_id][k]
|
|
|
|
res[event_id] = {k: hve}
|
|
|
|
|
|
|
|
return succeed(res)
|
|
|
|
|
|
|
|
def get_events(self, events):
|
2018-08-10 15:54:09 +02:00
|
|
|
return succeed({event_id: self.events[event_id] for event_id in events})
|
2018-07-16 15:05:31 +02:00
|
|
|
|
|
|
|
def are_users_erased(self, users):
|
|
|
|
return succeed({u: False for u in users})
|