2019-08-28 13:18:53 +02:00
|
|
|
# -*- coding: utf-8 -*-
|
|
|
|
# Copyright 2019 The Matrix.org Foundation C.I.C.
|
|
|
|
#
|
|
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
# you may not use this file except in compliance with the License.
|
|
|
|
# You may obtain a copy of the License at
|
|
|
|
#
|
|
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
#
|
|
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
# See the License for the specific language governing permissions and
|
|
|
|
# limitations under the License.
|
|
|
|
|
|
|
|
import json
|
2020-10-29 12:27:37 +01:00
|
|
|
import logging
|
|
|
|
from io import StringIO
|
2019-08-28 13:18:53 +02:00
|
|
|
|
2020-10-29 12:27:37 +01:00
|
|
|
from synapse.logging._terse_json import JsonFormatter, TerseJsonFormatter
|
2020-12-11 13:25:01 +01:00
|
|
|
from synapse.logging.context import LoggingContext, LoggingContextFilter
|
2019-08-28 13:18:53 +02:00
|
|
|
|
2020-10-29 12:27:37 +01:00
|
|
|
from tests.logging import LoggerCleanupMixin
|
|
|
|
from tests.unittest import TestCase
|
2019-08-28 13:18:53 +02:00
|
|
|
|
|
|
|
|
2020-10-29 12:27:37 +01:00
|
|
|
class TerseJsonTestCase(LoggerCleanupMixin, TestCase):
|
2020-12-11 13:25:01 +01:00
|
|
|
def setUp(self):
|
|
|
|
self.output = StringIO()
|
|
|
|
|
|
|
|
def get_log_line(self):
|
|
|
|
# One log message, with a single trailing newline.
|
|
|
|
data = self.output.getvalue()
|
|
|
|
logs = data.splitlines()
|
|
|
|
self.assertEqual(len(logs), 1)
|
|
|
|
self.assertEqual(data.count("\n"), 1)
|
|
|
|
return json.loads(logs[0])
|
|
|
|
|
2020-10-29 12:27:37 +01:00
|
|
|
def test_terse_json_output(self):
|
2019-08-28 13:18:53 +02:00
|
|
|
"""
|
2020-10-29 12:27:37 +01:00
|
|
|
The Terse JSON formatter converts log messages to JSON.
|
2019-08-28 13:18:53 +02:00
|
|
|
"""
|
2020-12-11 13:25:01 +01:00
|
|
|
handler = logging.StreamHandler(self.output)
|
2020-10-29 12:27:37 +01:00
|
|
|
handler.setFormatter(TerseJsonFormatter())
|
|
|
|
logger = self.get_logger(handler)
|
2019-08-28 13:18:53 +02:00
|
|
|
|
2020-10-29 12:27:37 +01:00
|
|
|
logger.info("Hello there, %s!", "wally")
|
2019-08-28 13:18:53 +02:00
|
|
|
|
2020-12-11 13:25:01 +01:00
|
|
|
log = self.get_log_line()
|
2019-08-28 13:18:53 +02:00
|
|
|
|
|
|
|
# The terse logger should give us these keys.
|
|
|
|
expected_log_keys = [
|
|
|
|
"log",
|
|
|
|
"time",
|
|
|
|
"level",
|
2020-10-29 12:27:37 +01:00
|
|
|
"namespace",
|
2019-08-28 13:18:53 +02:00
|
|
|
]
|
2020-10-21 12:59:54 +02:00
|
|
|
self.assertCountEqual(log.keys(), expected_log_keys)
|
2020-10-29 12:27:37 +01:00
|
|
|
self.assertEqual(log["log"], "Hello there, wally!")
|
2019-08-28 13:18:53 +02:00
|
|
|
|
2020-10-29 12:27:37 +01:00
|
|
|
def test_extra_data(self):
|
2019-08-28 13:18:53 +02:00
|
|
|
"""
|
2020-10-29 12:27:37 +01:00
|
|
|
Additional information can be included in the structured logging.
|
2019-08-28 13:18:53 +02:00
|
|
|
"""
|
2020-12-11 13:25:01 +01:00
|
|
|
handler = logging.StreamHandler(self.output)
|
2020-10-29 12:27:37 +01:00
|
|
|
handler.setFormatter(TerseJsonFormatter())
|
|
|
|
logger = self.get_logger(handler)
|
2019-08-28 13:18:53 +02:00
|
|
|
|
2020-10-29 12:27:37 +01:00
|
|
|
logger.info(
|
|
|
|
"Hello there, %s!", "wally", extra={"foo": "bar", "int": 3, "bool": True}
|
2019-08-28 13:18:53 +02:00
|
|
|
)
|
|
|
|
|
2020-12-11 13:25:01 +01:00
|
|
|
log = self.get_log_line()
|
2019-08-28 13:18:53 +02:00
|
|
|
|
2020-10-29 12:27:37 +01:00
|
|
|
# The terse logger should give us these keys.
|
|
|
|
expected_log_keys = [
|
|
|
|
"log",
|
|
|
|
"time",
|
|
|
|
"level",
|
|
|
|
"namespace",
|
|
|
|
# The additional keys given via extra.
|
|
|
|
"foo",
|
|
|
|
"int",
|
|
|
|
"bool",
|
|
|
|
]
|
|
|
|
self.assertCountEqual(log.keys(), expected_log_keys)
|
2019-08-28 13:18:53 +02:00
|
|
|
|
2020-10-29 12:27:37 +01:00
|
|
|
# Check the values of the extra fields.
|
|
|
|
self.assertEqual(log["foo"], "bar")
|
|
|
|
self.assertEqual(log["int"], 3)
|
|
|
|
self.assertIs(log["bool"], True)
|
2019-08-28 13:18:53 +02:00
|
|
|
|
2020-10-29 12:27:37 +01:00
|
|
|
def test_json_output(self):
|
2019-08-28 13:18:53 +02:00
|
|
|
"""
|
2020-10-29 12:27:37 +01:00
|
|
|
The Terse JSON formatter converts log messages to JSON.
|
2019-08-28 13:18:53 +02:00
|
|
|
"""
|
2020-12-11 13:25:01 +01:00
|
|
|
handler = logging.StreamHandler(self.output)
|
2020-10-29 12:27:37 +01:00
|
|
|
handler.setFormatter(JsonFormatter())
|
|
|
|
logger = self.get_logger(handler)
|
2019-08-28 13:18:53 +02:00
|
|
|
|
2020-10-29 12:27:37 +01:00
|
|
|
logger.info("Hello there, %s!", "wally")
|
2019-08-28 13:18:53 +02:00
|
|
|
|
2020-12-11 13:25:01 +01:00
|
|
|
log = self.get_log_line()
|
|
|
|
|
|
|
|
# The terse logger should give us these keys.
|
|
|
|
expected_log_keys = [
|
|
|
|
"log",
|
|
|
|
"level",
|
|
|
|
"namespace",
|
|
|
|
]
|
|
|
|
self.assertCountEqual(log.keys(), expected_log_keys)
|
|
|
|
self.assertEqual(log["log"], "Hello there, wally!")
|
|
|
|
|
|
|
|
def test_with_context(self):
|
|
|
|
"""
|
|
|
|
The logging context should be added to the JSON response.
|
|
|
|
"""
|
|
|
|
handler = logging.StreamHandler(self.output)
|
|
|
|
handler.setFormatter(JsonFormatter())
|
2020-12-14 20:19:47 +01:00
|
|
|
handler.addFilter(LoggingContextFilter())
|
2020-12-11 13:25:01 +01:00
|
|
|
logger = self.get_logger(handler)
|
|
|
|
|
2020-12-14 20:19:47 +01:00
|
|
|
with LoggingContext(request="test"):
|
2020-12-11 13:25:01 +01:00
|
|
|
logger.info("Hello there, %s!", "wally")
|
|
|
|
|
|
|
|
log = self.get_log_line()
|
2019-08-28 13:18:53 +02:00
|
|
|
|
2020-10-29 12:27:37 +01:00
|
|
|
# The terse logger should give us these keys.
|
|
|
|
expected_log_keys = [
|
|
|
|
"log",
|
|
|
|
"level",
|
|
|
|
"namespace",
|
2020-12-11 13:25:01 +01:00
|
|
|
"request",
|
2020-10-29 12:27:37 +01:00
|
|
|
]
|
|
|
|
self.assertCountEqual(log.keys(), expected_log_keys)
|
|
|
|
self.assertEqual(log["log"], "Hello there, wally!")
|
2020-12-11 13:25:01 +01:00
|
|
|
self.assertEqual(log["request"], "test")
|