tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

Unread counts fixes (#8254)

Browse source 
* Fixup `ALTER TABLE` database queries

Make the new columns nullable, because doing otherwise can wedge a
server with a big database, as setting a default value rewrites the
table.

* Switch back to using the notifications count in the push badge

Clients are likely to be confused if we send a push but the badge count
is the unread messages one, and not the notifications one.

* Changelog
This commit is contained in:
Brendan Abolivier 2020-09-04 14:14:22 +01:00 committed by GitHub
parent db7de4d182
commit 041ee971c9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/8254.feature Normal file
View file

@ -0,0 +1 @@
Add unread messages count to sync responses, as specified in [MSC2654](https://github.com/matrix-org/matrix-doc/pull/2654).

2
synapse/push/push_tools.py
View file

@ -36,7 +36,7 @@ async def get_badge_count(store, user_id):
) )
# return one badge count per conversation, as count per # return one badge count per conversation, as count per
# message is so noisy as to be almost useless # message is so noisy as to be almost useless
badge += 1 if notifs["unread_count"] else 0 badge += 1 if notifs["notify_count"] else 0
return badge return badge

6
synapse/storage/databases/main/schema/delta/58/15unread_count.sql
View file

@ -19,8 +19,8 @@
-- Add columns to event_push_actions and event_push_actions_staging to track unread -- Add columns to event_push_actions and event_push_actions_staging to track unread
-- messages and calculate unread counts. -- messages and calculate unread counts.
ALTER TABLE event_push_actions_staging ADD COLUMN unread SMALLINT NOT NULL DEFAULT 0; ALTER TABLE event_push_actions_staging ADD COLUMN unread SMALLINT;
ALTER TABLE event_push_actions ADD COLUMN unread SMALLINT NOT NULL DEFAULT 0; ALTER TABLE event_push_actions ADD COLUMN unread SMALLINT;
-- Add column to event_push_summary -- Add column to event_push_summary
ALTER TABLE event_push_summary ADD COLUMN unread_count BIGINT NOT NULL DEFAULT 0; ALTER TABLE event_push_summary ADD COLUMN unread_count BIGINT;