tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

avoid modifying input parameter

Browse source
This commit is contained in:
Hubert Chathi 2019-09-05 17:03:31 -04:00
parent e47af0f086
commit 369462da74
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
synapse/handlers/e2e_keys.py
View file

@ -629,9 +629,9 @@ class E2eKeysHandler(object):
# split between checking signatures for own user and signatures for # split between checking signatures for own user and signatures for
# other users, since we verify them with different keys # other users, since we verify them with different keys
if user_id in signatures: self_signatures = signatures.get(user_id, {})
self_signatures = signatures[user_id] other_signatures = {k: v for k, v in signatures.items() if k != user_id}
del signatures[user_id] if self_signatures:
self_device_ids = list(self_signatures.keys()) self_device_ids = list(self_signatures.keys())
try: try:
# get our self-signing key to verify the signatures # get our self-signing key to verify the signatures
@ -766,9 +766,9 @@ class E2eKeysHandler(object):
} }
signed_users = [] # what user have been signed, for notifying signed_users = [] # what user have been signed, for notifying
if len(signatures): if other_signatures:
# if signatures isn't empty, then we have signatures for other # now check non-self signatures. These signatures will be signed
# users. These signatures will be signed by the user signing key # by the user-signing key
try: try:
# get our user-signing key to verify the signatures # get our user-signing key to verify the signatures
@ -776,7 +776,7 @@ class E2eKeysHandler(object):
user_id, "user_signing" user_id, "user_signing"
) )
for user, devicemap in signatures.items(): for user, devicemap in other_signatures.items():
device_id = None device_id = None
try: try:
# get the user's master key, to make sure it matches # get the user's master key, to make sure it matches