Review comments

This commit is contained in:
Erik Johnston 2019-09-25 17:22:33 +01:00
parent f8b02c5420
commit 39b50ad42a
4 changed files with 4 additions and 7 deletions

View file

@ -315,7 +315,7 @@ redaction_retention_period: 7d
# How long to track users' last seen time and IPs in the database.
#
# Defaults to `28d`. Set to `null` to disable.
# Defaults to `28d`. Set to `null` to disable clearing out of old rows.
#
#user_ips_max_age: 14d

View file

@ -745,7 +745,7 @@ class ServerConfig(Config):
# How long to track users' last seen time and IPs in the database.
#
# Defaults to `28d`. Set to `null` to disable.
# Defaults to `28d`. Set to `null` to disable clearing out of old rows.
#
#user_ips_max_age: 14d
"""

View file

@ -148,11 +148,8 @@ class BackgroundUpdateStore(SQLBaseStore):
return False
async def has_completed_background_update(self, update_name):
async def has_completed_background_update(self, update_name) -> bool:
"""Check if the given background update has finished running.
Returns:
Deferred[bool]
"""
if self._all_done:

View file

@ -506,7 +506,7 @@ class ClientIpStore(background_updates.BackgroundUpdateStore):
"""Removes entries in user IPs older than the configured period.
"""
if not self.user_ips_max_age:
if self.user_ips_max_age is None:
# Nothing to do
return