Rename context factory

Mjark is officially no fun.
This commit is contained in:
Daniel Wagner-Hall 2015-09-15 15:46:22 +01:00
parent 9fc0aad567
commit 3bcbabc9fb
2 changed files with 5 additions and 5 deletions

View file

@ -261,11 +261,11 @@ def _print_ex(e):
logger.exception(e) logger.exception(e)
class WoefullyInsecureContextFactory(ssl.ContextFactory): class InsecureInterceptableContextFactory(ssl.ContextFactory):
""" """
Factory for PyOpenSSL SSL contexts which does absolutely no certificate verification. Factory for PyOpenSSL SSL contexts which accepts any certificate for any domain.
Do not use this unless you really, really hate your users. Do not use this since it allows an attacker to intercept your communications.
""" """
def __init__(self): def __init__(self):

View file

@ -21,7 +21,7 @@
# Imports required for the default HomeServer() implementation # Imports required for the default HomeServer() implementation
from twisted.web.client import BrowserLikePolicyForHTTPS from twisted.web.client import BrowserLikePolicyForHTTPS
from synapse.federation import initialize_http_replication from synapse.federation import initialize_http_replication
from synapse.http.client import SimpleHttpClient, WoefullyInsecureContextFactory from synapse.http.client import SimpleHttpClient, InsecureInterceptableContextFactory
from synapse.notifier import Notifier from synapse.notifier import Notifier
from synapse.api.auth import Auth from synapse.api.auth import Auth
from synapse.handlers import Handlers from synapse.handlers import Handlers
@ -181,7 +181,7 @@ class HomeServer(BaseHomeServer):
def build_http_client_context_factory(self): def build_http_client_context_factory(self):
config = self.get_config() config = self.get_config()
return ( return (
WoefullyInsecureContextFactory() if config.use_insecure_ssl_client InsecureInterceptableContextFactory() if config.use_insecure_ssl_client
else BrowserLikePolicyForHTTPS() else BrowserLikePolicyForHTTPS()
) )