tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

Fix imsync's SELECT query to only find the rooms I'm actually joined in, not every room I have ever joined

Browse source
This commit is contained in:
Paul "LeoNerd" Evans 2014-08-15 15:44:53 +01:00
parent 5c88e57555
commit 3c532314ec
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
synapse/storage/roommember.py
View file

@ -111,9 +111,12 @@ class RoomMemberStore(SQLBaseStore):
for membership in membership_list: for membership in membership_list:
args.append(membership) args.append(membership)
# sub-select finds the row ID for the most recent (i.e. current)
# state change of this user per room, then the outer select finds those
query = ("SELECT room_id, membership FROM room_memberships" query = ("SELECT room_id, membership FROM room_memberships"
+ " WHERE user_id=? AND " + where_membership + " WHERE id IN (SELECT MAX(id) FROM room_memberships"
+ " GROUP BY room_id ORDER BY id DESC") + " WHERE user_id=? GROUP BY room_id)"
+ " AND " + where_membership)
return self._execute( return self._execute(
self.cursor_to_dict, query, *args self.cursor_to_dict, query, *args
) )