tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

Port group attestation renewal slow down from matrix-org-hotfixes (#7442)

Browse source
This commit is contained in:
Andrew Morgan 2020-05-06 20:21:38 +01:00 committed by GitHub
parent e053c86a96
commit 4162c39dcf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/7442.misc Normal file
View file

@ -0,0 +1 @@
Run group attestation renewal in series rather than parallel for performance.

6
synapse/groups/attestations.py
View file

@ -46,7 +46,6 @@ from twisted.internet import defer
from synapse.api.errors import HttpResponseException, RequestSendFailed, SynapseError from synapse.api.errors import HttpResponseException, RequestSendFailed, SynapseError
from synapse.metrics.background_process_metrics import run_as_background_process from synapse.metrics.background_process_metrics import run_as_background_process
from synapse.types import get_domain_from_id from synapse.types import get_domain_from_id
from synapse.util.async_helpers import yieldable_gather_results
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
@ -208,6 +207,5 @@ class GroupAttestionRenewer(object):
"Error renewing attestation of %r in %r", user_id, group_id "Error renewing attestation of %r in %r", user_id, group_id
) )
await yieldable_gather_results( for row in rows:
_renew_attestation, ((row["group_id"], row["user_id"]) for row in rows) await _renew_attestation((row["group_id"], row["user_id"]))
)