tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

Reject large transactions on federation (#4513)

Browse source 
* Reject large transactions on federation

* Add changelog

* lint

* Simplify large transaction handling
This commit is contained in:
Andrew Morgan 2019-01-31 11:44:04 +00:00 committed by Amber Brown
parent 6fba9fd20c
commit 563f6a832b
2 changed files with 17 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/4513.misc Normal file
View file

@ -0,0 +1 @@
Reject federation transactions if they include more than 50 PDUs or 100 EDUs.

16
synapse/federation/federation_server.py
View file

@ -148,6 +148,22 @@ class FederationServer(FederationBase):
logger.debug("[%s] Transaction is new", transaction.transaction_id) logger.debug("[%s] Transaction is new", transaction.transaction_id)
# Reject if PDU count > 50 and EDU count > 100
if (len(transaction.pdus) > 50
or (hasattr(transaction, "edus") and len(transaction.edus) > 100)):
logger.info(
"Transaction PDU or EDU count too large. Returning 400",
)
response = {}
yield self.transaction_actions.set_response(
origin,
transaction,
400, response
)
defer.returnValue((400, response))
received_pdus_counter.inc(len(transaction.pdus)) received_pdus_counter.inc(len(transaction.pdus))
origin_host, _ = parse_server_name(origin) origin_host, _ = parse_server_name(origin)