tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

Fix error in thumbnail generation (#11288)

Browse source 
Signed-off-by: Jonas Zeunert <jonas@zeunert.org>
This commit is contained in:
Neeeflix 2021-11-10 21:49:43 +01:00 committed by GitHub
parent 5cace20bf1
commit 6ce19b94e8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/11288.bugfix Normal file
View file

@ -0,0 +1 @@
Fix a long-standing bug where uploading extremely thin images (e.g. 1000x1) would fail. Contributed by @Neeeflix.

8
synapse/rest/media/v1/thumbnailer.py
View file

@ -101,8 +101,8 @@ class Thumbnailer:
fits within the given rectangle:: fits within the given rectangle::
(w_in / h_in) = (w_out / h_out) (w_in / h_in) = (w_out / h_out)
w_out = min(w_max, h_max * (w_in / h_in)) w_out = max(min(w_max, h_max * (w_in / h_in)), 1)
h_out = min(h_max, w_max * (h_in / w_in)) h_out = max(min(h_max, w_max * (h_in / w_in)), 1)
Args: Args:
max_width: The largest possible width. max_width: The largest possible width.
@ -110,9 +110,9 @@ class Thumbnailer:
""" """
if max_width * self.height < max_height * self.width: if max_width * self.height < max_height * self.width:
return max_width, (max_width * self.height) // self.width return max_width, max((max_width * self.height) // self.width, 1)
else: else:
return (max_height * self.width) // self.height, max_height return max((max_height * self.width) // self.height, 1), max_height
def _resize(self, width: int, height: int) -> Image.Image: def _resize(self, width: int, height: int) -> Image.Image:
# 1-bit or 8-bit color palette images need converting to RGB # 1-bit or 8-bit color palette images need converting to RGB