tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

Merge pull request #3521 from matrix-org/rav/optimise_stream_change_cache

Browse source 
Reduce set building in get_entities_changed
This commit is contained in:
Richard van der Hoff 2018-07-12 12:08:49 +01:00 committed by GitHub
commit 6dff49b8a9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/3521.feature Normal file
View file

@ -0,0 +1 @@
Cache optimisation for /sync requests

18
synapse/util/caches/stream_change_cache.py
View file

@ -74,14 +74,18 @@ class StreamChangeCache(object):
assert type(stream_pos) is int assert type(stream_pos) is int
if stream_pos >= self._earliest_known_stream_pos: if stream_pos >= self._earliest_known_stream_pos:
not_known_entities = set(entities) - set(self._entity_to_key) changed_entities = {
self._cache[k] for k in self._cache.islice(
result = ( start=self._cache.bisect_right(stream_pos),
{self._cache[k] for k in self._cache.islice(
start=self._cache.bisect_right(stream_pos))}
.intersection(entities)
.union(not_known_entities)
) )
}
# we need to include entities which we don't know about, as well as
# those which are known to have changed since the stream pos.
result = {
e for e in entities
if e in changed_entities or e not in self._entity_to_key
}
self.metrics.inc_hits() self.metrics.inc_hits()
else: else: