Since empty lookups now return 200/empty list not 404, we can safely log failures as exceptions

This commit is contained in:
Paul "LeoNerd" Evans 2016-08-18 14:18:37 +01:00
parent 3856582741
commit 718ffcf8bb

View file

@ -78,9 +78,8 @@ class ApplicationServiceApi(SimpleHttpClient):
try:
response = yield self.get_json(uri, fields)
defer.returnValue(response)
except Exception:
# TODO: would be noisy to log lookup failures, but we want to log
# other things. Hrm.
except Exception as ex:
logger.warning("query_3pu to %s threw exception %s", uri, ex)
defer.returnValue([])
@defer.inlineCallbacks