tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

Since empty lookups now return 200/empty list not 404, we can safely log failures as exceptions

Browse source
This commit is contained in:
Paul "LeoNerd" Evans 2016-08-18 14:18:37 +01:00
parent 3856582741
commit 718ffcf8bb
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
synapse/appservice/api.py
View file

@ -78,9 +78,8 @@ class ApplicationServiceApi(SimpleHttpClient):
try: try:
response = yield self.get_json(uri, fields) response = yield self.get_json(uri, fields)
defer.returnValue(response) defer.returnValue(response)
except Exception: except Exception as ex:
# TODO: would be noisy to log lookup failures, but we want to log logger.warning("query_3pu to %s threw exception %s", uri, ex)
# other things. Hrm.
defer.returnValue([]) defer.returnValue([])
@defer.inlineCallbacks @defer.inlineCallbacks