tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

Ease searching for M_TOO_LARGE-related error codes (#10750)

Browse source
This commit is contained in:
Andrew Morgan 2021-09-06 14:35:56 +01:00 committed by GitHub
parent e1641b46d1
commit 7bb3673f37
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/10750.misc Normal file
View file

@ -0,0 +1 @@
Refactor event size checking code to simplify searching the codebase for the origins of certain error strings that are occasionally emitted.

15
synapse/event_auth.py
View file

@ -216,21 +216,18 @@ def check(
def _check_size_limits(event: EventBase) -> None: def _check_size_limits(event: EventBase) -> None:
def too_big(field):
raise EventSizeError("%s too large" % (field,))
if len(event.user_id) > 255: if len(event.user_id) > 255:
too_big("user_id") raise EventSizeError("'user_id' too large")
if len(event.room_id) > 255: if len(event.room_id) > 255:
too_big("room_id") raise EventSizeError("'room_id' too large")
if event.is_state() and len(event.state_key) > 255: if event.is_state() and len(event.state_key) > 255:
too_big("state_key") raise EventSizeError("'state_key' too large")
if len(event.type) > 255: if len(event.type) > 255:
too_big("type") raise EventSizeError("'type' too large")
if len(event.event_id) > 255: if len(event.event_id) > 255:
too_big("event_id") raise EventSizeError("'event_id' too large")
if len(encode_canonical_json(event.get_pdu_json())) > MAX_PDU_SIZE: if len(encode_canonical_json(event.get_pdu_json())) > MAX_PDU_SIZE:
too_big("event") raise EventSizeError("event too large")
def _can_federate(event: EventBase, auth_events: StateMap[EventBase]) -> bool: def _can_federate(event: EventBase, auth_events: StateMap[EventBase]) -> bool: