tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

Fix "Re-starting finished log context" spam when creating events (#14947)

Browse source 
`run_in_background` calls re-use the current logging context. When they
are not awaited, they can complete after the current logging context has
been marked as finished, which leads to log spam. Use
`run_as_background_process` instead.

Fixes one of the instances of #13090.

Signed-off-by: Sean Quah <seanq@matrix.org>
This commit is contained in:
Sean Quah 2023-01-31 11:31:52 +00:00 committed by GitHub
parent 6d14fdc271
commit 805b641fb6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/14947.bugfix Normal file
View file

@ -0,0 +1 @@
Fix a long-standing bug where sending messages on servers with presence enabled would spam "Re-starting finished log context" log lines.

4
synapse/handlers/message.py
View file

@ -1939,7 +1939,9 @@ class EventCreationHandler:
if event.type == EventTypes.Message:
# We don't want to block sending messages on any presence code. This
# matters as sometimes presence code can take a while.
run_in_background(self._bump_active_time, requester.user)
run_as_background_process(
"bump_presence_active_time", self._bump_active_time, requester.user
)
async def _notify() -> None:
try: