Merge pull request #3754 from matrix-org/erikj/fix_whitelist

Allow federation_domain_whitelist to be emtpy list
This commit is contained in:
Erik Johnston 2018-08-24 12:23:39 +01:00 committed by GitHub
commit 84b4e76fed
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions

1
changelog.d/3754.bugfix Normal file
View file

@ -0,0 +1 @@
Fix 'federation_domain_whitelist' such that an empty list correctly blocks all outbound federation traffic

View file

@ -133,7 +133,7 @@ class MatrixFederationHttpClient(object):
failures, connection failures, SSL failures.) failures, connection failures, SSL failures.)
""" """
if ( if (
self.hs.config.federation_domain_whitelist and self.hs.config.federation_domain_whitelist is not None and
destination not in self.hs.config.federation_domain_whitelist destination not in self.hs.config.federation_domain_whitelist
): ):
raise FederationDeniedError(destination) raise FederationDeniedError(destination)