tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

Cache is_partial_state_room (#13693)

Browse source 
Fixes #13613.
This commit is contained in:
Erik Johnston 2022-09-01 17:07:01 +02:00 committed by GitHub
parent c913e440c0
commit 9d2823ab70
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/13693.misc Normal file
View file

@ -0,0 +1 @@
Add cache to `is_partial_state_room`.

11
synapse/storage/databases/main/room.py
View file

@ -1185,8 +1185,9 @@ class RoomWorkerStore(CacheInvalidationWorkerStore):
) )
return False return False
@staticmethod def _clear_partial_state_room_txn(
def _clear_partial_state_room_txn(txn: LoggingTransaction, room_id: str) -> None: self, txn: LoggingTransaction, room_id: str
) -> None:
DatabasePool.simple_delete_txn( DatabasePool.simple_delete_txn(
txn, txn,
table="partial_state_rooms_servers", table="partial_state_rooms_servers",
@ -1197,7 +1198,9 @@ class RoomWorkerStore(CacheInvalidationWorkerStore):
table="partial_state_rooms", table="partial_state_rooms",
keyvalues={"room_id": room_id}, keyvalues={"room_id": room_id},
) )
self._invalidate_cache_and_stream(txn, self.is_partial_state_room, (room_id,))
@cached()
async def is_partial_state_room(self, room_id: str) -> bool: async def is_partial_state_room(self, room_id: str) -> bool:
"""Checks if this room has partial state. """Checks if this room has partial state.
@ -1771,9 +1774,8 @@ class RoomStore(RoomBackgroundUpdateStore, RoomWorkerStore):
servers, servers,
) )
@staticmethod
def _store_partial_state_room_txn( def _store_partial_state_room_txn(
txn: LoggingTransaction, room_id: str, servers: Collection[str] self, txn: LoggingTransaction, room_id: str, servers: Collection[str]
) -> None: ) -> None:
DatabasePool.simple_insert_txn( DatabasePool.simple_insert_txn(
txn, txn,
@ -1788,6 +1790,7 @@ class RoomStore(RoomBackgroundUpdateStore, RoomWorkerStore):
keys=("room_id", "server_name"), keys=("room_id", "server_name"),
values=((room_id, s) for s in servers), values=((room_id, s) for s in servers),
) )
self._invalidate_cache_and_stream(txn, self.is_partial_state_room, (room_id,))
async def maybe_store_room_on_outlier_membership( async def maybe_store_room_on_outlier_membership(
self, room_id: str, room_version: RoomVersion self, room_id: str, room_version: RoomVersion