forked from MirrorHub/synapse
Enable reconnection in DB pool (#8726)
`adbapi.ConnectionPool` let's you turn on auto reconnect of DB connections. This is off by default. As far as I can tell if its not enabled dead connections never get removed from the pool. Maybe helps #8574
This commit is contained in:
parent
41a389934e
commit
c2d4467cd4
1
changelog.d/8726.bugfix
Normal file
1
changelog.d/8726.bugfix
Normal file
|
@ -0,0 +1 @@
|
|||
Fix bug where Synapse would not recover after losing connection to the database.
|
|
@ -88,13 +88,18 @@ def make_pool(
|
|||
"""Get the connection pool for the database.
|
||||
"""
|
||||
|
||||
# By default enable `cp_reconnect`. We need to fiddle with db_args in case
|
||||
# someone has explicitly set `cp_reconnect`.
|
||||
db_args = dict(db_config.config.get("args", {}))
|
||||
db_args.setdefault("cp_reconnect", True)
|
||||
|
||||
return adbapi.ConnectionPool(
|
||||
db_config.config["name"],
|
||||
cp_reactor=reactor,
|
||||
cp_openfun=lambda conn: engine.on_new_connection(
|
||||
LoggingDatabaseConnection(conn, engine, "on_new_connection")
|
||||
),
|
||||
**db_config.config.get("args", {}),
|
||||
**db_args,
|
||||
)
|
||||
|
||||
|
||||
|
|
Loading…
Reference in a new issue