tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

Remove unused VerifyKey.expired and .time_added fields (#5235)

Browse source 
These were never used, and poking arbitary data into objects from other
packages seems confusing at best.
This commit is contained in:
Richard van der Hoff 2019-05-23 11:46:05 +01:00 committed by GitHub
parent 2e052110ee
commit cc187f9337
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/5235.misc Normal file
View file

@ -0,0 +1 @@
Remove unused VerifyKey.expired and .time_added fields.

3
synapse/crypto/keyring.py
View file

@ -589,7 +589,6 @@ class Keyring(object):
key_base64 = key_data["key"] key_base64 = key_data["key"]
key_bytes = decode_base64(key_base64) key_bytes = decode_base64(key_base64)
verify_key = decode_verify_key_bytes(key_id, key_bytes) verify_key = decode_verify_key_bytes(key_id, key_bytes)
verify_key.time_added = time_now_ms
verify_keys[key_id] = verify_key verify_keys[key_id] = verify_key
old_verify_keys = {} old_verify_keys = {}
@ -598,8 +597,6 @@ class Keyring(object):
key_base64 = key_data["key"] key_base64 = key_data["key"]
key_bytes = decode_base64(key_base64) key_bytes = decode_base64(key_base64)
verify_key = decode_verify_key_bytes(key_id, key_bytes) verify_key = decode_verify_key_bytes(key_id, key_bytes)
verify_key.expired = key_data["expired_ts"]
verify_key.time_added = time_now_ms
old_verify_keys[key_id] = verify_key old_verify_keys[key_id] = verify_key
server_name = response_json["server_name"] server_name = response_json["server_name"]