tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

Merge pull request #513 from matrix-org/erikj/register_user_chars

Browse source 
Don't explode when given a unicode username in /register/
This commit is contained in:
Erik Johnston 2016-01-21 09:53:35 +00:00
commit d049e81b10
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
synapse/handlers/register.py
View file

@ -49,11 +49,10 @@ class RegistrationHandler(BaseHandler):
def check_username(self, localpart, guest_access_token=None): def check_username(self, localpart, guest_access_token=None):
yield run_on_reactor() yield run_on_reactor()
if urllib.quote(localpart) != localpart: if urllib.quote(localpart.encode('utf-8')) != localpart:
raise SynapseError( raise SynapseError(
400, 400,
"User ID must only contain characters which do not" "User ID can only contain characters a-z, 0-9, or '-./'",
" require URL encoding.",
Codes.INVALID_USERNAME Codes.INVALID_USERNAME
) )