tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

Fix a stale comment in get_room_version_id_txn. (#12969)

Browse source
This commit is contained in:
Patrick Cloke 2022-06-07 07:44:31 -04:00 committed by GitHub
parent 9dc3293e0b
commit d2fd7f7b5c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/12969.misc Normal file
View file

@ -0,0 +1 @@
Fix an inaccurate comment.

7
synapse/storage/databases/main/state.py
View file

@ -127,13 +127,8 @@ class StateGroupWorkerStore(EventsWorkerStore, SQLBaseStore):
NotFoundError: if the room is unknown NotFoundError: if the room is unknown
""" """
# First we try looking up room version from the database, but for old
# rooms we might not have added the room version to it yet so we fall
# back to previous behaviour and look in current state events.
#
# We really should have an entry in the rooms table for every room we # We really should have an entry in the rooms table for every room we
# care about, but let's be a bit paranoid (at least while the background # care about, but let's be a bit paranoid.
# update is happening) to avoid breaking existing rooms.
room_version = self.db_pool.simple_select_one_onecol_txn( room_version = self.db_pool.simple_select_one_onecol_txn(
txn, txn,
table="rooms", table="rooms",