tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

Do not attempt to bundled aggregations for /members and /state. (#11623)

Browse source 
Both of those APIs return state events, which will not have bundled
aggregations added anyway.
This commit is contained in:
Patrick Cloke 2021-12-29 08:02:03 -05:00 committed by GitHub
parent 15bb1c8511
commit f58b300d27
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/11623.bugfix Normal file
View file

@ -0,0 +1 @@
Fix a long-standing bug where responses included bundled aggregations when they should not, per [MSC2675](https://github.com/matrix-org/matrix-doc/pull/2675).

4
synapse/handlers/message.py
View file

@ -246,9 +246,7 @@ class MessageHandler:
room_state = room_state_events[membership_event_id]
now = self.clock.time_msec()
events = await self._event_serializer.serialize_events(
room_state.values(), now, bundle_aggregations=True
)
events = await self._event_serializer.serialize_events(room_state.values(), now)
return events
async def get_joined_members(self, requester: Requester, room_id: str) -> dict: