tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

Fix bug with reusing 'txn' when persisting event. (#10743)

Browse source 
This will only happen when a server has multiple out of band membership
events in a single room.
This commit is contained in:
Erik Johnston 2021-09-03 10:59:25 +01:00 committed by GitHub
parent 00640ee71a
commit f58d202e3f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
changelog.d/10743.bugfix Normal file
View file

@ -0,0 +1 @@
Fix edge case when persisting events into a room where there are multiple events we previously hadn't calculated auth chains for (and hadn't marked as needing to be calculated).

8
synapse/storage/databases/main/events.py
View file

@ -575,7 +575,13 @@ class PersistEventsStore:
missing_auth_chains.clear()
for auth_id, event_type, state_key, chain_id, sequence_number in txn:
for (
auth_id,
event_type,
state_key,
chain_id,
sequence_number,
) in txn.fetchall():
event_to_types[auth_id] = (event_type, state_key)
if chain_id is None: