Move arg default to the start of the function

Also don't overwrite the list that gets passed in.
This commit is contained in:
Richard van der Hoff 2016-03-02 16:44:14 +00:00
parent 863d3f26b3
commit fc1f932cc0

View file

@ -493,6 +493,8 @@ class RoomMemberHandler(BaseHandler):
Raises: Raises:
SynapseError if there was a problem changing the membership. SynapseError if there was a problem changing the membership.
""" """
remote_room_hosts = remote_room_hosts or []
target_user = UserID.from_string(event.state_key) target_user = UserID.from_string(event.state_key)
room_id = event.room_id room_id = event.room_id
@ -537,8 +539,7 @@ class RoomMemberHandler(BaseHandler):
pass pass
else: else:
# send the rejection to the inviter's HS. # send the rejection to the inviter's HS.
remote_room_hosts = remote_room_hosts or [] remote_room_hosts = remote_room_hosts + [inviter.doman]
remote_room_hosts.append(inviter.domain)
action = "remote_reject" action = "remote_reject"
federation_handler = self.hs.get_handlers().federation_handler federation_handler = self.hs.get_handlers().federation_handler