tileradotorg/synapse
1
0
Fork 0
forked from MirrorHub/synapse
Code Pull requests Activity

Cleanup top level request exception logging

Browse source 
Firstly, we always logged that the request was being handled via
`JsonResource._async_render`, so we change that to use the servlet name
we add to the request.

Secondly, we pass the exception information to the logger rather than
formatting it manually. This makes it consistent with other exception
logging, allwoing logging hooks and formatters to access the exception
information.
This commit is contained in:
Erik Johnston 2019-02-18 15:11:04 +00:00
parent d1b060b492
commit fe725f7e45
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
synapse/http/server.py
View file

@ -106,10 +106,10 @@ def wrap_json_request_handler(h):
# trace. # trace.
f = failure.Failure() f = failure.Failure()
logger.error( logger.error(
"Failed handle request via %r: %r: %s", "Failed handle request via %r: %r",
h, request.request_metrics.name,
request, request,
f.getTraceback().rstrip(), exc_info=(f.type, f.value, f.getTracebackObject()),
) )
# Only respond with an error response if we haven't already started # Only respond with an error response if we haven't already started
# writing, otherwise lets just kill the connection # writing, otherwise lets just kill the connection