Merge branch 'erikj/cache_deferreds' of github.com:matrix-org/synapse into erikj/cache_varargs_interface

This commit is contained in:
Erik Johnston 2015-08-07 19:18:47 +01:00
commit ffab798a38

View file

@ -184,8 +184,8 @@ class CacheDescriptor(object):
try:
cached_result_d = self.cache.get(keyargs)
observed = cached_result_d.observe()
if DEBUG_CACHES:
@defer.inlineCallbacks
def check_result(cached_result):
actual_result = yield self.function_to_call(obj, *args, **kwargs)
@ -196,9 +196,10 @@ class CacheDescriptor(object):
cached_result, actual_result,
)
raise ValueError("Stale cache entry")
cached_result_d.observe().addCallback(check_result)
defer.returnValue(cached_result)
observed.addCallback(check_result)
return cached_result_d.observe()
return observed
except KeyError:
# Get the sequence number of the cache before reading from the
# database so that we can tell if the cache is invalidated