tileradotorg/synapse

Author	SHA1	Message	Date
Andrew Morgan	c4514b97db	Add missing space before 'docker' link in release announcement script (#12612 )	2022-05-03 14:46:42 +00:00
Richard van der Hoff	db2edf5a65	Exclude OOB memberships from the federation sender (#12570 ) As the comment says, there is no need to process such events, and indeed we need to avoid doing so. Fixes #12509.	2022-05-03 12:47:56 +00:00
David Robertson	bf2fea8f7d	Add sanity checks to the release script (#12556 ) Check we're on the right branch before tagging, and on the right tag before uploading * Abort if we're on the wrong branch * Check we have the right tag checked out * Clarify that `publish` only releases to GitHub	2022-05-03 10:50:03 +00:00
Erik Johnston	ae7858f184	Fix race when persisting an event and deleting a room (#12594 ) This works by taking a row level lock on the `rooms` table at the start of both transactions, ensuring that they don't run at the same time. In the event persistence transaction we also check that there is an entry still in the `rooms` table. I can't figure out how to do this in SQLite. I was just going to lock the table, but it seems that we don't support that in SQLite either, so I'm really confused as to how we maintain integrity in SQLite when using `lock_table`....	2022-05-03 11:47:21 +01:00
David Robertson	01dcf7532d	Prune mypy ignore_missing_imports list (#12608 )	2022-05-03 11:03:20 +01:00
Richard van der Hoff	8d156ec0ba	Remove special-case for `twisted` logger (#12589 ) This was originally added when we first added a `MemoryHandler` to the default log config back in https://github.com/matrix-org/synapse/pull/8040, to ensure that we didn't explode with an infinite loop if there was an error formatting the logs. Since then, we made additional improvements to logging which make this workaround redundant. In particular: * we no longer attempt to log un-UTF8-decodable byte sequences, which were the most likely cause of an error in the first place. * https://github.com/matrix-org/synapse/pull/8268 ensures that in the unlikely case that there is an error, it won't cause an infinite loop.	2022-04-29 22:05:18 +01:00
David Robertson	57fac2a234	Allow unused ignores in "bleeding edge" CI (#12576 ) * Allow unused ignores in "bleeding edge" CI Where "bleeding edge" means the Twisted Trunk and Latest Deps jobs. Follow up from #12531. Resolves #12574. * Use `--extras all` in latest deps mypy CI Twisted trunk job already does this. Missed in #12531. * changelog	2022-04-29 17:57:23 +01:00
Patrick Cloke	3ae56d125c	Improve the docstrings for the receipts store. (#12581 )	2022-04-28 17:58:58 +00:00
Šimon Brandner	0d9eaa19fd	Use constants for receipt types in tests. (#12582 )	2022-04-28 13:34:33 -04:00
Sean Quah	0b684b59e5	Fix logging of incorrect status codes for disconnected requests (#12580 ) The status code of requests must always be set, regardless of client disconnection, otherwise they will always be logged as 200!. Broken for `respond_with_json` in `f48792eec4`. Broken for `respond_with_json_bytes` in `3e58ce72b4`. Broken for `respond_with_html_bytes` in `ea26e9a98b`. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-28 15:49:50 +00:00
DeepBlueV7.X	629aa51743	Add linebreak to pipx install quote in README (#12579 )	2022-04-28 13:54:46 +01:00
David Robertson	5d3509dfda	Revert accidental direct-to-develop commits. This reverts commit `5a320baa45`. This reverts commit `f282d5fc11`. This reverts commit `ce6ecdd4b4`.	2022-04-28 11:33:05 +01:00
David Robertson	5a320baa45	changelog	2022-04-28 11:31:26 +01:00
Sean Quah	78b99de7c2	Prefer `make_awaitable` over `defer.succeed` in tests (#12505 ) When configuring the return values of mocks, prefer awaitables from `make_awaitable` over `defer.succeed`. `Deferred`s are only awaitable once, so it is inappropriate for a mock to return the same `Deferred` multiple times. Also update `run_in_background` to support functions that return arbitrary awaitables. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-27 14:58:26 +01:00
Brendan Abolivier	5ef673de4f	Add a module API to allow modules to edit push rule actions (#12406 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-04-27 13:55:33 +00:00
reivilibre	d743b25c8f	Use supervisord to supervise Postgres and Caddy in the Complement image. (#12480 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-04-27 14:39:41 +01:00
David Robertson	30c8e7e408	Make `scripts-dev` pass `mypy --disallow-untyped-defs` (#12356 ) Not enforced in config yet. One day.	2022-04-27 13:10:31 +00:00
David Robertson	6463244375	Remove unused `# type: ignore`s (#12531 ) Over time we've begun to use newer versions of mypy, typeshed, stub packages---and of course we've improved our own annotations. This makes some type ignore comments no longer necessary. I have removed them. There was one exception: a module that imports `select.epoll`. The ignore is redundant on Linux, but I've kept it ignored for those of us who work on the source tree using not-Linux. (#11771) I'm more interested in the config line which enforces this. I want unused ignores to be reported, because I think it's useful feedback when annotating to know when you've fixed a problem you had to previously ignore. * Installing extras before typechecking Lacking an easy way to install all extras generically, let's bite the bullet and make install the hand-maintained `all` extra before typechecking. Now that https://github.com/matrix-org/backend-meta/pull/6 is merged to the release/v1 branch.	2022-04-27 14:03:44 +01:00
Patrick Cloke	8a23bde823	Consistently use collections.abc.Mapping to check frozendict. (#12564 )	2022-04-27 09:00:07 -04:00
Will Hunt	e8d1ec0e92	Add option to enable token registration without requiring 3pids (#12526 )	2022-04-27 12:57:53 +00:00
Dirk Klimpel	b76f1a4d5f	Add some type hints to datastore (#12485 )	2022-04-27 13:05:00 +01:00
Nick Mills-Barrett	63ba9ba38b	Bound ephemeral events by key (#12544 ) Co-authored-by: Brad Murray <bradtgmurray@gmail.com> Co-authored-by: Andrew Morgan <andrewm@element.io>	2022-04-26 20:14:21 +01:00
David Robertson	9986621bc8	Synapse 1.58.0rc2 (2022-04-26) ============================== This release candidate fixes bugs related to Synapse 1.58.0rc1's logic for handling device list updates. Bugfixes -------- - Fix a bug introduced in Synapse 1.58.0rc1 where the main process could consume excessive amounts of CPU and memory while handling sentry logging failures. ([\#12554](https://github.com/matrix-org/synapse/issues/12554)) - Fix a bug introduced in Synapse 1.58.0rc1 where opentracing contexts were not correctly sent to whitelisted remote servers with device lists updates. ([\#12555](https://github.com/matrix-org/synapse/issues/12555)) Internal Changes ---------------- - Reduce unnecessary work when handling remote device list updates. ([\#12557](https://github.com/matrix-org/synapse/issues/12557)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmJoINsACgkQkD7OEIo5 3t0ETA//VANpmz0ykLeBA0XRW0eifQkHnQyBoZQtXL+IUmV9FZcX2q/akuQ5toJL p+AAJ6bKfYSwxyxgw3bJhftOVsIpG546auqVHvRXznlHk9vXKnuYevOz1ifnYSih j58fYTWnYZYv04uADbTX4fnJjiPDhiRYCZF6RiB5u1HGl1gr+Q1kJI7CL289/d1V MgBsJfzjHw+M7Vl2doddINnG65oPzrntMysv+PAma+WFxjQvLQoiaui96kaDM/2W XdFQh4k3OeyhBHKVk3+KrV9zPEh16JuymKDWoAnaMeIBBPwtngZp8tkEr4rSW8gP fOGDOMfqu896WqyT20fVhWzrsi24UjCw2TxY1C2UdCOoNqVJvMMMZ/aB129+8S/5 65FOI77Oqmn2KGQ5+75hun3a9UcsRD+9iitg2wajxlle5yk6ZFi095aZVf94ls8d uSWakqvFr6PAY8TnvthQNsAj00LJVqKKH3RrNw7pDOX7QWE1qbcbPHFrtCMHC5Bz Z1/LDqNCxhwruPEghmg+0ToRama5uYdeCMzqECZ8GmzhlouezMaFK6bFH1SGwNbo Idx60qwCXK3vHka3MVSqLg15gBGj1dQEJt8q/FVrYDemEFlNshPydJTbtbIOfj/R VEZa12gbtqFenPMQyDuzbFqgwirbeYQQHIRltQB3yDeggg8j4ng= =FAvF -----END PGP SIGNATURE----- gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmJoJswACgkQkD7OEIo5 3t3u0RAApTbw1tPIFXN9aQWVzBfaYRlw4zFKJlAl4JF6J7QT5qDny9NnhLTKqUPh bMj+IfcPN2nlUM6U6F9Fnu0HQXP9/hyVNLIauvqCnRa2GCb6F7fymSTJSsyUGSZW 0i3FXaR+OaIOqhjphGYx6oaVtGpgg7cKsp8VhVMTZrt0/sjFXxDV6oeaKfe2OpIE 6D4wYh13zS9CzzoNoMUkkqwUr2e+DbsCp5BkjbU8F2abRRpC14QSF4/qH0dfAQ4i A6Lj02Gzv/AcE5e6e3bRYQkt4L8+/di+aY3vbj4jsCqJYFTP4yvdc6iScFALyxXn QNGTZlctuNbR/v6WVQbiFtSyF1GnLos1+7jpEBpGRUk30H68zOwsi+qLZh9r98mB vQ0G2HA/klzdnIvq9DxWLL0PxQZKocdu5CT2ujV+6J7vkKAXmC/0rkDRWdi2qooU uRb3CbAHo4A6GnoqsrhY1i1JuUNbX7Nu2BZsLaiIdp2JTt6OzS/0zfUgCZzPw0u0 1586SlmiSdtXNMOlgpHPVtD71CCq/48tbccsomI1hk5dmiqlZX4hqsHSQY97k422 NV9LNpPo0K5l2Qmegera94Qz0FzCv4TCSDEAXn//lHCZ6eAVARk6Wym0UCOXToqw Xg1igJEkGOkIcwXj6GpG+r8yMdYD52xG6Ud8ZbYTX1glDfVWN4U= =YYmi -----END PGP SIGNATURE----- Merge tag 'v1.58.0rc2' into develop Synapse 1.58.0rc2 (2022-04-26) ============================== This release candidate fixes bugs related to Synapse 1.58.0rc1's logic for handling device list updates. Bugfixes -------- - Fix a bug introduced in Synapse 1.58.0rc1 where the main process could consume excessive amounts of CPU and memory while handling sentry logging failures. ([\#12554](https://github.com/matrix-org/synapse/issues/12554)) - Fix a bug introduced in Synapse 1.58.0rc1 where opentracing contexts were not correctly sent to whitelisted remote servers with device lists updates. ([\#12555](https://github.com/matrix-org/synapse/issues/12555)) Internal Changes ---------------- - Reduce unnecessary work when handling remote device list updates. ([\#12557](https://github.com/matrix-org/synapse/issues/12557))	2022-04-26 18:07:15 +01:00
David Robertson	6b64ee9ec7	1.58.0rc2	2022-04-26 17:16:43 +01:00
Erik Johnston	f59e3f4c90	Mark remote device list updates as already handled (#12557 )	2022-04-26 17:07:21 +01:00
David Robertson	6d89f1239c	Comment out dodgy log-kv (#12554 )	2022-04-26 15:53:06 +01:00
Erik Johnston	c48ab3734e	Fix sending opentracing contexts to remote servers (#12555 )	2022-04-26 14:48:16 +00:00
Jason Robinson	706456de1f	Mark Dockerfile as requiring BuildKit (#12541 ) Co-authored-by: David Robertson <davidr@element.io>	2022-04-26 15:31:52 +01:00
David Robertson	30db7fdb91	1.58.0rc1	2022-04-26 11:15:33 +01:00
Shay	99ab45423a	build debian package for jammy jellyfish (#12543 )	2022-04-26 10:34:59 +01:00
Richard van der Hoff	17d99f758a	Optimise backfill calculation (#12522 ) Try to avoid an OOM by checking fewer extremities. Generally this is a big rewrite of _maybe_backfill, to try and fix some of the TODOs and other problems in it. It's best reviewed commit-by-commit.	2022-04-26 10:27:11 +01:00
Shay	e75c7e3b6d	Add a table of contents to config manual (#12527 ) * Update config_documentation.md	2022-04-25 11:43:59 -07:00
Sean Quah	8a87b4435a	Handle cancellation in `EventsWorkerStore._get_events_from_cache_or_db` (#12529 ) Multiple calls to `EventsWorkerStore._get_events_from_cache_or_db` can reuse the same database fetch, which is initiated by the first call. Ensure that cancelling the first call doesn't cancel the other calls sharing the same database fetch. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-25 19:39:17 +01:00
Sami Olmari	813d728d09	Correct typo in user_admin_api.md device deletion JSON (#12533 ) Signed-off-by: Sami Olmari <sami@olmari.fi>	2022-04-25 12:39:15 +00:00
David Robertson	8bac3e0435	disallow-untyped-defs in `docker` and `stubs` directories (#12528 )	2022-04-25 12:32:35 +00:00
Patrick Cloke	185da8f0f2	Misc. clean-ups to the relations code (#12519 ) * Corrects some typos / copy & paste errors in tests. * Clarifies docstrings. * Removes an unnecessary method.	2022-04-25 08:25:56 -04:00
villepeh	d9b71410c2	Add HAProxy delegation example to docs (#12501 ) Signed-off-by: Ville Petteri Huh	2022-04-25 13:18:18 +01:00
Dirk Klimpel	a36a38b1ca	Add some example configurations for worker (#12492 ) Signed-off-by: Dirk Klimpel <dirk@klimpel.org>	2022-04-25 13:17:03 +01:00
Sean Quah	a50fb411b3	Update `delay_cancellation` to accept any awaitable (#12468 ) This will mainly be useful when dealing with module callbacks, which are all typed as returning `Awaitable`s instead of coroutines or `Deferred`s. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-22 18:20:06 +01:00
Will Hunt	b82fff66df	MSC3202: Fix device_unused_fallback_keys -> device_unused_fallback_key_types (#12520 ) * Fix device_unused_fallback_keys -> device_unused_fallback_key_types * changelog	2022-04-22 16:03:46 +01:00
Richard van der Hoff	f5668f0b4a	Await un-partial-stating after a partial-state join (#12399 ) When we join a room via the faster-joins mechanism, we end up with "partial state" at some points on the event DAG. Many parts of the codebase need to wait for the full state to load. So, we implement a mechanism to keep track of which events have partial state, and wait for them to be fully-populated.	2022-04-21 07:42:03 +01:00
David Robertson	09b4f6e46d	Remove leftover references to setup.py (#12514 ) * Remove leftover references to setup.py Missed in #12478. * Changelog	2022-04-20 18:16:49 +00:00
David Robertson	e5a76ec00b	Dump setuptools; correct pyproject version number (#12478 )	2022-04-20 17:33:20 +01:00
Patrick Cloke	103f51d867	Fix Jinja templating error when generating thumbnail URLs. (#12510 ) scale is meant to be a constant string, not refer to a variable.	2022-04-20 12:03:03 -04:00
David Robertson	ecef741add	Recommend poetry in docs (#12475 ) * Recommend poetry in docs - readme - contributor guide - upgrade notes - new dev cheat sheet for poetry Co-authored-by: Shay <hillerys@element.io> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-04-20 15:18:21 +01:00
Patrick Cloke	d0c1f4ca4c	Remove unnecessary config overrides for MSC3666. (#12511 )	2022-04-20 09:56:59 -04:00
Tulir Asokan	4bc8cb4669	Implement MSC2815: allow room moderators to view redacted event content (#12427 ) Implements matrix-org/matrix-spec-proposals#2815 Signed-off-by: Tulir Asokan <tulir@maunium.net>	2022-04-20 12:57:39 +01:00
David Robertson	eed38c5027	Add CI job to act as a canary for testing against latest dependencies (#12472 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-04-20 12:48:44 +01:00
Erik Johnston	c1482a352a	Fix returned count of delete extremities admin API (#12496 )	2022-04-19 16:49:45 +01:00
Richard van der Hoff	b80bb7e452	Fix `/room/.../event/...` to return the original event after any edits (#12476 ) This is what the MSC (now) requires. Fixes https://github.com/matrix-org/synapse/issues/10310.	2022-04-19 16:42:19 +01:00
Richard van der Hoff	798deb3a10	Fix typo in deb changelogs from release script (#12497 ) The release script used to incorrectly write `New synapse release 1.57.0~rc1.` instead of `New synapse release 1.57.0rc1.`	2022-04-19 16:41:52 +01:00
Jan Christian Grünhage	a1f87f57ff	Implement MSC3383: include destination in X-Matrix auth header (#11398 ) Co-authored-by: Jan Christian Grünhage <jan.christian@gruenhage.xyz> Co-authored-by: Marcus Hoffmann <bubu@bubu1.eu>	2022-04-19 16:23:53 +01:00
Dirk Klimpel	fbdee86004	Fix a link in `README.rst` (#12495 ) * Fix a link in `README.rst` * newsfile	2022-04-19 13:00:41 +00:00
Richard van der Hoff	b121a3ad2b	Back out implementation of MSC2314 (#12474 ) MSC2314 has now been closed, so we're backing out its implementation, which originally happened in #6176. Unfortunately it's not a direct revert, as that PR mixed in a bunch of unrelated changes to tests etc.	2022-04-19 11:17:29 +00:00
Travis Ralston	f8d3ee9570	Fix grammatical error in error message (#12483 ) * Fix grammatical error in error message * changelog	2022-04-18 12:41:55 -06:00
Shay	3c758d9808	Add a manual documenting config file options (#12368 )	2022-04-18 11:32:30 -07:00
Richard van der Hoff	aaaff98202	Dockerfile-workers: reduce the amount we install (#12464 ) This is an attempt to reduce the rebuild time. In short, we reduce the amount of stuff that the dockerfile installs, so as to give a faster startup.	2022-04-14 15:36:49 +01:00
reivilibre	7efddbebef	Update documentation to reflect that `run_background_tasks_on` is no longer experimental. (#12451 ) * Background workers aren't experimental anymore * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * Stream writers aren't experimental either	2022-04-14 15:25:22 +01:00
Richard van der Hoff	960b4fb409	complement-synapse-workers: factor out separate entry point script (#12467 ) ... with a bit more verbosity.	2022-04-14 14:56:10 +01:00
Dirk Klimpel	a743f7d33e	Replace `federation_reader` with `generic_worker` in docs (#12457 )	2022-04-14 13:09:07 +01:00
Erik Johnston	0b014eb25e	Only send out device list updates for our own users (#12465 ) Broke in #12365	2022-04-14 13:05:31 +01:00
David Robertson	535a689cfc	Reintroduce the lint targets in the linter script (#12455 )	2022-04-14 11:33:06 +01:00
David Robertson	6b3e0ea6bd	Use `poetry` to manage the virtualenv in debian packages (#12449 ) * Use `poetry` to build venv in debian packages Co-authored-by: Dan Callahan <danc@element.io> Co-authored-by: Shay <hillerys@element.io> * Changelog * Only pull in from requirements.txt Addresses the same problem as #12439. * Include `test` and `all` extras `poetry export` helpfully silently ignores an unknown extra Haven't seen this before because it's the only place we export `all` and `test`. I could have __sworm__ that the syntax `--extra "all test"` worked for `poetry install`... * Clean up requirements file on subsequence builds * Fix shell syntax Co-authored-by: Dan Callahan <danc@element.io> Co-authored-by: Shay <hillerys@element.io>	2022-04-14 11:03:24 +01:00
Richard van der Hoff	8af8a9bce5	Dockerfile-workers: give the master its own log config (#12466 ) When we run a worker-mode synapse under docker, everything gets logged to stdout. Currently, output from the workers is tacked with a worker name, for example: ``` 2022-04-13 15:27:56,810 - worker:frontend_proxy1 - synapse.util.caches.lrucache - 154 - INFO - LruCache._expire_old_entries-0 - Dropped 0 items from caches ``` - note `worker:frontend_proxy1`. No such tag is applied to log lines from the master, which makes somewhat confusing reading. To fix this, we generate a dedicated log config file for the master in the same way that we do for the workers, and use that.	2022-04-13 20:50:08 +01:00
Shay	8e2759f2d8	Limit `device_id` size to 512B (#12454 ) *	2022-04-13 10:04:01 -07:00
Andrew Morgan	0922462fc7	docs: Don't render the table of contents on the print page (#12340 )	2022-04-13 08:27:51 -07:00
David Baker	73d8ded0b0	Prevent a sync request from removing a user's busy presence status (#12213 ) In trying to use the MSC3026 busy presence status, the user's status would be set back to 'online' next time they synced. This change makes it so that syncing does not affect a user's presence status if it is currently set to 'busy': it must be removed through the presence API. The MSC defers to implementations on the behaviour of busy presence, so this ought to remain compatible with the MSC.	2022-04-13 16:21:07 +01:00
Nick Mills-Barrett	e3a49f4784	Fix missing sync events during historical batch imports (#12319 ) Discovered after much in-depth investigation in #12281. Closes: #12281 Closes: #3305 Signed off by: Nick Mills-Barrett nick@beeper.com	2022-04-13 11:38:35 +01:00
David Robertson	d24cd17820	Use poetry lockfile in twisted trunk CI job (#12425 ) Fixes #12458 Co-authored-by: Sean Quah <seanq@element.io> Co-authored-by: Dan Callahan <danc@element.io>	2022-04-13 11:26:53 +01:00
Jonathan de Jong	36d8b83888	Rename Mutual Rooms `unstable_features` flag to match MSC (#12445 ) Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>	2022-04-13 10:32:44 +01:00
Shay	32545d2e26	Bump twisted version to the latest in lockfile (#12441 )	2022-04-12 13:46:55 -07:00
David Robertson	5a275a2377	Run "main" trial tests under poetry (#12438 ) * Run "main" trial tests under poetry Olddeps and twisted trunk tests are handled in separate PRs. The PyPy config is a best-effort only; it's completely untested. Pulled out from #12337. * Changelog	2022-04-12 17:41:21 +01:00
David Robertson	58c657322a	Run lints under poetry in CI; remove lint tox jobs (#12434 ) Co-authored-by: Dan Callahan <danc@element.io>	2022-04-12 17:35:48 +01:00
Erik Johnston	aa28110264	Process device list updates asynchronously (#12365 )	2022-04-12 16:50:40 +01:00
Patrick Cloke	4bdbebccb9	Remove the unstable event field for `/send_join` per MSC3083. (#12395 ) This was missed when initially stabilising room version 8 and was left in as a compatibility shim. Most homeservers have upgraded to a version which expects the proper field name, and the failure mode is reasonable (a user on an older server may have to attempt joining the room twice with an obscure error message the first time).	2022-04-12 11:27:45 -04:00
Erik Johnston	ba1588461b	Fix typos in release script docs (#12450 )	2022-04-12 15:12:57 +00:00
Erik Johnston	a468768104	Merge branch 'release-v1.57' into develop	2022-04-12 15:28:41 +01:00
Patrick Cloke	9535fd0f9c	Disable groups/communities by default. (#12344 ) This disables the endpoints (and sync response fields) for groups/communities by default.	2022-04-12 10:20:46 -04:00
Richard van der Hoff	320186319a	Resync state after partial-state join (#12394 ) We work through all the events with partial state, updating the state at each of them. Once it's done, we recalculate the state for the whole room, and then mark the room as having complete state.	2022-04-12 13:23:43 +00:00
Patrick Cloke	86cf6a3a17	Remove references to unstable identifiers from MSC3440. (#12382 ) Removes references to unstable thread relation, unstable identifiers for filtering parameters, and the experimental config flag.	2022-04-12 08:42:03 -04:00
Erik Johnston	641f43ba81	1.57.0rc1	2022-04-12 13:39:35 +01:00
Dirk Klimpel	1783156dbc	Add some type hints to datastore (#12423 ) * Add some type hints to datastore * newsfile * change `Collection` to `List` * refactor return type of `select_users_txn` * correct type hint in `stream.py` * Remove `Optional` in `select_users_txn` * remove not needed return type in `__init__` * Revert change in `get_stream_id_for_event_txn` * Remove import from `Literal`	2022-04-12 11:54:00 +01:00
David Robertson	4e13743738	Poetry: select olddeps using `poetry` (#12407 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-04-12 10:50:11 +00:00
Erik Johnston	3ad74b63e5	Specify tls extra for Twisted dependency. (#12444 ) * Specify `tls` extra for Twisted dependency. It was already pulled in for us by `treq`, but we should be explicit that we do use the `tls` functionality of Twisted directly. * Mark `idna` as dev-dependency This doesn't actually change anything, as `Twisted[tls]` will put it in as a main dependency anyway.	2022-04-12 10:49:02 +00:00
David Robertson	5f8173dd80	Workaround pip bug installing latest treq and not-latest twisted from hashes (#12439 ) The requirements file generated by `poetry export` isn't correctly processed by `pip install -r requirements.txt`. It contains twisted and treq, both pinned to 22.2.0. When `pip` installs treq, it notices that `Twisted[tls]` is required. It then tries to acquire the latest twisted release, only to fail (because this hash isn't listed in the requirements file).From e.g. https://github.com/matrix-org/synapse/runs/5977154990?check_suite_focus=true > ``` > #15 9.204 Collecting Twisted[tls]>=18.7.0 > #15 9.205 ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not: > #15 9.205 Twisted[tls]>=18.7.0 from `38622ff95b/Twisted-22.4.0-py3-none-any.whl (sha256)`=f9f7a91f94932477a9fc3b169d57f54f96c6e74a23d78d9ce54039a7f48928a2 (from treq==22.2.0->-r /synapse/requirements.txt (line 724)) > #15 ERROR: executor failed running [/bin/sh -c pip install --prefix="/install" --no-warn-script-location -r /synapse/requirements.txt]: exit code: 1 > ``` The underlying pip issue is https://github.com/pypa/pip/issues/9644. A comment notes that one can avoid this behaviour with by `pip install`ing with the `--no-deps` flag. Let us do so. (At first glance, the problem looks like https://github.com/python-poetry/poetry/issues/5311, but that was a bug in `poetry install`; this is `poetry export`, whose behaviour is fine AFAICS).	2022-04-12 10:16:01 +01:00
Patrick Cloke	ab3165efb7	Remove experimental configuration flag for MSC3666. (#12436 )	2022-04-11 15:37:46 -04:00
Patrick Cloke	4586119f0b	Add missing type hints to config classes. (#12402 )	2022-04-11 12:07:23 -04:00
Richard van der Hoff	214f3b7d21	Enable certificate checking during complement tests (#12435 )	2022-04-11 16:35:41 +01:00
Patrick Cloke	772bad2562	Do not consider events by ignored users for bundled aggregations (#12235 ) Consider the requester's ignored users when calculating the bundled aggregations. See #12285 / `4df10d3214` for corresponding changes for the `/relations` endpoint.	2022-04-11 10:09:57 -04:00
Richard van der Hoff	3cdf5a1386	Fix up healthcheck generation for workers docker image (#12405 ) This wasn't quite generating the right thing.	2022-04-11 13:38:58 +00:00
David Robertson	961ee75a9b	Disallow untyped defs in synapse._scripts (#12422 ) Of note: * No untyped defs in `register_new_matrix_user` This one might be contraversial. `request_registration` has three dependency-injection arguments used for testing. I'm removing the injection of the `requests` module and using `unitest.mock.patch` in the test cases instead. Doing `reveal_type(requests)` and `reveal_type(requests.get)` before the change: ``` synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "Any" synapse/_scripts/register_new_matrix_user.py:46: note: Revealed type is "Any" ``` And after: ``` synapse/_scripts/register_new_matrix_user.py:44: note: Revealed type is "types.ModuleType" synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "def (url: Union[builtins.str, builtins.bytes], params: Union[Union[_typeshed.SupportsItems[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], typing.Iterable[Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]]], builtins.str, builtins.bytes], None] =, data: Union[Any, None] =, headers: Union[Any, None] =, cookies: Union[Any, None] =, files: Union[Any, None] =, auth: Union[Any, None] =, timeout: Union[Any, None] =, allow_redirects: builtins.bool =, proxies: Union[Any, None] =, hooks: Union[Any, None] =, stream: Union[Any, None] =, verify: Union[Any, None] =, cert: Union[Any, None] =, json: Union[Any, None] =) -> requests.models.Response" ``` * Drive-by comment in `synapse.storage.types` * No untyped defs in `synapse_port_db` This was by far the most painful. I'm happy to break this up into smaller pieces for review if it's not managable as-is.	2022-04-11 12:41:55 +01:00
Richard van der Hoff	5f72ea1bde	Move complement setup stuff into the Synapse repo (#12404 ) Fixes matrix-org/complement#330 (or it will, once we remove the old files). It's not quite a lift-and-shift: I've also taken the opportunity to get rid of the custom CA that we used to use to sign the TLS certs, which has been superceded by the CA exposed by Complement.	2022-04-11 11:39:28 +01:00
reivilibre	85ca963c1a	Add Module API for reading and writing global account data. (#12391 )	2022-04-11 10:05:43 +01:00
David Robertson	98ec375b26	CI: Fix the export-data job to run under poetry (#12418 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-04-08 19:18:54 +00:00
reivilibre	e630722f11	Optimise `_update_client_ips_batch_txn` to batch together database operations. (#12252 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-04-08 15:29:13 +01:00
David Robertson	0cd182f296	Make `synapse._scripts` pass typechecks (#12421 )	2022-04-08 14:00:12 +00:00
David Robertson	dd5cc37aa4	Stop maintaining a list of lint targets in `lint.sh` (#12420 )	2022-04-08 14:36:09 +01:00
David Robertson	95a038c106	Unify HTTP query parameter type hints (#12415 ) * Pull out query param types to `synapse.http.types` * Use QueryParams everywhere * Simplify `encode_query_args` * Add annotation which would have caught #12410	2022-04-08 13:06:51 +01:00
Jorge Florian	2e2d8cc2f9	Update the server notices user profile in room if changed. (#12115 )	2022-04-08 07:51:27 -04:00
David Robertson	7851a2c62f	CI: Get the portdb job to run under poetry (#12412 )	2022-04-08 12:00:05 +01:00
Jorge Florian	78e4d96a4d	Add missing type definitions for scripts in docker folder (#12280 ) Signed-off-by: Jorge Florian <jafn28@gmail.com>	2022-04-08 10:10:58 +00:00
Erik Johnston	7732c4902c	Fix rejecting invites over federation (#12409 ) Currently causes future incremental syncs to fail. Broke by #12191	2022-04-07 15:54:16 +01:00
Erik Johnston	36af768c13	Fix fetching public rooms over federation (#12410 ) Broke by #12364	2022-04-07 14:18:02 +00:00
Patrick Cloke	1a90c1e3af	Do not add groups to sync results if disabled. (#12408 )	2022-04-07 09:29:56 -04:00
Erik Johnston	d1cd96ce29	Add opentracing spans to calls to external cache (#12380 )	2022-04-07 13:18:29 +01:00
David Robertson	3a7e97c7ad	Poetry: use locked environment in Docker images (#12385 )	2022-04-07 11:43:31 +00:00
Patrick Cloke	0bcb651b3f	Support the v1 endpoint for `/relations`. (#12403 ) Now that MSC2675 has passed FCP and the implementation is compliant with the final version.	2022-04-07 07:08:23 -04:00
Eric Eastwood	350062661c	Clarify that we mark as outliers because we don't have any state for them (#12345 ) As discussed at https://github.com/matrix-org/synapse/pull/12179#discussion_r837263852	2022-04-06 16:34:33 -05:00
Eric Eastwood	f931c0602a	Update changelog to describe changes from #12370 relative to `develop` (#12401 )	2022-04-06 14:41:15 -04:00
Patrick Cloke	6902e9ff2b	Remove docs for converting a legacy structured logging config. (#12392 ) And update the upgrade notes to point at old versions of the documentation.	2022-04-06 13:41:14 -04:00
Patrick Cloke	05a37f4008	Remove support for the unstable identifier from MSC3288. (#12398 )	2022-04-06 13:27:46 -04:00
David Robertson	2cf74cf2fc	Narrow the `importlib_metadata` dependency (#12400 )	2022-04-06 17:37:56 +01:00
Richard van der Hoff	6fe757d69e	Fix `synapse_event_persisted_position` metric (#12390 ) Fixes a bug introduced in #11417 where we would only included backfilled events in `synapse_event_persisted_position`	2022-04-06 13:52:39 +00:00
Richard van der Hoff	ae01a7edd3	Update type annotations for compatiblity with prometheus_client 0.14 (#12389 ) Principally, `prometheus_client.REGISTRY.register` now requires its argument to extend `prometheus_client.Collector`. Additionally, `Gauge.set` is now annotated so that passing `Optional[int]` causes an error.	2022-04-06 12:59:04 +00:00
Eric Eastwood	793d03e2c5	Generate historic pagination token for `/messages` when no `?from` token provided (#12370 )	2022-04-06 11:40:28 +01:00
David Robertson	573cd0f92f	Add missing dependency on importlib_metadata (#12384 )	2022-04-05 18:25:56 +00:00
David Robertson	7ec9b06303	Poetry: initial pyproject.toml and poetry.lock (#12381 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-04-05 18:40:56 +01:00
Sean Quah	fd1e7d0fc2	Post 1.56.0 release tidy up (#12379 )	2022-04-05 17:35:20 +01:00
Andrew Morgan	163fd686b5	Update mdbook to 0.4.17 (#12339 ) Update mdbook (the tool used to render the documentation website) to version 0.4.17.	2022-04-05 17:21:58 +01:00
Sean Quah	79e7c2c426	Fix edge case where a `Linearizer` could get stuck (#12358 ) Just after a task acquires a contended `Linearizer` lock, it sleeps. If the task is cancelled during this sleep, we need to release the lock. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-05 17:19:16 +01:00
Sean Quah	31c1209c50	Make `StreamToken` and `RoomStreamToken` methods propagate cancellations (#12366 ) `StreamToken.from_string` and `RoomStreamToken.parse` are both async methods that could be cancelled. These methods must not replace `CancelledError`s with `SynapseError`s. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-05 16:56:52 +01:00
Sean Quah	9c4c49991d	Update docstrings for `ReadWriteLock` tests (#12354 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-04-05 16:54:40 +01:00
Sean Quah	800ba87cc8	Refactor and convert `Linearizer` to async (#12357 ) Refactor and convert `Linearizer` to async. This makes a `Linearizer` cancellation bug easier to fix. Also refactor to use an async context manager, which eliminates an unlikely footgun where code that doesn't immediately use the context manager could forget to release the lock. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-05 15:43:52 +01:00
Sean Quah	41b5f72677	Convert `Linearizer` tests from `inlineCallbacks` to async (#12353 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-04-05 14:56:09 +01:00
Erik Johnston	66053b6bfb	Prefill more stream change caches. (#12372 )	2022-04-05 14:26:41 +01:00
Dirk Klimpel	d666fc02fa	Add type hints to some tests files (#12371 )	2022-04-05 13:54:41 +01:00
reivilibre	42d8710f38	Fix a spec compliance issue where requests to the `/publicRooms` federation API would specify `limit` as a string. (#12364 )	2022-04-05 12:45:36 +01:00
reivilibre	708d88b1a2	Allow specifying the Postgres database's port when running unit tests with Postgres. (#12376 )	2022-04-05 12:44:48 +01:00
Richard van der Hoff	efdbcfd6af	Synapse 1.56.0rc1 (2022-03-29) ============================== Features -------- - Allow modules to store already existing 3PID associations. ([\#12195](https://github.com/matrix-org/synapse/issues/12195)) - Allow registering server administrators using the module API. Contributed by Famedly. ([\#12250](https://github.com/matrix-org/synapse/issues/12250)) Bugfixes -------- - Fix a long-standing bug which caused the `/_matrix/federation/v1/state` and `/_matrix/federation/v1/state_ids` endpoints to return incorrect or invalid data when called for an event which we have stored as an "outlier". ([\#12087](https://github.com/matrix-org/synapse/issues/12087)) - Fix a long-standing bug where events from ignored users would still be considered for relations. ([\#12227](https://github.com/matrix-org/synapse/issues/12227), [\#12232](https://github.com/matrix-org/synapse/issues/12232), [\#12285](https://github.com/matrix-org/synapse/issues/12285)) - Fix a bug introduced in Synapse 1.53.0 where an unnecessary query could be performed when fetching bundled aggregations for threads. ([\#12228](https://github.com/matrix-org/synapse/issues/12228)) - Fix a bug introduced in Synapse 1.52.0 where admins could not deactivate and GDPR-erase a user if Synapse was configured with limits on avatars. ([\#12261](https://github.com/matrix-org/synapse/issues/12261)) Improved Documentation ---------------------- - Fix the link to the module documentation in the legacy spam checker warning message. ([\#12231](https://github.com/matrix-org/synapse/issues/12231)) - Remove incorrect prefixes in the worker documentation for some endpoints. ([\#12243](https://github.com/matrix-org/synapse/issues/12243)) - Correct `check_username_for_spam` annotations and docs. ([\#12246](https://github.com/matrix-org/synapse/issues/12246)) - Correct Authentik OpenID typo, and add notes on troubleshooting. Contributed by @IronTooch. ([\#12275](https://github.com/matrix-org/synapse/issues/12275)) - HAProxy reverse proxy guide update to stop sending IPv4-mapped address to homeserver. Contributed by @villepeh. ([\#12279](https://github.com/matrix-org/synapse/issues/12279)) Internal Changes ---------------- - Rename `shared_rooms` to `mutual_rooms` ([MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)), as per proposal changes. ([\#12036](https://github.com/matrix-org/synapse/issues/12036)) - Remove check on `update_user_directory` for shared rooms handler ([MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)), and update/expand documentation. ([\#12038](https://github.com/matrix-org/synapse/issues/12038)) - Refactor `create_new_client_event` to use a new parameter, `state_event_ids`, which accurately describes the usage with [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) instead of abusing `auth_event_ids`. ([\#12083](https://github.com/matrix-org/synapse/issues/12083), [\#12304](https://github.com/matrix-org/synapse/issues/12304)) - Refuse to start if registration is enabled without email, captcha, or token-based verification unless the new config flag `enable_registration_without_verification` is set. ([\#12091](https://github.com/matrix-org/synapse/issues/12091)) - Add tests for database transaction callbacks. ([\#12198](https://github.com/matrix-org/synapse/issues/12198)) - Handle cancellation in `DatabasePool.runInteraction`. ([\#12199](https://github.com/matrix-org/synapse/issues/12199)) - Add missing type hints for cache storage. ([\#12216](https://github.com/matrix-org/synapse/issues/12216)) - Add missing type hints for storage. ([\#12248](https://github.com/matrix-org/synapse/issues/12248), [\#12255](https://github.com/matrix-org/synapse/issues/12255)) - Add type hints to tests files. ([\#12224](https://github.com/matrix-org/synapse/issues/12224), [\#12240](https://github.com/matrix-org/synapse/issues/12240), [\#12256](https://github.com/matrix-org/synapse/issues/12256)) - Use type stubs for `psycopg2`. ([\#12269](https://github.com/matrix-org/synapse/issues/12269)) - Improve type annotations for `execute_values`. ([\#12311](https://github.com/matrix-org/synapse/issues/12311)) - Clean-up logic around rebasing URLs for URL image previews. ([\#12219](https://github.com/matrix-org/synapse/issues/12219)) - Use the `ignored_users` table in additional places instead of re-parsing the account data. ([\#12225](https://github.com/matrix-org/synapse/issues/12225)) - Refactor the relations endpoints to add a `RelationsHandler`. ([\#12237](https://github.com/matrix-org/synapse/issues/12237)) - Generate announcement links in the release script. ([\#12242](https://github.com/matrix-org/synapse/issues/12242)) - Improve error message when dependencies check finds a broken installation. ([\#12244](https://github.com/matrix-org/synapse/issues/12244)) - Compress metrics HTTP resource when enabled. Contributed by Nick @ Beeper. ([\#12258](https://github.com/matrix-org/synapse/issues/12258)) - Refuse to start if the PostgreSQL database has a non-`C` locale, unless the config flag `allow_unsafe_db_locale` is set to true. ([\#12262](https://github.com/matrix-org/synapse/issues/12262), [\#12288](https://github.com/matrix-org/synapse/issues/12288)) - Optionally include account validity expiration information to experimental [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) account status responses. ([\#12266](https://github.com/matrix-org/synapse/issues/12266)) - Add a new cache `_get_membership_from_event_id` to speed up push rule calculations in large rooms. ([\#12272](https://github.com/matrix-org/synapse/issues/12272)) - Re-enable Complement concurrency in CI. ([\#12283](https://github.com/matrix-org/synapse/issues/12283)) - Remove unused test utilities. ([\#12291](https://github.com/matrix-org/synapse/issues/12291)) - Enhance logging for inbound federation events. ([\#12301](https://github.com/matrix-org/synapse/issues/12301)) - Fix compatibility with the recently-released Jinja 3.1. ([\#12313](https://github.com/matrix-org/synapse/issues/12313)) - Avoid trying to calculate the state at outlier events. ([\#12314](https://github.com/matrix-org/synapse/issues/12314)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEdVkXOgzrGzds0jtrHgFcFF8ZFs0FAmJC33MACgkQHgFcFF8Z Fs0IFhAAhz45kNCqWfBip8yc7GE95ZnMfX4PymrIQeJOtloecQCyRrcS8r0GJhvq j5cRfMNoaoMZKOQsqyjLiY02QUX/8hUOgAD4SEa9Jmc4a2ZwjJ3hxy8dKx89gdZ+ E+uUhJZUNV9UovDIOYd+DPB1//tFdzfYtZmbmddJbWv2jZwb4fmTEnK+j5dp4TMR Z6/aA1IQB2PZqihQLmtKHCC6xCv7zaCmvS7Z1oUACOm7W1cX0F2P51M11+rK5ipi tasRBhdGmMu9eGm9QfeQkY++5HLjTfNuSwSP37tP5RMjKckpJS7f6vooJ7EtVtaY YPlTsjsngWaDk+ETK9ZN3ATtI1StB+6agiTAjO3kJzai++eKQaNrkzIhhftLYfsa 2CIoy2BM7iPp/u+MF5VkxN/QCcnK43VuDU+iR8MCzjTQJPSxsAYrjsd8MMD0rCBa dib2IdF1Xlijg0iSdV/ToeMx/KDYh+l5hcltkLy1To68IvFqf0kGvlcDk2rtLWzz QsWf5PGc+YXQM8IMF38BmuE1HCI0rEJH5V/Jl1UkXFaQdf1bIXmWxKTNHjVP/2Uq dfI4qPtszWOjJT7bBgJbjqX1QBzzIU7ShM8cRlj4Lfc6bdhWG3G+CCACl29t/T9K NBboIPEbCqw2GJMz1EoNciRHhFnsvQyG1QaHywRwaIuzNX8ohEw= =J5w/ -----END PGP SIGNATURE----- Merge tag 'v1.56.0rc1' into develop Synapse 1.56.0rc1 (2022-03-29) ============================== Features -------- - Allow modules to store already existing 3PID associations. ([\#12195](https://github.com/matrix-org/synapse/issues/12195)) - Allow registering server administrators using the module API. Contributed by Famedly. ([\#12250](https://github.com/matrix-org/synapse/issues/12250)) Bugfixes -------- - Fix a long-standing bug which caused the `/_matrix/federation/v1/state` and `/_matrix/federation/v1/state_ids` endpoints to return incorrect or invalid data when called for an event which we have stored as an "outlier". ([\#12087](https://github.com/matrix-org/synapse/issues/12087)) - Fix a long-standing bug where events from ignored users would still be considered for relations. ([\#12227](https://github.com/matrix-org/synapse/issues/12227), [\#12232](https://github.com/matrix-org/synapse/issues/12232), [\#12285](https://github.com/matrix-org/synapse/issues/12285)) - Fix a bug introduced in Synapse 1.53.0 where an unnecessary query could be performed when fetching bundled aggregations for threads. ([\#12228](https://github.com/matrix-org/synapse/issues/12228)) - Fix a bug introduced in Synapse 1.52.0 where admins could not deactivate and GDPR-erase a user if Synapse was configured with limits on avatars. ([\#12261](https://github.com/matrix-org/synapse/issues/12261)) Improved Documentation ---------------------- - Fix the link to the module documentation in the legacy spam checker warning message. ([\#12231](https://github.com/matrix-org/synapse/issues/12231)) - Remove incorrect prefixes in the worker documentation for some endpoints. ([\#12243](https://github.com/matrix-org/synapse/issues/12243)) - Correct `check_username_for_spam` annotations and docs. ([\#12246](https://github.com/matrix-org/synapse/issues/12246)) - Correct Authentik OpenID typo, and add notes on troubleshooting. Contributed by @IronTooch. ([\#12275](https://github.com/matrix-org/synapse/issues/12275)) - HAProxy reverse proxy guide update to stop sending IPv4-mapped address to homeserver. Contributed by @villepeh. ([\#12279](https://github.com/matrix-org/synapse/issues/12279)) Internal Changes ---------------- - Rename `shared_rooms` to `mutual_rooms` ([MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)), as per proposal changes. ([\#12036](https://github.com/matrix-org/synapse/issues/12036)) - Remove check on `update_user_directory` for shared rooms handler ([MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)), and update/expand documentation. ([\#12038](https://github.com/matrix-org/synapse/issues/12038)) - Refactor `create_new_client_event` to use a new parameter, `state_event_ids`, which accurately describes the usage with [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) instead of abusing `auth_event_ids`. ([\#12083](https://github.com/matrix-org/synapse/issues/12083), [\#12304](https://github.com/matrix-org/synapse/issues/12304)) - Refuse to start if registration is enabled without email, captcha, or token-based verification unless the new config flag `enable_registration_without_verification` is set. ([\#12091](https://github.com/matrix-org/synapse/issues/12091)) - Add tests for database transaction callbacks. ([\#12198](https://github.com/matrix-org/synapse/issues/12198)) - Handle cancellation in `DatabasePool.runInteraction`. ([\#12199](https://github.com/matrix-org/synapse/issues/12199)) - Add missing type hints for cache storage. ([\#12216](https://github.com/matrix-org/synapse/issues/12216)) - Add missing type hints for storage. ([\#12248](https://github.com/matrix-org/synapse/issues/12248), [\#12255](https://github.com/matrix-org/synapse/issues/12255)) - Add type hints to tests files. ([\#12224](https://github.com/matrix-org/synapse/issues/12224), [\#12240](https://github.com/matrix-org/synapse/issues/12240), [\#12256](https://github.com/matrix-org/synapse/issues/12256)) - Use type stubs for `psycopg2`. ([\#12269](https://github.com/matrix-org/synapse/issues/12269)) - Improve type annotations for `execute_values`. ([\#12311](https://github.com/matrix-org/synapse/issues/12311)) - Clean-up logic around rebasing URLs for URL image previews. ([\#12219](https://github.com/matrix-org/synapse/issues/12219)) - Use the `ignored_users` table in additional places instead of re-parsing the account data. ([\#12225](https://github.com/matrix-org/synapse/issues/12225)) - Refactor the relations endpoints to add a `RelationsHandler`. ([\#12237](https://github.com/matrix-org/synapse/issues/12237)) - Generate announcement links in the release script. ([\#12242](https://github.com/matrix-org/synapse/issues/12242)) - Improve error message when dependencies check finds a broken installation. ([\#12244](https://github.com/matrix-org/synapse/issues/12244)) - Compress metrics HTTP resource when enabled. Contributed by Nick @ Beeper. ([\#12258](https://github.com/matrix-org/synapse/issues/12258)) - Refuse to start if the PostgreSQL database has a non-`C` locale, unless the config flag `allow_unsafe_db_locale` is set to true. ([\#12262](https://github.com/matrix-org/synapse/issues/12262), [\#12288](https://github.com/matrix-org/synapse/issues/12288)) - Optionally include account validity expiration information to experimental [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) account status responses. ([\#12266](https://github.com/matrix-org/synapse/issues/12266)) - Add a new cache `_get_membership_from_event_id` to speed up push rule calculations in large rooms. ([\#12272](https://github.com/matrix-org/synapse/issues/12272)) - Re-enable Complement concurrency in CI. ([\#12283](https://github.com/matrix-org/synapse/issues/12283)) - Remove unused test utilities. ([\#12291](https://github.com/matrix-org/synapse/issues/12291)) - Enhance logging for inbound federation events. ([\#12301](https://github.com/matrix-org/synapse/issues/12301)) - Fix compatibility with the recently-released Jinja 3.1. ([\#12313](https://github.com/matrix-org/synapse/issues/12313)) - Avoid trying to calculate the state at outlier events. ([\#12314](https://github.com/matrix-org/synapse/issues/12314))	2022-04-05 12:26:20 +01:00
Eric Eastwood	5218fe7670	Explain how to decipher live and historic pagination tokens (#12317 )	2022-04-05 10:57:09 +01:00
Shay	f608e6c8cf	Update broken link in `workers.md` (#12369 )	2022-04-04 17:40:31 -07:00
Eric Eastwood	9633eb2162	Allow non-member state sent in room batch to resolve for historic events (MSC2716) (#12329 ) Part of https://github.com/matrix-org/synapse/issues/12110 Complement test: https://github.com/matrix-org/complement/pull/354 Previously, they didn't resolve because async `filter_events_for_client` removes all outlier state except for out-of-band membership. And fundamentally, we have the state at these events so they shouldn't be marked as outliers.	2022-04-04 14:54:50 -05:00
Erik Johnston	b446c99ac9	Prefill the device_list_stream_cache (#12367 ) * Prefill the device_list_stream_cache * Newsfile * Newsfile	2022-04-04 20:12:25 +01:00
Erik Johnston	5c9e39e619	Track device list updates per room. (#12321 ) This is a first step in dealing with #7721. The idea is basically that rather than calculating the full set of users a device list update needs to be sent to up front, we instead simply record the rooms the user was in at the time of the change. This will allow a few things: 1. we can defer calculating the set of remote servers that need to be poked about the change; and 2. during `/sync` and `/keys/changes` we can avoid also avoid calculating users who share rooms with other users, and instead just look at the rooms that have changed. However, care needs to be taken to correctly handle server downgrades. As such this PR writes to both `device_lists_changes_in_room` and the `device_lists_outbound_pokes` table synchronously. In a future release we can then bump the database schema compat version to `69` and then we can assume that the new `device_lists_changes_in_room` exists and is handled. There is a temporary option to disable writing to `device_lists_outbound_pokes` synchronously, allowing us to test the new code path does work (and by implication upgrading to a future release and downgrading to this one will work correctly). Note: Ideally we'd do the calculation of room to servers on a worker (e.g. the background worker), but currently only master can write to the `device_list_outbound_pokes` table.	2022-04-04 15:25:20 +01:00
David Robertson	80839a44f1	Remove more dead/broken dev scripts (#12355 )	2022-04-03 21:21:08 +01:00
Richard van der Hoff	f0b03186d9	Add type hints for `tests/unittest.py`. (#12347 ) In particular, add type hints for get_success and friends, which are then helpful in a bunch of places.	2022-04-01 16:04:16 +00:00
Richard van der Hoff	33ebee47e4	Remove redundant `get_success` calls in test code (#12346 ) There are a bunch of places we call get_success on an immediate value, which is unnecessary. Let's rip them out, and remove the redundant functionality in get_success and friends.	2022-04-01 16:10:31 +01:00
reivilibre	c4cf916ed7	Default to `private` room visibility rather than `public` when a client does not specify one, according to spec. (#12350 )	2022-04-01 15:55:09 +01:00
David Robertson	336bff1104	Burn `check_signature` dev script. (#12351 )	2022-04-01 13:41:42 +00:00
Nick Mills-Barrett	993d90f82b	Use a sequence to generate AS transaction IDs, drop `last_txn` AS state (#12209 ) Switching to a sequence means there's no need to track `last_txn` on the AS state table to generate new TXN IDs. This also means that there is no longer contention between the AS scheduler and AS handler on updates to the `application_services_state` table, which will prevent serialization errors during the complete AS txn transaction.	2022-04-01 13:33:25 +00:00
David Robertson	21351820e0	Remove `list_url_patterns` dev script (#12349 )	2022-04-01 13:05:21 +00:00
Richard van der Hoff	b7762b0c9f	Move single-use methods out of `TestCase` (#12348 ) These methods are only used by a single testcase, so they shouldn't be cluttering up the base `TestCase` class.	2022-04-01 12:48:08 +00:00
reivilibre	f871222880	Move `update_client_ip` background job from the main process to the background worker. (#12251 )	2022-04-01 13:08:55 +01:00
Richard van der Hoff	319a805cd3	Raise an exception when getting state at an outlier (#12191 ) It seems like calling `_get_state_group_for_events` for an event where the state is unknown is an error. Accordingly, let's raise an exception rather than silently returning an empty result.	2022-04-01 13:01:49 +01:00
Richard van der Hoff	9b43df1f7b	Optimise `_get_state_after_missing_prev_event`: use `/state` (#12040 ) If we're missing most of the events in the room state, then we may as well call the /state endpoint, instead of individually requesting each and every event.	2022-04-01 12:53:42 +01:00
Brendan Abolivier	e4409301ba	Add a module callback to react to account data changes (#12327 ) Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2022-04-01 11:22:48 +02:00
Amanda Graven	4e900ece42	Add set_user_admin function to the module API (#12341 )	2022-04-01 09:31:30 +01:00
Patrick Cloke	bebf994ee8	Move MSC2654 support behind an experimental configuration flag. (#12295 ) To match the current thinking on disabling experimental features by default.	2022-03-31 15:05:13 -04:00
Richard van der Hoff	6927d87254	Handle outliers in `/federation/v1/event` (#12332 ) The intention here is to avoid doing state lookups for outliers in `/_matrix/federation/v1/event`. Unfortunately that's expanded into something of a rewrite of `filter_events_for_server`, which ended up trying to do that operation in a couple of places.	2022-03-31 17:39:34 +00:00
Patrick Cloke	11df4ec6c2	Add more type hints to the main state store. (#12267 )	2022-03-31 13:38:09 -04:00
Brendan Abolivier	5e88143dff	Add a callback to react to 3PID associations (#12302 )	2022-03-31 18:27:21 +02:00
Patrick Cloke	adbf975623	Remove an unnecessary class from the relations code. (#12338 ) The PaginationChunk class attempted to bundle some properties together, but really just caused callers to jump through hoops and hid implementation details.	2022-03-31 07:13:49 -04:00
David Robertson	15cdcf8f30	Remove `dockerfile-pgtests` (#12336 )	2022-03-31 11:30:07 +01:00
David Robertson	5a32ec59b2	Ignore .envrc for direnv users (#12335 )	2022-03-31 11:03:07 +01:00
David Robertson	9a3f1f5383	Nuke the tox `packaging` job (#12334 )	2022-03-31 11:01:26 +01:00
Brendan Abolivier	f96b85eca8	Ensure the type of URL attributes is always str when matching against preview blacklist (#12333 )	2022-03-31 11:49:49 +02:00
Patrick Cloke	c31c1091d4	Remove the unused and unstable `/aggregations` endpoint. (#12293 ) This endpoint was removed from MSC2675 before it was approved. It is currently unspecified (even in any MSCs) and therefore subject to removal. It is not implemented by any known clients. This also changes the bundled aggregation format for `m.annotation`, which previously included pagination tokens for the `/aggregations` endpoint, which are no longer useful.	2022-03-30 11:45:32 -04:00
Andrew Morgan	d8d0271977	Send device list updates to application services (MSC3202) - part 1 (#11881 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-30 14:39:27 +01:00
reivilibre	2fc15ac718	Flesh out documentation for running SyTest against Synapse, including use of Postgres and worker mode. (#12271 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-30 12:55:05 +00:00
David Robertson	a7fb66e800	Update dead links in check-newsfragment.sh (#12331 )	2022-03-30 11:44:28 +00:00
Andrew Morgan	19a1d6a42a	Remove references to "msc2403" (#12165 )	2022-03-30 11:15:47 +00:00
Andrew Morgan	c8cbd66d3b	Start application service stream token tracking from 1 (#12193 ) Co-authored-by: Erik Johnston <erik@matrix.org>	2022-03-30 11:10:12 +00:00
Richard van der Hoff	9b67715bc3	Disable proactive sends for remote joins (#12330 ) Do not attempt to send remote joins out over federation. Normally, it will do nothing; occasionally, it will do the wrong thing.	2022-03-30 12:04:35 +01:00
Brendan Abolivier	437a8ed9ef	Add a configuration to exclude rooms from sync response (#12310 )	2022-03-30 09:43:04 +00:00
David Robertson	e0bb268134	Fix typechecker problems exposed by signedjson 1.1.2 (#12326 )	2022-03-29 21:37:50 +00:00
Richard van der Hoff	1f32b90b0f	Room batch: fix up handling of unknown prev_event_ids (#12316 )	2022-03-29 14:56:25 +01:00
Sean Quah	8a519f8abc	Update `LoggingTransaction.call_after` and `call_on_exception` docstrings (#12315 ) Document the behaviour of `LoggingTransaction.call_after` and `LoggingTransaction.call_on_exception` when transactions are retried. Signed-off-by: Sean Quah <seanq@element.io>	2022-03-29 12:31:05 +01:00
David Robertson	a2b00a4486	Bump `black` and `click` versions (#12320 )	2022-03-29 10:41:19 +00:00
Brendan Abolivier	b690fe749b	1.56.0rc1	2022-03-29 10:41:04 +01:00
Eric Eastwood	6f2943714b	Remove unused `auth_event_ids` argument plumbing (#12304 ) Follow-up to https://github.com/matrix-org/synapse/pull/12083 Since we are now using the new `state_event_ids` parameter to do all of the heavy lifting. We can remove any spots where we plumbed `auth_event_ids` just for MSC2716 things in https://github.com/matrix-org/synapse/pull/9247/files. Removing `auth_event_ids` from following functions: - `create_and_send_nonmember_event` - `_local_membership_update` - `update_membership` - `update_membership_locked`	2022-03-29 09:18:52 +01:00
Richard van der Hoff	287a9c1e20	Exclude outliers in `on_backfill_request` (#12314 ) When we are processing a `/backfill` request from a remote server, exclude any outliers from consideration early on. We can't return outliers anyway (since we don't know the state at the outlier), and filtering them out earlier means that we won't attempt to calulate the state for them.	2022-03-28 19:20:14 +01:00
Dirk Klimpel	ac95167d2f	Add some type hints to datastore. (#12255 )	2022-03-28 14:11:14 -04:00
Brendan Abolivier	4ba55a620f	Un-revert Jinja2 fix (#12313 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-03-28 17:02:57 +00:00
Brendan Abolivier	8cd760fca8	Allow modules to store already existing 3PID associations (#12195 )	2022-03-28 18:57:19 +02:00
reivilibre	89f11f8c6f	Improve type annotations for `execute_values`. (#12311 )	2022-03-28 17:21:23 +01:00
villepeh	a4643a685c	HAProxy guide update (#12279 ) HAproxy reverse proxy guide update to stop sending IPv4-mapped address to HS.	2022-03-28 10:48:18 +00:00
Shay	3c41d87b67	Add restrictions by default to open registration in Synapse (#12091 )	2022-03-25 10:11:01 -07:00
Erik Johnston	7ca8ee67a5	Add cache for `get_membership_from_event_ids` (#12272 ) This should speed up push rule calculations for rooms with large numbers of local users when the main push rule cache fails. Co-authored-by: reivilibre <oliverw@matrix.org>	2022-03-25 14:58:56 +00:00
Richard van der Hoff	38adf14998	Enhance logging for inbound federation events (#12301 ) It is currently rather hard to see which rooms are causing inbound federation traffic. Add the room id to the logs.	2022-03-25 14:44:57 +00:00
Eric Eastwood	14662d3c18	Refactor `create_new_client_event` to use a new parameter, `state_event_ids`, which accurately describes the usage with MSC2716 instead of abusing `auth_event_ids` (#12083 ) Spawned from https://github.com/matrix-org/synapse/pull/10975#discussion_r813183430 Part of [MSC2716](https://github.com/matrix-org/matrix-spec-proposals/pull/2716)	2022-03-25 09:21:06 -05:00
David Robertson	fffb3c4c8f	Always allow the empty string as an avatar_url. (#12261 ) Hopefully this fixes #12257. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-25 13:28:42 +00:00
IronTooch	61aae18d45	Authentik OpenID minor doc update (#12275 )	2022-03-25 12:40:10 +00:00
Brendan Abolivier	5859e2fe0c	Mention the new behaviour on unsafe database locale in the upgrade notes (#12288 ) Co-authored-by: Shay <hillerys@element.io>	2022-03-25 10:56:18 +01:00
kegsay	8b7b371ff6	Re-enable test concurrency on Complement (#12283 )	2022-03-24 15:59:06 -04:00
Patrick Cloke	1800bd47a8	Remove unused test code. (#12291 ) The `MockHttpResource` and `MockKey` objects were unused since #9396 (`74af356baf`).	2022-03-24 19:25:52 +00:00
Patrick Cloke	4df10d3214	Do not consider events by ignored users for relations (#12285 ) Filter the events returned from `/relations` for the requester's ignored users in a similar way to `/messages` (and `/sync`).	2022-03-24 10:25:42 -04:00
Brendan Abolivier	5436b014f4	Optionally include account validity in MSC3720 account status responses (#12266 )	2022-03-24 11:19:41 +01:00
Shay	e78d4f61fc	Refuse to start if DB has an unsafe locale (#12262 )	2022-03-23 10:23:05 -07:00
David Robertson	f4c5e5864c	Use psycopg2 type stubs (#12269 )	2022-03-23 14:03:24 +00:00
Jonathan de Jong	c5776780f0	Remove mutual_rooms `update_user_directory` check, and add extra documentation (#12038 ) Resolves #10339	2022-03-23 12:47:07 +00:00
Nicolas Werner	692b82838e	Allow registering admin users using the module API (#12250 ) Signed-off-by: Nicolas Werner <n.werner@famedly.com>	2022-03-23 12:48:47 +01:00
Jonathan de Jong	516d092ff9	Rename shared_rooms to mutual_rooms (#12036 ) Co-authored-by: reivilibre <olivier@librepush.net>	2022-03-23 11:19:20 +00:00
Andrew Morgan	831d4797ab	Merge branch 'master' into develop	2022-03-22 16:31:28 +00:00
Andrew Morgan	34baf76451	1.55.0	2022-03-22 14:02:52 +00:00
Michael Telatynski	01211e0c16	Tweak copy for sso account details template (#12265 ) * Tweak copy for sso account details template * Update sso footer copyright year * Add newsfragment Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>	2022-03-22 10:22:25 +00:00
Dirk Klimpel	9d21ecf7ce	Add type hints to tests files. (#12256 )	2022-03-21 09:43:16 -04:00
David Robertson	0a59f977a2	Merge branch 'release-v1.55' into develop	2022-03-21 12:29:53 +00:00
reivilibre	6134b3079e	Reword 'Choose your user name' as 'Choose your account name' in the SSO registration template, in order to comply with SIWA guidelines. (#12260 ) * Reword as 'Choose your account name' * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>	2022-03-21 12:16:46 +00:00
Nick Mills-Barrett	1530cef192	Make it possible to enable compression for the metrics HTTP resource (#12258 ) * Make it possible to enable compression for the metrics HTTP resource This can provide significant bandwidth savings pulling metrics from synapse instances. * Add changelog file. * Fix type hint	2022-03-21 11:52:10 +00:00
Richard van der Hoff	afa17f0eab	Return a 404 from `/state` for an outlier (#12087 ) * Replace `get_state_for_pdu` with `get_state_ids_for_pdu` and `get_events_as_list`. * Return a 404 from `/state` and `/state_ids` for an outlier	2022-03-21 11:23:32 +00:00
David Robertson	bf9d549e3a	Try to detect borked package installations. (#12244 ) * Try to detect borked package installations. Fixes #12223. Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-03-18 19:03:46 +00:00
Patrick Cloke	8fe930c215	Move get_bundled_aggregations to relations handler. (#12237 ) The get_bundled_aggregations code is fairly high-level and uses a lot of store methods, we move it into the handler as that seems like a better fit.	2022-03-18 17:49:32 +00:00
Patrick Cloke	80e0e1f35e	Only fetch thread participation for events with threads. (#12228 ) We fetch the thread summary in two phases: 1. The summary that is shared by all users (count of messages and latest event). 2. Whether the requesting user has participated in the thread. There's no use in attempting step 2 for events which did not return a summary from step 1.	2022-03-18 17:15:45 +00:00
Patrick Cloke	2177e356bc	Sync more worker regexes in the documentation. (#12243 )	2022-03-18 12:51:27 -04:00
Dirk Klimpel	c46065fa3d	Add some type hints to datastore (#12248 ) * inherit `MonthlyActiveUsersStore` from `RegistrationWorkerStore` Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-18 15:24:18 +00:00
David Robertson	872dbb0181	Correct `check_username_for_spam` annotations and docs (#12246 ) * Formally type the UserProfile in user searches * export UserProfile in synapse.module_api * Update docs Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-03-18 13:51:41 +00:00
David Robertson	12d1f82db2	Generate announcement links in release script (#12242 )	2022-03-17 13:46:05 +00:00
Dirk Klimpel	9e06e22064	Add type hints to more tests files. (#12240 )	2022-03-17 07:25:50 -04:00
Patrick Cloke	3f7cfbc9e5	Merge branch 'release-v1.55' into develop	2022-03-16 12:22:07 -04:00
Patrick Cloke	f70afbd565	Re-generate changelog.	2022-03-16 12:20:05 -04:00
Patrick Cloke	96274565ff	Fix bundling aggregations if unsigned is not a returned event field. (#12234 ) An error occured if a filter was supplied with `event_fields` which did not include `unsigned`. In that case, bundled aggregations are still added as the spec states it is allowed for servers to add additional fields.	2022-03-16 12:17:39 -04:00
Sean Quah	6121056740	Handle cancellation in `DatabasePool.runInteraction()` (#12199 ) To handle cancellation, we ensure that `after_callback`s and `exception_callback`s are always run, since the transaction will complete on another thread regardless of cancellation. We also wait until everything is done before releasing the `CancelledError`, so that logging contexts won't get used after they have been finished. Signed-off-by: Sean Quah <seanq@element.io>	2022-03-16 15:07:41 +00:00
Patrick Cloke	fc9bd620ce	Add a relations handler to avoid duplication. (#12227 ) Adds a handler layer between the REST and datastore layers for relations.	2022-03-16 10:39:15 -04:00
Patrick Cloke	c486fa5fd9	Add some missing type hints to cache datastore. (#12216 )	2022-03-16 10:37:04 -04:00
David Robertson	86965605a4	Fix dead link in spam checker warning (#12231 )	2022-03-16 13:52:59 +00:00
Patrick Cloke	1da0f79d54	Refactor relations tests (#12232 ) * Moves the relation pagination tests to a separate class. * Move the assertion of the response code into the `_send_relation` helper. * Moves some helpers into the base-class.	2022-03-16 09:20:57 -04:00
Patrick Cloke	4587b35929	Clean-up logic for rebasing URLs during URL preview. (#12219 ) By using urljoin from the standard library and reducing the number of places URLs are rebased.	2022-03-16 07:21:36 -04:00
Patrick Cloke	dda9b7fc4d	Use the ignored_users table to test event visibility & sync. (#12225 ) Instead of fetching the raw account data and re-parsing it. The ignored_users table is a denormalised version of the account data for quick searching.	2022-03-15 14:06:05 -04:00
Sean Quah	dea577998f	Add tests for database transaction callbacks (#12198 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-15 15:40:34 +00:00
Dirk Klimpel	5dd949bee6	Add type hints to some tests/handlers files. (#12224 )	2022-03-15 09:16:37 -04:00
David Robertson	d1130a249b	1.55.0rc1	2022-03-15 11:00:01 +00:00
Sean Quah	2fcf4b3f6c	Add cancellation support to `@cached` and `@cachedList` decorators (#12183 ) These decorators mostly support cancellation already. Add cancellation tests and fix use of finished logging contexts by delaying cancellation, as suggested by @erikjohnston. Signed-off-by: Sean Quah <seanq@element.io>	2022-03-14 19:04:29 +00:00
Sean Quah	605d161d7d	Add cancellation support to `ReadWriteLock` (#12120 ) Also convert `ReadWriteLock` to use async context managers. Signed-off-by: Sean Quah <seanq@element.io>	2022-03-14 18:49:07 +00:00
Sean Quah	8e5706d144	Fix broken background updates when using sqlite with `enable_search` off (#12215 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-14 17:52:58 +00:00
Sean Quah	90b2327066	Add `delay_cancellation` utility function (#12180 ) `delay_cancellation` behaves like `stop_cancellation`, except it delays `CancelledError`s until the original `Deferred` resolves. This is handy for unifying cleanup paths and ensuring that uncancelled coroutines don't use finished logcontexts. Signed-off-by: Sean Quah <seanq@element.io>	2022-03-14 17:52:15 +00:00
Patrick Cloke	54f674f7a9	Deprecate the groups/communities endpoints and add an experimental configuration flag. (#12200 )	2022-03-12 13:23:37 -05:00
Shay	ef3619e61d	Add config settings for background update parameters (#11980 )	2022-03-11 10:46:45 -08:00
Brendan Abolivier	e6a106fd5e	Implement a Jinja2 filter to extract localparts from email addresses (#12212 )	2022-03-11 15:15:11 +00:00
reivilibre	4a53f35737	Improve code documentation for the typing stream over replication. (#12211 )	2022-03-11 14:00:15 +00:00
Nick Mills-Barrett	735e89bd3a	Add an additional HTTP pusher + push rule tests. (#12188 ) And rename the field used for caching from _id to _cache_key.	2022-03-11 08:45:26 -05:00
Brendan Abolivier	003cc6910a	Update the SSO username picker template to comply with SIWA guidelines (#12210 ) Fixes https://github.com/matrix-org/synapse/issues/12205	2022-03-11 13:20:00 +00:00
Dirk Klimpel	32c828d0f7	Add type hints to `tests/rest`. (#12208 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-11 12:42:22 +00:00
Patrick Cloke	e10a2fe0c2	Add some type hints to the tests.handlers module. (#12207 )	2022-03-11 07:07:15 -05:00
Patrick Cloke	bc9dff1d95	Remove unnecessary pass statements. (#12206 )	2022-03-11 07:06:21 -05:00
Andrew Morgan	3b12f6d61b	Note that contributors can sign off privately (#12204 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-11 11:10:20 +00:00
Richard van der Hoff	483f2aa2ec	Retention test: avoid relying on state at purged events (#12202 ) This test was relying on poking events which weren't in the database into filter_events_for_client.	2022-03-11 10:33:49 +00:00
~creme	7577894bec	Document that most streams can only have a single writer. (#12196 ) This includes the `typing`, `to_device`, `account_data`, `receipts`, and `presence` streams (really anything except the `events` stream).	2022-03-10 18:15:19 +00:00
Shay	ed9aea42fa	fix misleading comment in `check_events_for_spam` (#12203 )	2022-03-10 09:40:07 -08:00
reivilibre	72e7f1c420	Remove workaround introduced in Synapse v1.50.0rc1 for Mjolnir compatibility. Breaks compatibility with Mjolnir v1.3.1 and earlier. (#11700 )	2022-03-10 15:53:23 +00:00
Patrick Cloke	ea27528b5d	Support stable identifiers for MSC3440: Threading (#12151 ) The unstable identifiers are still supported if the experimental configuration flag is enabled. The unstable identifiers will be removed in a future release.	2022-03-10 15:36:13 +00:00
Richard van der Hoff	52a947dc46	Updates to the Room DAG concepts development document (#12179 ) Some stuff that came up while we were talking about #12173.	2022-03-10 15:18:31 +00:00
Patrick Cloke	88cd6f9378	Allow retrieving the relations of a redacted event. (#12130 ) This is allowed per MSC2675, although the original implementation did not allow for it and would return an empty chunk / not bundle aggregations. The main thing to improve is that the various caches get cleared properly when an event is redacted, and that edits must not leak if the original event is redacted (as that would presumably leak something similar to the original event content).	2022-03-10 09:03:59 -05:00
Patrick Cloke	3e4af36bc8	Rename get_tcp_replication to get_replication_command_handler. (#12192 ) Since the object it returns is a ReplicationCommandHandler. This is clean-up from adding support to Redis where the command handler was added as an additional layer of abstraction from the TCP protocol.	2022-03-10 13:01:56 +00:00
Sean Quah	a4c1fdb44a	Remove dead code in `tests/storage/test_database.py` (#12197 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-09 18:45:21 +00:00
Will Hunt	15382b1afa	Add third_party module callbacks to check if a user can delete a room and deactivate a user (#12028 ) * Add check_can_deactivate_user * Add check_can_shutdown_rooms * Documentation * callbacks, not functions * Various suggested tweaks * Add tests for test_check_can_shutdown_room and test_check_can_deactivate_user * Update check_can_deactivate_user to not take a Requester * Fix check_can_shutdown_room docs * Renegade and use `by_admin` instead of `admin_user_id` * fix lint * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-03-09 18:23:57 +00:00
Patrick Cloke	690cb4f3b3	Allow for ignoring some arguments when caching. (#12189 ) * `@cached` can now take an `uncached_args` which is an iterable of names to not use in the cache key. * Requires `@cached`, @cachedList` and `@lru_cache` to use keyword arguments for clarity. * Asserts that keyword-only arguments in cached functions are not accepted. (I tested this briefly and I don't believe this works properly.)	2022-03-09 18:07:41 +00:00
Patrick Cloke	032688854b	Remove some unused variables/parameters. (#12187 )	2022-03-09 15:29:39 +00:00
Nick Mills-Barrett	180d8ff0d4	Retry some http replication failures (#12182 ) This allows for the target process to be down for around a minute which provides time for restarts during synapse upgrades/config updates. Closes: #12178 Signed off by Nick Mills-Barrett nick@beeper.com	2022-03-09 14:53:28 +00:00
Richard van der Hoff	dc8d825ef2	Skip attempt to get state at backwards-extremities (#12173 ) We don't have the state at a backwards-extremity, so this is never going to do anything useful.	2022-03-09 11:00:48 +00:00
Patrick Cloke	9a0172d49f	Clean-up demo scripts & documentation (#12143 ) * Rewrites the demo documentation to be clearer, accurate, and moves it to our documentation tree. * Improvements to the demo scripts: * `clean.sh` now runs `stop.sh` first to avoid zombie processes. * Uses more modern Synapse configuration (and removes some obsolete configuration). * Consistently use the HTTP ports for server name, etc. * Remove the `demo/etc` directory and place everything into the `demo/808x` directories.	2022-03-08 15:02:59 -05:00
Sean Quah	5627182788	Use `ParamSpec` in type hints for `synapse.logging.context` (#12150 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-08 15:58:14 +00:00
Olivier Wilkinson (reivilibre)	0dc9c5653c	Merge branch 'master' into develop	2022-03-08 15:37:35 +00:00
reivilibre	bfa7d6b035	Fix CI not attaching source distributions and wheels to the GitHub releases. (#12131 )	2022-03-08 15:11:50 +00:00
Erik Johnston	2ce27a24fe	Add experimental environment variable to enable asyncio reactor (#12135 )	2022-03-08 13:23:18 +00:00
Patrick Cloke	ca9234a9eb	Do not return allowed_room_ids from /hierarchy response. (#12175 ) This field is only to be used in the Server-Server API, and not the Client-Server API, but was being leaked when a federation response was used in the /hierarchy API.	2022-03-08 08:09:11 -05:00
Patrick Cloke	d8bab6793c	Fix incorrect type hints for txredis. (#12042 ) Some properties were marked as RedisProtocol instead of ConnectionHandler, which wraps RedisProtocol instance(s).	2022-03-08 07:26:05 -05:00
Olivier Wilkinson (reivilibre)	ea992adf86	1.54.0	2022-03-08 10:55:26 +00:00
reivilibre	2eef234ae3	Fix a bug introduced in 1.54.0rc1 which meant that Synapse would refuse to start if pre-release versions of dependencies were installed. (#12177 ) * Add failing test to characterise the regression #12176 * Permit pre-release versions of specified packages * Newsfile (bugfix) Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>	2022-03-08 10:47:28 +00:00
Shay	26211fec24	Fix a bug in background updates wherein background updates are never run using the default batch size (#12157 )	2022-03-07 09:44:33 -08:00
Patrick Cloke	f63bedef07	Invalidate caches when an event with a relation is redacted. (#12121 ) The caches for the target of the relation must be cleared so that the bundled aggregations are re-calculated after the redaction is processed.	2022-03-07 14:00:05 +00:00
Richard van der Hoff	0211f18d65	Switch the `tests-done` job to an Action (#12161 ) I've factored it out for easier use in other workflows.	2022-03-07 12:24:06 +00:00
Richard van der Hoff	00a67f831a	Merge remote-tracking branch 'origin/release-v1.54' into develop	2022-03-04 22:40:51 +00:00
David Robertson	d2ef1a79cf	Relax version guard for packaging (#12166 ) It’s just occurred to me that #12088 pulled in the “packaging” package (~=21.3). I pulled in the newest version I had at the time. I only use it for packaging.requirements.Requirements. Which was added in packaging 16.1: https://github.com/pypa/packaging/releases/tag/16.1 https://pkgs.org/download/python3-packaging suggests that the oldest version we care about is 17.1 in Ubuntu Bionic. So I think with this bound we're hunky dory.	2022-03-04 22:40:24 +00:00
Erik Johnston	0752ab7a36	Reduce to-device queries for /sync. (#12163 )	2022-03-04 17:57:27 +00:00
Sean Quah	75574726a7	Add type hints for `ObservableDeferred` attributes (#12159 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-04 15:37:02 +00:00
Sean Quah	158e0937eb	Add test for `ObservableDeferred`'s cancellation behaviour (#12149 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-04 13:10:05 +00:00
Patrick Cloke	cd1ae3d0b4	Remove backwards compatibility with RelationPaginationToken. (#12138 )	2022-03-04 07:10:10 -05:00
David Robertson	36071d39f7	Changelog (#12153 )	2022-03-04 12:01:51 +00:00
David Robertson	4aeb00ca20	Move synctl into `synapse._scripts` and expose as an entrypoint (#12140 )	2022-03-04 11:58:49 +00:00
Erik Johnston	423cca9efe	Spread out sending device lists to remote hosts (#12132 )	2022-03-04 11:48:15 +00:00
Richard van der Hoff	87c230c27c	Update client-visibility filtering for outlier events (#12155 ) Avoid trying to get the state for outliers, which isn't a sensible thing to do.	2022-03-04 10:31:19 +00:00
Richard van der Hoff	d56202b038	Fix type of `events` in `StateGroupStorage` and `StateHandler` (#12156 ) We make multiple passes over this, so a regular iterable won't do.	2022-03-04 10:25:18 +00:00
Richard van der Hoff	8533c8b03d	Avoid generating state groups for local out-of-band leaves (#12154 ) If we locally generate a rejection for an invite received over federation, it is stored as an outlier (because we probably don't have the state for the room). However, currently we still generate a state group for it (even though the state in that state group will be nonsense). By setting the `outlier` param on `create_event`, we avoid the nonsensical state.	2022-03-03 19:58:08 +00:00
Andrew Morgan	fb0ffa9676	Rename various ApplicationServices interested methods (#11915 )	2022-03-03 18:14:09 +00:00
David Robertson	9297d040a7	Detox, part 2 of N (#12152 ) I've argued in #11537 that poetry and tox don't cooperate well at the moment. (See also #12119.) Therefore I'm pruning away bits of tox to make the transition to poetry easier. This change removes the commands for coverage. We don't use coverage in anger at the moment. It shouldn't be too hard to add coverage as a dev-dependency and reintroduce this if we really want it.	2022-03-03 17:14:09 +00:00
Dirk Klimpel	7e91107be1	Add type hints to `tests/rest` (#12146 ) * Add type hints to `tests/rest` * newsfile * change import from `SigningKey`	2022-03-03 16:05:44 +00:00
Patrick Cloke	1d11b452b7	Use the proper serialization format when bundling aggregations. (#12090 ) This ensures that the `latest_event` field of the bundled aggregation for threads uses the same format as the other events in the response.	2022-03-03 10:43:06 -05:00
David Robertson	cea1b58c4a	Don't impose version checks on dev extras at runtime (#12129 ) * Fix incorrect argument in test case * Add copyright header * Docstring and __all__ * Exclude dev depenencies * Use changelog from #12088 * Include version in error messages This will hopefully distinguish between the version of the source code and the version of the distribution package that is installed. * Linter script is your friend	2022-03-03 12:47:55 +00:00
Eric Eastwood	a511a890d7	Enable MSC2716 Complement tests in Synapse (#12145 ) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-03-03 11:19:20 +00:00
Erik Johnston	61fd2a8f59	Limit the size of the aggregation_key (#12101 ) There's no reason to let people use long keys.	2022-03-03 10:52:35 +00:00
Eric Eastwood	31b125ccec	Enable MSC3030 Complement tests in Synapse (#12144 ) The Complement tests for MSC3030 are now merged, https://github.com/matrix-org/complement/pull/178 Synapse implmentation: https://github.com/matrix-org/synapse/pull/9445	2022-03-03 11:45:23 +01:00
Brendan Abolivier	ae8a616b49	Correctly register deactivation and profile update module callbacks (#12141 )	2022-03-03 11:39:58 +01:00
David Robertson	11282ade1d	Move the `snapcraft` configuration to `contrib`. (#12142 ) * Move the `snapcraft` configuration to `contrib`. We're happy for people to package this as a snap image if it's useful, but we don't support or maintain it. I'd like to move the config to `contrib` to reflect this state of affairs. * Changelog	2022-03-02 19:22:44 +00:00
David Robertson	1fbe0316a9	Add suffices to scripts in scripts-dev (#12137 ) * Rename scripts-dev to have suffices * Update references to `scripts-dev` * Changelog * These scripts don't pass mypy	2022-03-02 18:00:26 +00:00
David Robertson	106959b3cf	Remove unused mocks from `test_typing` (#12136 ) * Remove unused mocks from `test_typing` It's not clear what these do. `get_user_by_access_token` has the wrong signature, including the return type. Tests all pass without these. I think we should nuke them. * Changelog * Fixup imports	2022-03-02 17:24:52 +00:00
Dirk Klimpel	2ffaf30803	Add type hints to `tests/rest/client` (#12108 ) * Add type hints to `tests/rest/client` * newsfile * fix imports * add `test_account.py` * Remove one type hint in `test_report_event.py` * change `on_create_room` to `async` * update new functions in `test_third_party_rules.py` * Add `test_filter.py` * add `test_rooms.py` * change to `assertEquals` to `assertEqual` * lint	2022-03-02 16:34:14 +00:00
Andrew Morgan	b4461e7d8a	Enable complexity checking in complexity checking docs example (#11998 )	2022-03-02 16:11:16 +00:00
Olivier Wilkinson (reivilibre)	594a07ede4	Synapse 1.54.0rc1 (2022-03-02) ============================== Please note that this will be the last release of Synapse that is compatible with Mjolnir 1.3.1 and earlier. Administrators of servers which have the Mjolnir module installed are advised to upgrade Mjolnir to version 1.3.2 or later. Features -------- - Add support for [MSC3202](https://github.com/matrix-org/matrix-doc/pull/3202): sending one-time key counts and fallback key usage states to Application Services. ([\#11617](https://github.com/matrix-org/synapse/issues/11617)) - Improve the generated URL previews for some web pages. Contributed by @AndrewRyanChama. ([\#11985](https://github.com/matrix-org/synapse/issues/11985)) - Track cache invalidations in Prometheus metrics, as already happens for cache eviction based on size or time. ([\#12000](https://github.com/matrix-org/synapse/issues/12000)) - Implement experimental support for [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) (account status endpoints). ([\#12001](https://github.com/matrix-org/synapse/issues/12001), [\#12067](https://github.com/matrix-org/synapse/issues/12067)) - Enable modules to set a custom display name when registering a user. ([\#12009](https://github.com/matrix-org/synapse/issues/12009)) - Advertise Matrix 1.1 and 1.2 support on `/_matrix/client/versions`. ([\#12020](https://github.com/matrix-org/synapse/issues/12020), ([\#12022](https://github.com/matrix-org/synapse/issues/12022)) - Support only the stable identifier for [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069)'s `is_guest` on `/_matrix/client/v3/account/whoami`. ([\#12021](https://github.com/matrix-org/synapse/issues/12021)) - Use room version 9 as the default room version (per [MSC3589](https://github.com/matrix-org/matrix-doc/pull/3589)). ([\#12058](https://github.com/matrix-org/synapse/issues/12058)) - Add module callbacks to react to user deactivation status changes (i.e. deactivations and reactivations) and profile updates. ([\#12062](https://github.com/matrix-org/synapse/issues/12062)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where an edit of the latest event in a thread would not be properly applied to the thread summary. ([\#11992](https://github.com/matrix-org/synapse/issues/11992)) - Fix long-standing bug where the `get_rooms_for_user` cache was not correctly invalidated for remote users when the server left a room. ([\#11999](https://github.com/matrix-org/synapse/issues/11999)) - Fix a 500 error with Postgres when looking backwards with the [MSC3030](https://github.com/matrix-org/matrix-doc/pull/3030) `/timestamp_to_event?dir=b` endpoint. ([\#12024](https://github.com/matrix-org/synapse/issues/12024)) - Properly fix a long-standing bug where wrong data could be inserted into the `event_search` table when using SQLite. This could block running `synapse_port_db` with an `argument of type 'int' is not iterable` error. This bug was partially fixed by a change in Synapse 1.44.0. ([\#12037](https://github.com/matrix-org/synapse/issues/12037)) - Fix slow performance of `/logout` in some cases where refresh tokens are in use. The slowness existed since the initial implementation of refresh tokens in version 1.38.0. ([\#12056](https://github.com/matrix-org/synapse/issues/12056)) - Fix a long-standing bug where Synapse would make additional failing requests over federation for missing data. ([\#12077](https://github.com/matrix-org/synapse/issues/12077)) - Fix occasional `Unhandled error in Deferred` error message. ([\#12089](https://github.com/matrix-org/synapse/issues/12089)) - Fix a bug introduced in Synapse 1.51.0 where incoming federation transactions containing at least one EDU would be dropped if debug logging was enabled for `synapse.8631_debug`. ([\#12098](https://github.com/matrix-org/synapse/issues/12098)) - Fix a long-standing bug which could cause push notifications to malfunction if `use_frozen_dicts` was set in the configuration. ([\#12100](https://github.com/matrix-org/synapse/issues/12100)) - Fix an extremely rare, long-standing bug in `ReadWriteLock` that would cause an error when a newly unblocked writer completes instantly. ([\#12105](https://github.com/matrix-org/synapse/issues/12105)) - Make a `POST` to `/rooms/<room_id>/receipt/m.read/<event_id>` only trigger a push notification if the count of unread messages is different to the one in the last successfully sent push. This reduces server load and load on the receiving device. ([\#11835](https://github.com/matrix-org/synapse/issues/11835)) Updates to the Docker image --------------------------- - The Docker image no longer automatically creates a temporary volume at `/data`. This is not expected to affect normal usage. ([\#11997](https://github.com/matrix-org/synapse/issues/11997)) - Use Python 3.9 in Docker images by default. ([\#12112](https://github.com/matrix-org/synapse/issues/12112)) Improved Documentation ---------------------- - Document support for the `to_device`, `account_data`, `receipts`, and `presence` stream writers for workers. ([\#11599](https://github.com/matrix-org/synapse/issues/11599)) - Explain the meaning of spam checker callbacks' return values. ([\#12003](https://github.com/matrix-org/synapse/issues/12003)) - Clarify information about external Identity Provider IDs. ([\#12004](https://github.com/matrix-org/synapse/issues/12004)) Deprecations and Removals ------------------------- - Deprecate using `synctl` with the config option `synctl_cache_factor` and print a warning if a user still uses this option. ([\#11865](https://github.com/matrix-org/synapse/issues/11865)) - Remove support for the legacy structured logging configuration (please see the the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#legacy-structured-logging-configuration-removal) if you are using `structured: true` in the Synapse configuration). ([\#12008](https://github.com/matrix-org/synapse/issues/12008)) - Drop support for [MSC3283](https://github.com/matrix-org/matrix-doc/pull/3283) unstable flags now that the stable flags are supported. ([\#12018](https://github.com/matrix-org/synapse/issues/12018)) - Remove the unstable `/spaces` endpoint from [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946). ([\#12073](https://github.com/matrix-org/synapse/issues/12073)) Internal Changes ---------------- - Make the `get_room_version` method use `get_room_version_id` to benefit from caching. ([\#11808](https://github.com/matrix-org/synapse/issues/11808)) - Remove unnecessary condition on knock -> leave auth rule check. ([\#11900](https://github.com/matrix-org/synapse/issues/11900)) - Add tests for device list changes between local users. ([\#11972](https://github.com/matrix-org/synapse/issues/11972)) - Optimise calculating `device_list` changes in `/sync`. ([\#11974](https://github.com/matrix-org/synapse/issues/11974)) - Add missing type hints to storage classes. ([\#11984](https://github.com/matrix-org/synapse/issues/11984)) - Refactor the search code for improved readability. ([\#11991](https://github.com/matrix-org/synapse/issues/11991)) - Move common deduplication code down into `_auth_and_persist_outliers`. ([\#11994](https://github.com/matrix-org/synapse/issues/11994)) - Limit concurrent joins from applications services. ([\#11996](https://github.com/matrix-org/synapse/issues/11996)) - Preparation for faster-room-join work: when parsing the `send_join` response, get the `m.room.create` event from `state`, not `auth_chain`. ([\#12005](https://github.com/matrix-org/synapse/issues/12005), [\#12039](https://github.com/matrix-org/synapse/issues/12039)) - Preparation for faster-room-join work: parse MSC3706 fields in send_join response. ([\#12011](https://github.com/matrix-org/synapse/issues/12011)) - Preparation for faster-room-join work: persist information on which events and rooms have partial state to the database. ([\#12012](https://github.com/matrix-org/synapse/issues/12012)) - Preparation for faster-room-join work: Support for calling `/federation/v1/state` on a remote server. ([\#12013](https://github.com/matrix-org/synapse/issues/12013)) - Configure `tox` to use `venv` rather than `virtualenv`. ([\#12015](https://github.com/matrix-org/synapse/issues/12015)) - Fix bug in `StateFilter.return_expanded()` and add some tests. ([\#12016](https://github.com/matrix-org/synapse/issues/12016)) - Use Matrix v1.1 endpoints (`/_matrix/client/v3/auth/...`) in fallback auth HTML forms. ([\#12019](https://github.com/matrix-org/synapse/issues/12019)) - Update the `olddeps` CI job to use an old version of `markupsafe`. ([\#12025](https://github.com/matrix-org/synapse/issues/12025)) - Upgrade Mypy to version 0.931. ([\#12030](https://github.com/matrix-org/synapse/issues/12030)) - Remove legacy `HomeServer.get_datastore()`. ([\#12031](https://github.com/matrix-org/synapse/issues/12031), [\#12070](https://github.com/matrix-org/synapse/issues/12070)) - Minor typing fixes. ([\#12034](https://github.com/matrix-org/synapse/issues/12034), [\#12069](https://github.com/matrix-org/synapse/issues/12069)) - After joining a room, create a dedicated logcontext to process the queued events. ([\#12041](https://github.com/matrix-org/synapse/issues/12041)) - Tidy up GitHub Actions config which builds distributions for PyPI. ([\#12051](https://github.com/matrix-org/synapse/issues/12051)) - Move configuration out of `setup.cfg`. ([\#12052](https://github.com/matrix-org/synapse/issues/12052), [\#12059](https://github.com/matrix-org/synapse/issues/12059)) - Fix error message when a worker process fails to talk to another worker process. ([\#12060](https://github.com/matrix-org/synapse/issues/12060)) - Fix using the `complement.sh` script without specifying a directory or a branch. Contributed by Nico on behalf of Famedly. ([\#12063](https://github.com/matrix-org/synapse/issues/12063)) - Add type hints to `tests/rest/client`. ([\#12066](https://github.com/matrix-org/synapse/issues/12066), [\#12072](https://github.com/matrix-org/synapse/issues/12072), [\#12084](https://github.com/matrix-org/synapse/issues/12084), [\#12094](https://github.com/matrix-org/synapse/issues/12094)) - Add some logging to `/sync` to try and track down #11916. ([\#12068](https://github.com/matrix-org/synapse/issues/12068)) - Inspect application dependencies using `importlib.metadata` or its backport. ([\#12088](https://github.com/matrix-org/synapse/issues/12088)) - Use `assertEqual` instead of the deprecated `assertEquals` in test code. ([\#12092](https://github.com/matrix-org/synapse/issues/12092)) - Move experimental support for [MSC3440](https://github.com/matrix-org/matrix-doc/pull/3440) to `/versions`. ([\#12099](https://github.com/matrix-org/synapse/issues/12099)) - Add `stop_cancellation` utility function to stop `Deferred`s from being cancelled. ([\#12106](https://github.com/matrix-org/synapse/issues/12106)) - Improve exception handling for concurrent execution. ([\#12109](https://github.com/matrix-org/synapse/issues/12109)) - Advertise support for Python 3.10 in packaging files. ([\#12111](https://github.com/matrix-org/synapse/issues/12111)) - Move CI checks out of tox, to facilitate a move to using poetry. ([\#12119](https://github.com/matrix-org/synapse/issues/12119)) -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE8SRSDO7gYkSP4chELS76LzL74EcFAmIffxUACgkQLS76LzL7 4EefXxAAvnJb1BxzWwlYyKaDULjmNfsKilRWlT/A1/7VaumB84H4gFQklLuMbJdR pyktlkmVZrnLG+Vz2JfgFm4wTXvLGieACvlAodQWztQX2szqPAHeq0A0vuMgJEay mVKVnU6b83CONBr021/lm6NOBetbUqOVyiFsnuBKlLPs4WdSt+3DvBRZ3hsQTrCV zEOSdzVM67yr0xo3/vmT+nzlfcegJ64EOT+dFwMfKnoWbRK0lMwnob1WZbiOE0+9 9hoqEucbmzf/4IKgURxmNmrUDIPGUlGq4BnKMGMNyrwWv9v+8pXuIqzOYEUnWVBh upvS88OBswk2EXIIk22/rf5gohNShQDmki41CVTH32G+dP72YxCfTGsafwUpS+Hm KlojCRccmo2y2sQnLzrhswsOPFiYP0AORPIp3hO1mVTMZ7EgjsP4Y8C/S54Oe03F 6U3M5pv6aqURiAHAnyC4KbPOVqUbEzthUuRINEDp5QhNSFyvtwV9DTaFixMpMdR0 OJU8tMaGmCtqdsqNOZ4vGhzPVD/1kJ0KapPyJbkVSGoRdlI01sqO7Nu+k8AZ1oEc nkoR5zMTysCAuGCIOtCWB8NOFBNyEgcCdz3356e+wvWx4PazIFsfyEXskzZY50iK dAIdr+w+kyf4d/e9JpK7YHrPP5uP2s0V8Y4MvDx3wUXJ6VZ834Y= =jw9M -----END PGP SIGNATURE----- Merge tag 'v1.54.0rc1' into develop Synapse 1.54.0rc1 (2022-03-02) ============================== Please note that this will be the last release of Synapse that is compatible with Mjolnir 1.3.1 and earlier. Administrators of servers which have the Mjolnir module installed are advised to upgrade Mjolnir to version 1.3.2 or later. Features -------- - Add support for [MSC3202](https://github.com/matrix-org/matrix-doc/pull/3202): sending one-time key counts and fallback key usage states to Application Services. ([\#11617](https://github.com/matrix-org/synapse/issues/11617)) - Improve the generated URL previews for some web pages. Contributed by @AndrewRyanChama. ([\#11985](https://github.com/matrix-org/synapse/issues/11985)) - Track cache invalidations in Prometheus metrics, as already happens for cache eviction based on size or time. ([\#12000](https://github.com/matrix-org/synapse/issues/12000)) - Implement experimental support for [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) (account status endpoints). ([\#12001](https://github.com/matrix-org/synapse/issues/12001), [\#12067](https://github.com/matrix-org/synapse/issues/12067)) - Enable modules to set a custom display name when registering a user. ([\#12009](https://github.com/matrix-org/synapse/issues/12009)) - Advertise Matrix 1.1 and 1.2 support on `/_matrix/client/versions`. ([\#12020](https://github.com/matrix-org/synapse/issues/12020), ([\#12022](https://github.com/matrix-org/synapse/issues/12022)) - Support only the stable identifier for [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069)'s `is_guest` on `/_matrix/client/v3/account/whoami`. ([\#12021](https://github.com/matrix-org/synapse/issues/12021)) - Use room version 9 as the default room version (per [MSC3589](https://github.com/matrix-org/matrix-doc/pull/3589)). ([\#12058](https://github.com/matrix-org/synapse/issues/12058)) - Add module callbacks to react to user deactivation status changes (i.e. deactivations and reactivations) and profile updates. ([\#12062](https://github.com/matrix-org/synapse/issues/12062)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where an edit of the latest event in a thread would not be properly applied to the thread summary. ([\#11992](https://github.com/matrix-org/synapse/issues/11992)) - Fix long-standing bug where the `get_rooms_for_user` cache was not correctly invalidated for remote users when the server left a room. ([\#11999](https://github.com/matrix-org/synapse/issues/11999)) - Fix a 500 error with Postgres when looking backwards with the [MSC3030](https://github.com/matrix-org/matrix-doc/pull/3030) `/timestamp_to_event?dir=b` endpoint. ([\#12024](https://github.com/matrix-org/synapse/issues/12024)) - Properly fix a long-standing bug where wrong data could be inserted into the `event_search` table when using SQLite. This could block running `synapse_port_db` with an `argument of type 'int' is not iterable` error. This bug was partially fixed by a change in Synapse 1.44.0. ([\#12037](https://github.com/matrix-org/synapse/issues/12037)) - Fix slow performance of `/logout` in some cases where refresh tokens are in use. The slowness existed since the initial implementation of refresh tokens in version 1.38.0. ([\#12056](https://github.com/matrix-org/synapse/issues/12056)) - Fix a long-standing bug where Synapse would make additional failing requests over federation for missing data. ([\#12077](https://github.com/matrix-org/synapse/issues/12077)) - Fix occasional `Unhandled error in Deferred` error message. ([\#12089](https://github.com/matrix-org/synapse/issues/12089)) - Fix a bug introduced in Synapse 1.51.0 where incoming federation transactions containing at least one EDU would be dropped if debug logging was enabled for `synapse.8631_debug`. ([\#12098](https://github.com/matrix-org/synapse/issues/12098)) - Fix a long-standing bug which could cause push notifications to malfunction if `use_frozen_dicts` was set in the configuration. ([\#12100](https://github.com/matrix-org/synapse/issues/12100)) - Fix an extremely rare, long-standing bug in `ReadWriteLock` that would cause an error when a newly unblocked writer completes instantly. ([\#12105](https://github.com/matrix-org/synapse/issues/12105)) - Make a `POST` to `/rooms/<room_id>/receipt/m.read/<event_id>` only trigger a push notification if the count of unread messages is different to the one in the last successfully sent push. This reduces server load and load on the receiving device. ([\#11835](https://github.com/matrix-org/synapse/issues/11835)) Updates to the Docker image --------------------------- - The Docker image no longer automatically creates a temporary volume at `/data`. This is not expected to affect normal usage. ([\#11997](https://github.com/matrix-org/synapse/issues/11997)) - Use Python 3.9 in Docker images by default. ([\#12112](https://github.com/matrix-org/synapse/issues/12112)) Improved Documentation ---------------------- - Document support for the `to_device`, `account_data`, `receipts`, and `presence` stream writers for workers. ([\#11599](https://github.com/matrix-org/synapse/issues/11599)) - Explain the meaning of spam checker callbacks' return values. ([\#12003](https://github.com/matrix-org/synapse/issues/12003)) - Clarify information about external Identity Provider IDs. ([\#12004](https://github.com/matrix-org/synapse/issues/12004)) Deprecations and Removals ------------------------- - Deprecate using `synctl` with the config option `synctl_cache_factor` and print a warning if a user still uses this option. ([\#11865](https://github.com/matrix-org/synapse/issues/11865)) - Remove support for the legacy structured logging configuration (please see the the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#legacy-structured-logging-configuration-removal) if you are using `structured: true` in the Synapse configuration). ([\#12008](https://github.com/matrix-org/synapse/issues/12008)) - Drop support for [MSC3283](https://github.com/matrix-org/matrix-doc/pull/3283) unstable flags now that the stable flags are supported. ([\#12018](https://github.com/matrix-org/synapse/issues/12018)) - Remove the unstable `/spaces` endpoint from [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946). ([\#12073](https://github.com/matrix-org/synapse/issues/12073)) Internal Changes ---------------- - Make the `get_room_version` method use `get_room_version_id` to benefit from caching. ([\#11808](https://github.com/matrix-org/synapse/issues/11808)) - Remove unnecessary condition on knock -> leave auth rule check. ([\#11900](https://github.com/matrix-org/synapse/issues/11900)) - Add tests for device list changes between local users. ([\#11972](https://github.com/matrix-org/synapse/issues/11972)) - Optimise calculating `device_list` changes in `/sync`. ([\#11974](https://github.com/matrix-org/synapse/issues/11974)) - Add missing type hints to storage classes. ([\#11984](https://github.com/matrix-org/synapse/issues/11984)) - Refactor the search code for improved readability. ([\#11991](https://github.com/matrix-org/synapse/issues/11991)) - Move common deduplication code down into `_auth_and_persist_outliers`. ([\#11994](https://github.com/matrix-org/synapse/issues/11994)) - Limit concurrent joins from applications services. ([\#11996](https://github.com/matrix-org/synapse/issues/11996)) - Preparation for faster-room-join work: when parsing the `send_join` response, get the `m.room.create` event from `state`, not `auth_chain`. ([\#12005](https://github.com/matrix-org/synapse/issues/12005), [\#12039](https://github.com/matrix-org/synapse/issues/12039)) - Preparation for faster-room-join work: parse MSC3706 fields in send_join response. ([\#12011](https://github.com/matrix-org/synapse/issues/12011)) - Preparation for faster-room-join work: persist information on which events and rooms have partial state to the database. ([\#12012](https://github.com/matrix-org/synapse/issues/12012)) - Preparation for faster-room-join work: Support for calling `/federation/v1/state` on a remote server. ([\#12013](https://github.com/matrix-org/synapse/issues/12013)) - Configure `tox` to use `venv` rather than `virtualenv`. ([\#12015](https://github.com/matrix-org/synapse/issues/12015)) - Fix bug in `StateFilter.return_expanded()` and add some tests. ([\#12016](https://github.com/matrix-org/synapse/issues/12016)) - Use Matrix v1.1 endpoints (`/_matrix/client/v3/auth/...`) in fallback auth HTML forms. ([\#12019](https://github.com/matrix-org/synapse/issues/12019)) - Update the `olddeps` CI job to use an old version of `markupsafe`. ([\#12025](https://github.com/matrix-org/synapse/issues/12025)) - Upgrade Mypy to version 0.931. ([\#12030](https://github.com/matrix-org/synapse/issues/12030)) - Remove legacy `HomeServer.get_datastore()`. ([\#12031](https://github.com/matrix-org/synapse/issues/12031), [\#12070](https://github.com/matrix-org/synapse/issues/12070)) - Minor typing fixes. ([\#12034](https://github.com/matrix-org/synapse/issues/12034), [\#12069](https://github.com/matrix-org/synapse/issues/12069)) - After joining a room, create a dedicated logcontext to process the queued events. ([\#12041](https://github.com/matrix-org/synapse/issues/12041)) - Tidy up GitHub Actions config which builds distributions for PyPI. ([\#12051](https://github.com/matrix-org/synapse/issues/12051)) - Move configuration out of `setup.cfg`. ([\#12052](https://github.com/matrix-org/synapse/issues/12052), [\#12059](https://github.com/matrix-org/synapse/issues/12059)) - Fix error message when a worker process fails to talk to another worker process. ([\#12060](https://github.com/matrix-org/synapse/issues/12060)) - Fix using the `complement.sh` script without specifying a directory or a branch. Contributed by Nico on behalf of Famedly. ([\#12063](https://github.com/matrix-org/synapse/issues/12063)) - Add type hints to `tests/rest/client`. ([\#12066](https://github.com/matrix-org/synapse/issues/12066), [\#12072](https://github.com/matrix-org/synapse/issues/12072), [\#12084](https://github.com/matrix-org/synapse/issues/12084), [\#12094](https://github.com/matrix-org/synapse/issues/12094)) - Add some logging to `/sync` to try and track down #11916. ([\#12068](https://github.com/matrix-org/synapse/issues/12068)) - Inspect application dependencies using `importlib.metadata` or its backport. ([\#12088](https://github.com/matrix-org/synapse/issues/12088)) - Use `assertEqual` instead of the deprecated `assertEquals` in test code. ([\#12092](https://github.com/matrix-org/synapse/issues/12092)) - Move experimental support for [MSC3440](https://github.com/matrix-org/matrix-doc/pull/3440) to `/versions`. ([\#12099](https://github.com/matrix-org/synapse/issues/12099)) - Add `stop_cancellation` utility function to stop `Deferred`s from being cancelled. ([\#12106](https://github.com/matrix-org/synapse/issues/12106)) - Improve exception handling for concurrent execution. ([\#12109](https://github.com/matrix-org/synapse/issues/12109)) - Advertise support for Python 3.10 in packaging files. ([\#12111](https://github.com/matrix-org/synapse/issues/12111)) - Move CI checks out of tox, to facilitate a move to using poetry. ([\#12119](https://github.com/matrix-org/synapse/issues/12119))	2022-03-02 15:26:43 +00:00
Erik Johnston	6d282a9c89	Make release script write correct no-op changelog (#12127 ) As we want to include the previous version in the "No new changes..." string.	2022-03-02 14:28:18 +00:00
Patrick Cloke	1103c5fe8a	Check if instances are lists, not sequences. (#12128 ) As a str is a sequence, the checks were not granular enough and would allow lists or strings, when only lists were valid.	2022-03-02 13:18:51 +00:00
David Robertson	f3f0ab10fe	Move scripts directory inside synapse, exposing as setuptools entry_points (#12118 ) * Two scripts are basically entry_points already * Move and rename scripts/* to synapse/_scripts/.py Delete sync_room_to_group.pl * Expose entry points in setup.py * Update linter script and config * Fixup scripts & docs mentioning scripts that moved Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2022-03-02 13:00:16 +00:00
Patrick Cloke	6adb89ff00	Improve and refactor the tests for relations. (#12113 ) * Modernizes code (f-strings, etc.) * Fixes incorrect comments. * Splits the test case into two. * Factors out some duplicated code.	2022-03-02 06:56:16 -05:00
Olivier Wilkinson (reivilibre)	879e4a7bd7	1.54.0rc1	2022-03-02 10:45:16 +00:00
Olivier Wilkinson (reivilibre)	a43a5ea5bf	Remove misleading newsfile from #12126 which backs out an unreleased change.	2022-03-02 10:38:10 +00:00
reivilibre	c7b2f1ccdc	Back out in-flight state caching changes. (#12126 )	2022-03-02 10:37:04 +00:00
lukasdenk	8e56a1b73c	Make get_room_version use cached get_room_version_id. (#11808 )	2022-03-02 10:35:34 +00:00
David Robertson	5f62a094de	Detox, part 1 of N (#12119 ) * Don't use `tox` for `check-sampleconfig` * Don't use `tox` for check-newsfragment	2022-03-01 19:47:02 +00:00
David Robertson	313581e4e9	Use importlib.metadata to read requirements (#12088 ) * Pull runtime dep checks into their own module * Reimplement `check_requirements` using `importlib` I've tried to make this clearer. We start by working out which of Synapse's requirements we need to be installed here and now. I was surprised that there wasn't an easier way to see which packages were installed by a given extra. I've pulled out the error messages into functions that deal with "is this for an extra or not". And I've rearranged the loop over two different sets of requirements into one loop with a "must be instaled" flag. I hope you agree that this is clearer. * Test cases	2022-03-01 17:44:41 +00:00
Sean Quah	4d6b6c17c8	Fix rare error in `ReadWriteLock` when writers complete immediately (#12105 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-01 15:27:15 +00:00
Brendan Abolivier	300ed0b8a6	Add module callbacks called for reacting to deactivation status change and profile update (#12062 )	2022-03-01 15:00:03 +00:00

... 4 5 6 7 8 ...

6050 commits