tileradotorg/synapse

Author	SHA1	Message	Date
Jonathan de Jong	7c407efdc8	Update test logging to be able to accept braces (#8335 )	2020-09-18 07:56:40 -04:00
Patrick Cloke	9db4c1b175	Add flags to /versions about whether new rooms are encrypted by default. (#8343 )	2020-09-18 07:56:20 -04:00
Erik Johnston	5e42e61609	Merge remote-tracking branch 'origin/release-v1.20.0' into develop	2020-09-18 10:50:04 +01:00
Erik Johnston	14b5b48a22	Fix ratelimiting for federation `/send` requests. (#8342 ) c.f. #8295 for rationale	2020-09-18 10:49:29 +01:00
Jonathan de Jong	efb6b6629c	Move lint dependencies to extras_require (#8330 ) Lint dependencies can now be installed with pip install -e ".[lint]" This should help keep the version in sync between tox and documentation.	2020-09-17 16:45:22 -04:00
Matthew Hodgson	ad055ea4cc	blacklist MSC2753 sytests until it's implemented in synapse (#8285 ) Dendrite's implementing MSC2753 over at https://github.com/matrix-org/dendrite/pull/1370 to prove the implementation for MSC purposes, and so sytest has sprouted tests for it over at https://github.com/matrix-org/sytest/pull/944. But we don't want them to run on synapse until synapse implements it.	2020-09-17 14:02:20 -04:00
Jonathan de Jong	837293c314	Remove obsolete __future__ imports (#8337 )	2020-09-17 08:37:01 -04:00
Patrick Cloke	c3c9732c53	Use admin_patterns for all admin APIs. (#8331 ) This reduces duplication of the admin prefix in regular expressions.	2020-09-17 07:04:15 -04:00
Jonathan de Jong	53284c425e	Fix a potential bug of UnboundLocalError (#8329 ) Replaced with less buggier control flow	2020-09-17 11:54:56 +01:00
Jonathan de Jong	a3f124b821	Switch metaclass initialization to python 3-compatible syntax (#8326 )	2020-09-16 15:15:55 -04:00
Erik Johnston	5ffd68dca1	1.19.2	2020-09-16 13:37:03 +01:00
Erik Johnston	5dd051acae	Merge branch 'erikj/fix_origin_check' into develop	2020-09-16 12:43:02 +01:00
Erik Johnston	97659b7489	Newsfile	2020-09-16 12:05:01 +01:00
reivilibre	576bc37d31	Catch-up after Federation Outage (split, 4): catch-up loop (#8272 )	2020-09-15 09:07:19 +01:00
Patrick Cloke	aec294ee0d	Use slots in attrs classes where possible (#8296 ) slots use less memory (and attribute access is faster) while slightly limiting the flexibility of the class attributes. This focuses on objects which are instantiated "often" and for short periods of time.	2020-09-14 12:50:06 -04:00
Tulir Asokan	b82d68c0bd	Add the topic and avatar to the room details admin API (#8305 )	2020-09-14 10:07:04 -04:00
Patrick Cloke	6605470bfb	Improve SAML error messages (#8248 )	2020-09-14 09:05:36 -04:00
Erik Johnston	04cc249b43	Add experimental support for sharding event persister. Again. (#8294 ) This is not ready for production yet. Caveats: 1. We should write some tests... 2. The stream token that we use for events can get stalled at the minimum position of all writers. This means that new events may not be processed and e.g. sent down sync streams if a writer isn't writing or is slow.	2020-09-14 10:16:41 +01:00
Erik Johnston	fe8ed1b46f	Make `StreamToken.room_key` be a `RoomStreamToken` instance. (#8281 )	2020-09-11 12:22:55 +01:00
Dan Callaghan	c312ee3cde	Use TLSv1.2 for fake servers in tests (#8208 ) Some Linux distros have begun disabling TLSv1.0 and TLSv1.1 by default for security reasons, for example in Fedora 33 onwards: https://fedoraproject.org/wiki/Changes/StrongCryptoSettings2 Use TLSv1.2 for the fake TLS servers created in the test suite, to avoid failures due to OpenSSL disallowing TLSv1.0: <twisted.python.failure.Failure OpenSSL.SSL.Error: [('SSL routines', 'ssl_choose_client_version', 'unsupported protocol')]> Signed-off-by: Dan Callaghan <djc@djc.id.au>	2020-09-10 19:49:08 +01:00
Andrew Morgan	95d869c357	Add /_synapse/client to the reverse proxy docs (#8227 ) This PR adds a information about forwarding `/_synapse/client` endpoints through your reverse proxy. The first of these endpoints are introduced in https://github.com/matrix-org/synapse/pull/8004.	2020-09-10 13:26:34 +01:00
Erik Johnston	5d3e306d9f	Clean up `Notifier.on_new_room_event` code path (#8288 ) The idea here is that we pass the `max_stream_id` to everything, and only use the stream ID of the particular event to figure out when the max stream position has caught up to the event and we can notify people about it. This is to maintain the distinction between the position of an item in the stream (i.e. event A has stream ID 513) and a token that can be used to partition the stream (i.e. give me all events after stream ID 352). This distinction becomes important when the tokens are more complicated than a single number, which they will be once we start tracking the position of multiple writers in the tokens. The valid operations here are: 1. Is a position before or after a token 2. Fetching all events between two tokens 3. Merging multiple tokens to get the "max", i.e. `C = max(A, B)` means that for all positions P where P is before A or before B, then P is before C. Future PR will change the token type to a dedicated type.	2020-09-10 13:24:43 +01:00
Andrew Morgan	a3a90ee031	Show a confirmation page during user password reset (#8004 ) This PR adds a confirmation step to resetting your user password between clicking the link in your email and your password actually being reset. This is to better align our password reset flow with the industry standard of requiring a confirmation from the user after email validation.	2020-09-10 11:45:12 +01:00
Patrick Cloke	b312769c0e	Do not error when thumbnailing invalid files (#8236 ) If a file cannot be thumbnailed for some reason (e.g. the file is empty), then catch the exception and convert it to a reasonable error message for the client.	2020-09-09 12:59:41 -04:00
Patrick Cloke	2ea1c68249	Remove some unused distributor signals (#8216 ) Removes the `user_joined_room` and stops calling it since there are no observers. Also cleans-up some other unused signals and related code.	2020-09-09 12:22:00 -04:00
Erik Johnston	c9dbee50ae	Fixup pusher pool notifications (#8287 ) `pusher_pool.on_new_notifications` expected a min and max stream ID, however that was not what we were passing in. Instead, let's just pass it the current max stream ID and have it track the last stream ID it got passed. I believe that it mostly worked as we called the function for every event. However, it would break for events that got persisted out of order, i.e, that were persisted but the max stream ID wasn't incremented as not all preceding events had finished persisting, and push for that event would be delayed until another event got pushed to the effected users.	2020-09-09 16:56:08 +01:00
Matthew Hodgson	453dfe210b	blacklist MSC2753 sytests until it's implemented in synapse (#8285 ) Dendrite's implementing MSC2753 over at https://github.com/matrix-org/dendrite/pull/1370 to prove the implementation for MSC purposes, and so sytest has sprouted tests for it over at https://github.com/matrix-org/sytest/pull/944. But we don't want them to run on synapse until synapse implements it.	2020-09-09 13:25:59 +01:00
reivilibre	a5370072b5	Don't remember `enabled` of deleted push rules and properly return 404 for missing push rules in `.../actions` and `.../enabled` (#7796 ) Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2020-09-09 11:39:39 +01:00
Patrick Cloke	e45b834119	Add types to async_helpers (#8260 )	2020-09-08 16:50:51 -04:00
Erik Johnston	1553adc831	Fix mypy error on develop (#8282 )	2020-09-08 17:43:31 +01:00
DeepBlueV7.X	560f3b8609	Include method in thumbnail media name (#7124 ) This fixes an issue where different methods (crop/scale) overwrite each other. This first tries the new path. If that fails and we are looking for a remote thumbnail, it tries the old path. If that still isn't found, it continues as normal. This should probably be removed in the future, after some of the newer thumbnails were generated with the new path on most deployments. Then the overhead should be minimal if the other thumbnails need to be regenerated. Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>	2020-09-08 17:19:50 +01:00
Erik Johnston	63c0e9e195	Add types to StreamToken and RoomStreamToken (#8279 ) The intention here is to change `StreamToken.room_key` to be a `RoomStreamToken` in a future PR, but that is a big enough change without this refactoring too.	2020-09-08 16:48:15 +01:00
Andrew Morgan	094896a69d	Add a config option for validating 'next_link' parameters against a domain whitelist (#8275 ) This is a config option ported over from DINUM's Sydent: https://github.com/matrix-org/sydent/pull/285 They've switched to validating 3PIDs via Synapse rather than Sydent, and would like to retain this functionality. This original purpose for this change is phishing prevention. This solution could also potentially be replaced by a similar one to https://github.com/matrix-org/synapse/pull/8004, but across all `*/submit_token` endpoint. This option may still be useful to enterprise even with that safeguard in place though, if they want to be absolutely sure that their employees don't follow links to other domains.	2020-09-08 16:03:09 +01:00
Erik Johnston	0f545e6b96	Clean up types for PaginationConfig (#8250 ) This removes `SourcePaginationConfig` and `get_pagination_rows`. The reasoning behind this is that these generic classes/functions erased the types of the IDs it used (i.e. instead of passing around `StreamToken` it'd pass in e.g. `token.room_key`, which don't have uniform types).	2020-09-08 15:00:17 +01:00
Richard van der Hoff	703e2b8a96	Use the right constructor for log records (#8278 ) Update `log_function` to use the right factory to create log records, to make sure that they have `request` attributes. Fixes: #8267.	2020-09-08 14:52:51 +01:00
Erik Johnston	deedb91732	Fix `MultiWriterIdGenerator.current_position`. (#8257 ) It did not correctly handle IDs finishing being persisted out of order, resulting in the `current_position` lagging until new IDs are persisted.	2020-09-08 14:26:54 +01:00
Richard van der Hoff	cca03dbec8	Synapse 1.20.0rc1 (2020-09-08) ============================== Removal warning --------------- Some older clients used a [disallowed character](https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-register-email-requesttoken) (`:`) in the `client_secret` parameter of various endpoints. The incorrect behaviour was allowed for backwards compatibility, but is now being removed from Synapse as most users have updated their client. Further context can be found at [\#6766](https://github.com/matrix-org/synapse/issues/6766). Features -------- - Add an endpoint to query your shared rooms with another user as an implementation of [MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666). ([\#7785](https://github.com/matrix-org/synapse/issues/7785)) - Iteratively encode JSON to avoid blocking the reactor. ([\#8013](https://github.com/matrix-org/synapse/issues/8013), [\#8116](https://github.com/matrix-org/synapse/issues/8116)) - Add support for shadow-banning users (ignoring any message send requests). ([\#8034](https://github.com/matrix-org/synapse/issues/8034), [\#8092](https://github.com/matrix-org/synapse/issues/8092), [\#8095](https://github.com/matrix-org/synapse/issues/8095), [\#8142](https://github.com/matrix-org/synapse/issues/8142), [\#8152](https://github.com/matrix-org/synapse/issues/8152), [\#8157](https://github.com/matrix-org/synapse/issues/8157), [\#8158](https://github.com/matrix-org/synapse/issues/8158), [\#8176](https://github.com/matrix-org/synapse/issues/8176)) - Use the default template file when its equivalent is not found in a custom template directory. ([\#8037](https://github.com/matrix-org/synapse/issues/8037), [\#8107](https://github.com/matrix-org/synapse/issues/8107), [\#8252](https://github.com/matrix-org/synapse/issues/8252)) - Add unread messages count to sync responses, as specified in [MSC2654](https://github.com/matrix-org/matrix-doc/pull/2654). ([\#8059](https://github.com/matrix-org/synapse/issues/8059), [\#8254](https://github.com/matrix-org/synapse/issues/8254), [\#8270](https://github.com/matrix-org/synapse/issues/8270), [\#8274](https://github.com/matrix-org/synapse/issues/8274)) - Optimise `/federation/v1/user/devices/` API by only returning devices with encryption keys. ([\#8198](https://github.com/matrix-org/synapse/issues/8198)) Bugfixes -------- - Fix a memory leak by limiting the length of time that messages will be queued for a remote server that has been unreachable. ([\#7864](https://github.com/matrix-org/synapse/issues/7864)) - Fix `Re-starting finished log context PUT-nnnn` warning when event persistence failed. ([\#8081](https://github.com/matrix-org/synapse/issues/8081)) - Synapse now correctly enforces the valid characters in the `client_secret` parameter used in various endpoints. ([\#8101](https://github.com/matrix-org/synapse/issues/8101)) - Fix a bug introduced in v1.7.2 impacting message retention policies that would allow federated homeservers to dictate a retention period that's lower than the configured minimum allowed duration in the configuration file. ([\#8104](https://github.com/matrix-org/synapse/issues/8104)) - Fix a long-standing bug where invalid JSON would be accepted by Synapse. ([\#8106](https://github.com/matrix-org/synapse/issues/8106)) - Fix a bug introduced in Synapse v1.12.0 which could cause `/sync` requests to fail with a 404 if you had a very old outstanding room invite. ([\#8110](https://github.com/matrix-org/synapse/issues/8110)) - Return a proper error code when the rooms of an invalid group are requested. ([\#8129](https://github.com/matrix-org/synapse/issues/8129)) - Fix a bug which could cause a leaked postgres connection if synapse was set to daemonize. ([\#8131](https://github.com/matrix-org/synapse/issues/8131)) - Clarify the error code if a user tries to register with a numeric ID. This bug was introduced in v1.15.0. ([\#8135](https://github.com/matrix-org/synapse/issues/8135)) - Fix a bug where appservices with ratelimiting disabled would still be ratelimited when joining rooms. This bug was introduced in v1.19.0. ([\#8139](https://github.com/matrix-org/synapse/issues/8139)) - Fix logging in via OpenID Connect with a provider that uses integer user IDs. ([\#8190](https://github.com/matrix-org/synapse/issues/8190)) - Fix a longstanding bug where user directory updates could break when unexpected profile data was included in events. ([\#8223](https://github.com/matrix-org/synapse/issues/8223)) - Fix a longstanding bug where stats updates could break when unexpected profile data was included in events. ([\#8226](https://github.com/matrix-org/synapse/issues/8226)) - Fix slow start times for large servers by removing a table scan of the `users` table from startup code. ([\#8271](https://github.com/matrix-org/synapse/issues/8271)) Updates to the Docker image --------------------------- - Fix builds of the Docker image on non-x86 platforms. ([\#8144](https://github.com/matrix-org/synapse/issues/8144)) - Added curl for healthcheck support and readme updates for the change. Contributed by @maquis196. ([\#8147](https://github.com/matrix-org/synapse/issues/8147)) Improved Documentation ---------------------- - Link to matrix-synapse-rest-password-provider in the password provider documentation. ([\#8111](https://github.com/matrix-org/synapse/issues/8111)) - Updated documentation to note that Synapse does not follow `HTTP 308` redirects due to an upstream library not supporting them. Contributed by Ryan Cole. ([\#8120](https://github.com/matrix-org/synapse/issues/8120)) - Explain better what GDPR-erased means when deactivating a user. ([\#8189](https://github.com/matrix-org/synapse/issues/8189)) Internal Changes ---------------- - Add filter `name` to the `/users` admin API, which filters by user ID or displayname. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7377](https://github.com/matrix-org/synapse/issues/7377), [\#8163](https://github.com/matrix-org/synapse/issues/8163)) - Reduce run times of some unit tests by advancing the reactor a fewer number of times. ([\#7757](https://github.com/matrix-org/synapse/issues/7757)) - Don't fail `/submit_token` requests on incorrect session ID if `request_token_inhibit_3pid_errors` is turned on. ([\#7991](https://github.com/matrix-org/synapse/issues/7991)) - Convert various parts of the codebase to async/await. ([\#8071](https://github.com/matrix-org/synapse/issues/8071), [\#8072](https://github.com/matrix-org/synapse/issues/8072), [\#8074](https://github.com/matrix-org/synapse/issues/8074), [\#8075](https://github.com/matrix-org/synapse/issues/8075), [\#8076](https://github.com/matrix-org/synapse/issues/8076), [\#8087](https://github.com/matrix-org/synapse/issues/8087), [\#8100](https://github.com/matrix-org/synapse/issues/8100), [\#8119](https://github.com/matrix-org/synapse/issues/8119), [\#8121](https://github.com/matrix-org/synapse/issues/8121), [\#8133](https://github.com/matrix-org/synapse/issues/8133), [\#8156](https://github.com/matrix-org/synapse/issues/8156), [\#8162](https://github.com/matrix-org/synapse/issues/8162), [\#8166](https://github.com/matrix-org/synapse/issues/8166), [\#8168](https://github.com/matrix-org/synapse/issues/8168), [\#8173](https://github.com/matrix-org/synapse/issues/8173), [\#8191](https://github.com/matrix-org/synapse/issues/8191), [\#8192](https://github.com/matrix-org/synapse/issues/8192), [\#8193](https://github.com/matrix-org/synapse/issues/8193), [\#8194](https://github.com/matrix-org/synapse/issues/8194), [\#8195](https://github.com/matrix-org/synapse/issues/8195), [\#8197](https://github.com/matrix-org/synapse/issues/8197), [\#8199](https://github.com/matrix-org/synapse/issues/8199), [\#8200](https://github.com/matrix-org/synapse/issues/8200), [\#8201](https://github.com/matrix-org/synapse/issues/8201), [\#8202](https://github.com/matrix-org/synapse/issues/8202), [\#8207](https://github.com/matrix-org/synapse/issues/8207), [\#8213](https://github.com/matrix-org/synapse/issues/8213), [\#8214](https://github.com/matrix-org/synapse/issues/8214)) - Remove some unused database functions. ([\#8085](https://github.com/matrix-org/synapse/issues/8085)) - Add type hints to various parts of the codebase. ([\#8090](https://github.com/matrix-org/synapse/issues/8090), [\#8127](https://github.com/matrix-org/synapse/issues/8127), [\#8187](https://github.com/matrix-org/synapse/issues/8187), [\#8241](https://github.com/matrix-org/synapse/issues/8241), [\#8140](https://github.com/matrix-org/synapse/issues/8140), [\#8183](https://github.com/matrix-org/synapse/issues/8183), [\#8232](https://github.com/matrix-org/synapse/issues/8232), [\#8235](https://github.com/matrix-org/synapse/issues/8235), [\#8237](https://github.com/matrix-org/synapse/issues/8237), [\#8244](https://github.com/matrix-org/synapse/issues/8244)) - Return the previous stream token if a non-member event is a duplicate. ([\#8093](https://github.com/matrix-org/synapse/issues/8093), [\#8112](https://github.com/matrix-org/synapse/issues/8112)) - Separate `get_current_token` into two since there are two different use cases for it. ([\#8113](https://github.com/matrix-org/synapse/issues/8113)) - Remove `ChainedIdGenerator`. ([\#8123](https://github.com/matrix-org/synapse/issues/8123)) - Reduce the amount of whitespace in JSON stored and sent in responses. ([\#8124](https://github.com/matrix-org/synapse/issues/8124)) - Update the test federation client to handle streaming responses. ([\#8130](https://github.com/matrix-org/synapse/issues/8130)) - Micro-optimisations to `get_auth_chain_ids`. ([\#8132](https://github.com/matrix-org/synapse/issues/8132)) - Refactor `StreamIdGenerator` and `MultiWriterIdGenerator` to have the same interface. ([\#8161](https://github.com/matrix-org/synapse/issues/8161)) - Add functions to `MultiWriterIdGen` used by events stream. ([\#8164](https://github.com/matrix-org/synapse/issues/8164), [\#8179](https://github.com/matrix-org/synapse/issues/8179)) - Fix tests that were broken due to the merge of 1.19.1. ([\#8167](https://github.com/matrix-org/synapse/issues/8167)) - Make `SlavedIdTracker.advance` have the same interface as `MultiWriterIDGenerator`. ([\#8171](https://github.com/matrix-org/synapse/issues/8171)) - Remove unused `is_guest` parameter from, and add safeguard to, `MessageHandler.get_room_data`. ([\#8174](https://github.com/matrix-org/synapse/issues/8174), [\#8181](https://github.com/matrix-org/synapse/issues/8181)) - Standardize the mypy configuration. ([\#8175](https://github.com/matrix-org/synapse/issues/8175)) - Refactor some of `LoginRestServlet`'s helper methods, and move them to `AuthHandler` for easier reuse. ([\#8182](https://github.com/matrix-org/synapse/issues/8182)) - Fix `wait_for_stream_position` to allow multiple waiters on same stream ID. ([\#8196](https://github.com/matrix-org/synapse/issues/8196)) - Make `MultiWriterIDGenerator` work for streams that use negative values. ([\#8203](https://github.com/matrix-org/synapse/issues/8203)) - Refactor queries for device keys and cross-signatures. ([\#8204](https://github.com/matrix-org/synapse/issues/8204), [\#8205](https://github.com/matrix-org/synapse/issues/8205), [\#8222](https://github.com/matrix-org/synapse/issues/8222), [\#8224](https://github.com/matrix-org/synapse/issues/8224), [\#8225](https://github.com/matrix-org/synapse/issues/8225), [\#8231](https://github.com/matrix-org/synapse/issues/8231), [\#8233](https://github.com/matrix-org/synapse/issues/8233), [\#8234](https://github.com/matrix-org/synapse/issues/8234)) - Fix type hints for functions decorated with `@cached`. ([\#8240](https://github.com/matrix-org/synapse/issues/8240)) - Remove obsolete `order` field from federation send queues. ([\#8245](https://github.com/matrix-org/synapse/issues/8245)) - Stop sub-classing from object. ([\#8249](https://github.com/matrix-org/synapse/issues/8249)) - Add more logging to debug slow startup. ([\#8264](https://github.com/matrix-org/synapse/issues/8264)) - Do not attempt to upgrade database schema on worker processes. ([\#8266](https://github.com/matrix-org/synapse/issues/8266), [\#8276](https://github.com/matrix-org/synapse/issues/8276)) -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEv27Axt/F4vrTL/8QOSor00I9eP8FAl9XgG0ACgkQOSor00I9 eP9k9gf8DqxUoYYGGvKrUC0NW5XLLE6qiLI+a+3QqsnWvvAjCzJOPH5xsFWl0YkR phUmz0KyuIvYokr6RYEG37l7U0hWQKck1/LrgBDOtEWTO+n/bacxNawhJyFOXATc AZgnCVyhklALUre43QzwlFL1cGQnIBuAHuHa+etj5AO+9eC/QPuJBMryzUVH8dGY 37B2lLTv4ULpSsQ+neQULSyu1EOEyurxNY/RydYaC8bgrOCQgkWPbssQX6MSdHWz ua+GZ36KAQT6jUmjuTqJXbRKtewjN2anmTb5LrHz1W5GATOY7hH3xsnwHd1oikwW 56vhm1tJZExkWvqfB9XteJcIEZ0epQ== =JecA -----END PGP SIGNATURE----- Merge tag 'v1.20.0rc1' into develop Synapse 1.20.0rc1 (2020-09-08) ============================== Removal warning --------------- Some older clients used a [disallowed character](https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-register-email-requesttoken) (`:`) in the `client_secret` parameter of various endpoints. The incorrect behaviour was allowed for backwards compatibility, but is now being removed from Synapse as most users have updated their client. Further context can be found at [\#6766](https://github.com/matrix-org/synapse/issues/6766). Features -------- - Add an endpoint to query your shared rooms with another user as an implementation of [MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666). ([\#7785](https://github.com/matrix-org/synapse/issues/7785)) - Iteratively encode JSON to avoid blocking the reactor. ([\#8013](https://github.com/matrix-org/synapse/issues/8013), [\#8116](https://github.com/matrix-org/synapse/issues/8116)) - Add support for shadow-banning users (ignoring any message send requests). ([\#8034](https://github.com/matrix-org/synapse/issues/8034), [\#8092](https://github.com/matrix-org/synapse/issues/8092), [\#8095](https://github.com/matrix-org/synapse/issues/8095), [\#8142](https://github.com/matrix-org/synapse/issues/8142), [\#8152](https://github.com/matrix-org/synapse/issues/8152), [\#8157](https://github.com/matrix-org/synapse/issues/8157), [\#8158](https://github.com/matrix-org/synapse/issues/8158), [\#8176](https://github.com/matrix-org/synapse/issues/8176)) - Use the default template file when its equivalent is not found in a custom template directory. ([\#8037](https://github.com/matrix-org/synapse/issues/8037), [\#8107](https://github.com/matrix-org/synapse/issues/8107), [\#8252](https://github.com/matrix-org/synapse/issues/8252)) - Add unread messages count to sync responses, as specified in [MSC2654](https://github.com/matrix-org/matrix-doc/pull/2654). ([\#8059](https://github.com/matrix-org/synapse/issues/8059), [\#8254](https://github.com/matrix-org/synapse/issues/8254), [\#8270](https://github.com/matrix-org/synapse/issues/8270), [\#8274](https://github.com/matrix-org/synapse/issues/8274)) - Optimise `/federation/v1/user/devices/` API by only returning devices with encryption keys. ([\#8198](https://github.com/matrix-org/synapse/issues/8198)) Bugfixes -------- - Fix a memory leak by limiting the length of time that messages will be queued for a remote server that has been unreachable. ([\#7864](https://github.com/matrix-org/synapse/issues/7864)) - Fix `Re-starting finished log context PUT-nnnn` warning when event persistence failed. ([\#8081](https://github.com/matrix-org/synapse/issues/8081)) - Synapse now correctly enforces the valid characters in the `client_secret` parameter used in various endpoints. ([\#8101](https://github.com/matrix-org/synapse/issues/8101)) - Fix a bug introduced in v1.7.2 impacting message retention policies that would allow federated homeservers to dictate a retention period that's lower than the configured minimum allowed duration in the configuration file. ([\#8104](https://github.com/matrix-org/synapse/issues/8104)) - Fix a long-standing bug where invalid JSON would be accepted by Synapse. ([\#8106](https://github.com/matrix-org/synapse/issues/8106)) - Fix a bug introduced in Synapse v1.12.0 which could cause `/sync` requests to fail with a 404 if you had a very old outstanding room invite. ([\#8110](https://github.com/matrix-org/synapse/issues/8110)) - Return a proper error code when the rooms of an invalid group are requested. ([\#8129](https://github.com/matrix-org/synapse/issues/8129)) - Fix a bug which could cause a leaked postgres connection if synapse was set to daemonize. ([\#8131](https://github.com/matrix-org/synapse/issues/8131)) - Clarify the error code if a user tries to register with a numeric ID. This bug was introduced in v1.15.0. ([\#8135](https://github.com/matrix-org/synapse/issues/8135)) - Fix a bug where appservices with ratelimiting disabled would still be ratelimited when joining rooms. This bug was introduced in v1.19.0. ([\#8139](https://github.com/matrix-org/synapse/issues/8139)) - Fix logging in via OpenID Connect with a provider that uses integer user IDs. ([\#8190](https://github.com/matrix-org/synapse/issues/8190)) - Fix a longstanding bug where user directory updates could break when unexpected profile data was included in events. ([\#8223](https://github.com/matrix-org/synapse/issues/8223)) - Fix a longstanding bug where stats updates could break when unexpected profile data was included in events. ([\#8226](https://github.com/matrix-org/synapse/issues/8226)) - Fix slow start times for large servers by removing a table scan of the `users` table from startup code. ([\#8271](https://github.com/matrix-org/synapse/issues/8271)) Updates to the Docker image --------------------------- - Fix builds of the Docker image on non-x86 platforms. ([\#8144](https://github.com/matrix-org/synapse/issues/8144)) - Added curl for healthcheck support and readme updates for the change. Contributed by @maquis196. ([\#8147](https://github.com/matrix-org/synapse/issues/8147)) Improved Documentation ---------------------- - Link to matrix-synapse-rest-password-provider in the password provider documentation. ([\#8111](https://github.com/matrix-org/synapse/issues/8111)) - Updated documentation to note that Synapse does not follow `HTTP 308` redirects due to an upstream library not supporting them. Contributed by Ryan Cole. ([\#8120](https://github.com/matrix-org/synapse/issues/8120)) - Explain better what GDPR-erased means when deactivating a user. ([\#8189](https://github.com/matrix-org/synapse/issues/8189)) Internal Changes ---------------- - Add filter `name` to the `/users` admin API, which filters by user ID or displayname. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7377](https://github.com/matrix-org/synapse/issues/7377), [\#8163](https://github.com/matrix-org/synapse/issues/8163)) - Reduce run times of some unit tests by advancing the reactor a fewer number of times. ([\#7757](https://github.com/matrix-org/synapse/issues/7757)) - Don't fail `/submit_token` requests on incorrect session ID if `request_token_inhibit_3pid_errors` is turned on. ([\#7991](https://github.com/matrix-org/synapse/issues/7991)) - Convert various parts of the codebase to async/await. ([\#8071](https://github.com/matrix-org/synapse/issues/8071), [\#8072](https://github.com/matrix-org/synapse/issues/8072), [\#8074](https://github.com/matrix-org/synapse/issues/8074), [\#8075](https://github.com/matrix-org/synapse/issues/8075), [\#8076](https://github.com/matrix-org/synapse/issues/8076), [\#8087](https://github.com/matrix-org/synapse/issues/8087), [\#8100](https://github.com/matrix-org/synapse/issues/8100), [\#8119](https://github.com/matrix-org/synapse/issues/8119), [\#8121](https://github.com/matrix-org/synapse/issues/8121), [\#8133](https://github.com/matrix-org/synapse/issues/8133), [\#8156](https://github.com/matrix-org/synapse/issues/8156), [\#8162](https://github.com/matrix-org/synapse/issues/8162), [\#8166](https://github.com/matrix-org/synapse/issues/8166), [\#8168](https://github.com/matrix-org/synapse/issues/8168), [\#8173](https://github.com/matrix-org/synapse/issues/8173), [\#8191](https://github.com/matrix-org/synapse/issues/8191), [\#8192](https://github.com/matrix-org/synapse/issues/8192), [\#8193](https://github.com/matrix-org/synapse/issues/8193), [\#8194](https://github.com/matrix-org/synapse/issues/8194), [\#8195](https://github.com/matrix-org/synapse/issues/8195), [\#8197](https://github.com/matrix-org/synapse/issues/8197), [\#8199](https://github.com/matrix-org/synapse/issues/8199), [\#8200](https://github.com/matrix-org/synapse/issues/8200), [\#8201](https://github.com/matrix-org/synapse/issues/8201), [\#8202](https://github.com/matrix-org/synapse/issues/8202), [\#8207](https://github.com/matrix-org/synapse/issues/8207), [\#8213](https://github.com/matrix-org/synapse/issues/8213), [\#8214](https://github.com/matrix-org/synapse/issues/8214)) - Remove some unused database functions. ([\#8085](https://github.com/matrix-org/synapse/issues/8085)) - Add type hints to various parts of the codebase. ([\#8090](https://github.com/matrix-org/synapse/issues/8090), [\#8127](https://github.com/matrix-org/synapse/issues/8127), [\#8187](https://github.com/matrix-org/synapse/issues/8187), [\#8241](https://github.com/matrix-org/synapse/issues/8241), [\#8140](https://github.com/matrix-org/synapse/issues/8140), [\#8183](https://github.com/matrix-org/synapse/issues/8183), [\#8232](https://github.com/matrix-org/synapse/issues/8232), [\#8235](https://github.com/matrix-org/synapse/issues/8235), [\#8237](https://github.com/matrix-org/synapse/issues/8237), [\#8244](https://github.com/matrix-org/synapse/issues/8244)) - Return the previous stream token if a non-member event is a duplicate. ([\#8093](https://github.com/matrix-org/synapse/issues/8093), [\#8112](https://github.com/matrix-org/synapse/issues/8112)) - Separate `get_current_token` into two since there are two different use cases for it. ([\#8113](https://github.com/matrix-org/synapse/issues/8113)) - Remove `ChainedIdGenerator`. ([\#8123](https://github.com/matrix-org/synapse/issues/8123)) - Reduce the amount of whitespace in JSON stored and sent in responses. ([\#8124](https://github.com/matrix-org/synapse/issues/8124)) - Update the test federation client to handle streaming responses. ([\#8130](https://github.com/matrix-org/synapse/issues/8130)) - Micro-optimisations to `get_auth_chain_ids`. ([\#8132](https://github.com/matrix-org/synapse/issues/8132)) - Refactor `StreamIdGenerator` and `MultiWriterIdGenerator` to have the same interface. ([\#8161](https://github.com/matrix-org/synapse/issues/8161)) - Add functions to `MultiWriterIdGen` used by events stream. ([\#8164](https://github.com/matrix-org/synapse/issues/8164), [\#8179](https://github.com/matrix-org/synapse/issues/8179)) - Fix tests that were broken due to the merge of 1.19.1. ([\#8167](https://github.com/matrix-org/synapse/issues/8167)) - Make `SlavedIdTracker.advance` have the same interface as `MultiWriterIDGenerator`. ([\#8171](https://github.com/matrix-org/synapse/issues/8171)) - Remove unused `is_guest` parameter from, and add safeguard to, `MessageHandler.get_room_data`. ([\#8174](https://github.com/matrix-org/synapse/issues/8174), [\#8181](https://github.com/matrix-org/synapse/issues/8181)) - Standardize the mypy configuration. ([\#8175](https://github.com/matrix-org/synapse/issues/8175)) - Refactor some of `LoginRestServlet`'s helper methods, and move them to `AuthHandler` for easier reuse. ([\#8182](https://github.com/matrix-org/synapse/issues/8182)) - Fix `wait_for_stream_position` to allow multiple waiters on same stream ID. ([\#8196](https://github.com/matrix-org/synapse/issues/8196)) - Make `MultiWriterIDGenerator` work for streams that use negative values. ([\#8203](https://github.com/matrix-org/synapse/issues/8203)) - Refactor queries for device keys and cross-signatures. ([\#8204](https://github.com/matrix-org/synapse/issues/8204), [\#8205](https://github.com/matrix-org/synapse/issues/8205), [\#8222](https://github.com/matrix-org/synapse/issues/8222), [\#8224](https://github.com/matrix-org/synapse/issues/8224), [\#8225](https://github.com/matrix-org/synapse/issues/8225), [\#8231](https://github.com/matrix-org/synapse/issues/8231), [\#8233](https://github.com/matrix-org/synapse/issues/8233), [\#8234](https://github.com/matrix-org/synapse/issues/8234)) - Fix type hints for functions decorated with `@cached`. ([\#8240](https://github.com/matrix-org/synapse/issues/8240)) - Remove obsolete `order` field from federation send queues. ([\#8245](https://github.com/matrix-org/synapse/issues/8245)) - Stop sub-classing from object. ([\#8249](https://github.com/matrix-org/synapse/issues/8249)) - Add more logging to debug slow startup. ([\#8264](https://github.com/matrix-org/synapse/issues/8264)) - Do not attempt to upgrade database schema on worker processes. ([\#8266](https://github.com/matrix-org/synapse/issues/8266), [\#8276](https://github.com/matrix-org/synapse/issues/8276))	2020-09-08 14:04:20 +01:00
Richard van der Hoff	525efab612	1.20.0rc1	2020-09-08 12:58:37 +01:00
Patrick Cloke	72bec36d50	Directly import json from the standard library. (#8259 ) By importing from canonicaljson the simplejson module was still being used in some situations. After this change the std lib json is consistenty used throughout Synapse.	2020-09-08 07:33:48 -04:00
Patrick Cloke	cef00211c8	Allow for make_awaitable's return value to be re-used. (#8261 )	2020-09-08 07:26:55 -04:00
Andrew Morgan	68cdb3708e	Rename 'populate_stats_process_rooms_2' background job back to 'populate_stats_process_rooms' again (#8243 ) Fixes https://github.com/matrix-org/synapse/issues/8238 Alongside the delta file, some changes were also necessary to the codebase to remove references to the now defunct `populate_stats_process_rooms_2` background job. Thankfully the latter doesn't seem to have made it into any documentation yet :)	2020-09-08 11:05:59 +01:00
Richard van der Hoff	ad28030c12	Systemd docs: configure workers to start after main process. (#8276 )	2020-09-08 10:57:43 +01:00
Richard van der Hoff	8d6f97f932	Merge remote-tracking branch 'origin/release-v1.20.0' into develop	2020-09-08 09:58:07 +01:00
Brendan Abolivier	d8762cc116	Only add rows to the push actions table if the event notifies or should be marked unread (#8274 )	2020-09-07 16:56:27 +01:00
Richard van der Hoff	77794ebc77	Fix stack overflow when logging system encounters an error (#8268 )	2020-09-07 16:54:30 +01:00
Richard van der Hoff	ef2804d27c	Avoid table-scanning users at startup (#8271 ) This takes about 10 seconds in the best case; often more.	2020-09-07 16:48:52 +01:00
Brendan Abolivier	a55e2707d7	Fix unread count failing on NULL values (#8270 ) Fix unread counts making sync fail if the value of the `unread_count` column in `event_push_summary` is `None`.	2020-09-07 15:15:06 +01:00
Richard van der Hoff	0dae7d80bf	Add more logging to debug slow startup (#8264 ) I'm hoping this will provide some pointers for debugging https://github.com/matrix-org/synapse/issues/7968.	2020-09-07 13:36:02 +01:00
Richard van der Hoff	96312536f2	Refuse to upgrade database on worker processes (#8266 )	2020-09-07 13:04:10 +01:00
Alexandre Morignot	7586fdf1e8	Bump canonicaljson to version 1.4.0 (#8262 ) The version 1.3.0 has a bug with unicode charecters: ``` >>> from canonicaljson import encode_pretty_printed_json >>> encode_pretty_printed_json({'a': 'à'}) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/erdnaxeli/.pyenv/versions/3.6.7/lib/python3.6/site-packages/canonicaljson.py", line 96, in encode_pretty_printed_json return _pretty_encoder.encode(json_object).encode("ascii") UnicodeEncodeError: 'ascii' codec can't encode character '\xe0' in position 12: ordinal not in range(128) ``` Signed-off-by: Alexandre Morignot <erdnaxeli@cervoi.se> Co-authored-by: Alexandre Morignot <erdnaxeli@cervoi.se>	2020-09-07 12:21:38 +01:00
Richard van der Hoff	5b452df23b	Run database updates in a transaction (#8265 ) Fixes: #6467	2020-09-07 11:41:50 +01:00
reivilibre	765437df54	Add tests for `last_successful_stream_ordering` (#8258 )	2020-09-07 10:11:38 +01:00
Richard van der Hoff	77b4711bc2	Merge branch 'release-v1.20.0' into develop	2020-09-06 23:32:28 +01:00
reivilibre	7513006b09	In light of #8255 , use BIGINTs for destination_rooms (#8256 )	2020-09-04 15:07:29 +01:00
reivilibre	17fa4c7ca7	Catch up after Federation Outage (split, 2): Track last successful stream ordering after transmission (#8247 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2020-09-04 15:06:51 +01:00
Richard van der Hoff	f25af1f9c7	Add cross-signing sigs to the `keys` object (#8234 ) All the callers want this info in the same place, so let's reduce the duplication by doing it here.	2020-09-04 15:06:05 +01:00
Brendan Abolivier	041ee971c9	Unread counts fixes (#8254 ) * Fixup `ALTER TABLE` database queries Make the new columns nullable, because doing otherwise can wedge a server with a big database, as setting a default value rewrites the table. * Switch back to using the notifications count in the push badge Clients are likely to be confused if we send a push but the badge count is the unread messages one, and not the notifications one. * Changelog	2020-09-04 14:14:22 +01:00
Patrick Cloke	db7de4d182	Fix a regression from calling read_templates. (#8252 ) Regressed in #8037.	2020-09-04 09:10:33 -04:00
reivilibre	58f61f10f7	Catch-up after Federation Outage (split, 1) (#8230 ) Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>	2020-09-04 12:22:23 +01:00
reivilibre	e351298444	Fix type signature in simple_select_one_onecol and friends (#8241 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2020-09-04 12:02:29 +01:00
Patrick Cloke	c619253db8	Stop sub-classing object (#8249 )	2020-09-04 06:54:56 -04:00
Brendan Abolivier	9f8abdcc38	Revert "Add experimental support for sharding event persister. (#8170 )" (#8242 ) * Revert "Add experimental support for sharding event persister. (#8170)" This reverts commit `82c1ee1c22`. * Changelog	2020-09-04 10:19:42 +01:00
Erik Johnston	be16ee59a8	Add type hints to more handlers (#8244 )	2020-09-03 22:02:29 +01:00
reivilibre	4535e849d7	Remove obsolete order field in `send_new_transaction` (#8245 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2020-09-03 19:23:07 +01:00
Richard van der Hoff	f97f9485ee	Split fetching device keys and signatures into two transactions (#8233 ) I think this is simpler (and moves stuff out of the db threads)	2020-09-03 18:27:26 +01:00
Erik Johnston	208e1d3eb3	Fix typing for `@cached` wrapped functions (#8240 ) This requires adding a mypy plugin to fiddle with the type signatures a bit.	2020-09-03 15:38:32 +01:00
Patrick Cloke	15c35c250c	Remove useless changelog about reverting a #8239 .	2020-09-03 09:47:41 -04:00
Patrick Cloke	2aa127c207	Revert pinning of setuptools (#8239 )	2020-09-03 09:45:36 -04:00
Erik Johnston	5bfc79486d	Fix typing for SyncHandler (#8237 )	2020-09-03 12:54:10 +01:00
Richard van der Hoff	6f6f371a87	wrap `_get_e2e_device_keys_and_signatures_txn` in a non-txn method (#8231 ) We have three things which all call `_get_e2e_device_keys_and_signatures_txn` with their own `runInteraction`. Factor out the common code.	2020-09-03 11:50:49 +01:00
Patrick Cloke	c8758cb72f	Add an overload for simple_select_one_onecol_txn. (#8235 )	2020-09-02 15:03:12 -04:00
Patrick Cloke	912e024913	Convert runInteraction to async/await (#8156 )	2020-09-02 13:11:02 -04:00
Erik Johnston	112266eafd	Add StreamStore to mypy (#8232 )	2020-09-02 17:52:38 +01:00
Brendan Abolivier	5a1dd297c3	Re-implement unread counts (again) (#8059 )	2020-09-02 17:19:37 +01:00
Richard van der Hoff	0d4f614fda	Refactor `_get_e2e_device_keys_for_federation_query_txn` (#8225 ) We can use the existing `_get_e2e_device_keys_and_signatures_txn` instead of creating our own txn function	2020-09-02 15:53:26 +01:00
Erik Johnston	82c1ee1c22	Add experimental support for sharding event persister. (#8170 ) This is not ready for production yet. Caveats: 1. We should write some tests... 2. The stream token that we use for events can get stalled at the minimum position of all writers. This means that new events may not be processed and e.g. sent down sync streams if a writer isn't writing or is slow.	2020-09-02 15:48:37 +01:00
Will Hunt	b257c788c0	Add /user/{user_id}/shared_rooms/ api (#7785 ) * Add shared_rooms api * Add changelog * Add . * Wrap response in {"rooms": } * linting * Add unstable_features key * Remove options from isort that aren't part of 5.x `-y` and `-rc` are now default behaviour and no longer exist. `dont-skip` is no longer required https://timothycrosley.github.io/isort/CHANGELOG/#500-penny-july-4-2020 * Update imports to make isort happy * Add changelog * Update tox.ini file with correct invocation * fix linting again for isort * Vendor prefix unstable API * Fix to match spec * import Codes * import Codes * Use FORBIDDEN * Update changelog.d/7785.feature Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Implement get_shared_rooms_for_users * a comma * trailing whitespace * Handle the easy feedback * Switch to using runInteraction * Add tests * Feedback * Seperate unstable endpoint from v2 * Add upgrade node * a line * Fix style by adding a blank line at EOF. * Update synapse/storage/databases/main/user_directory.py Co-authored-by: Tulir Asokan <tulir@maunium.net> * Update synapse/storage/databases/main/user_directory.py Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Update UPGRADE.rst Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Fix UPGRADE/CHANGELOG unstable paths unstable unstable unstable Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Tulir Asokan <tulir@maunium.net> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Tulir Asokan <tulir@maunium.net>	2020-09-02 13:18:40 +01:00
Patrick Cloke	9356656e67	Do not try to store invalid data in the stats table (#8226 )	2020-09-02 07:59:39 -04:00
Patrick Cloke	d250521cf5	Convert the main methods run by the reactor to async. (#8213 )	2020-09-02 07:44:50 -04:00
Richard van der Hoff	abeab964d5	Make _get_e2e_device_keys_and_signatures_txn return an attrs (#8224 ) this makes it a bit clearer what's going on.	2020-09-02 11:47:26 +01:00
Patrick Cloke	b939251c37	Fix errors when updating the user directory with invalid data (#8223 )	2020-09-01 13:02:41 -04:00
Brendan Abolivier	b5133dd97f	Explain better what GDPR-erased means (#8189 ) Fixes https://github.com/matrix-org/synapse/issues/8185	2020-09-01 16:31:59 +01:00
Patrick Cloke	37db6252b7	Convert additional databases to async/await part 3 (#8201 )	2020-09-01 11:04:17 -04:00
Patrick Cloke	7d103a594e	Convert appservice code to async/await. (#8207 )	2020-09-01 11:03:49 -04:00
Richard van der Hoff	5615eb5cb4	Rename `_get_e2e_device_keys_txn` (#8222 ) ... to `_get_e2e_device_keys_and_signatures_txn`, to better reflect what it does.	2020-09-01 16:02:17 +01:00
Patrick Cloke	54f8d73c00	Convert additional databases to async/await (#8199 )	2020-09-01 09:21:48 -04:00
Patrick Cloke	5bf8e5f55b	Convert the well known resolver to async (#8214 )	2020-09-01 09:15:22 -04:00
Patrick Cloke	da77520cd1	Convert additional databases to async/await part 2 (#8200 )	2020-09-01 08:39:04 -04:00
Erik Johnston	bbb3c8641c	Make MultiWriterIDGenerator work for streams that use negative stream IDs (#8203 ) This is so that we can use it for the backfill events stream.	2020-09-01 13:36:25 +01:00
Patrick Cloke	318245eaa6	Do not install setuptools 50.0. (#8212 ) This is due to compatibility issues with old Python versions.	2020-09-01 08:16:58 -04:00
Richard van der Hoff	aa07c37cf0	Move and rename `get_devices_with_keys_by_user` (#8204 ) * Move `get_devices_with_keys_by_user` to `EndToEndKeyWorkerStore` this seems a better fit for it. This commit simply moves the existing code: no other changes at all. * Rename `get_devices_with_keys_by_user` to better reflect what it does. * get_device_stream_token abstract method To avoid referencing fields which are declared in the derived classes, make `get_device_stream_token` abstract, and define that in the classes which define `_device_list_id_gen`.	2020-09-01 12:41:21 +01:00
Richard van der Hoff	45e8f7726f	Rename `get_e2e_device_keys` to better reflect its purpose (#8205 ) ... and to show that it does something slightly different to `_get_e2e_device_keys_txn`. `include_all_devices` and `include_deleted_devices` were never used (and `include_deleted_devices` was broken, since that would cause `None`s in the result which were not handled in the loop below. Add some typing too.	2020-08-29 00:14:17 +01:00
Patrick Cloke	d2ac767de2	Convert ReadWriteLock to async/await. (#8202 )	2020-08-28 16:47:11 -04:00
Erik Johnston	3b4556cf87	Fix `wait_for_stream_position` for multiple waiters. (#8196 ) This fixes a bug where having multiple callers waiting on the same stream and position will cause it to try and compare two deferreds, which fails (due to the sorted list having an entry of `Tuple[int, Deferred]`).	2020-08-28 17:12:45 +01:00
Patrick Cloke	d58fda99ff	Convert `event_push_actions`, `registration`, and `roommember` datastores to async (#8197 )	2020-08-28 11:34:50 -04:00
Richard van der Hoff	22b926c284	Only return devices with keys from `/federation/v1/user/devices/` (#8198 ) There's not much point in returning all the others, and some people have a silly number of devices.	2020-08-28 15:59:28 +01:00
Patrick Cloke	aec7085179	Convert state and stream stores and related code to async (#8194 )	2020-08-28 09:37:55 -04:00
Patrick Cloke	b055dc9322	Ensure that the OpenID Connect remote ID is a string. (#8190 )	2020-08-28 08:56:36 -04:00
Patrick Cloke	5c03134d0f	Convert additional database code to async/await. (#8195 )	2020-08-28 07:54:27 -04:00
Patrick Cloke	d5e73cb6aa	Define StateMap as immutable and add a MutableStateMap type. (#8183 )	2020-08-28 07:28:53 -04:00
Andrew Morgan	2c2e649be2	Move and refactor LoginRestServlet helper methods (#8182 ) This is split out from https://github.com/matrix-org/synapse/pull/7438, which had gotten rather large. `LoginRestServlet` has a couple helper methods, `login_submission_legacy_convert` and `login_id_thirdparty_from_phone`. They're primarily used for converting legacy user login submissions to "identifier" dicts ([see spec](https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-login)). Identifying information such as usernames or 3PID information used to be top-level in the login body. They're now supposed to be put inside an [identifier](https://matrix.org/docs/spec/client_server/r0.6.1#identifier-types) parameter instead. #7438's purpose is to allow using the new identifier parameter during User-Interactive Authentication, which is currently handled in AuthHandler. That's why I've moved these helper methods there. I also moved the refactoring of these method from #7438 as they're relevant.	2020-08-28 09:58:17 +01:00
Patrick Cloke	e00816ad98	Do not yield on awaitables in tests. (#8193 )	2020-08-27 17:24:46 -04:00
Patrick Cloke	b49a5b9307	Convert stats and related calls to async/await (#8192 )	2020-08-27 17:24:37 -04:00
Patrick Cloke	b71d4a094c	Convert simple_delete to async/await. (#8191 )	2020-08-27 14:16:41 -04:00
Patrick Cloke	9b7ac03af3	Convert calls of async database methods to async (#8166 )	2020-08-27 13:38:41 -04:00
Patrick Cloke	c9fa696ea2	simple_search_list_txn should return None, not 0. (#8187 )	2020-08-27 12:07:13 -04:00
Erik Johnston	5649b7f3d0	Fix missing _add_persisted_position (#8179 ) This was forgotten in #8164.	2020-08-27 13:20:34 +01:00
Patrick Cloke	30426c7063	Convert additional database methods to async (select list, search, insert_many, delete_*) (#8168 )	2020-08-27 07:41:01 -04:00
Patrick Cloke	4a739c73b4	Convert simple_update* and simple_select* to async (#8173 )	2020-08-27 07:08:38 -04:00
Andrew Morgan	a466b67972	Reduce run-times of tests by advancing the reactor less (#7757 )	2020-08-27 11:39:53 +01:00
Andrew Morgan	b8f20e4276	Remove remaining is_guest argument uses from get_room_data calls (#8181 ) #8174 removed the `is_guest` parameter from `get_room_data`, at the same time that #8157 was merged using it, colliding together to break unit tests on develop. This PR removes the `is_guest` parameter from the call in the broken test. Uses the same changelog as #8174.	2020-08-26 17:26:56 +01:00
Patrick Cloke	6fe12c9512	Do not propagate typing notifications from shadow-banned users. (#8176 )	2020-08-26 12:05:36 -04:00
Andrew Morgan	e0d6244beb	Remove unused parameter from, and add safeguard in, get_room_data (#8174 ) Small cleanup PR. * Removed the unused `is_guest` argument * Added a safeguard to a (currently) impossible code path, fixing static checking at the same time.	2020-08-26 15:07:35 +01:00
Christopher May-Townsend	ed18f32e1b	Add required Debian dependencies to allow docker builds on the arm platform (#8144 ) Signed-off-by: Christopher May-Townsend <chris@maytownsend.co.uk>	2020-08-26 15:03:20 +01:00
Patrick Cloke	98125bba7a	Allow running mypy directly. (#8175 )	2020-08-26 09:59:37 -04:00
Richard van der Hoff	88b9807ba4	Update the test federation client to handle streaming responses (#8130 ) Now that the server supports streaming back JSON responses, it would be nice to show the response as it is streamed, in the test tool.	2020-08-26 14:11:38 +01:00
Patrick Cloke	2e6c90ff84	Do not propagate profile changes of shadow-banned users into rooms. (#8157 )	2020-08-26 08:49:01 -04:00
Erik Johnston	e3c91a3c55	Make SlavedIdTracker.advance have same interface as MultiWriterIDGenerator (#8171 )	2020-08-26 13:15:20 +01:00
Patrick Cloke	4c6c56dc58	Convert simple_select_one and simple_select_one_onecol to async (#8162 )	2020-08-26 07:19:32 -04:00
Patrick Cloke	56efa9ec71	Fix rate limiting unit tests. (#8167 ) These were passing on the release-v1.19.1 branch but started failing once merged to develop.	2020-08-26 07:19:20 -04:00
Erik Johnston	eba98fb024	Add functions to `MultiWriterIdGen` used by events stream (#8164 )	2020-08-25 17:32:30 +01:00
Patrick Cloke	5099bd68da	Do not allow send_nonmember_event to be called with shadow-banned users. (#8158 )	2020-08-25 10:52:15 -04:00
Brendan Abolivier	b79d69796c	1.19.1rc1	2020-08-25 15:24:39 +01:00
Erik Johnston	2231dffee6	Make StreamIdGen `get_next` and `get_next_mult` async (#8161 ) This is mainly so that `StreamIdGenerator` and `MultiWriterIdGenerator` will have the same interface, allowing them to be used interchangeably.	2020-08-25 15:10:08 +01:00
Andrew Morgan	74bf8d4d06	Wording fixes to 'name' user admin api filter (#8163 ) Some fixes to wording I noticed after merging #7377.	2020-08-25 15:03:24 +01:00
Manuel Stahl	97962ad17b	Search in columns 'name' and 'displayname' in the admin users endpoint (#7377 ) * Search in columns 'name' and 'displayname' in the admin users endpoint Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>	2020-08-25 14:18:14 +01:00
Patrick Cloke	5758dcf30c	Add type hints for state. (#8140 )	2020-08-24 14:25:27 -04:00
Patrick Cloke	cbd8d83da7	Stop shadow-banned users from sending non-member events. (#8142 )	2020-08-24 13:58:56 -04:00
Brendan Abolivier	420484a334	Allow capping a room's retention policy (#8104 )	2020-08-24 18:21:04 +01:00
Christopher May-Townsend	64e8a4697a	Add healthcheck for default localhost 8008 port on /health endpoint. (#8147 )	2020-08-24 18:15:18 +01:00
Patrick Cloke	3f8f96be00	Fix flaky shadow-ban tests. (#8152 )	2020-08-24 13:08:33 -04:00
Brendan Abolivier	393a811a41	Fix join ratelimiter breaking profile updates and idempotency (#8153 )	2020-08-24 18:06:04 +01:00
Will Hunt	2df82ae451	Do not apply ratelimiting on joins to appservices (#8139 ) Add new method ratelimiter.can_requester_do_action and ensure that appservices are exempt from being ratelimited. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>	2020-08-24 14:53:53 +01:00
Brendan Abolivier	3f49f74610	Don't fail /submit_token requests on incorrect session ID if request_token_inhibit_3pid_errors is turned on (#7991 ) * Don't raise session_id errors on submit_token if request_token_inhibit_3pid_errors is set * Changelog * Also wait some time before responding to /requestToken * Incorporate review * Update synapse/storage/databases/main/registration.py Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Incorporate review Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2020-08-24 11:33:55 +01:00
Will Hunt	cbbf9126cb	Do not apply ratelimiting on joins to appservices (#8139 ) Add new method ratelimiter.can_requester_do_action and ensure that appservices are exempt from being ratelimited. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>	2020-08-21 15:07:56 +01:00
Richard van der Hoff	09fd0eda81	Micro-optimisations to get_auth_chain_ids (#8132 )	2020-08-21 10:06:45 +01:00
Patrick Cloke	3f91638da6	Allow denying or shadow banning registrations via the spam checker (#8034 )	2020-08-20 15:42:58 -04:00
Patrick Cloke	e259d63f73	Stop shadow-banned users from sending invites. (#8095 )	2020-08-20 15:07:42 -04:00
Richard van der Hoff	318f4e738e	Be more tolerant of membership events in unknown rooms (#8110 ) It turns out that not all out-of-band membership events are labelled as such, so we need to be more accepting here.	2020-08-20 16:42:12 +01:00
Patrick Cloke	592cdf73be	Improve the error code when trying to register using a name reserved for guests. (#8135 )	2020-08-20 10:39:41 -04:00
Patrick Cloke	dbc630a628	Use the JSON encoder without whitespace in more places. (#8124 )	2020-08-20 10:32:33 -04:00
Patrick Cloke	5eac0b7e76	Add more types to synapse.storage.database. (#8127 )	2020-08-20 09:00:59 -04:00
Patrick Cloke	731dfff347	Ensure a group ID is valid before trying to get rooms for it. (#8129 )	2020-08-20 06:41:32 -04:00
Patrick Cloke	76c43f086a	Do not assume calls to runInteraction return Deferreds. (#8133 )	2020-08-20 06:39:55 -04:00
Richard van der Hoff	12aebdfa5a	Close the database connection we create during startup (#8131 ) ... otherwise it gets leaked.	2020-08-19 20:41:53 +01:00
Erik Johnston	c9c544cda5	Remove `ChainedIdGenerator`. (#8123 ) It's just a thin wrapper around two ID gens to make `get_current_token` and `get_next` return tuples. This can easily be replaced by calling the appropriate methods on the underlying ID gens directly.	2020-08-19 13:41:51 +01:00
Patrick Cloke	f594e434c3	Switch the JSON byte producer from a pull to a push producer. (#8116 )	2020-08-19 08:07:57 -04:00
Ryan Cole	cfeb37f039	Updated docs: Added note about missing 308 redirect support. (#8120 ) * Updated docs: Added note about missing 308 redirect support. * Added changelog	2020-08-19 12:26:50 +01:00
Patrick Cloke	eebf52be06	Be stricter about JSON that is accepted by Synapse (#8106 )	2020-08-19 07:26:03 -04:00
Patrick Cloke	d89692ea84	Convert runWithConnection to async. (#8121 )	2020-08-19 07:09:24 -04:00
Patrick Cloke	d294f0e7e1	Remove the unused inlineCallbacks code-paths in the caching code (#8119 )	2020-08-19 07:09:07 -04:00
Erik Johnston	76d21d14a0	Separate `get_current_token` into two. (#8113 ) The function is used for two purposes: 1) for subscribers of streams to get a token they can use to get further updates with, and 2) for replication to track position of the writers of the stream. For streams with a single writer the two scenarios produce the same result, however the situation becomes complicated for streams with multiple writers. The current `MultiWriterIdGenerator` does not correctly handle the first case (which is not an issue as its only used for the `caches` stream which nothing subscribes to outside of replication).	2020-08-19 10:39:31 +01:00
Patrick Cloke	f40645e60b	Convert events worker database to async/await. (#8071 )	2020-08-18 16:20:49 -04:00
Patrick Cloke	acfb7c3b5d	Add a link to the matrix-synapse-rest-password-provider. (#8111 )	2020-08-18 09:54:35 -04:00
Patrick Cloke	3c01724b33	Fix the return type of send_nonmember_events. (#8112 )	2020-08-18 09:53:13 -04:00
Andrew Morgan	5cf7c12995	Remove : from allowed client_secret chars (#8101 ) Closes: https://github.com/matrix-org/synapse/issues/6766 Equivalent Sydent PR: https://github.com/matrix-org/sydent/pull/309 I believe it's now time to remove the extra allowed `:` from `client_secret` parameters.	2020-08-18 14:14:27 +01:00
Patrick Cloke	408aef8276	Rename changelog from bugfix to misc.	2020-08-18 09:09:11 -04:00
Patrick Cloke	2f4d60a5ba	Iteratively encode JSON responses to avoid blocking the reactor. (#8013 )	2020-08-18 08:49:59 -04:00
Patrick Cloke	25e55d2598	Return the previous stream token if a non-member event is a duplicate. (#8093 )	2020-08-18 07:53:23 -04:00
Andrew Morgan	8b6c176aee	Add resources.consent conditional dependency back (#8107 ) Turns out that part of the codebase (synapse.config.server) checks for this key explicitly. Remove that check.	2020-08-18 10:59:54 +01:00
Patrick Cloke	050e20e7ca	Convert some of the general database methods to async (#8100 )	2020-08-17 12:18:01 -04:00
Andrew Morgan	e04e465b4d	Use the default templates when a custom template file cannot be found (#8037 ) Fixes https://github.com/matrix-org/synapse/issues/6583	2020-08-17 17:05:00 +01:00
Patrick Cloke	ad6190c925	Convert stream database to async/await. (#8074 )	2020-08-17 07:24:46 -04:00
Patrick Cloke	ac77cdb64e	Add a shadow-banned flag to users. (#8092 )	2020-08-14 12:37:59 -04:00
Patrick Cloke	b069b78bb4	Convert pusher databases to async/await. (#8075 )	2020-08-14 10:30:16 -04:00
Patrick Cloke	e8861957d9	Convert receipts and events databases to async/await. (#8076 )	2020-08-14 10:05:19 -04:00
Erik Johnston	dc22090a67	Add type hints to synapse.handlers.room (#8090 )	2020-08-14 14:47:53 +01:00
Patrick Cloke	6b7ce1d332	Remove some unused database functions. (#8085 )	2020-08-14 09:25:40 -04:00
Patrick Cloke	894dae74fe	Convert misc database code to async (#8087 )	2020-08-14 07:24:26 -04:00
Patrick Cloke	7bdf9828d5	Remove a space at the start of a changelog entry.	2020-08-13 14:16:18 -04:00
Olivier Wilkinson (reivilibre)	bfd79c2988	Synapse 1.19.0rc1 (2020-08-13) ============================== Removal warning --------------- As outlined in the [previous release](https://github.com/matrix-org/synapse/releases/tag/v1.18.0), we are no longer publishing Docker images with the `-py3` tag suffix. On top of that, we have also removed the `latest-py3` tag. Please see [the announcement in the upgrade notes for 1.18.0](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180). Features -------- - Add option to allow server admins to join rooms which fail complexity checks. Contributed by @lugino-emeritus. ([\#7902](https://github.com/matrix-org/synapse/issues/7902)) - Add an option to purge room or not with delete room admin endpoint (`POST /_synapse/admin/v1/rooms/<room_id>/delete`). Contributed by @dklimpel. ([\#7964](https://github.com/matrix-org/synapse/issues/7964)) - Add rate limiting to users joining rooms. ([\#8008](https://github.com/matrix-org/synapse/issues/8008)) - Add a `/health` endpoint to every configured HTTP listener that can be used as a health check endpoint by load balancers. ([\#8048](https://github.com/matrix-org/synapse/issues/8048)) - Allow login to be blocked based on the values of SAML attributes. ([\#8052](https://github.com/matrix-org/synapse/issues/8052)) - Allow guest access to the `GET /_matrix/client/r0/rooms/{room_id}/members` endpoint, according to MSC2689. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7314](https://github.com/matrix-org/synapse/issues/7314)) Bugfixes -------- - Fix a bug introduced in Synapse v1.7.2 which caused inaccurate membership counts in the room directory. ([\#7977](https://github.com/matrix-org/synapse/issues/7977)) - Fix a long standing bug: 'Duplicate key value violates unique constraint "event_relations_id"' when message retention is configured. ([\#7978](https://github.com/matrix-org/synapse/issues/7978)) - Fix "no create event in auth events" when trying to reject invitation after inviter leaves. Bug introduced in Synapse v1.10.0. ([\#7980](https://github.com/matrix-org/synapse/issues/7980)) - Fix various comments and minor discrepencies in server notices code. ([\#7996](https://github.com/matrix-org/synapse/issues/7996)) - Fix a long standing bug where HTTP HEAD requests resulted in a 400 error. ([\#7999](https://github.com/matrix-org/synapse/issues/7999)) - Fix a long-standing bug which caused two copies of some log lines to be written when synctl was used along with a MemoryHandler logger. ([\#8011](https://github.com/matrix-org/synapse/issues/8011), [\#8012](https://github.com/matrix-org/synapse/issues/8012)) Updates to the Docker image --------------------------- - We no longer publish Docker images with the `-py3` tag suffix, as [announced in the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180). ([\#8056](https://github.com/matrix-org/synapse/issues/8056)) Improved Documentation ---------------------- - Document how to set up a client .well-known file and fix several pieces of outdated documentation. ([\#7899](https://github.com/matrix-org/synapse/issues/7899)) - Improve workers docs. ([\#7990](https://github.com/matrix-org/synapse/issues/7990), [\#8000](https://github.com/matrix-org/synapse/issues/8000)) - Fix typo in `docs/workers.md`. ([\#7992](https://github.com/matrix-org/synapse/issues/7992)) - Add documentation for how to undo a room shutdown. ([\#7998](https://github.com/matrix-org/synapse/issues/7998), [\#8010](https://github.com/matrix-org/synapse/issues/8010)) Internal Changes ---------------- - Reduce the amount of whitespace in JSON stored and sent in responses. Contributed by David Vo. ([\#7372](https://github.com/matrix-org/synapse/issues/7372)) - Switch to the JSON implementation from the standard library and bump the minimum version of the canonicaljson library to 1.2.0. ([\#7936](https://github.com/matrix-org/synapse/issues/7936), [\#7979](https://github.com/matrix-org/synapse/issues/7979)) - Convert various parts of the codebase to async/await. ([\#7947](https://github.com/matrix-org/synapse/issues/7947), [\#7948](https://github.com/matrix-org/synapse/issues/7948), [\#7949](https://github.com/matrix-org/synapse/issues/7949), [\#7951](https://github.com/matrix-org/synapse/issues/7951), [\#7963](https://github.com/matrix-org/synapse/issues/7963), [\#7973](https://github.com/matrix-org/synapse/issues/7973), [\#7975](https://github.com/matrix-org/synapse/issues/7975), [\#7976](https://github.com/matrix-org/synapse/issues/7976), [\#7981](https://github.com/matrix-org/synapse/issues/7981), [\#7987](https://github.com/matrix-org/synapse/issues/7987), [\#7989](https://github.com/matrix-org/synapse/issues/7989), [\#8003](https://github.com/matrix-org/synapse/issues/8003), [\#8014](https://github.com/matrix-org/synapse/issues/8014), [\#8016](https://github.com/matrix-org/synapse/issues/8016), [\#8027](https://github.com/matrix-org/synapse/issues/8027), [\#8031](https://github.com/matrix-org/synapse/issues/8031), [\#8032](https://github.com/matrix-org/synapse/issues/8032), [\#8035](https://github.com/matrix-org/synapse/issues/8035), [\#8042](https://github.com/matrix-org/synapse/issues/8042), [\#8044](https://github.com/matrix-org/synapse/issues/8044), [\#8045](https://github.com/matrix-org/synapse/issues/8045), [\#8061](https://github.com/matrix-org/synapse/issues/8061), [\#8062](https://github.com/matrix-org/synapse/issues/8062), [\#8063](https://github.com/matrix-org/synapse/issues/8063), [\#8066](https://github.com/matrix-org/synapse/issues/8066), [\#8069](https://github.com/matrix-org/synapse/issues/8069), [\#8070](https://github.com/matrix-org/synapse/issues/8070)) - Move some database-related log lines from the default logger to the database/transaction loggers. ([\#7952](https://github.com/matrix-org/synapse/issues/7952)) - Add a script to detect source code files using non-unix line terminators. ([\#7965](https://github.com/matrix-org/synapse/issues/7965), [\#7970](https://github.com/matrix-org/synapse/issues/7970)) - Log the SAML session ID during creation. ([\#7971](https://github.com/matrix-org/synapse/issues/7971)) - Implement new experimental push rules for some users. ([\#7997](https://github.com/matrix-org/synapse/issues/7997)) - Remove redundant and unreliable signature check for v1 Identity Service lookup responses. ([\#8001](https://github.com/matrix-org/synapse/issues/8001)) - Improve the performance of the register endpoint. ([\#8009](https://github.com/matrix-org/synapse/issues/8009)) - Reduce less useful output in the newsfragment CI step. Add a link to the changelog section of the contributing guide on error. ([\#8024](https://github.com/matrix-org/synapse/issues/8024)) - Rename storage layer objects to be more sensible. ([\#8033](https://github.com/matrix-org/synapse/issues/8033)) - Change the default log config to reduce disk I/O and storage for new servers. ([\#8040](https://github.com/matrix-org/synapse/issues/8040)) - Add an assertion on `prev_events` in `create_new_client_event`. ([\#8041](https://github.com/matrix-org/synapse/issues/8041)) - Add a comment to `ServerContextFactory` about the use of `SSLv23_METHOD`. ([\#8043](https://github.com/matrix-org/synapse/issues/8043)) - Log `OPTIONS` requests at `DEBUG` rather than `INFO` level to reduce amount logged at `INFO`. ([\#8049](https://github.com/matrix-org/synapse/issues/8049)) - Reduce amount of outbound request logging at `INFO` level. ([\#8050](https://github.com/matrix-org/synapse/issues/8050)) - It is no longer necessary to explicitly define `filters` in the logging configuration. (Continuing to do so is redundant but harmless.) ([\#8051](https://github.com/matrix-org/synapse/issues/8051)) - Add and improve type hints. ([\#8058](https://github.com/matrix-org/synapse/issues/8058), [\#8064](https://github.com/matrix-org/synapse/issues/8064), [\#8060](https://github.com/matrix-org/synapse/issues/8060), [\#8067](https://github.com/matrix-org/synapse/issues/8067)) -----BEGIN PGP SIGNATURE----- iQJKBAABCgA0FiEEnGyN+jjiKnCf/nYCBnFee20mPkIFAl81c5QWHG9saXZpZXJA bGlicmVwdXNoLm5ldAAKCRAGcV57bSY+QvA7D/9qMkvldt24XZymcY9WV3Po+SzC Ijb+ZXdbUq/ZmhqJWeK7NRwiYLPuJHOUZ1Bk2GF6U8OOYQLoz+UmtShXxSu32cwc /0UUxsF+CAuxs6NowUq2d4n/5Hkl4A2Oi0NP7sjU4k7TJU9s5wWrG0l20EBUfx0r XPxDjZUPNoVH+Ecj3l3jt8+ixNeyWHPOmJsZmzOYEnfA8eAmHEozJ7ymh6qiR5qQ apfK9VeWR1bLJ/zUv+U4mTWRL8YSkswdtU6PamJjf86lMfEZJPp32l5ydEmq+4KV MaljYo20QuxkOrdQghtjiPakxhxCJAQRDBNMcMFTclicexlwEwoRgT9XjXhujd7G D58q6x+Nsy7YaZdE92ZGqaok3taoV1rmAQOV1qm/7SnmPyomOamlTnuIknvkJdys i5Vir0HcbcStNlVIWAYJdO7/t0JoEerI/eH1j2PJu35d8/Q4RFbuLSwUCaKErmPl BuGPrSGztEfRu604JJn5lpHQKBsI+oS/F68Xet6mlzNeidnY0AYxjyyYj7qJo4X7 z9EX4UY1PTIGHQ13l4iG4wb4KgRk9APPw4G8xwhWDJQWvNVuePOHGM+sw4fV22wP FDKxb4+r2Sa9hnKpUzlGj+AJWbSwldF1Cdyo1l8b/fzo3UJbzeG8216xVfE+K91o pxrQoiSqq0Isn8dtmw== =pUup -----END PGP SIGNATURE----- Merge tag 'v1.19.0rc1' into develop Synapse 1.19.0rc1 (2020-08-13) ============================== Removal warning --------------- As outlined in the [previous release](https://github.com/matrix-org/synapse/releases/tag/v1.18.0), we are no longer publishing Docker images with the `-py3` tag suffix. On top of that, we have also removed the `latest-py3` tag. Please see [the announcement in the upgrade notes for 1.18.0](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180). Features -------- - Add option to allow server admins to join rooms which fail complexity checks. Contributed by @lugino-emeritus. ([\#7902](https://github.com/matrix-org/synapse/issues/7902)) - Add an option to purge room or not with delete room admin endpoint (`POST /_synapse/admin/v1/rooms/<room_id>/delete`). Contributed by @dklimpel. ([\#7964](https://github.com/matrix-org/synapse/issues/7964)) - Add rate limiting to users joining rooms. ([\#8008](https://github.com/matrix-org/synapse/issues/8008)) - Add a `/health` endpoint to every configured HTTP listener that can be used as a health check endpoint by load balancers. ([\#8048](https://github.com/matrix-org/synapse/issues/8048)) - Allow login to be blocked based on the values of SAML attributes. ([\#8052](https://github.com/matrix-org/synapse/issues/8052)) - Allow guest access to the `GET /_matrix/client/r0/rooms/{room_id}/members` endpoint, according to MSC2689. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7314](https://github.com/matrix-org/synapse/issues/7314)) Bugfixes -------- - Fix a bug introduced in Synapse v1.7.2 which caused inaccurate membership counts in the room directory. ([\#7977](https://github.com/matrix-org/synapse/issues/7977)) - Fix a long standing bug: 'Duplicate key value violates unique constraint "event_relations_id"' when message retention is configured. ([\#7978](https://github.com/matrix-org/synapse/issues/7978)) - Fix "no create event in auth events" when trying to reject invitation after inviter leaves. Bug introduced in Synapse v1.10.0. ([\#7980](https://github.com/matrix-org/synapse/issues/7980)) - Fix various comments and minor discrepencies in server notices code. ([\#7996](https://github.com/matrix-org/synapse/issues/7996)) - Fix a long standing bug where HTTP HEAD requests resulted in a 400 error. ([\#7999](https://github.com/matrix-org/synapse/issues/7999)) - Fix a long-standing bug which caused two copies of some log lines to be written when synctl was used along with a MemoryHandler logger. ([\#8011](https://github.com/matrix-org/synapse/issues/8011), [\#8012](https://github.com/matrix-org/synapse/issues/8012)) Updates to the Docker image --------------------------- - We no longer publish Docker images with the `-py3` tag suffix, as [announced in the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180). ([\#8056](https://github.com/matrix-org/synapse/issues/8056)) Improved Documentation ---------------------- - Document how to set up a client .well-known file and fix several pieces of outdated documentation. ([\#7899](https://github.com/matrix-org/synapse/issues/7899)) - Improve workers docs. ([\#7990](https://github.com/matrix-org/synapse/issues/7990), [\#8000](https://github.com/matrix-org/synapse/issues/8000)) - Fix typo in `docs/workers.md`. ([\#7992](https://github.com/matrix-org/synapse/issues/7992)) - Add documentation for how to undo a room shutdown. ([\#7998](https://github.com/matrix-org/synapse/issues/7998), [\#8010](https://github.com/matrix-org/synapse/issues/8010)) Internal Changes ---------------- - Reduce the amount of whitespace in JSON stored and sent in responses. Contributed by David Vo. ([\#7372](https://github.com/matrix-org/synapse/issues/7372)) - Switch to the JSON implementation from the standard library and bump the minimum version of the canonicaljson library to 1.2.0. ([\#7936](https://github.com/matrix-org/synapse/issues/7936), [\#7979](https://github.com/matrix-org/synapse/issues/7979)) - Convert various parts of the codebase to async/await. ([\#7947](https://github.com/matrix-org/synapse/issues/7947), [\#7948](https://github.com/matrix-org/synapse/issues/7948), [\#7949](https://github.com/matrix-org/synapse/issues/7949), [\#7951](https://github.com/matrix-org/synapse/issues/7951), [\#7963](https://github.com/matrix-org/synapse/issues/7963), [\#7973](https://github.com/matrix-org/synapse/issues/7973), [\#7975](https://github.com/matrix-org/synapse/issues/7975), [\#7976](https://github.com/matrix-org/synapse/issues/7976), [\#7981](https://github.com/matrix-org/synapse/issues/7981), [\#7987](https://github.com/matrix-org/synapse/issues/7987), [\#7989](https://github.com/matrix-org/synapse/issues/7989), [\#8003](https://github.com/matrix-org/synapse/issues/8003), [\#8014](https://github.com/matrix-org/synapse/issues/8014), [\#8016](https://github.com/matrix-org/synapse/issues/8016), [\#8027](https://github.com/matrix-org/synapse/issues/8027), [\#8031](https://github.com/matrix-org/synapse/issues/8031), [\#8032](https://github.com/matrix-org/synapse/issues/8032), [\#8035](https://github.com/matrix-org/synapse/issues/8035), [\#8042](https://github.com/matrix-org/synapse/issues/8042), [\#8044](https://github.com/matrix-org/synapse/issues/8044), [\#8045](https://github.com/matrix-org/synapse/issues/8045), [\#8061](https://github.com/matrix-org/synapse/issues/8061), [\#8062](https://github.com/matrix-org/synapse/issues/8062), [\#8063](https://github.com/matrix-org/synapse/issues/8063), [\#8066](https://github.com/matrix-org/synapse/issues/8066), [\#8069](https://github.com/matrix-org/synapse/issues/8069), [\#8070](https://github.com/matrix-org/synapse/issues/8070)) - Move some database-related log lines from the default logger to the database/transaction loggers. ([\#7952](https://github.com/matrix-org/synapse/issues/7952)) - Add a script to detect source code files using non-unix line terminators. ([\#7965](https://github.com/matrix-org/synapse/issues/7965), [\#7970](https://github.com/matrix-org/synapse/issues/7970)) - Log the SAML session ID during creation. ([\#7971](https://github.com/matrix-org/synapse/issues/7971)) - Implement new experimental push rules for some users. ([\#7997](https://github.com/matrix-org/synapse/issues/7997)) - Remove redundant and unreliable signature check for v1 Identity Service lookup responses. ([\#8001](https://github.com/matrix-org/synapse/issues/8001)) - Improve the performance of the register endpoint. ([\#8009](https://github.com/matrix-org/synapse/issues/8009)) - Reduce less useful output in the newsfragment CI step. Add a link to the changelog section of the contributing guide on error. ([\#8024](https://github.com/matrix-org/synapse/issues/8024)) - Rename storage layer objects to be more sensible. ([\#8033](https://github.com/matrix-org/synapse/issues/8033)) - Change the default log config to reduce disk I/O and storage for new servers. ([\#8040](https://github.com/matrix-org/synapse/issues/8040)) - Add an assertion on `prev_events` in `create_new_client_event`. ([\#8041](https://github.com/matrix-org/synapse/issues/8041)) - Add a comment to `ServerContextFactory` about the use of `SSLv23_METHOD`. ([\#8043](https://github.com/matrix-org/synapse/issues/8043)) - Log `OPTIONS` requests at `DEBUG` rather than `INFO` level to reduce amount logged at `INFO`. ([\#8049](https://github.com/matrix-org/synapse/issues/8049)) - Reduce amount of outbound request logging at `INFO` level. ([\#8050](https://github.com/matrix-org/synapse/issues/8050)) - It is no longer necessary to explicitly define `filters` in the logging configuration. (Continuing to do so is redundant but harmless.) ([\#8051](https://github.com/matrix-org/synapse/issues/8051)) - Add and improve type hints. ([\#8058](https://github.com/matrix-org/synapse/issues/8058), [\#8064](https://github.com/matrix-org/synapse/issues/8064), [\#8060](https://github.com/matrix-org/synapse/issues/8060), [\#8067](https://github.com/matrix-org/synapse/issues/8067))	2020-08-13 18:22:58 +01:00
Olivier Wilkinson (reivilibre)	091ca3910d	1.19.0rc1	2020-08-13 17:12:21 +01:00
Richard van der Hoff	53834bb9c4	Run `remove_push_actions_from_staging` in foreground (#8081 ) If we got an error persisting an event, we would try to remove the push actions asynchronously, which would lead to a 'Re-starting finished log context' warning. I don't think there's any need for this to be asynchronous.	2020-08-13 17:05:31 +01:00
reivilibre	ff0e894656	Drop federation transmission queues during a significant remote outage. (#7864 ) * Empty federation transmission queues when we are backing off. Fixes #7828. Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> * Address feedback Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> * Reword newsfile	2020-08-13 12:35:04 +01:00
Patrick Cloke	dd8f28bd3f	Fix unawaited coroutine error in tests. (#8072 )	2020-08-13 07:11:39 -04:00
Patrick Cloke	fbe930dad2	Convert the roommember database to async/await. (#8070 )	2020-08-12 12:14:34 -04:00
Patrick Cloke	5ecc8b5825	Convert devices database to async/await. (#8069 )	2020-08-12 10:51:42 -04:00
Erik Johnston	5dd73d029e	Add type hints to handlers.message and events.builder (#8067 )	2020-08-12 15:05:50 +01:00
Patrick Cloke	d68e10f308	Convert account data, device inbox, and censor events databases to async/await (#8063 )	2020-08-12 09:29:06 -04:00
Patrick Cloke	a3a59bab7b	Convert appservice, group server, profile and more databases to async (#8066 )	2020-08-12 09:28:48 -04:00
Erik Johnston	9d1e4942ab	Fix typing for notifier (#8064 )	2020-08-12 14:03:08 +01:00
Erik Johnston	6ba621d786	Merge pull request #8060 from matrix-org/erikj/type_server Change HomeServer definition to work with typing.	2020-08-11 22:32:14 +01:00
Patrick Cloke	04faa0bfa9	Convert tags and metrics databases to async/await (#8062 )	2020-08-11 17:21:20 -04:00
Patrick Cloke	a0acdfa9e9	Converts event_federation and registration databases to async/await (#8061 )	2020-08-11 17:21:13 -04:00
Erik Johnston	fdb46b5442	Merge remote-tracking branch 'origin/develop' into erikj/type_server	2020-08-11 22:03:14 +01:00
Erik Johnston	61d8ff0d44	Auto set logging filter (#8051 ) We do this to prevent foot guns. The default config uses a MemoryFilter, but users are free to change to logging to files directly. If they do then they have to ensure to set the `filters: [context]` on the right handler, otherwise records get written with the wrong context. Instead we move the logic to happen when we generate a record, which is when we log rather than handle. (It's possible to add filters to loggers in the config, however they don't apply to descendant loggers and so they have to be manually set on every logger used in the code base)	2020-08-11 21:58:56 +01:00
Erik Johnston	3c796e4159	Update changelog.d/8051.misc Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2020-08-11 21:08:43 +01:00
Erik Johnston	a1e9bb9eae	Add typing info to Notifier (#8058 )	2020-08-11 19:40:02 +01:00
Erik Johnston	e1af09dccb	Newsfile	2020-08-11 18:10:46 +01:00
Erik Johnston	a0f574f3c2	Reduce INFO logging (#8050 ) c.f. #8021 A lot of the code here is to change the `Completed 200 OK` logging to include the request URI so that we can drop the `Sending request...` log line. Some notes: 1. We won't log retries, which may be confusing considering the time taken log line includes retries and sleeps. 2. The `_send_request_with_optional_trailing_slash` will always be logged without the forward slash, even if it succeeded only with the forward slash.	2020-08-11 18:10:07 +01:00
Erik Johnston	db131b6b22	Change the default log config to reduce disk I/O and storage (#8040 ) * Change default log config to buffer by default. This batches up writes to the filesystem, which is more efficient for disk I/O. This means that it can take some time for logs to get written to disk. Note that ERROR logs (and above) immediately flush the buffer. This only effects new installs, as we only write the log config if started with `--generate-config` (in the same way we do for generating signing keys). * Default to keeping last 4 days of logs. This hopefully reduces the amount of logs kept for new servers. Keeping the last 1GB of logs is likely overkill for new servers, but equally may not be enough for busy ones. Instead, we keep the last four days worth of logs, enough so that admins can investigate any problems that happened over e.g. a long weekend.	2020-08-11 18:09:46 +01:00
Erik Johnston	64e5bb0dc8	Newsfile	2020-08-11 18:03:26 +01:00
Richard van der Hoff	0cb169900e	Implement login blocking based on SAML attributes (#8052 ) Hopefully this mostly speaks for itself. I also did a bit of cleaning up of the error handling. Fixes #8047	2020-08-11 16:08:10 +01:00
Richard van der Hoff	aa827b6ad7	Merge remote-tracking branch 'origin/master' into develop	2020-08-10 23:42:12 +01:00
Richard van der Hoff	39c3f68758	Stop uploading -py3 docker images (#8056 )	2020-08-10 23:41:50 +01:00
Richard van der Hoff	fcbab08cbd	Add an assertion on prev_events in create_new_client_event (#8041 ) I think this would have caught all the cases in https://github.com/matrix-org/synapse/issues/7642 - and I think a 500 makes more sense here than a 403	2020-08-10 12:29:47 +01:00
Brendan Abolivier	cdbb8e6d6e	Implement new experimental push rules (#7997 ) With an undocumented configuration setting to enable them for specific users.	2020-08-10 11:48:01 +01:00
Patrick Cloke	7f837959ea	Convert directory, e2e_room_keys, end_to_end_keys, monthly_active_users database to async (#8042 )	2020-08-07 13:36:29 -04:00
Patrick Cloke	f3fe6961b2	Convert additional database stores to async/await (#8045 )	2020-08-07 12:17:17 -04:00
Travis Ralston	1048ed2afa	Clarify that undoing a shutdown might not be possible (#8010 )	2020-08-07 17:16:24 +01:00

... 2 3 4 5 6 ...

3547 commits