synapse/changelog.d/12505.misc at 01dcf7532d7863b2721156a4817716a8628fe73f - tileradotorg/synapse - tilera Git

tileradotorg/synapse

forked from MirrorHub/synapse

Sean Quah 78b99de7c2

Prefer make_awaitable over defer.succeed in tests (#12505 )

When configuring the return values of mocks, prefer awaitables from
`make_awaitable` over `defer.succeed`. `Deferred`s are only awaitable
once, so it is inappropriate for a mock to return the same `Deferred`
multiple times.

Also update `run_in_background` to support functions that return
arbitrary awaitables.

Signed-off-by: Sean Quah <seanq@element.io>

2022-04-27 14:58:26 +01:00

1 line

85 B

Text

Raw Blame History

Use `make_awaitable` instead of `defer.succeed` for return values of mocks in tests.