synapse/changelog.d/8585.bugfix at 2b3af01791120de5d0b829395109b42870d9e465 - tileradotorg/synapse - tilera Git

tileradotorg/synapse

forked from MirrorHub/synapse

Andrew Morgan a312e890f5

Cast errors generated during synapse_port_db to str (#8585 )

I noticed in https://github.com/matrix-org/synapse/issues/8575 that the `end_error` variable in `synapse_port_db` is set to an `Exception`, even though later we expect it to be a `str`.

This PR simply casts an exception raised to a string. I'm doing this instead of having `end_error` be of type exception as we explicitly set `end_error` to a str here:

d25eb8f370/scripts/synapse_port_db (L542-L547)

This whole file could probably use some heavy refactoring, but until then at least this fix will prevent exception contents from being hidden from us and users.

2020-10-20 11:47:24 +01:00

1 line

No EOL

115 B

Text

Raw Blame History

Fix a bug that prevented errors encountered during execution of the `synapse_port_db` from being correctly printed.