synapse/changelog.d/9585.bugfix at 4655d2221e79b0ecdcb88c7e1eef467eec2ed481 - tileradotorg/synapse - tilera Git

tileradotorg/synapse

forked from MirrorHub/synapse

Andrew Morgan 7b06f85c0e

Ensure we use a copy of the event content dict before modifying it in serialize_event (#9585 )

This bug was discovered by DINUM. We were modifying `serialized_event["content"]`, which - if you've got `USE_FROZEN_DICTS` turned on or are [using a third party rules module](17cd48fe51/synapse/events/third_party_rules.py (L73-L76)) - will raise a 500 if you try to a edit a reply to a message.

`serialized_event["content"]` could be set to the edit event's content, instead of a copy of it, which is bad as we attempt to modify it. Instead, we also end up modifying the original event's content. DINUM uses a third party rules module, which meant the event's content got frozen and thus an exception was raised.

To be clear, the problem is not that the event's content was frozen. In fact doing so helped us uncover the fact we weren't copying event content correctly.

2021-03-17 16:51:55 +00:00

1 line

No EOL

81 B

Text

Raw Blame History

Fix a longstanding bug that could cause issues when editing a reply to a message.