synapse/changelog.d/4487.misc at 5180f12bae880f76a483bc945951635c77596499 - tileradotorg/synapse - tilera Git

tileradotorg/synapse

forked from MirrorHub/synapse

Richard van der Hoff d840019192

Fix idna and ipv6 literal handling in MatrixFederationAgent (#4487 )

Turns out that the library does a better job of parsing URIs than our
reinvented wheel. Who knew.

There are two things going on here. The first is that, unlike
parse_server_name, URI.fromBytes will strip off square brackets from IPv6
literals, which means that it is valid input to ClientTLSOptionsFactory and
HostnameEndpoint.

The second is that we stay in `bytes` throughout (except for the argument to
ClientTLSOptionsFactory), which avoids the weirdness of (sometimes) ending up
with idna-encoded values being held in `unicode` variables. TBH it probably
would have been ok but it made the tests fragile.

2019-01-28 09:56:59 +00:00

1 line

60 B

Text

Raw Blame History

Fix idna and ipv6 literal handling in MatrixFederationAgent