synapse/changelog.d/7291.misc at 69a1ac00b2a00608368aa0d71fb0490a0501bd16 - tileradotorg/synapse - tilera Git

tileradotorg/synapse

forked from MirrorHub/synapse

Richard van der Hoff 67ff7b8ba0

Improve type checking in replication.tcp.Stream (#7291 )

The general idea here is to get rid of the type: ignore annotations on all of the current_token and update_function assignments, which would have caught #7290.

After a bit of experimentation, it seems like the least-awful way to do this is to pass the offending functions in as parameters to the Stream constructor. Unfortunately that means that the concrete implementations no longer have the same constructor signature as Stream itself, which means that it gets hard to correctly annotate STREAMS_MAP.

I've also introduced a couple of new types, to take out some duplication.

2020-04-17 14:49:55 +01:00

1 line

72 B

Text

Raw Blame History

Improve typing annotations in `synapse.replication.tcp.streams.Stream`.