synapse/changelog.d/13960.misc at 70a4317692adcf7f1dacb201cda2188c8495bfa9 - tileradotorg/synapse - tilera Git

tileradotorg/synapse

forked from MirrorHub/synapse

Eric Eastwood a52c40e2a6

Fix get_users_in_room mis-use in transfer_room_state_on_room_upgrade (#13960 )

Spawning from looking into `get_users_in_room` while investigating https://github.com/matrix-org/synapse/issues/13942#issuecomment-1262787050.

See https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755 for the original exploration around finding `get_users_in_room` mis-uses.

Related to the following PRs where we also cleaned up some `get_users_in_room` mis-uses:

 - https://github.com/matrix-org/synapse/pull/13605
 - https://github.com/matrix-org/synapse/pull/13608
 - https://github.com/matrix-org/synapse/pull/13606
 - https://github.com/matrix-org/synapse/pull/13958

2022-09-30 20:10:50 -05:00

1 line

137 B

Text

Raw Blame History

Use dedicated `get_local_users_in_room(room_id)` function to find local users when calculating users to copy over during a room upgrade.