synapse/changelog.d/9466.bugfix at 7f5d753d06c5d36097e68045cfc83a32ee6e7889 - tileradotorg/synapse - tilera Git

tileradotorg/synapse

forked from MirrorHub/synapse

Erik Johnston 2927921942

Clean up ShardedWorkerHandlingConfig (#9466 )

* Split ShardedWorkerHandlingConfig

This is so that we have a type level understanding of when it is safe to
call `get_instance(..)` (as opposed to `should_handle(..)`).

* Remove special cases in ShardedWorkerHandlingConfig.

`ShardedWorkerHandlingConfig` tried to handle the various different ways
it was possible to configure federation senders and pushers. This led to
special cases that weren't hit during testing.

To fix this the handling of the different cases is moved from there and
`generic_worker` into the worker config class. This allows us to have
the logic in one place and allows the rest of the code to ignore the
different cases.

2021-02-24 13:23:18 +00:00

1 line

49 B

Text

Raw Blame History

Fix deleting pushers when using sharded pushers.