synapse/changelog.d/6491.bugfix at aeaeb72ee41076b0f08b07ea4686d1c38acf2d6b - tileradotorg/synapse - tilera Git

tileradotorg/synapse

forked from MirrorHub/synapse

Richard van der Hoff 18660a34d8

Fix inaccurate per-block metrics (#6491 )

`Measure` incorrectly assumed that it was the only thing being done by the parent `LoggingContext`. For instance, during a "renew group attestations" operation, hundreds of `outbound_request` calls could take place in parallel, all using the same `LoggingContext`. This would mean that any resources used during *any* of those calls would be reported against *all* of them, producing wildly inaccurate results.

Instead, we now give each `Measure` block its own `LoggingContext` (using the parent `LoggingContext` mechanism to ensure that the log lines look correct and that the metrics are ultimately propogated to the top level for reporting against requests/backgrond tasks).

2019-12-09 11:55:30 +00:00

1 line

45 B

Text

Raw Blame History

Fix inaccurate per-block Prometheus metrics.