synapse/changelog.d/11724.misc at d09099642e3a1fe9b26149fa57c58db3c26afc10 - tileradotorg/synapse - tilera Git

tileradotorg/synapse

forked from MirrorHub/synapse

Richard van der Hoff 6a78ede569

Improve reactor_tick_time metric (#11724 )

The existing implementation of the `python_twisted_reactor_tick_time` metric is pretty useless, because it *only* 
measures the time taken to execute timed calls and callbacks from threads. That neglects everything that 
happens off the back of I/O, which is obviously quite a lot for us.

To improve this, I've hooked into a different place in the reactor - in particular, where it calls `epoll`. That call is 
the only place it should wait for something to happen - the rest of the loop *should* be quick.

I've also removed `python_twisted_reactor_pending_calls`, because I don't believe anyone ever looks at it, and
it's a nuisance to populate.

2022-01-17 12:14:40 +00:00

1 line

74 B

Text

Raw Blame History

Improve accuracy of `python_twisted_reactor_tick_time` prometheus metric.