synapse/changelog.d/11012.bugfix at d52c58dfa3f548b489dae0b1945cf733d4a6538c - tileradotorg/synapse - tilera Git

tileradotorg/synapse

forked from MirrorHub/synapse

Richard van der Hoff da957a60e8

Ensure that we correctly auth events returned by send_join (#11012 )

This is the final piece of the jigsaw for #9595. As with other changes before this one (eg #10771), we need to make sure that we auth the auth events in the right order, and actually check that their predecessors haven't been rejected.

To do this I've reused the existing code we use when persisting outliers elsewhere.

I've removed the code for attempting to fetch missing auth_events - the events should have been present in the send_join response, so the likely reason they are missing is that we couldn't verify them, so requesting them again is unlikely to help. Instead, we simply drop any state which relies on those auth events, as we do at a backwards-extremity. See also matrix-org/complement#216 for a test for this.

2021-10-25 15:21:09 +01:00

1 line

130 B

Text

Raw Blame History

Fix a long-standing bug which meant that events received over federation were sometimes incorrectly accepted into the room state.