synapse/changelog.d/9069.misc at de45bf5b5b72ea4cc6d16f2c41d7f2a6e1c350bf - tileradotorg/synapse - tilera Git

tileradotorg/synapse

forked from MirrorHub/synapse

Richard van der Hoff 2ec8ca5e60

Remove SynapseRequest.get_user_agent (#9069 )

SynapseRequest is in danger of becoming a bit of a dumping-ground for "useful stuff relating to Requests",
which isn't really its intention (its purpose is to override render, finished and connectionLost to set up the 
LoggingContext and write the right entries to the request log).

Putting utility functions inside SynapseRequest means that lots of our code ends up requiring a
SynapseRequest when there is nothing synapse-specific about the Request at all, and any old
twisted.web.iweb.IRequest will do. This increases code coupling and makes testing more difficult.

In short: move get_user_agent out to a utility function.

2021-01-12 12:34:16 +00:00

1 line

40 B

Text

Raw Blame History

Remove `SynapseRequest.get_user_agent`.