synapse/changelog.d/14812.bugfix at f075f6ae2bfb87495283128865d535466e86bfa1 - tileradotorg/synapse - tilera Git

tileradotorg/synapse

forked from MirrorHub/synapse

Sean Quah 772e8c2385

Fix stack overflow in _PerHostRatelimiter due to synchronous requests (#14812 )

When there are many synchronous requests waiting on a
`_PerHostRatelimiter`, each request will be started recursively just
after the previous request has completed. Under the right conditions,
this leads to stack exhaustion.

A common way for requests to become synchronous is when the remote
client disconnects early, because the homeserver is overloaded and slow
to respond.

Avoid stack exhaustion under these conditions by deferring subsequent
requests until the next reactor tick.

Fixes #14480.

Signed-off-by: Sean Quah <seanq@matrix.org>

2023-01-13 00:16:21 +00:00

1 line

155 B

Text

Raw Blame History

Fix a long-standing bug where Synapse would exhaust the stack when processing many federation requests where the remote homeserver has disconencted early.