synapse

mirror of https://mau.dev/maunium/synapse.git synced 2024-11-14 14:01:59 +01:00

Author	SHA1	Message	Date
Shay	71e8afe34d	Update EventContext `get_current_event_ids` and `get_prev_event_ids` to accept state filters and update calls where possible (#12791 )	2022-05-20 09:54:12 +01:00
Sean Quah	2be5a2b07b	Fix `RetryDestinationLimiter` re-starting finished log contexts (#12803 ) Signed-off-by: Sean Quah <seanq@matrix.org>	2022-05-19 20:17:10 +01:00
Andrew Morgan	96df31239c	Add a unit test for copying over arbitrary room types when upgrading a room (#12792 )	2022-05-19 18:32:48 +01:00
reivilibre	177b884ad7	Lay some foundation work to allow workers to only subscribe to some kinds of messages, reducing replication traffic. (#12672 )	2022-05-19 16:29:08 +01:00
Shay	eb4aaa1b4b	Add detail to `cache_autotuning` config option documentation (#12776 )	2022-05-19 07:47:07 -07:00
Shay	ab2a615cfb	Update configuration manual to document size-related suffixes (#12777 )	2022-05-19 07:46:33 -07:00
Petr Vaněk	684feeaf2f	Properly close providers.json file stream. (#12794 )	2022-05-19 14:23:59 +00:00
reivilibre	66a5f6c400	Add a unique index to `state_group_edges` to prevent duplicates being accidentally introduced and the consequential impact to performance. (#12687 )	2022-05-19 14:16:49 +01:00
Jae Lo Presti	f16ec055cc	hash_password: raise an error if no config file is specified (#12789 )	2022-05-19 13:03:13 +00:00
David Robertson	b935c9529c	Simplify untyped-defs config in mypy.ini (#12790 )	2022-05-19 13:49:58 +01:00
Aminda Suomalainen	d25935cd3d	Implement MSC3818: copy room type on upgrade (#12786 ) Resolves: #11896 Signed-off-by: Aminda Suomalainen <suomalainen+git@mikaela.info>	2022-05-19 12:28:10 +01:00
Sami Olmari	47619017f9	Add missing user directory search endpoint to the generic worker documentation (#12773 ) Signed-off-by: Sami Olmari <sami@olmari.fi>	2022-05-19 12:03:12 +01:00
David Robertson	6ff99e3bea	Downgrade some OIDC exceptions to warnings (#12723 )	2022-05-18 20:10:21 +01:00
Patrick Cloke	a1cb05b3e8	Fix federation in demo scripts. (#12783 )	2022-05-18 14:49:33 -04:00
Richard van der Hoff	d38c73e9ab	Skip waiting for full state if a StateFilter does not require it (#12498 ) If `StateFilter` specifies a state set which we will have regardless of state-syncing, then we may as well return it immediately.	2022-05-18 18:33:57 +00:00
Andrew Morgan	0fce474a40	Fix YAML parsing error in `url_preview_accept_language` (#12785 )	2022-05-18 17:24:44 +00:00
Shay	19d79b6ebe	Refactor `resolve_state_groups_for_events` to not pull out full state when no state resolution happens. (#12775 )	2022-05-18 10:15:52 -07:00
Sean Quah	3d8839c30c	Add documentation for cancellation of request processing (#12761 ) Signed-off-by: Sean Quah <seanq@matrix.org>	2022-05-18 17:56:23 +01:00
Dirk Klimpel	50ae4eafe1	Add some type hints to `event_federation` datastore (#12753 ) Co-authored-by: David Robertson <david.m.robertson1@gmail.com>	2022-05-18 16:02:10 +01:00
reivilibre	635f0d916b	Do not keep going if there are 5 back-to-back background update failures. (#12781 )	2022-05-18 13:57:59 +00:00
reivilibre	df4963548b	Give a meaningful error message when a client tries to create a room with an invalid alias localpart. (#12779 )	2022-05-18 11:46:06 +00:00
Andrew Morgan	a167304c8b	Switch the 'Configuration' link in the docs homepage to the config manual (#12748 )	2022-05-18 11:29:32 +00:00
Andrew Morgan	deca250e3f	Add some documentation around the `rc_invites` option to the config docs (#12759 )	2022-05-18 12:21:32 +01:00
David Robertson	d4713d3e33	Discard null-containing strings before updating the user directory (#12762 )	2022-05-18 11:28:14 +01:00
Hubert Chathi	8afb7b55d0	Make handling of federation Authorization header (more) compliant with RFC7230 (#12774 ) The main differences are: - values with delimiters (such as colons) should be quoted, so always quote the origin, since it could contain a colon followed by a port number - should allow more than one space after "X-Matrix" - quoted values with backslash-escaped characters should be unescaped - names should be case insensitive	2022-05-18 11:19:30 +01:00
Adam	37935b5183	Move methods that call add_push_rule to PushRuleStore (#12772 ) Signed-off-by: Adam Roddick <ajroddick@tuta.io>	2022-05-18 09:37:48 +00:00
David Robertson	0d17357fcd	Suggest using docker when testing against postgres (#12765 ) Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-05-17 18:05:53 +00:00
Mathieu Velten	182ca78a12	Delete events from federation_inbound_events_staging table on purge (#12770 )	2022-05-17 17:01:06 +00:00
David Robertson	5331fb5b47	allow `on_invalidate=None` in `@cached` methods (#12769 )	2022-05-17 16:06:45 +00:00
Dirk Klimpel	6edefef602	Add some type hints to datastore (#12717 )	2022-05-17 15:29:06 +01:00
Travis Ralston	942c30b16b	Add a new room version for MSC3787's knock+restricted join rule (#12623 )	2022-05-17 10:41:39 +00:00
Richard van der Hoff	24b590de32	Remove code which updates `application_services_state.last_txn` (#12680 ) This column is unused as of #12209, so let's stop writing to it.	2022-05-17 11:07:18 +01:00
SpiritCroc	a34a41f135	Fix push for m.read events (#12721 ) badge_count_last_call was always zero when the response for push notifications included a "rejected" key which mapped to an empty list.	2022-05-17 11:03:07 +01:00
Erik Johnston	32ef24fbd7	Add index to cache invalidations (#12747 ) For workers that rarely write to the cache the `get_all_updated_caches` query can become expensive if the worker falls behind when reading the cache.	2022-05-17 09:34:59 +00:00
Erik Johnston	fcf951d5dc	Track in memory events using weakrefs (#10533 )	2022-05-17 10:34:27 +01:00
David Robertson	1fe202a1a3	Tidy up and type-hint the database engine modules (#12734 ) Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-05-17 00:34:38 +01:00
Andrew Morgan	6d8d1218dd	Fix typo in name of 'run_background_tasks_on' option in config manual (#12749 )	2022-05-16 17:31:12 +00:00
Andrew Morgan	3eafee629d	Revert "changelog" This reverts commit `e24c11afd6`. whoops...	2022-05-16 17:52:22 +01:00
Andrew Morgan	e24c11afd6	changelog	2022-05-16 17:51:43 +01:00
Andrew Morgan	83be72d76c	Add `StreamKeyType` class and replace string literals with constants (#12567 )	2022-05-16 15:35:31 +00:00
Šimon Brandner	3ce15cc7be	Avoid unnecessary copies when filtering private read receipts. (#12711 ) A minor optimization to avoid unnecessary copying/building identical dictionaries when filtering private read receipts. Also clarifies comments and cleans-up some tests.	2022-05-16 15:06:23 +00:00
Dirk Klimpel	8060034612	Fix typo in listener config (#12742 )	2022-05-16 13:50:07 +00:00
Sean Quah	a5c26750b5	Fix room upgrades creating an empty room when auth fails (#12696 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-05-16 14:06:04 +01:00
Patrick Cloke	86a515ccbf	Consolidate logic for parsing relations. (#12693 ) Parse the `m.relates_to` event content field (which describes relations) in a single place, this is used during: * Event persistence. * Validation of the Client-Server API. * Fetching bundled aggregations. * Processing of push rules. Each of these separately implement the logic and each made slightly different assumptions about what was valid. Some had minor / potential bugs.	2022-05-16 12:42:45 +00:00
Shay	cde8af9a49	Add config flags to allow for cache auto-tuning (#12701 )	2022-05-13 12:32:39 -07:00
Till	e8ae472d3b	Update configs used by Complement to allow more invites (#12731 )	2022-05-13 16:45:47 +01:00
Brendan Abolivier	9013104429	Don't create an empty room when checking for MAU limits (#12713 )	2022-05-13 15:30:15 +02:00
David Robertson	aec69d2481	Another batch of type annotations (#12726 )	2022-05-13 12:35:31 +01:00
Jess Porter	39bed28b28	SpamChecker metrics (#12513 ) * add Measure blocks all over SpamChecker Signed-off-by: jesopo <github@lolnerd.net> * fix test_spam_checker_may_join_room and test_threepid_invite_spamcheck * better changelog entry	2022-05-13 12:17:38 +01:00
Niklas	c9fc2c0d22	Update issuer URL in example OIDC Keycloak config (#12727 ) * Update openid.md Newer versions of keycloak returning a 404 when using the `/auth` prefix. Related: https://github.com/matrix-org/synapse/issues/12714	2022-05-13 10:15:51 +00:00
Andrew Morgan	57f6c496d0	URL preview cache expiry logs: INFO -> DEBUG, text clarifications (#12720 )	2022-05-12 18:16:32 +01:00
David Robertson	17e1eb7749	Reduce the number of "untyped defs" (#12716 )	2022-05-12 14:33:50 +00:00
Andy Balaam	de1e599b9d	add default_power_level_content_override config option. (#12618 ) Co-authored-by: Matthew Hodgson <matthew@matrix.org>	2022-05-12 10:41:35 +00:00
Andrew Morgan	409573f6d0	Fix reference to the wrong symbol in the media admin api docs (#12715 )	2022-05-12 09:29:37 +01:00
Sean Quah	bf7ce92bf7	Enable cancellation of `GET /members` and `GET /state` requests (#12708 ) Enable cancellation of `GET /rooms/$room_id/members`, `GET /rooms/$room_id/state` and `GET /rooms/$room_id/state/$state_key/*` requests. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-11 17:22:34 +01:00
David Robertson	db10f2c037	No longer permit empty body when sending receipts (#12709 )	2022-05-11 15:34:17 +00:00
Sean Quah	6ee61b9052	Complain if a federation endpoint has the `@cancellable` flag (#12705 ) `BaseFederationServlet` wraps its endpoints in a bunch of async code that has not been vetted for compatibility with cancellation. Fail CI if a `@cancellable` flag is applied to a federation endpoint. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-11 14:52:26 +01:00
David Robertson	d38d242411	Reload cache factors from disk on SIGHUP (#12673 )	2022-05-11 13:43:22 +00:00
Sean Quah	a559c8b0d9	Respect the `@cancellable` flag for `ReplicationEndpoint`s (#12700 ) While `ReplicationEndpoint`s register themselves via `JsonResource`, they pass a method that calls the handler, instead of the handler itself, to `register_paths`. As a result, `JsonResource` will not correctly pick up the `@cancellable` flag and we have to apply it ourselves. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-11 12:25:39 +01:00
Sean Quah	9d8e380d2e	Respect the `@cancellable` flag for `RestServlet`s and `BaseFederationServlet`s (#12699 ) Both `RestServlet`s and `BaseFederationServlet`s register their handlers with `HttpServer.register_paths` / `JsonResource.register_paths`. Update `JsonResource` to respect the `@cancellable` flag on handlers registered in this way. Although `ReplicationEndpoint` also registers itself using `register_paths`, it does not pass the handler method that would have the `@cancellable` flag directly, and so needs separate handling. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-11 12:25:13 +01:00
Sean Quah	dffecade7d	Respect the `@cancellable` flag for `DirectServe{Html,Json}Resource`s (#12698 ) `DirectServeHtmlResource` and `DirectServeJsonResource` both inherit from `_AsyncResource`. These classes expect to be subclassed with `_async_render_*` methods. This commit has no effect on `JsonResource`, despite inheriting from `_AsyncResource`. `JsonResource` has its own `_async_render` override which will need to be updated separately. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-11 12:24:48 +01:00
Patrick Cloke	a4c75918b3	Remove unneeded `ActionGenerator` class. (#12691 ) It simply passes through to `BulkPushRuleEvaluator`, which can be called directly instead.	2022-05-11 07:15:21 -04:00
Eric Eastwood	84facf769e	Fix `/messages` throwing a 500 when querying for non-existent room (#12683 ) Fix https://github.com/matrix-org/synapse/issues/12678 Complement test added: https://github.com/matrix-org/complement/pull/369 Before: 500 internal server error After: According to the [spec](https://spec.matrix.org/latest/client-server-api/#get_matrixclientv3roomsroomidmessages), calling `/messages` against a non-existent `room_id` should throw a 403 forbidden (since you're not part of the room). This also matches the behavior before https://github.com/matrix-org/synapse/pull/12370 which regressed Synapse to the 500 behavior. ```json { "errcode": "M_FORBIDDEN", "error": "User @test:my.synapse.server not in room !dne:my.synapse.server, and room previews are disabled" } ```	2022-05-10 23:39:14 -05:00
Erik Johnston	c72d26c1e1	Refactor `EventContext` (#12689 ) Refactor how the `EventContext` class works, with the intention of reducing the amount of state we fetch from the DB during event processing. The idea here is to get rid of the cached `current_state_ids` and `prev_state_ids` that live in the `EventContext`, and instead defer straight to the database (and its caching). One change that may have a noticeable effect is that we now no longer prefill the `get_current_state_ids` cache on a state change. However, that query is relatively light, since its just a case of reading a table from the DB (unlike fetching state at an event which is more heavyweight). For deployments with workers this cache isn't even used. Part of #12684	2022-05-10 19:43:13 +00:00
Sean Quah	c997bfb926	Capture the `Deferred` for request cancellation in `_AsyncResource` (#12694 ) All async request processing goes through `_AsyncResource`, so this is the only place where a `Deferred` needs to be captured for cancellation. Unfortunately, the same isn't true for determining whether a request can be cancelled. Each of `RestServlet`, `BaseFederationServlet`, `DirectServe{Html,Json}Resource` and `ReplicationEndpoint` have different wrappers around the method doing the request handling and they all need to be handled separately. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-10 20:39:05 +01:00
Patrick Cloke	29f06704b8	Fix incorrect type hint in filtering code. (#12695 )	2022-05-10 14:10:22 -04:00
Dirk Klimpel	989fa33096	Add some type hints to datastore. (#12477 )	2022-05-10 14:07:48 -04:00
Richard van der Hoff	147f098fb4	Stop writing to `event_reference_hashes` (#12679 ) This table is never read, since #11794. We stop writing to it; in future we can drop it altogether.	2022-05-10 15:35:08 +01:00
Sean Quah	dbb12a0b54	Add helper class for testing request cancellation (#12630 ) Also expose the `SynapseRequest` from `FakeChannel` in tests, so that we can call `Request.connectionLost` to simulate a client disconnecting. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-10 14:06:56 +01:00
Sean Quah	5cfb004595	Add ability to cancel disconnected requests to `SynapseRequest` (#12588 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-05-10 14:06:08 +01:00
Sean Quah	5c00151c28	Add `@cancellable` decorator, for use on request handlers (#12586 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-05-10 14:05:22 +01:00
David Robertson	2aad0ae57f	Synapse 1.59.0rc1 (2022-05-10) ============================== This release makes several changes that server administrators should be aware of: - Device name lookup over federation is now disabled by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - The `synapse.app.appservice` and `synapse.app.user_dir` worker application types are now deprecated. ([\#12452](https://github.com/matrix-org/synapse/issues/12452), [\#12654](https://github.com/matrix-org/synapse/issues/12654)) See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1590) for more details. Additionally, this release removes the non-standard `m.login.jwt` login type from Synapse. It can be replaced with `org.matrix.login.jwt` for identical behaviour. This is only used if `jwt_config.enabled` is set to `true` in the configuration. ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) Features -------- - Support [MSC3266](https://github.com/matrix-org/matrix-doc/pull/3266) room summaries over federation. ([\#11507](https://github.com/matrix-org/synapse/issues/11507)) - Implement [changes](`4a77139249`) to [MSC2285 (hidden read receipts)](https://github.com/matrix-org/matrix-spec-proposals/pull/2285). Contributed by @SimonBrandner. ([\#12168](https://github.com/matrix-org/synapse/issues/12168), [\#12635](https://github.com/matrix-org/synapse/issues/12635), [\#12636](https://github.com/matrix-org/synapse/issues/12636), [\#12670](https://github.com/matrix-org/synapse/issues/12670)) - Extend the [module API](https://github.com/matrix-org/synapse/blob/release-v1.59/synapse/module_api/__init__.py) to allow modules to change actions for existing push rules of local users. ([\#12406](https://github.com/matrix-org/synapse/issues/12406)) - Add the `notify_appservices_from_worker` configuration option (superseding `notify_appservices`) to allow a generic worker to be designated as the worker to send traffic to Application Services. ([\#12452](https://github.com/matrix-org/synapse/issues/12452)) - Add the `update_user_directory_from_worker` configuration option (superseding `update_user_directory`) to allow a generic worker to be designated as the worker to update the user directory. ([\#12654](https://github.com/matrix-org/synapse/issues/12654)) - Add new `enable_registration_token_3pid_bypass` configuration option to allow registrations via token as an alternative to verifying a 3pid. ([\#12526](https://github.com/matrix-org/synapse/issues/12526)) - Implement [MSC3786](https://github.com/matrix-org/matrix-spec-proposals/pull/3786): Add a default push rule to ignore `m.room.server_acl` events. ([\#12601](https://github.com/matrix-org/synapse/issues/12601)) - Add new `mau_appservice_trial_days` configuration option to specify a different trial period for users registered via an appservice. ([\#12619](https://github.com/matrix-org/synapse/issues/12619)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where the latest thread reply provided failed to include the proper bundled aggregations. ([\#12273](https://github.com/matrix-org/synapse/issues/12273)) - Fix a bug introduced in Synapse 1.22.0 where attempting to send a large amount of read receipts to an application service all at once would result in duplicate content and abnormally high memory usage. Contributed by Brad & Nick @ Beeper. ([\#12544](https://github.com/matrix-org/synapse/issues/12544)) - Fix a bug introduced in Synapse 1.57.0 which could cause `Failed to calculate hosts in room` errors to be logged for outbound federation. ([\#12570](https://github.com/matrix-org/synapse/issues/12570)) - Fix a long-standing bug where status codes would almost always get logged as `200!`, irrespective of the actual status code, when clients disconnect before a request has finished processing. ([\#12580](https://github.com/matrix-org/synapse/issues/12580)) - Fix race when persisting an event and deleting a room that could lead to outbound federation breaking. ([\#12594](https://github.com/matrix-org/synapse/issues/12594)) - Fix a bug introduced in Synapse 1.53.0 where bundled aggregations for annotations/edits were incorrectly calculated. ([\#12633](https://github.com/matrix-org/synapse/issues/12633)) - Fix a long-standing bug where rooms containing power levels with string values could not be upgraded. ([\#12657](https://github.com/matrix-org/synapse/issues/12657)) - Prevent memory leak from reoccurring when presence is disabled. ([\#12656](https://github.com/matrix-org/synapse/issues/12656)) Updates to the Docker image --------------------------- - Explicitly opt-in to using [BuildKit-specific features](https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/syntax.md) in the Dockerfile. This fixes issues with building images in some GitLab CI environments. ([\#12541](https://github.com/matrix-org/synapse/issues/12541)) - Update the "Build docker images" GitHub Actions workflow to use `docker/metadata-action` to generate docker image tags, instead of a custom shell script. Contributed by @henryclw. ([\#12573](https://github.com/matrix-org/synapse/issues/12573)) Improved Documentation ---------------------- - Update SQL statements and replace use of old table `user_stats_historical` in docs for Synapse Admins. ([\#12536](https://github.com/matrix-org/synapse/issues/12536)) - Add missing linebreak to `pipx` install instructions. ([\#12579](https://github.com/matrix-org/synapse/issues/12579)) - Add information about the TCP replication module to docs. ([\#12621](https://github.com/matrix-org/synapse/issues/12621)) - Fixes to the formatting of `README.rst`. ([\#12627](https://github.com/matrix-org/synapse/issues/12627)) - Fix docs on how to run specific Complement tests using the `complement.sh` test runner. ([\#12664](https://github.com/matrix-org/synapse/issues/12664)) Deprecations and Removals ------------------------- - Remove unstable identifiers from [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069). ([\#12596](https://github.com/matrix-org/synapse/issues/12596)) - Remove the unspecified `m.login.jwt` login type and the unstable `uk.half-shot.msc2778.login.application_service` from [MSC2778](https://github.com/matrix-org/matrix-doc/pull/2778). ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) - Synapse now requires at least Python 3.7.1 (up from 3.7.0), for compatibility with the latest Twisted trunk. ([\#12613](https://github.com/matrix-org/synapse/issues/12613)) Internal Changes ---------------- - Use supervisord to supervise Postgres and Caddy in the Complement image to reduce restart time. ([\#12480](https://github.com/matrix-org/synapse/issues/12480)) - Immediately retry any requests that have backed off when a server comes back online. ([\#12500](https://github.com/matrix-org/synapse/issues/12500)) - Use `make_awaitable` instead of `defer.succeed` for return values of mocks in tests. ([\#12505](https://github.com/matrix-org/synapse/issues/12505)) - Consistently check if an object is a `frozendict`. ([\#12564](https://github.com/matrix-org/synapse/issues/12564)) - Protect module callbacks with read semantics against cancellation. ([\#12568](https://github.com/matrix-org/synapse/issues/12568)) - Improve comments and error messages around access tokens. ([\#12577](https://github.com/matrix-org/synapse/issues/12577)) - Improve docstrings for the receipts store. ([\#12581](https://github.com/matrix-org/synapse/issues/12581)) - Use constants for read-receipts in tests. ([\#12582](https://github.com/matrix-org/synapse/issues/12582)) - Log status code of cancelled requests as 499 and avoid logging stack traces for them. ([\#12587](https://github.com/matrix-org/synapse/issues/12587), [\#12663](https://github.com/matrix-org/synapse/issues/12663)) - Remove special-case for `twisted` logger from default log config. ([\#12589](https://github.com/matrix-org/synapse/issues/12589)) - Use `getClientAddress` instead of the deprecated `getClientIP`. ([\#12599](https://github.com/matrix-org/synapse/issues/12599)) - Add link to documentation in Grafana Dashboard. ([\#12602](https://github.com/matrix-org/synapse/issues/12602)) - Reduce log spam when running multiple event persisters. ([\#12610](https://github.com/matrix-org/synapse/issues/12610)) - Add extra debug logging to federation sender. ([\#12614](https://github.com/matrix-org/synapse/issues/12614)) - Prevent remote homeservers from requesting local user device names by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - Add a consistency check on events which we read from the database. ([\#12620](https://github.com/matrix-org/synapse/issues/12620)) - Remove use of the `constantly` library and switch to enums for `EventRedactBehaviour`. Contributed by @andrewdoh. ([\#12624](https://github.com/matrix-org/synapse/issues/12624)) - Remove unused code related to receipts. ([\#12632](https://github.com/matrix-org/synapse/issues/12632)) - Minor improvements to the scripts for running Synapse in worker mode under Complement. ([\#12637](https://github.com/matrix-org/synapse/issues/12637)) - Move `pympler` back in to the `all` extras. ([\#12652](https://github.com/matrix-org/synapse/issues/12652)) - Fix spelling of `M_UNRECOGNIZED` in comments. ([\#12665](https://github.com/matrix-org/synapse/issues/12665)) - Release script: confirm the commit to be tagged before tagging. ([\#12556](https://github.com/matrix-org/synapse/issues/12556)) - Fix a typo in the announcement text generated by the Synapse release development script. ([\#12612](https://github.com/matrix-org/synapse/issues/12612)) - Fix scripts-dev to pass typechecking. ([\#12356](https://github.com/matrix-org/synapse/issues/12356)) - Add some type hints to datastore. ([\#12485](https://github.com/matrix-org/synapse/issues/12485)) - Remove unused `# type: ignore`s. ([\#12531](https://github.com/matrix-org/synapse/issues/12531)) - Allow unused `# type: ignore` comments in bleeding edge CI jobs. ([\#12576](https://github.com/matrix-org/synapse/issues/12576)) - Remove redundant lines of config from `mypy.ini`. ([\#12608](https://github.com/matrix-org/synapse/issues/12608)) - Update to mypy 0.950. ([\#12650](https://github.com/matrix-org/synapse/issues/12650)) - Use `Concatenate` to better annotate `_do_execute`. ([\#12666](https://github.com/matrix-org/synapse/issues/12666)) - Use `ParamSpec` to refine type hints. ([\#12667](https://github.com/matrix-org/synapse/issues/12667)) - Fix mypy against latest pillow stubs. ([\#12671](https://github.com/matrix-org/synapse/issues/12671)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmJ6UDoACgkQkD7OEIo5 3t3XMw/9GfROfC///lio77EhdI0lh39bkgvfqkFE/wRYtTs4n3ZSiclgVBnNmgnN WnLvjL/4wXRjzJZ8vcO+qG0OasT3H9l5xdGE+7h8oUMIYCG7Xdyx37xnhv5IC8Y5 dAjqs2mMnIWnAqyOAVZQVgmNLDhRAb9YGCJ3fJY9cV8dmzr8/RzR8gXrFPaBT9Nj w5Xag0jkiJuff4+Y5oan2yBxMvHT/zAb8rQf5wNjen00lwYHSAr/5aiAsbnHcMYM q0ZahVB/hVaA5GqxwrySlE0mqrPP6M/CpbcLr1h8LlmLdgA6f3vcf/sREGq6wCRK Z8yYXM4RyvNTyYirQfnP5QseVazJqcCY0pCXrMnQxwXda7nSDKjXo0WFBmyIQpK4 YqDvlOhECr+Pcac/EAviH2OEvTMBg4cUs1xdm4/CBElIOZQPyXHJ0DLku8R0CRx/ i01fN0I/r/wX1Oliy4wFJgSYt/uUQzZaJmRieK8fznlFibM3Gk1GvniX0M5Hu6cZ PQuHdPqRxQzvBmEAA1hxTfyOaDeP3g29NnOz9cjsBiAVNqUbEV5KFusjwksI4kcT Bsdk+v/i8/Kx6t0ovRI2i3JJAFNWmUzpY0iDzY3kJCn1YmEMZ7rs+e5qRmv2eBLW oS9dhLGsW7A/mJC6fLM+CATwbFiL/SqB5ocnl4POodZ/b27eDyw= =NPHq -----END PGP SIGNATURE----- gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmJ6V/YACgkQkD7OEIo5 3t0ANA/7BZ762LAjLNsFvJVxnH8LjDEjsjCyjHQ/zzVkAete3354zcW/mqN2YzMl shaxHucfZ9sKCXlOSuwY9N+1Q24ALMAb8QebCQZjNamxKqddpMD0+ijeaKRoFq8P 6VY5saL+rjW0g2QaKE/IHc99UKnw/cNN/vGa3xc3dJFRiiNkK95jS8R7aaaT2mXB 9frbbN0Q45Q6JTU9qJTP6jqdYmKZNjvIHBJcEXkstGqS8NPJXpfVKMZIgTj/8nGL RVJqOStsnHdx4vywZ76GPTAxQ+ZjXMilIbz+bF/6Zw1SCJEZfwFOelYApwMi0qU7 yDK7xeokKxzXyykzmptmiqmePCbr9fHbk+BJtE7VblMdj7OaM7jX7foSX6J1elIp zwDwBK0VH3CJzk9SRoy4JW3PI9K45DZodev33CT+sT39/wYTiV3mbGIYkgP8oSDH rd588QZDovVDy6NWzxkT0MsutHE5Rhx2aP+hkIFDHL4WWnKeFRD5HbiZfg/eC6r0 0nPRY2CCikvqLRqefTi4dgxb+twVBnioPZiDBTEKA/M1/qVg978SIpdHsfmaDJf9 BzWsvfsns0t54J2QnazOjKx2yxIYH6pZ2VFnrb47404O5O3+TuKZL9eX8oNZeBFl JKZKD2xii/ktkw5p27RxEpBJ13hrssN+RMd0JrvS3LTa5G9aIUM= =2gaD -----END PGP SIGNATURE----- Merge tag 'v1.59.0rc1' into develop Synapse 1.59.0rc1 (2022-05-10) ============================== This release makes several changes that server administrators should be aware of: - Device name lookup over federation is now disabled by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - The `synapse.app.appservice` and `synapse.app.user_dir` worker application types are now deprecated. ([\#12452](https://github.com/matrix-org/synapse/issues/12452), [\#12654](https://github.com/matrix-org/synapse/issues/12654)) See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1590) for more details. Additionally, this release removes the non-standard `m.login.jwt` login type from Synapse. It can be replaced with `org.matrix.login.jwt` for identical behaviour. This is only used if `jwt_config.enabled` is set to `true` in the configuration. ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) Features -------- - Support [MSC3266](https://github.com/matrix-org/matrix-doc/pull/3266) room summaries over federation. ([\#11507](https://github.com/matrix-org/synapse/issues/11507)) - Implement [changes](`4a77139249`) to [MSC2285 (hidden read receipts)](https://github.com/matrix-org/matrix-spec-proposals/pull/2285). Contributed by @SimonBrandner. ([\#12168](https://github.com/matrix-org/synapse/issues/12168), [\#12635](https://github.com/matrix-org/synapse/issues/12635), [\#12636](https://github.com/matrix-org/synapse/issues/12636), [\#12670](https://github.com/matrix-org/synapse/issues/12670)) - Extend the [module API](https://github.com/matrix-org/synapse/blob/release-v1.59/synapse/module_api/__init__.py) to allow modules to change actions for existing push rules of local users. ([\#12406](https://github.com/matrix-org/synapse/issues/12406)) - Add the `notify_appservices_from_worker` configuration option (superseding `notify_appservices`) to allow a generic worker to be designated as the worker to send traffic to Application Services. ([\#12452](https://github.com/matrix-org/synapse/issues/12452)) - Add the `update_user_directory_from_worker` configuration option (superseding `update_user_directory`) to allow a generic worker to be designated as the worker to update the user directory. ([\#12654](https://github.com/matrix-org/synapse/issues/12654)) - Add new `enable_registration_token_3pid_bypass` configuration option to allow registrations via token as an alternative to verifying a 3pid. ([\#12526](https://github.com/matrix-org/synapse/issues/12526)) - Implement [MSC3786](https://github.com/matrix-org/matrix-spec-proposals/pull/3786): Add a default push rule to ignore `m.room.server_acl` events. ([\#12601](https://github.com/matrix-org/synapse/issues/12601)) - Add new `mau_appservice_trial_days` configuration option to specify a different trial period for users registered via an appservice. ([\#12619](https://github.com/matrix-org/synapse/issues/12619)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where the latest thread reply provided failed to include the proper bundled aggregations. ([\#12273](https://github.com/matrix-org/synapse/issues/12273)) - Fix a bug introduced in Synapse 1.22.0 where attempting to send a large amount of read receipts to an application service all at once would result in duplicate content and abnormally high memory usage. Contributed by Brad & Nick @ Beeper. ([\#12544](https://github.com/matrix-org/synapse/issues/12544)) - Fix a bug introduced in Synapse 1.57.0 which could cause `Failed to calculate hosts in room` errors to be logged for outbound federation. ([\#12570](https://github.com/matrix-org/synapse/issues/12570)) - Fix a long-standing bug where status codes would almost always get logged as `200!`, irrespective of the actual status code, when clients disconnect before a request has finished processing. ([\#12580](https://github.com/matrix-org/synapse/issues/12580)) - Fix race when persisting an event and deleting a room that could lead to outbound federation breaking. ([\#12594](https://github.com/matrix-org/synapse/issues/12594)) - Fix a bug introduced in Synapse 1.53.0 where bundled aggregations for annotations/edits were incorrectly calculated. ([\#12633](https://github.com/matrix-org/synapse/issues/12633)) - Fix a long-standing bug where rooms containing power levels with string values could not be upgraded. ([\#12657](https://github.com/matrix-org/synapse/issues/12657)) - Prevent memory leak from reoccurring when presence is disabled. ([\#12656](https://github.com/matrix-org/synapse/issues/12656)) Updates to the Docker image --------------------------- - Explicitly opt-in to using [BuildKit-specific features](https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/syntax.md) in the Dockerfile. This fixes issues with building images in some GitLab CI environments. ([\#12541](https://github.com/matrix-org/synapse/issues/12541)) - Update the "Build docker images" GitHub Actions workflow to use `docker/metadata-action` to generate docker image tags, instead of a custom shell script. Contributed by @henryclw. ([\#12573](https://github.com/matrix-org/synapse/issues/12573)) Improved Documentation ---------------------- - Update SQL statements and replace use of old table `user_stats_historical` in docs for Synapse Admins. ([\#12536](https://github.com/matrix-org/synapse/issues/12536)) - Add missing linebreak to `pipx` install instructions. ([\#12579](https://github.com/matrix-org/synapse/issues/12579)) - Add information about the TCP replication module to docs. ([\#12621](https://github.com/matrix-org/synapse/issues/12621)) - Fixes to the formatting of `README.rst`. ([\#12627](https://github.com/matrix-org/synapse/issues/12627)) - Fix docs on how to run specific Complement tests using the `complement.sh` test runner. ([\#12664](https://github.com/matrix-org/synapse/issues/12664)) Deprecations and Removals ------------------------- - Remove unstable identifiers from [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069). ([\#12596](https://github.com/matrix-org/synapse/issues/12596)) - Remove the unspecified `m.login.jwt` login type and the unstable `uk.half-shot.msc2778.login.application_service` from [MSC2778](https://github.com/matrix-org/matrix-doc/pull/2778). ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) - Synapse now requires at least Python 3.7.1 (up from 3.7.0), for compatibility with the latest Twisted trunk. ([\#12613](https://github.com/matrix-org/synapse/issues/12613)) Internal Changes ---------------- - Use supervisord to supervise Postgres and Caddy in the Complement image to reduce restart time. ([\#12480](https://github.com/matrix-org/synapse/issues/12480)) - Immediately retry any requests that have backed off when a server comes back online. ([\#12500](https://github.com/matrix-org/synapse/issues/12500)) - Use `make_awaitable` instead of `defer.succeed` for return values of mocks in tests. ([\#12505](https://github.com/matrix-org/synapse/issues/12505)) - Consistently check if an object is a `frozendict`. ([\#12564](https://github.com/matrix-org/synapse/issues/12564)) - Protect module callbacks with read semantics against cancellation. ([\#12568](https://github.com/matrix-org/synapse/issues/12568)) - Improve comments and error messages around access tokens. ([\#12577](https://github.com/matrix-org/synapse/issues/12577)) - Improve docstrings for the receipts store. ([\#12581](https://github.com/matrix-org/synapse/issues/12581)) - Use constants for read-receipts in tests. ([\#12582](https://github.com/matrix-org/synapse/issues/12582)) - Log status code of cancelled requests as 499 and avoid logging stack traces for them. ([\#12587](https://github.com/matrix-org/synapse/issues/12587), [\#12663](https://github.com/matrix-org/synapse/issues/12663)) - Remove special-case for `twisted` logger from default log config. ([\#12589](https://github.com/matrix-org/synapse/issues/12589)) - Use `getClientAddress` instead of the deprecated `getClientIP`. ([\#12599](https://github.com/matrix-org/synapse/issues/12599)) - Add link to documentation in Grafana Dashboard. ([\#12602](https://github.com/matrix-org/synapse/issues/12602)) - Reduce log spam when running multiple event persisters. ([\#12610](https://github.com/matrix-org/synapse/issues/12610)) - Add extra debug logging to federation sender. ([\#12614](https://github.com/matrix-org/synapse/issues/12614)) - Prevent remote homeservers from requesting local user device names by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - Add a consistency check on events which we read from the database. ([\#12620](https://github.com/matrix-org/synapse/issues/12620)) - Remove use of the `constantly` library and switch to enums for `EventRedactBehaviour`. Contributed by @andrewdoh. ([\#12624](https://github.com/matrix-org/synapse/issues/12624)) - Remove unused code related to receipts. ([\#12632](https://github.com/matrix-org/synapse/issues/12632)) - Minor improvements to the scripts for running Synapse in worker mode under Complement. ([\#12637](https://github.com/matrix-org/synapse/issues/12637)) - Move `pympler` back in to the `all` extras. ([\#12652](https://github.com/matrix-org/synapse/issues/12652)) - Fix spelling of `M_UNRECOGNIZED` in comments. ([\#12665](https://github.com/matrix-org/synapse/issues/12665)) - Release script: confirm the commit to be tagged before tagging. ([\#12556](https://github.com/matrix-org/synapse/issues/12556)) - Fix a typo in the announcement text generated by the Synapse release development script. ([\#12612](https://github.com/matrix-org/synapse/issues/12612)) - Fix scripts-dev to pass typechecking. ([\#12356](https://github.com/matrix-org/synapse/issues/12356)) - Add some type hints to datastore. ([\#12485](https://github.com/matrix-org/synapse/issues/12485)) - Remove unused `# type: ignore`s. ([\#12531](https://github.com/matrix-org/synapse/issues/12531)) - Allow unused `# type: ignore` comments in bleeding edge CI jobs. ([\#12576](https://github.com/matrix-org/synapse/issues/12576)) - Remove redundant lines of config from `mypy.ini`. ([\#12608](https://github.com/matrix-org/synapse/issues/12608)) - Update to mypy 0.950. ([\#12650](https://github.com/matrix-org/synapse/issues/12650)) - Use `Concatenate` to better annotate `_do_execute`. ([\#12666](https://github.com/matrix-org/synapse/issues/12666)) - Use `ParamSpec` to refine type hints. ([\#12667](https://github.com/matrix-org/synapse/issues/12667)) - Fix mypy against latest pillow stubs. ([\#12671](https://github.com/matrix-org/synapse/issues/12671))	2022-05-10 13:17:56 +01:00
Patrick Cloke	b44fbdffa4	Move free functions into PushRuleEvaluatorForEvent. (#12677 ) * Move `_condition_checker` into `PushRuleEvaluatorForEvent`. * Move the condition cache into `PushRuleEvaluatorForEvent`. * Improve docstrings. * Inline a method which is only called once.	2022-05-10 07:54:30 -04:00
Patrick Cloke	02cdace707	Add class-diagrams and notes for push. (#12676 )	2022-05-10 07:43:34 -04:00
David Robertson	2bae6d93c9	I manually added O's change, remove newsfile	2022-05-10 11:17:42 +01:00
reivilibre	699192fc1a	Add the `update_user_directory_from_worker` configuration option (superseding `update_user_directory`) to allow a generic worker to be designated as the worker to update the user directory. (#12654 ) Co-authored-by: Shay <hillerys@element.io>	2022-05-10 11:08:45 +01:00
David Robertson	e5fd23fb6f	1.59.0rc1	2022-05-10 10:45:13 +01:00
Erik Johnston	8dd3e0e084	Immediately retry any requests that have backed off when a server comes back online. (#12500 ) Otherwise it can take up to a minute for any in-flight `/send` requests to be retried.	2022-05-10 10:39:54 +01:00
Šimon Brandner	ade3008821	Implement MSC3786: Add a default push rule to ignore m.room.server_acl events (#12601 ) Fixes vector-im/element-web#20788 Implements matrix-org/matrix-spec-proposals#3786	2022-05-10 08:57:36 +01:00
Shay	d80a7ab151	Update `replication.md` with info on TCP module structure (#12621 )	2022-05-09 14:46:43 -07:00
Dirk Klimpel	615d96ad6e	Update SQL statements in docs for Synapse Admins (#12536 )	2022-05-09 14:43:02 -07:00
Richard van der Hoff	34e84fee68	Tweaks to workers-under-complement (#12637 ) * Bump the HS startup timeout * Log prefixes for more processes * Bump the overall timeout	2022-05-09 22:41:06 +01:00
Val Lorentz	bf0c3ca20a	Fix inconsistent spelling of 'M_UNRECOGNIZED'. (#12665 )	2022-05-09 20:29:07 +00:00
Sean Quah	a00462dd99	Implement cancellation support/protection for module callbacks (#12568 ) There's no guarantee that module callbacks will handle cancellation appropriately. Protect module callbacks with read semantics from cancellation and avoid swallowing `CancelledError`s that arise. Other module callbacks, such as the `on_*` callbacks, are presumed to live on code paths that involve writes and aren't cancellation-friendly. These module callbacks have been left alone. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-09 12:31:14 +01:00
David Robertson	8de0facaae	Fix mypy against latest pillow stubs (#12671 )	2022-05-09 10:48:14 +00:00
Sean Quah	41a882e62d	Update changelog for #12587 to be more accurate (#12663 ) #12587 has fallen on the wrong side of the release cutoff to the rest of the related PRs. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-09 11:34:39 +01:00
David Robertson	fa0eab9c8e	Use `ParamSpec` in a few places (#12667 )	2022-05-09 10:27:39 +00:00
Erik Johnston	c5969b346d	Don't error on unknown receipt types (#12670 ) Fixes #12669	2022-05-09 11:09:19 +01:00
Sheogorath	77258b6725	docs(contrib): Add link to documentation in dashboard (#12602 )	2022-05-09 10:08:31 +00:00
Eric Eastwood	18d6c18aa1	Fix docs on how to run specific Complement tests after recent `complement.sh` change (#12664 )	2022-05-09 10:38:32 +01:00
David Robertson	26c1ad71c5	Use `Concatenate` to annotate `do_execute` (#12666 )	2022-05-09 10:28:38 +01:00
David Robertson	0ce2201932	Move `pympler` back into the `all` extras (#12652 ) * Move `pympler` back into the `all` extras Undoes a change I made in #12381. I can't fully remember my reasoning, but this changed the contents of the debian packages in a backwards incompatible way. We're not aware of anyone who's been bitten by this, but we still want to fix it. To the reviewer: please be convinced that the debian packages will still contain pympler after this change. * Debian changelog entry to keep the linter happy	2022-05-07 13:40:58 +01:00
David Robertson	051a1c3f22	Convert stringy power levels to integers on room upgrade (#12657 )	2022-05-07 13:37:29 +01:00
Erik Johnston	4337d33a73	Prevent memory leak from reoccurring when presence is disabled. (#12656 )	2022-05-06 16:41:57 +00:00
David Robertson	2607b3e181	Update mypy to 0.950 and fix complaints (#12650 )	2022-05-06 12:35:20 +00:00
reivilibre	c2d50e9f6c	Add the `notify_appservices_from_worker` configuration option (superseding `notify_appservices`) to allow a generic worker to be designated as the worker to send traffic to Application Services. (#12452 )	2022-05-06 11:43:53 +01:00
DeepBlueV7.X	a377a43386	Support MSC3266 room summaries over federation (#11507 ) Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>	2022-05-05 15:25:00 +01:00
Šimon Brandner	ef86cf3d28	Update `_on_new_receipts()` to work with MSC2285 changes. (#12636 )	2022-05-05 13:25:51 +00:00
reivilibre	07fa53ec40	Improve comments and error messages around access tokens. (#12577 )	2022-05-05 13:39:59 +01:00
Henry	b8fa24b022	Use `docker/metadata-action` to generate docker image tags (#12573 ) Update the "Build docker images" GitHub Actions workflow to use `docker/metadata-action` to generate docker image tags, instead of a custom shell script. Signed-off-by: Henry <97804910+henryclw@users.noreply.github.com>	2022-05-05 12:36:42 +00:00
Šimon Brandner	9ae0253f4e	Use `private` instead of `hidden` in MSC2285 related code. (#12635 )	2022-05-05 12:31:25 +00:00
Patrick Cloke	f90d381c7b	Edits/annotations should not have any bundled aggregations calculated. (#12633 ) Fixes a regression from `8b309adb43` (#11660) and `b65acead42` (#11752) where events which themselves were an edit or an annotation could have bundled aggregations calculated, which is not allowed.	2022-05-05 08:15:12 -04:00
Patrick Cloke	ddc8bba00f	Remove unused receipt datastore methods. (#12632 ) The last usage was removed in `5a1dd297c3` (#8059).	2022-05-05 07:51:19 -04:00
Will Hunt	cc7656099d	Fix typo in some instances of enable_registration_token_3pid_bypass. (#12639 )	2022-05-05 07:11:52 -04:00
Erik Johnston	c0379d6e5b	Reduce log spam when running multiple event persisters (#12610 )	2022-05-05 10:20:23 +01:00
Will Hunt	2d74a8c178	Add `mau_appservice_trial_days` config (#12619 ) * Add mau_appservice_trial_days * Add a test * Tweaks * changelog * Ensure we sync after the delay * Fix types * Add config statement * Fix test * Reinstate logging that got removed * Fix feature name	2022-05-04 19:33:26 +01:00
Patrick Cloke	7fbf42499d	Use `getClientAddress` instead of `getClientIP`. (#12599 ) getClientIP was deprecated in Twisted 18.4.0, which also added getClientAddress. The Synapse minimum version for Twisted is currently 18.9.0, so all supported versions have the new API.	2022-05-04 14:11:21 -04:00
Šimon Brandner	116a4c8340	Implement changes to MSC2285 (hidden read receipts) (#12168 ) * Changes hidden read receipts to be a separate receipt type (instead of a field on `m.read`). * Updates the `/receipts` endpoint to accept `m.fully_read`.	2022-05-04 11:59:22 -04:00
Andrew Morgan	332cce8dcf	Disable device name lookup over federation by default (#12616 )	2022-05-04 16:41:40 +01:00
Patrick Cloke	ba3fd54bad	Remove unstable/unspecced login types. (#12597 ) * `m.login.jwt`, which was never specced and has been deprecated since Synapse 1.16.0. (`org.matrix.login.jwt` can be used instead.) * `uk.half-shot.msc2778.login.application_service`, which was stabilized as part of the Matrix spec v1.2 release.	2022-05-04 13:53:21 +00:00
Sean Quah	b2df0716bc	Improve logging for cancelled requests (#12587 ) Don't log stack traces for cancelled requests and use a custom HTTP status code of 499. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-04 13:38:55 +01:00
Patrick Cloke	75dff3dc98	Include bundled aggregations for the latest event in a thread. (#12273 ) The `latest_event` field of the bundled aggregations for `m.thread` relations did not include bundled aggregations itself. This resulted in clients needing to immediately request the event from the server (and thus making it useless that the latest event itself was serialized instead of just including an event ID).	2022-05-04 08:38:18 -04:00
andrew do	01e625513a	remove constantly lib use and switch to enums. (#12624 )	2022-05-04 11:26:11 +00:00
Richard van der Hoff	873d467976	Fixes to the formatting of README.rst (#12627 ) Fixes a couple of formatting errors which were introduced in #12475.	2022-05-04 11:02:19 +01:00
Richard van der Hoff	96e0cdbc5a	Add a consistency check on events read from the database (#12620 ) I've seen a few errors which can only plausibly be explained by the calculated event id for an event being different from the ID of the event in the database. It should be cheap to check this, so let's do so and raise an exception.	2022-05-03 21:27:52 +01:00
David Robertson	9ce51a47f6	Bump Synapse minimum Python version to 3.7.1 (#12613 )	2022-05-03 19:22:06 +01:00
Patrick Cloke	aa5f5ede33	Remove unstable identifiers for MSC3069. (#12596 )	2022-05-03 12:43:12 -04:00
Richard van der Hoff	d66d68f917	Add extra debug logging to federation sender (#12614 ) ... in order to debug some problems we've been having with certain events not being sent when expected.	2022-05-03 16:32:40 +01:00
Andrew Morgan	c4514b97db	Add missing space before 'docker' link in release announcement script (#12612 )	2022-05-03 14:46:42 +00:00
Richard van der Hoff	db2edf5a65	Exclude OOB memberships from the federation sender (#12570 ) As the comment says, there is no need to process such events, and indeed we need to avoid doing so. Fixes #12509.	2022-05-03 12:47:56 +00:00
David Robertson	bf2fea8f7d	Add sanity checks to the release script (#12556 ) Check we're on the right branch before tagging, and on the right tag before uploading * Abort if we're on the wrong branch * Check we have the right tag checked out * Clarify that `publish` only releases to GitHub	2022-05-03 10:50:03 +00:00
Erik Johnston	ae7858f184	Fix race when persisting an event and deleting a room (#12594 ) This works by taking a row level lock on the `rooms` table at the start of both transactions, ensuring that they don't run at the same time. In the event persistence transaction we also check that there is an entry still in the `rooms` table. I can't figure out how to do this in SQLite. I was just going to lock the table, but it seems that we don't support that in SQLite either, so I'm really confused as to how we maintain integrity in SQLite when using `lock_table`....	2022-05-03 11:47:21 +01:00
David Robertson	01dcf7532d	Prune mypy ignore_missing_imports list (#12608 )	2022-05-03 11:03:20 +01:00
Richard van der Hoff	8d156ec0ba	Remove special-case for `twisted` logger (#12589 ) This was originally added when we first added a `MemoryHandler` to the default log config back in https://github.com/matrix-org/synapse/pull/8040, to ensure that we didn't explode with an infinite loop if there was an error formatting the logs. Since then, we made additional improvements to logging which make this workaround redundant. In particular: * we no longer attempt to log un-UTF8-decodable byte sequences, which were the most likely cause of an error in the first place. * https://github.com/matrix-org/synapse/pull/8268 ensures that in the unlikely case that there is an error, it won't cause an infinite loop.	2022-04-29 22:05:18 +01:00
David Robertson	57fac2a234	Allow unused ignores in "bleeding edge" CI (#12576 ) * Allow unused ignores in "bleeding edge" CI Where "bleeding edge" means the Twisted Trunk and Latest Deps jobs. Follow up from #12531. Resolves #12574. * Use `--extras all` in latest deps mypy CI Twisted trunk job already does this. Missed in #12531. * changelog	2022-04-29 17:57:23 +01:00
Patrick Cloke	3ae56d125c	Improve the docstrings for the receipts store. (#12581 )	2022-04-28 17:58:58 +00:00
Šimon Brandner	0d9eaa19fd	Use constants for receipt types in tests. (#12582 )	2022-04-28 13:34:33 -04:00
Sean Quah	0b684b59e5	Fix logging of incorrect status codes for disconnected requests (#12580 ) The status code of requests must always be set, regardless of client disconnection, otherwise they will always be logged as 200!. Broken for `respond_with_json` in `f48792eec4`. Broken for `respond_with_json_bytes` in `3e58ce72b4`. Broken for `respond_with_html_bytes` in `ea26e9a98b`. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-28 15:49:50 +00:00
DeepBlueV7.X	629aa51743	Add linebreak to pipx install quote in README (#12579 )	2022-04-28 13:54:46 +01:00
David Robertson	5d3509dfda	Revert accidental direct-to-develop commits. This reverts commit `5a320baa45`. This reverts commit `f282d5fc11`. This reverts commit `ce6ecdd4b4`.	2022-04-28 11:33:05 +01:00
David Robertson	5a320baa45	changelog	2022-04-28 11:31:26 +01:00
Sean Quah	78b99de7c2	Prefer `make_awaitable` over `defer.succeed` in tests (#12505 ) When configuring the return values of mocks, prefer awaitables from `make_awaitable` over `defer.succeed`. `Deferred`s are only awaitable once, so it is inappropriate for a mock to return the same `Deferred` multiple times. Also update `run_in_background` to support functions that return arbitrary awaitables. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-27 14:58:26 +01:00
Brendan Abolivier	5ef673de4f	Add a module API to allow modules to edit push rule actions (#12406 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-04-27 13:55:33 +00:00
reivilibre	d743b25c8f	Use supervisord to supervise Postgres and Caddy in the Complement image. (#12480 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-04-27 14:39:41 +01:00
David Robertson	30c8e7e408	Make `scripts-dev` pass `mypy --disallow-untyped-defs` (#12356 ) Not enforced in config yet. One day.	2022-04-27 13:10:31 +00:00
David Robertson	6463244375	Remove unused `# type: ignore`s (#12531 ) Over time we've begun to use newer versions of mypy, typeshed, stub packages---and of course we've improved our own annotations. This makes some type ignore comments no longer necessary. I have removed them. There was one exception: a module that imports `select.epoll`. The ignore is redundant on Linux, but I've kept it ignored for those of us who work on the source tree using not-Linux. (#11771) I'm more interested in the config line which enforces this. I want unused ignores to be reported, because I think it's useful feedback when annotating to know when you've fixed a problem you had to previously ignore. * Installing extras before typechecking Lacking an easy way to install all extras generically, let's bite the bullet and make install the hand-maintained `all` extra before typechecking. Now that https://github.com/matrix-org/backend-meta/pull/6 is merged to the release/v1 branch.	2022-04-27 14:03:44 +01:00
Patrick Cloke	8a23bde823	Consistently use collections.abc.Mapping to check frozendict. (#12564 )	2022-04-27 09:00:07 -04:00
Will Hunt	e8d1ec0e92	Add option to enable token registration without requiring 3pids (#12526 )	2022-04-27 12:57:53 +00:00
Dirk Klimpel	b76f1a4d5f	Add some type hints to datastore (#12485 )	2022-04-27 13:05:00 +01:00
Nick Mills-Barrett	63ba9ba38b	Bound ephemeral events by key (#12544 ) Co-authored-by: Brad Murray <bradtgmurray@gmail.com> Co-authored-by: Andrew Morgan <andrewm@element.io>	2022-04-26 20:14:21 +01:00
David Robertson	9986621bc8	Synapse 1.58.0rc2 (2022-04-26) ============================== This release candidate fixes bugs related to Synapse 1.58.0rc1's logic for handling device list updates. Bugfixes -------- - Fix a bug introduced in Synapse 1.58.0rc1 where the main process could consume excessive amounts of CPU and memory while handling sentry logging failures. ([\#12554](https://github.com/matrix-org/synapse/issues/12554)) - Fix a bug introduced in Synapse 1.58.0rc1 where opentracing contexts were not correctly sent to whitelisted remote servers with device lists updates. ([\#12555](https://github.com/matrix-org/synapse/issues/12555)) Internal Changes ---------------- - Reduce unnecessary work when handling remote device list updates. ([\#12557](https://github.com/matrix-org/synapse/issues/12557)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmJoINsACgkQkD7OEIo5 3t0ETA//VANpmz0ykLeBA0XRW0eifQkHnQyBoZQtXL+IUmV9FZcX2q/akuQ5toJL p+AAJ6bKfYSwxyxgw3bJhftOVsIpG546auqVHvRXznlHk9vXKnuYevOz1ifnYSih j58fYTWnYZYv04uADbTX4fnJjiPDhiRYCZF6RiB5u1HGl1gr+Q1kJI7CL289/d1V MgBsJfzjHw+M7Vl2doddINnG65oPzrntMysv+PAma+WFxjQvLQoiaui96kaDM/2W XdFQh4k3OeyhBHKVk3+KrV9zPEh16JuymKDWoAnaMeIBBPwtngZp8tkEr4rSW8gP fOGDOMfqu896WqyT20fVhWzrsi24UjCw2TxY1C2UdCOoNqVJvMMMZ/aB129+8S/5 65FOI77Oqmn2KGQ5+75hun3a9UcsRD+9iitg2wajxlle5yk6ZFi095aZVf94ls8d uSWakqvFr6PAY8TnvthQNsAj00LJVqKKH3RrNw7pDOX7QWE1qbcbPHFrtCMHC5Bz Z1/LDqNCxhwruPEghmg+0ToRama5uYdeCMzqECZ8GmzhlouezMaFK6bFH1SGwNbo Idx60qwCXK3vHka3MVSqLg15gBGj1dQEJt8q/FVrYDemEFlNshPydJTbtbIOfj/R VEZa12gbtqFenPMQyDuzbFqgwirbeYQQHIRltQB3yDeggg8j4ng= =FAvF -----END PGP SIGNATURE----- gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmJoJswACgkQkD7OEIo5 3t3u0RAApTbw1tPIFXN9aQWVzBfaYRlw4zFKJlAl4JF6J7QT5qDny9NnhLTKqUPh bMj+IfcPN2nlUM6U6F9Fnu0HQXP9/hyVNLIauvqCnRa2GCb6F7fymSTJSsyUGSZW 0i3FXaR+OaIOqhjphGYx6oaVtGpgg7cKsp8VhVMTZrt0/sjFXxDV6oeaKfe2OpIE 6D4wYh13zS9CzzoNoMUkkqwUr2e+DbsCp5BkjbU8F2abRRpC14QSF4/qH0dfAQ4i A6Lj02Gzv/AcE5e6e3bRYQkt4L8+/di+aY3vbj4jsCqJYFTP4yvdc6iScFALyxXn QNGTZlctuNbR/v6WVQbiFtSyF1GnLos1+7jpEBpGRUk30H68zOwsi+qLZh9r98mB vQ0G2HA/klzdnIvq9DxWLL0PxQZKocdu5CT2ujV+6J7vkKAXmC/0rkDRWdi2qooU uRb3CbAHo4A6GnoqsrhY1i1JuUNbX7Nu2BZsLaiIdp2JTt6OzS/0zfUgCZzPw0u0 1586SlmiSdtXNMOlgpHPVtD71CCq/48tbccsomI1hk5dmiqlZX4hqsHSQY97k422 NV9LNpPo0K5l2Qmegera94Qz0FzCv4TCSDEAXn//lHCZ6eAVARk6Wym0UCOXToqw Xg1igJEkGOkIcwXj6GpG+r8yMdYD52xG6Ud8ZbYTX1glDfVWN4U= =YYmi -----END PGP SIGNATURE----- Merge tag 'v1.58.0rc2' into develop Synapse 1.58.0rc2 (2022-04-26) ============================== This release candidate fixes bugs related to Synapse 1.58.0rc1's logic for handling device list updates. Bugfixes -------- - Fix a bug introduced in Synapse 1.58.0rc1 where the main process could consume excessive amounts of CPU and memory while handling sentry logging failures. ([\#12554](https://github.com/matrix-org/synapse/issues/12554)) - Fix a bug introduced in Synapse 1.58.0rc1 where opentracing contexts were not correctly sent to whitelisted remote servers with device lists updates. ([\#12555](https://github.com/matrix-org/synapse/issues/12555)) Internal Changes ---------------- - Reduce unnecessary work when handling remote device list updates. ([\#12557](https://github.com/matrix-org/synapse/issues/12557))	2022-04-26 18:07:15 +01:00
David Robertson	6b64ee9ec7	1.58.0rc2	2022-04-26 17:16:43 +01:00
Erik Johnston	f59e3f4c90	Mark remote device list updates as already handled (#12557 )	2022-04-26 17:07:21 +01:00
David Robertson	6d89f1239c	Comment out dodgy log-kv (#12554 )	2022-04-26 15:53:06 +01:00
Erik Johnston	c48ab3734e	Fix sending opentracing contexts to remote servers (#12555 )	2022-04-26 14:48:16 +00:00
Jason Robinson	706456de1f	Mark Dockerfile as requiring BuildKit (#12541 ) Co-authored-by: David Robertson <davidr@element.io>	2022-04-26 15:31:52 +01:00
David Robertson	30db7fdb91	1.58.0rc1	2022-04-26 11:15:33 +01:00
Shay	99ab45423a	build debian package for jammy jellyfish (#12543 )	2022-04-26 10:34:59 +01:00
Richard van der Hoff	17d99f758a	Optimise backfill calculation (#12522 ) Try to avoid an OOM by checking fewer extremities. Generally this is a big rewrite of _maybe_backfill, to try and fix some of the TODOs and other problems in it. It's best reviewed commit-by-commit.	2022-04-26 10:27:11 +01:00
Shay	e75c7e3b6d	Add a table of contents to config manual (#12527 ) * Update config_documentation.md	2022-04-25 11:43:59 -07:00
Sean Quah	8a87b4435a	Handle cancellation in `EventsWorkerStore._get_events_from_cache_or_db` (#12529 ) Multiple calls to `EventsWorkerStore._get_events_from_cache_or_db` can reuse the same database fetch, which is initiated by the first call. Ensure that cancelling the first call doesn't cancel the other calls sharing the same database fetch. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-25 19:39:17 +01:00
Sami Olmari	813d728d09	Correct typo in user_admin_api.md device deletion JSON (#12533 ) Signed-off-by: Sami Olmari <sami@olmari.fi>	2022-04-25 12:39:15 +00:00
David Robertson	8bac3e0435	disallow-untyped-defs in `docker` and `stubs` directories (#12528 )	2022-04-25 12:32:35 +00:00
Patrick Cloke	185da8f0f2	Misc. clean-ups to the relations code (#12519 ) * Corrects some typos / copy & paste errors in tests. * Clarifies docstrings. * Removes an unnecessary method.	2022-04-25 08:25:56 -04:00
villepeh	d9b71410c2	Add HAProxy delegation example to docs (#12501 ) Signed-off-by: Ville Petteri Huh	2022-04-25 13:18:18 +01:00
Dirk Klimpel	a36a38b1ca	Add some example configurations for worker (#12492 ) Signed-off-by: Dirk Klimpel <dirk@klimpel.org>	2022-04-25 13:17:03 +01:00
Sean Quah	a50fb411b3	Update `delay_cancellation` to accept any awaitable (#12468 ) This will mainly be useful when dealing with module callbacks, which are all typed as returning `Awaitable`s instead of coroutines or `Deferred`s. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-22 18:20:06 +01:00
Will Hunt	b82fff66df	MSC3202: Fix device_unused_fallback_keys -> device_unused_fallback_key_types (#12520 ) * Fix device_unused_fallback_keys -> device_unused_fallback_key_types * changelog	2022-04-22 16:03:46 +01:00
Richard van der Hoff	f5668f0b4a	Await un-partial-stating after a partial-state join (#12399 ) When we join a room via the faster-joins mechanism, we end up with "partial state" at some points on the event DAG. Many parts of the codebase need to wait for the full state to load. So, we implement a mechanism to keep track of which events have partial state, and wait for them to be fully-populated.	2022-04-21 07:42:03 +01:00
David Robertson	09b4f6e46d	Remove leftover references to setup.py (#12514 ) * Remove leftover references to setup.py Missed in #12478. * Changelog	2022-04-20 18:16:49 +00:00
David Robertson	e5a76ec00b	Dump setuptools; correct pyproject version number (#12478 )	2022-04-20 17:33:20 +01:00
Patrick Cloke	103f51d867	Fix Jinja templating error when generating thumbnail URLs. (#12510 ) scale is meant to be a constant string, not refer to a variable.	2022-04-20 12:03:03 -04:00
David Robertson	ecef741add	Recommend poetry in docs (#12475 ) * Recommend poetry in docs - readme - contributor guide - upgrade notes - new dev cheat sheet for poetry Co-authored-by: Shay <hillerys@element.io> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-04-20 15:18:21 +01:00
Patrick Cloke	d0c1f4ca4c	Remove unnecessary config overrides for MSC3666. (#12511 )	2022-04-20 09:56:59 -04:00
Tulir Asokan	4bc8cb4669	Implement MSC2815: allow room moderators to view redacted event content (#12427 ) Implements matrix-org/matrix-spec-proposals#2815 Signed-off-by: Tulir Asokan <tulir@maunium.net>	2022-04-20 12:57:39 +01:00
David Robertson	eed38c5027	Add CI job to act as a canary for testing against latest dependencies (#12472 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-04-20 12:48:44 +01:00
Erik Johnston	c1482a352a	Fix returned count of delete extremities admin API (#12496 )	2022-04-19 16:49:45 +01:00
Richard van der Hoff	b80bb7e452	Fix `/room/.../event/...` to return the original event after any edits (#12476 ) This is what the MSC (now) requires. Fixes https://github.com/matrix-org/synapse/issues/10310.	2022-04-19 16:42:19 +01:00
Richard van der Hoff	798deb3a10	Fix typo in deb changelogs from release script (#12497 ) The release script used to incorrectly write `New synapse release 1.57.0~rc1.` instead of `New synapse release 1.57.0rc1.`	2022-04-19 16:41:52 +01:00
Jan Christian Grünhage	a1f87f57ff	Implement MSC3383: include destination in X-Matrix auth header (#11398 ) Co-authored-by: Jan Christian Grünhage <jan.christian@gruenhage.xyz> Co-authored-by: Marcus Hoffmann <bubu@bubu1.eu>	2022-04-19 16:23:53 +01:00
Dirk Klimpel	fbdee86004	Fix a link in `README.rst` (#12495 ) * Fix a link in `README.rst` * newsfile	2022-04-19 13:00:41 +00:00
Richard van der Hoff	b121a3ad2b	Back out implementation of MSC2314 (#12474 ) MSC2314 has now been closed, so we're backing out its implementation, which originally happened in #6176. Unfortunately it's not a direct revert, as that PR mixed in a bunch of unrelated changes to tests etc.	2022-04-19 11:17:29 +00:00
Travis Ralston	f8d3ee9570	Fix grammatical error in error message (#12483 ) * Fix grammatical error in error message * changelog	2022-04-18 12:41:55 -06:00
Shay	3c758d9808	Add a manual documenting config file options (#12368 )	2022-04-18 11:32:30 -07:00
Richard van der Hoff	aaaff98202	Dockerfile-workers: reduce the amount we install (#12464 ) This is an attempt to reduce the rebuild time. In short, we reduce the amount of stuff that the dockerfile installs, so as to give a faster startup.	2022-04-14 15:36:49 +01:00
reivilibre	7efddbebef	Update documentation to reflect that `run_background_tasks_on` is no longer experimental. (#12451 ) * Background workers aren't experimental anymore * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> * Stream writers aren't experimental either	2022-04-14 15:25:22 +01:00
Richard van der Hoff	960b4fb409	complement-synapse-workers: factor out separate entry point script (#12467 ) ... with a bit more verbosity.	2022-04-14 14:56:10 +01:00
Dirk Klimpel	a743f7d33e	Replace `federation_reader` with `generic_worker` in docs (#12457 )	2022-04-14 13:09:07 +01:00
Erik Johnston	0b014eb25e	Only send out device list updates for our own users (#12465 ) Broke in #12365	2022-04-14 13:05:31 +01:00
David Robertson	535a689cfc	Reintroduce the lint targets in the linter script (#12455 )	2022-04-14 11:33:06 +01:00
David Robertson	6b3e0ea6bd	Use `poetry` to manage the virtualenv in debian packages (#12449 ) * Use `poetry` to build venv in debian packages Co-authored-by: Dan Callahan <danc@element.io> Co-authored-by: Shay <hillerys@element.io> * Changelog * Only pull in from requirements.txt Addresses the same problem as #12439. * Include `test` and `all` extras `poetry export` helpfully silently ignores an unknown extra Haven't seen this before because it's the only place we export `all` and `test`. I could have __sworm__ that the syntax `--extra "all test"` worked for `poetry install`... * Clean up requirements file on subsequence builds * Fix shell syntax Co-authored-by: Dan Callahan <danc@element.io> Co-authored-by: Shay <hillerys@element.io>	2022-04-14 11:03:24 +01:00
Richard van der Hoff	8af8a9bce5	Dockerfile-workers: give the master its own log config (#12466 ) When we run a worker-mode synapse under docker, everything gets logged to stdout. Currently, output from the workers is tacked with a worker name, for example: ``` 2022-04-13 15:27:56,810 - worker:frontend_proxy1 - synapse.util.caches.lrucache - 154 - INFO - LruCache._expire_old_entries-0 - Dropped 0 items from caches ``` - note `worker:frontend_proxy1`. No such tag is applied to log lines from the master, which makes somewhat confusing reading. To fix this, we generate a dedicated log config file for the master in the same way that we do for the workers, and use that.	2022-04-13 20:50:08 +01:00
Shay	8e2759f2d8	Limit `device_id` size to 512B (#12454 ) *	2022-04-13 10:04:01 -07:00
Andrew Morgan	0922462fc7	docs: Don't render the table of contents on the print page (#12340 )	2022-04-13 08:27:51 -07:00
David Baker	73d8ded0b0	Prevent a sync request from removing a user's busy presence status (#12213 ) In trying to use the MSC3026 busy presence status, the user's status would be set back to 'online' next time they synced. This change makes it so that syncing does not affect a user's presence status if it is currently set to 'busy': it must be removed through the presence API. The MSC defers to implementations on the behaviour of busy presence, so this ought to remain compatible with the MSC.	2022-04-13 16:21:07 +01:00
Nick Mills-Barrett	e3a49f4784	Fix missing sync events during historical batch imports (#12319 ) Discovered after much in-depth investigation in #12281. Closes: #12281 Closes: #3305 Signed off by: Nick Mills-Barrett nick@beeper.com	2022-04-13 11:38:35 +01:00
David Robertson	d24cd17820	Use poetry lockfile in twisted trunk CI job (#12425 ) Fixes #12458 Co-authored-by: Sean Quah <seanq@element.io> Co-authored-by: Dan Callahan <danc@element.io>	2022-04-13 11:26:53 +01:00
Jonathan de Jong	36d8b83888	Rename Mutual Rooms `unstable_features` flag to match MSC (#12445 ) Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>	2022-04-13 10:32:44 +01:00
Shay	32545d2e26	Bump twisted version to the latest in lockfile (#12441 )	2022-04-12 13:46:55 -07:00
David Robertson	5a275a2377	Run "main" trial tests under poetry (#12438 ) * Run "main" trial tests under poetry Olddeps and twisted trunk tests are handled in separate PRs. The PyPy config is a best-effort only; it's completely untested. Pulled out from #12337. * Changelog	2022-04-12 17:41:21 +01:00
David Robertson	58c657322a	Run lints under poetry in CI; remove lint tox jobs (#12434 ) Co-authored-by: Dan Callahan <danc@element.io>	2022-04-12 17:35:48 +01:00
Erik Johnston	aa28110264	Process device list updates asynchronously (#12365 )	2022-04-12 16:50:40 +01:00
Patrick Cloke	4bdbebccb9	Remove the unstable event field for `/send_join` per MSC3083. (#12395 ) This was missed when initially stabilising room version 8 and was left in as a compatibility shim. Most homeservers have upgraded to a version which expects the proper field name, and the failure mode is reasonable (a user on an older server may have to attempt joining the room twice with an obscure error message the first time).	2022-04-12 11:27:45 -04:00
Erik Johnston	ba1588461b	Fix typos in release script docs (#12450 )	2022-04-12 15:12:57 +00:00
Erik Johnston	a468768104	Merge branch 'release-v1.57' into develop	2022-04-12 15:28:41 +01:00
Patrick Cloke	9535fd0f9c	Disable groups/communities by default. (#12344 ) This disables the endpoints (and sync response fields) for groups/communities by default.	2022-04-12 10:20:46 -04:00
Richard van der Hoff	320186319a	Resync state after partial-state join (#12394 ) We work through all the events with partial state, updating the state at each of them. Once it's done, we recalculate the state for the whole room, and then mark the room as having complete state.	2022-04-12 13:23:43 +00:00
Patrick Cloke	86cf6a3a17	Remove references to unstable identifiers from MSC3440. (#12382 ) Removes references to unstable thread relation, unstable identifiers for filtering parameters, and the experimental config flag.	2022-04-12 08:42:03 -04:00
Erik Johnston	641f43ba81	1.57.0rc1	2022-04-12 13:39:35 +01:00
Dirk Klimpel	1783156dbc	Add some type hints to datastore (#12423 ) * Add some type hints to datastore * newsfile * change `Collection` to `List` * refactor return type of `select_users_txn` * correct type hint in `stream.py` * Remove `Optional` in `select_users_txn` * remove not needed return type in `__init__` * Revert change in `get_stream_id_for_event_txn` * Remove import from `Literal`	2022-04-12 11:54:00 +01:00
David Robertson	4e13743738	Poetry: select olddeps using `poetry` (#12407 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-04-12 10:50:11 +00:00
Erik Johnston	3ad74b63e5	Specify tls extra for Twisted dependency. (#12444 ) * Specify `tls` extra for Twisted dependency. It was already pulled in for us by `treq`, but we should be explicit that we do use the `tls` functionality of Twisted directly. * Mark `idna` as dev-dependency This doesn't actually change anything, as `Twisted[tls]` will put it in as a main dependency anyway.	2022-04-12 10:49:02 +00:00
David Robertson	5f8173dd80	Workaround pip bug installing latest treq and not-latest twisted from hashes (#12439 ) The requirements file generated by `poetry export` isn't correctly processed by `pip install -r requirements.txt`. It contains twisted and treq, both pinned to 22.2.0. When `pip` installs treq, it notices that `Twisted[tls]` is required. It then tries to acquire the latest twisted release, only to fail (because this hash isn't listed in the requirements file).From e.g. https://github.com/matrix-org/synapse/runs/5977154990?check_suite_focus=true > ``` > #15 9.204 Collecting Twisted[tls]>=18.7.0 > #15 9.205 ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not: > #15 9.205 Twisted[tls]>=18.7.0 from `38622ff95b/Twisted-22.4.0-py3-none-any.whl (sha256)`=f9f7a91f94932477a9fc3b169d57f54f96c6e74a23d78d9ce54039a7f48928a2 (from treq==22.2.0->-r /synapse/requirements.txt (line 724)) > #15 ERROR: executor failed running [/bin/sh -c pip install --prefix="/install" --no-warn-script-location -r /synapse/requirements.txt]: exit code: 1 > ``` The underlying pip issue is https://github.com/pypa/pip/issues/9644. A comment notes that one can avoid this behaviour with by `pip install`ing with the `--no-deps` flag. Let us do so. (At first glance, the problem looks like https://github.com/python-poetry/poetry/issues/5311, but that was a bug in `poetry install`; this is `poetry export`, whose behaviour is fine AFAICS).	2022-04-12 10:16:01 +01:00
Patrick Cloke	ab3165efb7	Remove experimental configuration flag for MSC3666. (#12436 )	2022-04-11 15:37:46 -04:00
Patrick Cloke	4586119f0b	Add missing type hints to config classes. (#12402 )	2022-04-11 12:07:23 -04:00
Richard van der Hoff	214f3b7d21	Enable certificate checking during complement tests (#12435 )	2022-04-11 16:35:41 +01:00
Patrick Cloke	772bad2562	Do not consider events by ignored users for bundled aggregations (#12235 ) Consider the requester's ignored users when calculating the bundled aggregations. See #12285 / `4df10d3214` for corresponding changes for the `/relations` endpoint.	2022-04-11 10:09:57 -04:00
Richard van der Hoff	3cdf5a1386	Fix up healthcheck generation for workers docker image (#12405 ) This wasn't quite generating the right thing.	2022-04-11 13:38:58 +00:00
David Robertson	961ee75a9b	Disallow untyped defs in synapse._scripts (#12422 ) Of note: * No untyped defs in `register_new_matrix_user` This one might be contraversial. `request_registration` has three dependency-injection arguments used for testing. I'm removing the injection of the `requests` module and using `unitest.mock.patch` in the test cases instead. Doing `reveal_type(requests)` and `reveal_type(requests.get)` before the change: ``` synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "Any" synapse/_scripts/register_new_matrix_user.py:46: note: Revealed type is "Any" ``` And after: ``` synapse/_scripts/register_new_matrix_user.py:44: note: Revealed type is "types.ModuleType" synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "def (url: Union[builtins.str, builtins.bytes], params: Union[Union[_typeshed.SupportsItems[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], typing.Iterable[Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]]], builtins.str, builtins.bytes], None] =, data: Union[Any, None] =, headers: Union[Any, None] =, cookies: Union[Any, None] =, files: Union[Any, None] =, auth: Union[Any, None] =, timeout: Union[Any, None] =, allow_redirects: builtins.bool =, proxies: Union[Any, None] =, hooks: Union[Any, None] =, stream: Union[Any, None] =, verify: Union[Any, None] =, cert: Union[Any, None] =, json: Union[Any, None] =) -> requests.models.Response" ``` * Drive-by comment in `synapse.storage.types` * No untyped defs in `synapse_port_db` This was by far the most painful. I'm happy to break this up into smaller pieces for review if it's not managable as-is.	2022-04-11 12:41:55 +01:00
Richard van der Hoff	5f72ea1bde	Move complement setup stuff into the Synapse repo (#12404 ) Fixes matrix-org/complement#330 (or it will, once we remove the old files). It's not quite a lift-and-shift: I've also taken the opportunity to get rid of the custom CA that we used to use to sign the TLS certs, which has been superceded by the CA exposed by Complement.	2022-04-11 11:39:28 +01:00
reivilibre	85ca963c1a	Add Module API for reading and writing global account data. (#12391 )	2022-04-11 10:05:43 +01:00
David Robertson	98ec375b26	CI: Fix the export-data job to run under poetry (#12418 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-04-08 19:18:54 +00:00
reivilibre	e630722f11	Optimise `_update_client_ips_batch_txn` to batch together database operations. (#12252 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-04-08 15:29:13 +01:00
David Robertson	0cd182f296	Make `synapse._scripts` pass typechecks (#12421 )	2022-04-08 14:00:12 +00:00
David Robertson	dd5cc37aa4	Stop maintaining a list of lint targets in `lint.sh` (#12420 )	2022-04-08 14:36:09 +01:00
David Robertson	95a038c106	Unify HTTP query parameter type hints (#12415 ) * Pull out query param types to `synapse.http.types` * Use QueryParams everywhere * Simplify `encode_query_args` * Add annotation which would have caught #12410	2022-04-08 13:06:51 +01:00
Jorge Florian	2e2d8cc2f9	Update the server notices user profile in room if changed. (#12115 )	2022-04-08 07:51:27 -04:00
David Robertson	7851a2c62f	CI: Get the portdb job to run under poetry (#12412 )	2022-04-08 12:00:05 +01:00
Jorge Florian	78e4d96a4d	Add missing type definitions for scripts in docker folder (#12280 ) Signed-off-by: Jorge Florian <jafn28@gmail.com>	2022-04-08 10:10:58 +00:00
Erik Johnston	7732c4902c	Fix rejecting invites over federation (#12409 ) Currently causes future incremental syncs to fail. Broke by #12191	2022-04-07 15:54:16 +01:00
Erik Johnston	36af768c13	Fix fetching public rooms over federation (#12410 ) Broke by #12364	2022-04-07 14:18:02 +00:00
Patrick Cloke	1a90c1e3af	Do not add groups to sync results if disabled. (#12408 )	2022-04-07 09:29:56 -04:00
Erik Johnston	d1cd96ce29	Add opentracing spans to calls to external cache (#12380 )	2022-04-07 13:18:29 +01:00
David Robertson	3a7e97c7ad	Poetry: use locked environment in Docker images (#12385 )	2022-04-07 11:43:31 +00:00
Patrick Cloke	0bcb651b3f	Support the v1 endpoint for `/relations`. (#12403 ) Now that MSC2675 has passed FCP and the implementation is compliant with the final version.	2022-04-07 07:08:23 -04:00
Eric Eastwood	350062661c	Clarify that we mark as outliers because we don't have any state for them (#12345 ) As discussed at https://github.com/matrix-org/synapse/pull/12179#discussion_r837263852	2022-04-06 16:34:33 -05:00
Eric Eastwood	f931c0602a	Update changelog to describe changes from #12370 relative to `develop` (#12401 )	2022-04-06 14:41:15 -04:00
Patrick Cloke	6902e9ff2b	Remove docs for converting a legacy structured logging config. (#12392 ) And update the upgrade notes to point at old versions of the documentation.	2022-04-06 13:41:14 -04:00
Patrick Cloke	05a37f4008	Remove support for the unstable identifier from MSC3288. (#12398 )	2022-04-06 13:27:46 -04:00
David Robertson	2cf74cf2fc	Narrow the `importlib_metadata` dependency (#12400 )	2022-04-06 17:37:56 +01:00
Richard van der Hoff	6fe757d69e	Fix `synapse_event_persisted_position` metric (#12390 ) Fixes a bug introduced in #11417 where we would only included backfilled events in `synapse_event_persisted_position`	2022-04-06 13:52:39 +00:00
Richard van der Hoff	ae01a7edd3	Update type annotations for compatiblity with prometheus_client 0.14 (#12389 ) Principally, `prometheus_client.REGISTRY.register` now requires its argument to extend `prometheus_client.Collector`. Additionally, `Gauge.set` is now annotated so that passing `Optional[int]` causes an error.	2022-04-06 12:59:04 +00:00
Eric Eastwood	793d03e2c5	Generate historic pagination token for `/messages` when no `?from` token provided (#12370 )	2022-04-06 11:40:28 +01:00
David Robertson	573cd0f92f	Add missing dependency on importlib_metadata (#12384 )	2022-04-05 18:25:56 +00:00
David Robertson	7ec9b06303	Poetry: initial pyproject.toml and poetry.lock (#12381 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-04-05 18:40:56 +01:00
Sean Quah	fd1e7d0fc2	Post 1.56.0 release tidy up (#12379 )	2022-04-05 17:35:20 +01:00
Andrew Morgan	163fd686b5	Update mdbook to 0.4.17 (#12339 ) Update mdbook (the tool used to render the documentation website) to version 0.4.17.	2022-04-05 17:21:58 +01:00
Sean Quah	79e7c2c426	Fix edge case where a `Linearizer` could get stuck (#12358 ) Just after a task acquires a contended `Linearizer` lock, it sleeps. If the task is cancelled during this sleep, we need to release the lock. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-05 17:19:16 +01:00
Sean Quah	31c1209c50	Make `StreamToken` and `RoomStreamToken` methods propagate cancellations (#12366 ) `StreamToken.from_string` and `RoomStreamToken.parse` are both async methods that could be cancelled. These methods must not replace `CancelledError`s with `SynapseError`s. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-05 16:56:52 +01:00
Sean Quah	9c4c49991d	Update docstrings for `ReadWriteLock` tests (#12354 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-04-05 16:54:40 +01:00
Sean Quah	800ba87cc8	Refactor and convert `Linearizer` to async (#12357 ) Refactor and convert `Linearizer` to async. This makes a `Linearizer` cancellation bug easier to fix. Also refactor to use an async context manager, which eliminates an unlikely footgun where code that doesn't immediately use the context manager could forget to release the lock. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-05 15:43:52 +01:00
Sean Quah	41b5f72677	Convert `Linearizer` tests from `inlineCallbacks` to async (#12353 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-04-05 14:56:09 +01:00
Erik Johnston	66053b6bfb	Prefill more stream change caches. (#12372 )	2022-04-05 14:26:41 +01:00
Dirk Klimpel	d666fc02fa	Add type hints to some tests files (#12371 )	2022-04-05 13:54:41 +01:00
reivilibre	42d8710f38	Fix a spec compliance issue where requests to the `/publicRooms` federation API would specify `limit` as a string. (#12364 )	2022-04-05 12:45:36 +01:00
reivilibre	708d88b1a2	Allow specifying the Postgres database's port when running unit tests with Postgres. (#12376 )	2022-04-05 12:44:48 +01:00
Richard van der Hoff	efdbcfd6af	Synapse 1.56.0rc1 (2022-03-29) ============================== Features -------- - Allow modules to store already existing 3PID associations. ([\#12195](https://github.com/matrix-org/synapse/issues/12195)) - Allow registering server administrators using the module API. Contributed by Famedly. ([\#12250](https://github.com/matrix-org/synapse/issues/12250)) Bugfixes -------- - Fix a long-standing bug which caused the `/_matrix/federation/v1/state` and `/_matrix/federation/v1/state_ids` endpoints to return incorrect or invalid data when called for an event which we have stored as an "outlier". ([\#12087](https://github.com/matrix-org/synapse/issues/12087)) - Fix a long-standing bug where events from ignored users would still be considered for relations. ([\#12227](https://github.com/matrix-org/synapse/issues/12227), [\#12232](https://github.com/matrix-org/synapse/issues/12232), [\#12285](https://github.com/matrix-org/synapse/issues/12285)) - Fix a bug introduced in Synapse 1.53.0 where an unnecessary query could be performed when fetching bundled aggregations for threads. ([\#12228](https://github.com/matrix-org/synapse/issues/12228)) - Fix a bug introduced in Synapse 1.52.0 where admins could not deactivate and GDPR-erase a user if Synapse was configured with limits on avatars. ([\#12261](https://github.com/matrix-org/synapse/issues/12261)) Improved Documentation ---------------------- - Fix the link to the module documentation in the legacy spam checker warning message. ([\#12231](https://github.com/matrix-org/synapse/issues/12231)) - Remove incorrect prefixes in the worker documentation for some endpoints. ([\#12243](https://github.com/matrix-org/synapse/issues/12243)) - Correct `check_username_for_spam` annotations and docs. ([\#12246](https://github.com/matrix-org/synapse/issues/12246)) - Correct Authentik OpenID typo, and add notes on troubleshooting. Contributed by @IronTooch. ([\#12275](https://github.com/matrix-org/synapse/issues/12275)) - HAProxy reverse proxy guide update to stop sending IPv4-mapped address to homeserver. Contributed by @villepeh. ([\#12279](https://github.com/matrix-org/synapse/issues/12279)) Internal Changes ---------------- - Rename `shared_rooms` to `mutual_rooms` ([MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)), as per proposal changes. ([\#12036](https://github.com/matrix-org/synapse/issues/12036)) - Remove check on `update_user_directory` for shared rooms handler ([MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)), and update/expand documentation. ([\#12038](https://github.com/matrix-org/synapse/issues/12038)) - Refactor `create_new_client_event` to use a new parameter, `state_event_ids`, which accurately describes the usage with [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) instead of abusing `auth_event_ids`. ([\#12083](https://github.com/matrix-org/synapse/issues/12083), [\#12304](https://github.com/matrix-org/synapse/issues/12304)) - Refuse to start if registration is enabled without email, captcha, or token-based verification unless the new config flag `enable_registration_without_verification` is set. ([\#12091](https://github.com/matrix-org/synapse/issues/12091)) - Add tests for database transaction callbacks. ([\#12198](https://github.com/matrix-org/synapse/issues/12198)) - Handle cancellation in `DatabasePool.runInteraction`. ([\#12199](https://github.com/matrix-org/synapse/issues/12199)) - Add missing type hints for cache storage. ([\#12216](https://github.com/matrix-org/synapse/issues/12216)) - Add missing type hints for storage. ([\#12248](https://github.com/matrix-org/synapse/issues/12248), [\#12255](https://github.com/matrix-org/synapse/issues/12255)) - Add type hints to tests files. ([\#12224](https://github.com/matrix-org/synapse/issues/12224), [\#12240](https://github.com/matrix-org/synapse/issues/12240), [\#12256](https://github.com/matrix-org/synapse/issues/12256)) - Use type stubs for `psycopg2`. ([\#12269](https://github.com/matrix-org/synapse/issues/12269)) - Improve type annotations for `execute_values`. ([\#12311](https://github.com/matrix-org/synapse/issues/12311)) - Clean-up logic around rebasing URLs for URL image previews. ([\#12219](https://github.com/matrix-org/synapse/issues/12219)) - Use the `ignored_users` table in additional places instead of re-parsing the account data. ([\#12225](https://github.com/matrix-org/synapse/issues/12225)) - Refactor the relations endpoints to add a `RelationsHandler`. ([\#12237](https://github.com/matrix-org/synapse/issues/12237)) - Generate announcement links in the release script. ([\#12242](https://github.com/matrix-org/synapse/issues/12242)) - Improve error message when dependencies check finds a broken installation. ([\#12244](https://github.com/matrix-org/synapse/issues/12244)) - Compress metrics HTTP resource when enabled. Contributed by Nick @ Beeper. ([\#12258](https://github.com/matrix-org/synapse/issues/12258)) - Refuse to start if the PostgreSQL database has a non-`C` locale, unless the config flag `allow_unsafe_db_locale` is set to true. ([\#12262](https://github.com/matrix-org/synapse/issues/12262), [\#12288](https://github.com/matrix-org/synapse/issues/12288)) - Optionally include account validity expiration information to experimental [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) account status responses. ([\#12266](https://github.com/matrix-org/synapse/issues/12266)) - Add a new cache `_get_membership_from_event_id` to speed up push rule calculations in large rooms. ([\#12272](https://github.com/matrix-org/synapse/issues/12272)) - Re-enable Complement concurrency in CI. ([\#12283](https://github.com/matrix-org/synapse/issues/12283)) - Remove unused test utilities. ([\#12291](https://github.com/matrix-org/synapse/issues/12291)) - Enhance logging for inbound federation events. ([\#12301](https://github.com/matrix-org/synapse/issues/12301)) - Fix compatibility with the recently-released Jinja 3.1. ([\#12313](https://github.com/matrix-org/synapse/issues/12313)) - Avoid trying to calculate the state at outlier events. ([\#12314](https://github.com/matrix-org/synapse/issues/12314)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEdVkXOgzrGzds0jtrHgFcFF8ZFs0FAmJC33MACgkQHgFcFF8Z Fs0IFhAAhz45kNCqWfBip8yc7GE95ZnMfX4PymrIQeJOtloecQCyRrcS8r0GJhvq j5cRfMNoaoMZKOQsqyjLiY02QUX/8hUOgAD4SEa9Jmc4a2ZwjJ3hxy8dKx89gdZ+ E+uUhJZUNV9UovDIOYd+DPB1//tFdzfYtZmbmddJbWv2jZwb4fmTEnK+j5dp4TMR Z6/aA1IQB2PZqihQLmtKHCC6xCv7zaCmvS7Z1oUACOm7W1cX0F2P51M11+rK5ipi tasRBhdGmMu9eGm9QfeQkY++5HLjTfNuSwSP37tP5RMjKckpJS7f6vooJ7EtVtaY YPlTsjsngWaDk+ETK9ZN3ATtI1StB+6agiTAjO3kJzai++eKQaNrkzIhhftLYfsa 2CIoy2BM7iPp/u+MF5VkxN/QCcnK43VuDU+iR8MCzjTQJPSxsAYrjsd8MMD0rCBa dib2IdF1Xlijg0iSdV/ToeMx/KDYh+l5hcltkLy1To68IvFqf0kGvlcDk2rtLWzz QsWf5PGc+YXQM8IMF38BmuE1HCI0rEJH5V/Jl1UkXFaQdf1bIXmWxKTNHjVP/2Uq dfI4qPtszWOjJT7bBgJbjqX1QBzzIU7ShM8cRlj4Lfc6bdhWG3G+CCACl29t/T9K NBboIPEbCqw2GJMz1EoNciRHhFnsvQyG1QaHywRwaIuzNX8ohEw= =J5w/ -----END PGP SIGNATURE----- Merge tag 'v1.56.0rc1' into develop Synapse 1.56.0rc1 (2022-03-29) ============================== Features -------- - Allow modules to store already existing 3PID associations. ([\#12195](https://github.com/matrix-org/synapse/issues/12195)) - Allow registering server administrators using the module API. Contributed by Famedly. ([\#12250](https://github.com/matrix-org/synapse/issues/12250)) Bugfixes -------- - Fix a long-standing bug which caused the `/_matrix/federation/v1/state` and `/_matrix/federation/v1/state_ids` endpoints to return incorrect or invalid data when called for an event which we have stored as an "outlier". ([\#12087](https://github.com/matrix-org/synapse/issues/12087)) - Fix a long-standing bug where events from ignored users would still be considered for relations. ([\#12227](https://github.com/matrix-org/synapse/issues/12227), [\#12232](https://github.com/matrix-org/synapse/issues/12232), [\#12285](https://github.com/matrix-org/synapse/issues/12285)) - Fix a bug introduced in Synapse 1.53.0 where an unnecessary query could be performed when fetching bundled aggregations for threads. ([\#12228](https://github.com/matrix-org/synapse/issues/12228)) - Fix a bug introduced in Synapse 1.52.0 where admins could not deactivate and GDPR-erase a user if Synapse was configured with limits on avatars. ([\#12261](https://github.com/matrix-org/synapse/issues/12261)) Improved Documentation ---------------------- - Fix the link to the module documentation in the legacy spam checker warning message. ([\#12231](https://github.com/matrix-org/synapse/issues/12231)) - Remove incorrect prefixes in the worker documentation for some endpoints. ([\#12243](https://github.com/matrix-org/synapse/issues/12243)) - Correct `check_username_for_spam` annotations and docs. ([\#12246](https://github.com/matrix-org/synapse/issues/12246)) - Correct Authentik OpenID typo, and add notes on troubleshooting. Contributed by @IronTooch. ([\#12275](https://github.com/matrix-org/synapse/issues/12275)) - HAProxy reverse proxy guide update to stop sending IPv4-mapped address to homeserver. Contributed by @villepeh. ([\#12279](https://github.com/matrix-org/synapse/issues/12279)) Internal Changes ---------------- - Rename `shared_rooms` to `mutual_rooms` ([MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)), as per proposal changes. ([\#12036](https://github.com/matrix-org/synapse/issues/12036)) - Remove check on `update_user_directory` for shared rooms handler ([MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)), and update/expand documentation. ([\#12038](https://github.com/matrix-org/synapse/issues/12038)) - Refactor `create_new_client_event` to use a new parameter, `state_event_ids`, which accurately describes the usage with [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) instead of abusing `auth_event_ids`. ([\#12083](https://github.com/matrix-org/synapse/issues/12083), [\#12304](https://github.com/matrix-org/synapse/issues/12304)) - Refuse to start if registration is enabled without email, captcha, or token-based verification unless the new config flag `enable_registration_without_verification` is set. ([\#12091](https://github.com/matrix-org/synapse/issues/12091)) - Add tests for database transaction callbacks. ([\#12198](https://github.com/matrix-org/synapse/issues/12198)) - Handle cancellation in `DatabasePool.runInteraction`. ([\#12199](https://github.com/matrix-org/synapse/issues/12199)) - Add missing type hints for cache storage. ([\#12216](https://github.com/matrix-org/synapse/issues/12216)) - Add missing type hints for storage. ([\#12248](https://github.com/matrix-org/synapse/issues/12248), [\#12255](https://github.com/matrix-org/synapse/issues/12255)) - Add type hints to tests files. ([\#12224](https://github.com/matrix-org/synapse/issues/12224), [\#12240](https://github.com/matrix-org/synapse/issues/12240), [\#12256](https://github.com/matrix-org/synapse/issues/12256)) - Use type stubs for `psycopg2`. ([\#12269](https://github.com/matrix-org/synapse/issues/12269)) - Improve type annotations for `execute_values`. ([\#12311](https://github.com/matrix-org/synapse/issues/12311)) - Clean-up logic around rebasing URLs for URL image previews. ([\#12219](https://github.com/matrix-org/synapse/issues/12219)) - Use the `ignored_users` table in additional places instead of re-parsing the account data. ([\#12225](https://github.com/matrix-org/synapse/issues/12225)) - Refactor the relations endpoints to add a `RelationsHandler`. ([\#12237](https://github.com/matrix-org/synapse/issues/12237)) - Generate announcement links in the release script. ([\#12242](https://github.com/matrix-org/synapse/issues/12242)) - Improve error message when dependencies check finds a broken installation. ([\#12244](https://github.com/matrix-org/synapse/issues/12244)) - Compress metrics HTTP resource when enabled. Contributed by Nick @ Beeper. ([\#12258](https://github.com/matrix-org/synapse/issues/12258)) - Refuse to start if the PostgreSQL database has a non-`C` locale, unless the config flag `allow_unsafe_db_locale` is set to true. ([\#12262](https://github.com/matrix-org/synapse/issues/12262), [\#12288](https://github.com/matrix-org/synapse/issues/12288)) - Optionally include account validity expiration information to experimental [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) account status responses. ([\#12266](https://github.com/matrix-org/synapse/issues/12266)) - Add a new cache `_get_membership_from_event_id` to speed up push rule calculations in large rooms. ([\#12272](https://github.com/matrix-org/synapse/issues/12272)) - Re-enable Complement concurrency in CI. ([\#12283](https://github.com/matrix-org/synapse/issues/12283)) - Remove unused test utilities. ([\#12291](https://github.com/matrix-org/synapse/issues/12291)) - Enhance logging for inbound federation events. ([\#12301](https://github.com/matrix-org/synapse/issues/12301)) - Fix compatibility with the recently-released Jinja 3.1. ([\#12313](https://github.com/matrix-org/synapse/issues/12313)) - Avoid trying to calculate the state at outlier events. ([\#12314](https://github.com/matrix-org/synapse/issues/12314))	2022-04-05 12:26:20 +01:00
Eric Eastwood	5218fe7670	Explain how to decipher live and historic pagination tokens (#12317 )	2022-04-05 10:57:09 +01:00
Shay	f608e6c8cf	Update broken link in `workers.md` (#12369 )	2022-04-04 17:40:31 -07:00
Eric Eastwood	9633eb2162	Allow non-member state sent in room batch to resolve for historic events (MSC2716) (#12329 ) Part of https://github.com/matrix-org/synapse/issues/12110 Complement test: https://github.com/matrix-org/complement/pull/354 Previously, they didn't resolve because async `filter_events_for_client` removes all outlier state except for out-of-band membership. And fundamentally, we have the state at these events so they shouldn't be marked as outliers.	2022-04-04 14:54:50 -05:00
Erik Johnston	b446c99ac9	Prefill the device_list_stream_cache (#12367 ) * Prefill the device_list_stream_cache * Newsfile * Newsfile	2022-04-04 20:12:25 +01:00
Erik Johnston	5c9e39e619	Track device list updates per room. (#12321 ) This is a first step in dealing with #7721. The idea is basically that rather than calculating the full set of users a device list update needs to be sent to up front, we instead simply record the rooms the user was in at the time of the change. This will allow a few things: 1. we can defer calculating the set of remote servers that need to be poked about the change; and 2. during `/sync` and `/keys/changes` we can avoid also avoid calculating users who share rooms with other users, and instead just look at the rooms that have changed. However, care needs to be taken to correctly handle server downgrades. As such this PR writes to both `device_lists_changes_in_room` and the `device_lists_outbound_pokes` table synchronously. In a future release we can then bump the database schema compat version to `69` and then we can assume that the new `device_lists_changes_in_room` exists and is handled. There is a temporary option to disable writing to `device_lists_outbound_pokes` synchronously, allowing us to test the new code path does work (and by implication upgrading to a future release and downgrading to this one will work correctly). Note: Ideally we'd do the calculation of room to servers on a worker (e.g. the background worker), but currently only master can write to the `device_list_outbound_pokes` table.	2022-04-04 15:25:20 +01:00
David Robertson	80839a44f1	Remove more dead/broken dev scripts (#12355 )	2022-04-03 21:21:08 +01:00
Richard van der Hoff	f0b03186d9	Add type hints for `tests/unittest.py`. (#12347 ) In particular, add type hints for get_success and friends, which are then helpful in a bunch of places.	2022-04-01 16:04:16 +00:00
Richard van der Hoff	33ebee47e4	Remove redundant `get_success` calls in test code (#12346 ) There are a bunch of places we call get_success on an immediate value, which is unnecessary. Let's rip them out, and remove the redundant functionality in get_success and friends.	2022-04-01 16:10:31 +01:00
reivilibre	c4cf916ed7	Default to `private` room visibility rather than `public` when a client does not specify one, according to spec. (#12350 )	2022-04-01 15:55:09 +01:00
David Robertson	336bff1104	Burn `check_signature` dev script. (#12351 )	2022-04-01 13:41:42 +00:00
Nick Mills-Barrett	993d90f82b	Use a sequence to generate AS transaction IDs, drop `last_txn` AS state (#12209 ) Switching to a sequence means there's no need to track `last_txn` on the AS state table to generate new TXN IDs. This also means that there is no longer contention between the AS scheduler and AS handler on updates to the `application_services_state` table, which will prevent serialization errors during the complete AS txn transaction.	2022-04-01 13:33:25 +00:00
David Robertson	21351820e0	Remove `list_url_patterns` dev script (#12349 )	2022-04-01 13:05:21 +00:00
Richard van der Hoff	b7762b0c9f	Move single-use methods out of `TestCase` (#12348 ) These methods are only used by a single testcase, so they shouldn't be cluttering up the base `TestCase` class.	2022-04-01 12:48:08 +00:00
reivilibre	f871222880	Move `update_client_ip` background job from the main process to the background worker. (#12251 )	2022-04-01 13:08:55 +01:00
Richard van der Hoff	319a805cd3	Raise an exception when getting state at an outlier (#12191 ) It seems like calling `_get_state_group_for_events` for an event where the state is unknown is an error. Accordingly, let's raise an exception rather than silently returning an empty result.	2022-04-01 13:01:49 +01:00
Richard van der Hoff	9b43df1f7b	Optimise `_get_state_after_missing_prev_event`: use `/state` (#12040 ) If we're missing most of the events in the room state, then we may as well call the /state endpoint, instead of individually requesting each and every event.	2022-04-01 12:53:42 +01:00
Brendan Abolivier	e4409301ba	Add a module callback to react to account data changes (#12327 ) Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2022-04-01 11:22:48 +02:00
Amanda Graven	4e900ece42	Add set_user_admin function to the module API (#12341 )	2022-04-01 09:31:30 +01:00
Patrick Cloke	bebf994ee8	Move MSC2654 support behind an experimental configuration flag. (#12295 ) To match the current thinking on disabling experimental features by default.	2022-03-31 15:05:13 -04:00
Richard van der Hoff	6927d87254	Handle outliers in `/federation/v1/event` (#12332 ) The intention here is to avoid doing state lookups for outliers in `/_matrix/federation/v1/event`. Unfortunately that's expanded into something of a rewrite of `filter_events_for_server`, which ended up trying to do that operation in a couple of places.	2022-03-31 17:39:34 +00:00
Patrick Cloke	11df4ec6c2	Add more type hints to the main state store. (#12267 )	2022-03-31 13:38:09 -04:00
Brendan Abolivier	5e88143dff	Add a callback to react to 3PID associations (#12302 )	2022-03-31 18:27:21 +02:00
Patrick Cloke	adbf975623	Remove an unnecessary class from the relations code. (#12338 ) The PaginationChunk class attempted to bundle some properties together, but really just caused callers to jump through hoops and hid implementation details.	2022-03-31 07:13:49 -04:00
David Robertson	15cdcf8f30	Remove `dockerfile-pgtests` (#12336 )	2022-03-31 11:30:07 +01:00
David Robertson	5a32ec59b2	Ignore .envrc for direnv users (#12335 )	2022-03-31 11:03:07 +01:00
David Robertson	9a3f1f5383	Nuke the tox `packaging` job (#12334 )	2022-03-31 11:01:26 +01:00
Brendan Abolivier	f96b85eca8	Ensure the type of URL attributes is always str when matching against preview blacklist (#12333 )	2022-03-31 11:49:49 +02:00
Patrick Cloke	c31c1091d4	Remove the unused and unstable `/aggregations` endpoint. (#12293 ) This endpoint was removed from MSC2675 before it was approved. It is currently unspecified (even in any MSCs) and therefore subject to removal. It is not implemented by any known clients. This also changes the bundled aggregation format for `m.annotation`, which previously included pagination tokens for the `/aggregations` endpoint, which are no longer useful.	2022-03-30 11:45:32 -04:00
Andrew Morgan	d8d0271977	Send device list updates to application services (MSC3202) - part 1 (#11881 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-30 14:39:27 +01:00
reivilibre	2fc15ac718	Flesh out documentation for running SyTest against Synapse, including use of Postgres and worker mode. (#12271 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-30 12:55:05 +00:00
David Robertson	a7fb66e800	Update dead links in check-newsfragment.sh (#12331 )	2022-03-30 11:44:28 +00:00
Andrew Morgan	19a1d6a42a	Remove references to "msc2403" (#12165 )	2022-03-30 11:15:47 +00:00
Andrew Morgan	c8cbd66d3b	Start application service stream token tracking from 1 (#12193 ) Co-authored-by: Erik Johnston <erik@matrix.org>	2022-03-30 11:10:12 +00:00
Richard van der Hoff	9b67715bc3	Disable proactive sends for remote joins (#12330 ) Do not attempt to send remote joins out over federation. Normally, it will do nothing; occasionally, it will do the wrong thing.	2022-03-30 12:04:35 +01:00
Brendan Abolivier	437a8ed9ef	Add a configuration to exclude rooms from sync response (#12310 )	2022-03-30 09:43:04 +00:00
David Robertson	e0bb268134	Fix typechecker problems exposed by signedjson 1.1.2 (#12326 )	2022-03-29 21:37:50 +00:00
Richard van der Hoff	1f32b90b0f	Room batch: fix up handling of unknown prev_event_ids (#12316 )	2022-03-29 14:56:25 +01:00
Sean Quah	8a519f8abc	Update `LoggingTransaction.call_after` and `call_on_exception` docstrings (#12315 ) Document the behaviour of `LoggingTransaction.call_after` and `LoggingTransaction.call_on_exception` when transactions are retried. Signed-off-by: Sean Quah <seanq@element.io>	2022-03-29 12:31:05 +01:00
David Robertson	a2b00a4486	Bump `black` and `click` versions (#12320 )	2022-03-29 10:41:19 +00:00
Brendan Abolivier	b690fe749b	1.56.0rc1	2022-03-29 10:41:04 +01:00
Eric Eastwood	6f2943714b	Remove unused `auth_event_ids` argument plumbing (#12304 ) Follow-up to https://github.com/matrix-org/synapse/pull/12083 Since we are now using the new `state_event_ids` parameter to do all of the heavy lifting. We can remove any spots where we plumbed `auth_event_ids` just for MSC2716 things in https://github.com/matrix-org/synapse/pull/9247/files. Removing `auth_event_ids` from following functions: - `create_and_send_nonmember_event` - `_local_membership_update` - `update_membership` - `update_membership_locked`	2022-03-29 09:18:52 +01:00
Richard van der Hoff	287a9c1e20	Exclude outliers in `on_backfill_request` (#12314 ) When we are processing a `/backfill` request from a remote server, exclude any outliers from consideration early on. We can't return outliers anyway (since we don't know the state at the outlier), and filtering them out earlier means that we won't attempt to calulate the state for them.	2022-03-28 19:20:14 +01:00
Dirk Klimpel	ac95167d2f	Add some type hints to datastore. (#12255 )	2022-03-28 14:11:14 -04:00
Brendan Abolivier	4ba55a620f	Un-revert Jinja2 fix (#12313 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-03-28 17:02:57 +00:00
Brendan Abolivier	8cd760fca8	Allow modules to store already existing 3PID associations (#12195 )	2022-03-28 18:57:19 +02:00
reivilibre	89f11f8c6f	Improve type annotations for `execute_values`. (#12311 )	2022-03-28 17:21:23 +01:00
villepeh	a4643a685c	HAProxy guide update (#12279 ) HAproxy reverse proxy guide update to stop sending IPv4-mapped address to HS.	2022-03-28 10:48:18 +00:00
Shay	3c41d87b67	Add restrictions by default to open registration in Synapse (#12091 )	2022-03-25 10:11:01 -07:00
Erik Johnston	7ca8ee67a5	Add cache for `get_membership_from_event_ids` (#12272 ) This should speed up push rule calculations for rooms with large numbers of local users when the main push rule cache fails. Co-authored-by: reivilibre <oliverw@matrix.org>	2022-03-25 14:58:56 +00:00
Richard van der Hoff	38adf14998	Enhance logging for inbound federation events (#12301 ) It is currently rather hard to see which rooms are causing inbound federation traffic. Add the room id to the logs.	2022-03-25 14:44:57 +00:00
Eric Eastwood	14662d3c18	Refactor `create_new_client_event` to use a new parameter, `state_event_ids`, which accurately describes the usage with MSC2716 instead of abusing `auth_event_ids` (#12083 ) Spawned from https://github.com/matrix-org/synapse/pull/10975#discussion_r813183430 Part of [MSC2716](https://github.com/matrix-org/matrix-spec-proposals/pull/2716)	2022-03-25 09:21:06 -05:00
David Robertson	fffb3c4c8f	Always allow the empty string as an avatar_url. (#12261 ) Hopefully this fixes #12257. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-25 13:28:42 +00:00
IronTooch	61aae18d45	Authentik OpenID minor doc update (#12275 )	2022-03-25 12:40:10 +00:00
Brendan Abolivier	5859e2fe0c	Mention the new behaviour on unsafe database locale in the upgrade notes (#12288 ) Co-authored-by: Shay <hillerys@element.io>	2022-03-25 10:56:18 +01:00
kegsay	8b7b371ff6	Re-enable test concurrency on Complement (#12283 )	2022-03-24 15:59:06 -04:00
Patrick Cloke	1800bd47a8	Remove unused test code. (#12291 ) The `MockHttpResource` and `MockKey` objects were unused since #9396 (`74af356baf`).	2022-03-24 19:25:52 +00:00
Patrick Cloke	4df10d3214	Do not consider events by ignored users for relations (#12285 ) Filter the events returned from `/relations` for the requester's ignored users in a similar way to `/messages` (and `/sync`).	2022-03-24 10:25:42 -04:00
Brendan Abolivier	5436b014f4	Optionally include account validity in MSC3720 account status responses (#12266 )	2022-03-24 11:19:41 +01:00
Shay	e78d4f61fc	Refuse to start if DB has an unsafe locale (#12262 )	2022-03-23 10:23:05 -07:00
David Robertson	f4c5e5864c	Use psycopg2 type stubs (#12269 )	2022-03-23 14:03:24 +00:00
Jonathan de Jong	c5776780f0	Remove mutual_rooms `update_user_directory` check, and add extra documentation (#12038 ) Resolves #10339	2022-03-23 12:47:07 +00:00
Nicolas Werner	692b82838e	Allow registering admin users using the module API (#12250 ) Signed-off-by: Nicolas Werner <n.werner@famedly.com>	2022-03-23 12:48:47 +01:00
Jonathan de Jong	516d092ff9	Rename shared_rooms to mutual_rooms (#12036 ) Co-authored-by: reivilibre <olivier@librepush.net>	2022-03-23 11:19:20 +00:00
Andrew Morgan	831d4797ab	Merge branch 'master' into develop	2022-03-22 16:31:28 +00:00
Andrew Morgan	34baf76451	1.55.0	2022-03-22 14:02:52 +00:00
Michael Telatynski	01211e0c16	Tweak copy for sso account details template (#12265 ) * Tweak copy for sso account details template * Update sso footer copyright year * Add newsfragment Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>	2022-03-22 10:22:25 +00:00
Dirk Klimpel	9d21ecf7ce	Add type hints to tests files. (#12256 )	2022-03-21 09:43:16 -04:00
David Robertson	0a59f977a2	Merge branch 'release-v1.55' into develop	2022-03-21 12:29:53 +00:00
reivilibre	6134b3079e	Reword 'Choose your user name' as 'Choose your account name' in the SSO registration template, in order to comply with SIWA guidelines. (#12260 ) * Reword as 'Choose your account name' * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>	2022-03-21 12:16:46 +00:00
Nick Mills-Barrett	1530cef192	Make it possible to enable compression for the metrics HTTP resource (#12258 ) * Make it possible to enable compression for the metrics HTTP resource This can provide significant bandwidth savings pulling metrics from synapse instances. * Add changelog file. * Fix type hint	2022-03-21 11:52:10 +00:00
Richard van der Hoff	afa17f0eab	Return a 404 from `/state` for an outlier (#12087 ) * Replace `get_state_for_pdu` with `get_state_ids_for_pdu` and `get_events_as_list`. * Return a 404 from `/state` and `/state_ids` for an outlier	2022-03-21 11:23:32 +00:00
David Robertson	bf9d549e3a	Try to detect borked package installations. (#12244 ) * Try to detect borked package installations. Fixes #12223. Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-03-18 19:03:46 +00:00
Patrick Cloke	8fe930c215	Move get_bundled_aggregations to relations handler. (#12237 ) The get_bundled_aggregations code is fairly high-level and uses a lot of store methods, we move it into the handler as that seems like a better fit.	2022-03-18 17:49:32 +00:00
Patrick Cloke	80e0e1f35e	Only fetch thread participation for events with threads. (#12228 ) We fetch the thread summary in two phases: 1. The summary that is shared by all users (count of messages and latest event). 2. Whether the requesting user has participated in the thread. There's no use in attempting step 2 for events which did not return a summary from step 1.	2022-03-18 17:15:45 +00:00
Patrick Cloke	2177e356bc	Sync more worker regexes in the documentation. (#12243 )	2022-03-18 12:51:27 -04:00
Dirk Klimpel	c46065fa3d	Add some type hints to datastore (#12248 ) * inherit `MonthlyActiveUsersStore` from `RegistrationWorkerStore` Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-18 15:24:18 +00:00
David Robertson	872dbb0181	Correct `check_username_for_spam` annotations and docs (#12246 ) * Formally type the UserProfile in user searches * export UserProfile in synapse.module_api * Update docs Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-03-18 13:51:41 +00:00
David Robertson	12d1f82db2	Generate announcement links in release script (#12242 )	2022-03-17 13:46:05 +00:00
Dirk Klimpel	9e06e22064	Add type hints to more tests files. (#12240 )	2022-03-17 07:25:50 -04:00
Patrick Cloke	3f7cfbc9e5	Merge branch 'release-v1.55' into develop	2022-03-16 12:22:07 -04:00
Patrick Cloke	f70afbd565	Re-generate changelog.	2022-03-16 12:20:05 -04:00
Patrick Cloke	96274565ff	Fix bundling aggregations if unsigned is not a returned event field. (#12234 ) An error occured if a filter was supplied with `event_fields` which did not include `unsigned`. In that case, bundled aggregations are still added as the spec states it is allowed for servers to add additional fields.	2022-03-16 12:17:39 -04:00
Sean Quah	6121056740	Handle cancellation in `DatabasePool.runInteraction()` (#12199 ) To handle cancellation, we ensure that `after_callback`s and `exception_callback`s are always run, since the transaction will complete on another thread regardless of cancellation. We also wait until everything is done before releasing the `CancelledError`, so that logging contexts won't get used after they have been finished. Signed-off-by: Sean Quah <seanq@element.io>	2022-03-16 15:07:41 +00:00
Patrick Cloke	fc9bd620ce	Add a relations handler to avoid duplication. (#12227 ) Adds a handler layer between the REST and datastore layers for relations.	2022-03-16 10:39:15 -04:00
Patrick Cloke	c486fa5fd9	Add some missing type hints to cache datastore. (#12216 )	2022-03-16 10:37:04 -04:00
David Robertson	86965605a4	Fix dead link in spam checker warning (#12231 )	2022-03-16 13:52:59 +00:00
Patrick Cloke	1da0f79d54	Refactor relations tests (#12232 ) * Moves the relation pagination tests to a separate class. * Move the assertion of the response code into the `_send_relation` helper. * Moves some helpers into the base-class.	2022-03-16 09:20:57 -04:00
Patrick Cloke	4587b35929	Clean-up logic for rebasing URLs during URL preview. (#12219 ) By using urljoin from the standard library and reducing the number of places URLs are rebased.	2022-03-16 07:21:36 -04:00
Patrick Cloke	dda9b7fc4d	Use the ignored_users table to test event visibility & sync. (#12225 ) Instead of fetching the raw account data and re-parsing it. The ignored_users table is a denormalised version of the account data for quick searching.	2022-03-15 14:06:05 -04:00
Sean Quah	dea577998f	Add tests for database transaction callbacks (#12198 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-15 15:40:34 +00:00
Dirk Klimpel	5dd949bee6	Add type hints to some tests/handlers files. (#12224 )	2022-03-15 09:16:37 -04:00
David Robertson	d1130a249b	1.55.0rc1	2022-03-15 11:00:01 +00:00
Sean Quah	2fcf4b3f6c	Add cancellation support to `@cached` and `@cachedList` decorators (#12183 ) These decorators mostly support cancellation already. Add cancellation tests and fix use of finished logging contexts by delaying cancellation, as suggested by @erikjohnston. Signed-off-by: Sean Quah <seanq@element.io>	2022-03-14 19:04:29 +00:00
Sean Quah	605d161d7d	Add cancellation support to `ReadWriteLock` (#12120 ) Also convert `ReadWriteLock` to use async context managers. Signed-off-by: Sean Quah <seanq@element.io>	2022-03-14 18:49:07 +00:00
Sean Quah	8e5706d144	Fix broken background updates when using sqlite with `enable_search` off (#12215 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-14 17:52:58 +00:00
Sean Quah	90b2327066	Add `delay_cancellation` utility function (#12180 ) `delay_cancellation` behaves like `stop_cancellation`, except it delays `CancelledError`s until the original `Deferred` resolves. This is handy for unifying cleanup paths and ensuring that uncancelled coroutines don't use finished logcontexts. Signed-off-by: Sean Quah <seanq@element.io>	2022-03-14 17:52:15 +00:00
Patrick Cloke	54f674f7a9	Deprecate the groups/communities endpoints and add an experimental configuration flag. (#12200 )	2022-03-12 13:23:37 -05:00
Shay	ef3619e61d	Add config settings for background update parameters (#11980 )	2022-03-11 10:46:45 -08:00
Brendan Abolivier	e6a106fd5e	Implement a Jinja2 filter to extract localparts from email addresses (#12212 )	2022-03-11 15:15:11 +00:00
reivilibre	4a53f35737	Improve code documentation for the typing stream over replication. (#12211 )	2022-03-11 14:00:15 +00:00
Nick Mills-Barrett	735e89bd3a	Add an additional HTTP pusher + push rule tests. (#12188 ) And rename the field used for caching from _id to _cache_key.	2022-03-11 08:45:26 -05:00
Brendan Abolivier	003cc6910a	Update the SSO username picker template to comply with SIWA guidelines (#12210 ) Fixes https://github.com/matrix-org/synapse/issues/12205	2022-03-11 13:20:00 +00:00
Dirk Klimpel	32c828d0f7	Add type hints to `tests/rest`. (#12208 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-11 12:42:22 +00:00
Patrick Cloke	e10a2fe0c2	Add some type hints to the tests.handlers module. (#12207 )	2022-03-11 07:07:15 -05:00
Patrick Cloke	bc9dff1d95	Remove unnecessary pass statements. (#12206 )	2022-03-11 07:06:21 -05:00
Andrew Morgan	3b12f6d61b	Note that contributors can sign off privately (#12204 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-11 11:10:20 +00:00
Richard van der Hoff	483f2aa2ec	Retention test: avoid relying on state at purged events (#12202 ) This test was relying on poking events which weren't in the database into filter_events_for_client.	2022-03-11 10:33:49 +00:00
~creme	7577894bec	Document that most streams can only have a single writer. (#12196 ) This includes the `typing`, `to_device`, `account_data`, `receipts`, and `presence` streams (really anything except the `events` stream).	2022-03-10 18:15:19 +00:00
Shay	ed9aea42fa	fix misleading comment in `check_events_for_spam` (#12203 )	2022-03-10 09:40:07 -08:00
reivilibre	72e7f1c420	Remove workaround introduced in Synapse v1.50.0rc1 for Mjolnir compatibility. Breaks compatibility with Mjolnir v1.3.1 and earlier. (#11700 )	2022-03-10 15:53:23 +00:00
Patrick Cloke	ea27528b5d	Support stable identifiers for MSC3440: Threading (#12151 ) The unstable identifiers are still supported if the experimental configuration flag is enabled. The unstable identifiers will be removed in a future release.	2022-03-10 15:36:13 +00:00
Richard van der Hoff	52a947dc46	Updates to the Room DAG concepts development document (#12179 ) Some stuff that came up while we were talking about #12173.	2022-03-10 15:18:31 +00:00
Patrick Cloke	88cd6f9378	Allow retrieving the relations of a redacted event. (#12130 ) This is allowed per MSC2675, although the original implementation did not allow for it and would return an empty chunk / not bundle aggregations. The main thing to improve is that the various caches get cleared properly when an event is redacted, and that edits must not leak if the original event is redacted (as that would presumably leak something similar to the original event content).	2022-03-10 09:03:59 -05:00
Patrick Cloke	3e4af36bc8	Rename get_tcp_replication to get_replication_command_handler. (#12192 ) Since the object it returns is a ReplicationCommandHandler. This is clean-up from adding support to Redis where the command handler was added as an additional layer of abstraction from the TCP protocol.	2022-03-10 13:01:56 +00:00
Sean Quah	a4c1fdb44a	Remove dead code in `tests/storage/test_database.py` (#12197 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-09 18:45:21 +00:00
Will Hunt	15382b1afa	Add third_party module callbacks to check if a user can delete a room and deactivate a user (#12028 ) * Add check_can_deactivate_user * Add check_can_shutdown_rooms * Documentation * callbacks, not functions * Various suggested tweaks * Add tests for test_check_can_shutdown_room and test_check_can_deactivate_user * Update check_can_deactivate_user to not take a Requester * Fix check_can_shutdown_room docs * Renegade and use `by_admin` instead of `admin_user_id` * fix lint * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-03-09 18:23:57 +00:00
Patrick Cloke	690cb4f3b3	Allow for ignoring some arguments when caching. (#12189 ) * `@cached` can now take an `uncached_args` which is an iterable of names to not use in the cache key. * Requires `@cached`, @cachedList` and `@lru_cache` to use keyword arguments for clarity. * Asserts that keyword-only arguments in cached functions are not accepted. (I tested this briefly and I don't believe this works properly.)	2022-03-09 18:07:41 +00:00
Patrick Cloke	032688854b	Remove some unused variables/parameters. (#12187 )	2022-03-09 15:29:39 +00:00
Nick Mills-Barrett	180d8ff0d4	Retry some http replication failures (#12182 ) This allows for the target process to be down for around a minute which provides time for restarts during synapse upgrades/config updates. Closes: #12178 Signed off by Nick Mills-Barrett nick@beeper.com	2022-03-09 14:53:28 +00:00
Richard van der Hoff	dc8d825ef2	Skip attempt to get state at backwards-extremities (#12173 ) We don't have the state at a backwards-extremity, so this is never going to do anything useful.	2022-03-09 11:00:48 +00:00
Patrick Cloke	9a0172d49f	Clean-up demo scripts & documentation (#12143 ) * Rewrites the demo documentation to be clearer, accurate, and moves it to our documentation tree. * Improvements to the demo scripts: * `clean.sh` now runs `stop.sh` first to avoid zombie processes. * Uses more modern Synapse configuration (and removes some obsolete configuration). * Consistently use the HTTP ports for server name, etc. * Remove the `demo/etc` directory and place everything into the `demo/808x` directories.	2022-03-08 15:02:59 -05:00
Sean Quah	5627182788	Use `ParamSpec` in type hints for `synapse.logging.context` (#12150 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-08 15:58:14 +00:00
Olivier Wilkinson (reivilibre)	0dc9c5653c	Merge branch 'master' into develop	2022-03-08 15:37:35 +00:00
reivilibre	bfa7d6b035	Fix CI not attaching source distributions and wheels to the GitHub releases. (#12131 )	2022-03-08 15:11:50 +00:00
Erik Johnston	2ce27a24fe	Add experimental environment variable to enable asyncio reactor (#12135 )	2022-03-08 13:23:18 +00:00
Patrick Cloke	ca9234a9eb	Do not return allowed_room_ids from /hierarchy response. (#12175 ) This field is only to be used in the Server-Server API, and not the Client-Server API, but was being leaked when a federation response was used in the /hierarchy API.	2022-03-08 08:09:11 -05:00
Patrick Cloke	d8bab6793c	Fix incorrect type hints for txredis. (#12042 ) Some properties were marked as RedisProtocol instead of ConnectionHandler, which wraps RedisProtocol instance(s).	2022-03-08 07:26:05 -05:00
Olivier Wilkinson (reivilibre)	ea992adf86	1.54.0	2022-03-08 10:55:26 +00:00
reivilibre	2eef234ae3	Fix a bug introduced in 1.54.0rc1 which meant that Synapse would refuse to start if pre-release versions of dependencies were installed. (#12177 ) * Add failing test to characterise the regression #12176 * Permit pre-release versions of specified packages * Newsfile (bugfix) Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>	2022-03-08 10:47:28 +00:00
Shay	26211fec24	Fix a bug in background updates wherein background updates are never run using the default batch size (#12157 )	2022-03-07 09:44:33 -08:00
Patrick Cloke	f63bedef07	Invalidate caches when an event with a relation is redacted. (#12121 ) The caches for the target of the relation must be cleared so that the bundled aggregations are re-calculated after the redaction is processed.	2022-03-07 14:00:05 +00:00
Richard van der Hoff	0211f18d65	Switch the `tests-done` job to an Action (#12161 ) I've factored it out for easier use in other workflows.	2022-03-07 12:24:06 +00:00
Richard van der Hoff	00a67f831a	Merge remote-tracking branch 'origin/release-v1.54' into develop	2022-03-04 22:40:51 +00:00
David Robertson	d2ef1a79cf	Relax version guard for packaging (#12166 ) It’s just occurred to me that #12088 pulled in the “packaging” package (~=21.3). I pulled in the newest version I had at the time. I only use it for packaging.requirements.Requirements. Which was added in packaging 16.1: https://github.com/pypa/packaging/releases/tag/16.1 https://pkgs.org/download/python3-packaging suggests that the oldest version we care about is 17.1 in Ubuntu Bionic. So I think with this bound we're hunky dory.	2022-03-04 22:40:24 +00:00
Erik Johnston	0752ab7a36	Reduce to-device queries for /sync. (#12163 )	2022-03-04 17:57:27 +00:00
Sean Quah	75574726a7	Add type hints for `ObservableDeferred` attributes (#12159 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-04 15:37:02 +00:00
Sean Quah	158e0937eb	Add test for `ObservableDeferred`'s cancellation behaviour (#12149 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-04 13:10:05 +00:00
Patrick Cloke	cd1ae3d0b4	Remove backwards compatibility with RelationPaginationToken. (#12138 )	2022-03-04 07:10:10 -05:00
David Robertson	36071d39f7	Changelog (#12153 )	2022-03-04 12:01:51 +00:00
David Robertson	4aeb00ca20	Move synctl into `synapse._scripts` and expose as an entrypoint (#12140 )	2022-03-04 11:58:49 +00:00
Erik Johnston	423cca9efe	Spread out sending device lists to remote hosts (#12132 )	2022-03-04 11:48:15 +00:00
Richard van der Hoff	87c230c27c	Update client-visibility filtering for outlier events (#12155 ) Avoid trying to get the state for outliers, which isn't a sensible thing to do.	2022-03-04 10:31:19 +00:00
Richard van der Hoff	d56202b038	Fix type of `events` in `StateGroupStorage` and `StateHandler` (#12156 ) We make multiple passes over this, so a regular iterable won't do.	2022-03-04 10:25:18 +00:00
Richard van der Hoff	8533c8b03d	Avoid generating state groups for local out-of-band leaves (#12154 ) If we locally generate a rejection for an invite received over federation, it is stored as an outlier (because we probably don't have the state for the room). However, currently we still generate a state group for it (even though the state in that state group will be nonsense). By setting the `outlier` param on `create_event`, we avoid the nonsensical state.	2022-03-03 19:58:08 +00:00
Andrew Morgan	fb0ffa9676	Rename various ApplicationServices interested methods (#11915 )	2022-03-03 18:14:09 +00:00
David Robertson	9297d040a7	Detox, part 2 of N (#12152 ) I've argued in #11537 that poetry and tox don't cooperate well at the moment. (See also #12119.) Therefore I'm pruning away bits of tox to make the transition to poetry easier. This change removes the commands for coverage. We don't use coverage in anger at the moment. It shouldn't be too hard to add coverage as a dev-dependency and reintroduce this if we really want it.	2022-03-03 17:14:09 +00:00
Dirk Klimpel	7e91107be1	Add type hints to `tests/rest` (#12146 ) * Add type hints to `tests/rest` * newsfile * change import from `SigningKey`	2022-03-03 16:05:44 +00:00
Patrick Cloke	1d11b452b7	Use the proper serialization format when bundling aggregations. (#12090 ) This ensures that the `latest_event` field of the bundled aggregation for threads uses the same format as the other events in the response.	2022-03-03 10:43:06 -05:00
David Robertson	cea1b58c4a	Don't impose version checks on dev extras at runtime (#12129 ) * Fix incorrect argument in test case * Add copyright header * Docstring and __all__ * Exclude dev depenencies * Use changelog from #12088 * Include version in error messages This will hopefully distinguish between the version of the source code and the version of the distribution package that is installed. * Linter script is your friend	2022-03-03 12:47:55 +00:00
Eric Eastwood	a511a890d7	Enable MSC2716 Complement tests in Synapse (#12145 ) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-03-03 11:19:20 +00:00
Erik Johnston	61fd2a8f59	Limit the size of the aggregation_key (#12101 ) There's no reason to let people use long keys.	2022-03-03 10:52:35 +00:00
Eric Eastwood	31b125ccec	Enable MSC3030 Complement tests in Synapse (#12144 ) The Complement tests for MSC3030 are now merged, https://github.com/matrix-org/complement/pull/178 Synapse implmentation: https://github.com/matrix-org/synapse/pull/9445	2022-03-03 11:45:23 +01:00
Brendan Abolivier	ae8a616b49	Correctly register deactivation and profile update module callbacks (#12141 )	2022-03-03 11:39:58 +01:00
David Robertson	11282ade1d	Move the `snapcraft` configuration to `contrib`. (#12142 ) * Move the `snapcraft` configuration to `contrib`. We're happy for people to package this as a snap image if it's useful, but we don't support or maintain it. I'd like to move the config to `contrib` to reflect this state of affairs. * Changelog	2022-03-02 19:22:44 +00:00
David Robertson	1fbe0316a9	Add suffices to scripts in scripts-dev (#12137 ) * Rename scripts-dev to have suffices * Update references to `scripts-dev` * Changelog * These scripts don't pass mypy	2022-03-02 18:00:26 +00:00
David Robertson	106959b3cf	Remove unused mocks from `test_typing` (#12136 ) * Remove unused mocks from `test_typing` It's not clear what these do. `get_user_by_access_token` has the wrong signature, including the return type. Tests all pass without these. I think we should nuke them. * Changelog * Fixup imports	2022-03-02 17:24:52 +00:00
Dirk Klimpel	2ffaf30803	Add type hints to `tests/rest/client` (#12108 ) * Add type hints to `tests/rest/client` * newsfile * fix imports * add `test_account.py` * Remove one type hint in `test_report_event.py` * change `on_create_room` to `async` * update new functions in `test_third_party_rules.py` * Add `test_filter.py` * add `test_rooms.py` * change to `assertEquals` to `assertEqual` * lint	2022-03-02 16:34:14 +00:00
Andrew Morgan	b4461e7d8a	Enable complexity checking in complexity checking docs example (#11998 )	2022-03-02 16:11:16 +00:00
Olivier Wilkinson (reivilibre)	594a07ede4	Synapse 1.54.0rc1 (2022-03-02) ============================== Please note that this will be the last release of Synapse that is compatible with Mjolnir 1.3.1 and earlier. Administrators of servers which have the Mjolnir module installed are advised to upgrade Mjolnir to version 1.3.2 or later. Features -------- - Add support for [MSC3202](https://github.com/matrix-org/matrix-doc/pull/3202): sending one-time key counts and fallback key usage states to Application Services. ([\#11617](https://github.com/matrix-org/synapse/issues/11617)) - Improve the generated URL previews for some web pages. Contributed by @AndrewRyanChama. ([\#11985](https://github.com/matrix-org/synapse/issues/11985)) - Track cache invalidations in Prometheus metrics, as already happens for cache eviction based on size or time. ([\#12000](https://github.com/matrix-org/synapse/issues/12000)) - Implement experimental support for [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) (account status endpoints). ([\#12001](https://github.com/matrix-org/synapse/issues/12001), [\#12067](https://github.com/matrix-org/synapse/issues/12067)) - Enable modules to set a custom display name when registering a user. ([\#12009](https://github.com/matrix-org/synapse/issues/12009)) - Advertise Matrix 1.1 and 1.2 support on `/_matrix/client/versions`. ([\#12020](https://github.com/matrix-org/synapse/issues/12020), ([\#12022](https://github.com/matrix-org/synapse/issues/12022)) - Support only the stable identifier for [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069)'s `is_guest` on `/_matrix/client/v3/account/whoami`. ([\#12021](https://github.com/matrix-org/synapse/issues/12021)) - Use room version 9 as the default room version (per [MSC3589](https://github.com/matrix-org/matrix-doc/pull/3589)). ([\#12058](https://github.com/matrix-org/synapse/issues/12058)) - Add module callbacks to react to user deactivation status changes (i.e. deactivations and reactivations) and profile updates. ([\#12062](https://github.com/matrix-org/synapse/issues/12062)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where an edit of the latest event in a thread would not be properly applied to the thread summary. ([\#11992](https://github.com/matrix-org/synapse/issues/11992)) - Fix long-standing bug where the `get_rooms_for_user` cache was not correctly invalidated for remote users when the server left a room. ([\#11999](https://github.com/matrix-org/synapse/issues/11999)) - Fix a 500 error with Postgres when looking backwards with the [MSC3030](https://github.com/matrix-org/matrix-doc/pull/3030) `/timestamp_to_event?dir=b` endpoint. ([\#12024](https://github.com/matrix-org/synapse/issues/12024)) - Properly fix a long-standing bug where wrong data could be inserted into the `event_search` table when using SQLite. This could block running `synapse_port_db` with an `argument of type 'int' is not iterable` error. This bug was partially fixed by a change in Synapse 1.44.0. ([\#12037](https://github.com/matrix-org/synapse/issues/12037)) - Fix slow performance of `/logout` in some cases where refresh tokens are in use. The slowness existed since the initial implementation of refresh tokens in version 1.38.0. ([\#12056](https://github.com/matrix-org/synapse/issues/12056)) - Fix a long-standing bug where Synapse would make additional failing requests over federation for missing data. ([\#12077](https://github.com/matrix-org/synapse/issues/12077)) - Fix occasional `Unhandled error in Deferred` error message. ([\#12089](https://github.com/matrix-org/synapse/issues/12089)) - Fix a bug introduced in Synapse 1.51.0 where incoming federation transactions containing at least one EDU would be dropped if debug logging was enabled for `synapse.8631_debug`. ([\#12098](https://github.com/matrix-org/synapse/issues/12098)) - Fix a long-standing bug which could cause push notifications to malfunction if `use_frozen_dicts` was set in the configuration. ([\#12100](https://github.com/matrix-org/synapse/issues/12100)) - Fix an extremely rare, long-standing bug in `ReadWriteLock` that would cause an error when a newly unblocked writer completes instantly. ([\#12105](https://github.com/matrix-org/synapse/issues/12105)) - Make a `POST` to `/rooms/<room_id>/receipt/m.read/<event_id>` only trigger a push notification if the count of unread messages is different to the one in the last successfully sent push. This reduces server load and load on the receiving device. ([\#11835](https://github.com/matrix-org/synapse/issues/11835)) Updates to the Docker image --------------------------- - The Docker image no longer automatically creates a temporary volume at `/data`. This is not expected to affect normal usage. ([\#11997](https://github.com/matrix-org/synapse/issues/11997)) - Use Python 3.9 in Docker images by default. ([\#12112](https://github.com/matrix-org/synapse/issues/12112)) Improved Documentation ---------------------- - Document support for the `to_device`, `account_data`, `receipts`, and `presence` stream writers for workers. ([\#11599](https://github.com/matrix-org/synapse/issues/11599)) - Explain the meaning of spam checker callbacks' return values. ([\#12003](https://github.com/matrix-org/synapse/issues/12003)) - Clarify information about external Identity Provider IDs. ([\#12004](https://github.com/matrix-org/synapse/issues/12004)) Deprecations and Removals ------------------------- - Deprecate using `synctl` with the config option `synctl_cache_factor` and print a warning if a user still uses this option. ([\#11865](https://github.com/matrix-org/synapse/issues/11865)) - Remove support for the legacy structured logging configuration (please see the the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#legacy-structured-logging-configuration-removal) if you are using `structured: true` in the Synapse configuration). ([\#12008](https://github.com/matrix-org/synapse/issues/12008)) - Drop support for [MSC3283](https://github.com/matrix-org/matrix-doc/pull/3283) unstable flags now that the stable flags are supported. ([\#12018](https://github.com/matrix-org/synapse/issues/12018)) - Remove the unstable `/spaces` endpoint from [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946). ([\#12073](https://github.com/matrix-org/synapse/issues/12073)) Internal Changes ---------------- - Make the `get_room_version` method use `get_room_version_id` to benefit from caching. ([\#11808](https://github.com/matrix-org/synapse/issues/11808)) - Remove unnecessary condition on knock -> leave auth rule check. ([\#11900](https://github.com/matrix-org/synapse/issues/11900)) - Add tests for device list changes between local users. ([\#11972](https://github.com/matrix-org/synapse/issues/11972)) - Optimise calculating `device_list` changes in `/sync`. ([\#11974](https://github.com/matrix-org/synapse/issues/11974)) - Add missing type hints to storage classes. ([\#11984](https://github.com/matrix-org/synapse/issues/11984)) - Refactor the search code for improved readability. ([\#11991](https://github.com/matrix-org/synapse/issues/11991)) - Move common deduplication code down into `_auth_and_persist_outliers`. ([\#11994](https://github.com/matrix-org/synapse/issues/11994)) - Limit concurrent joins from applications services. ([\#11996](https://github.com/matrix-org/synapse/issues/11996)) - Preparation for faster-room-join work: when parsing the `send_join` response, get the `m.room.create` event from `state`, not `auth_chain`. ([\#12005](https://github.com/matrix-org/synapse/issues/12005), [\#12039](https://github.com/matrix-org/synapse/issues/12039)) - Preparation for faster-room-join work: parse MSC3706 fields in send_join response. ([\#12011](https://github.com/matrix-org/synapse/issues/12011)) - Preparation for faster-room-join work: persist information on which events and rooms have partial state to the database. ([\#12012](https://github.com/matrix-org/synapse/issues/12012)) - Preparation for faster-room-join work: Support for calling `/federation/v1/state` on a remote server. ([\#12013](https://github.com/matrix-org/synapse/issues/12013)) - Configure `tox` to use `venv` rather than `virtualenv`. ([\#12015](https://github.com/matrix-org/synapse/issues/12015)) - Fix bug in `StateFilter.return_expanded()` and add some tests. ([\#12016](https://github.com/matrix-org/synapse/issues/12016)) - Use Matrix v1.1 endpoints (`/_matrix/client/v3/auth/...`) in fallback auth HTML forms. ([\#12019](https://github.com/matrix-org/synapse/issues/12019)) - Update the `olddeps` CI job to use an old version of `markupsafe`. ([\#12025](https://github.com/matrix-org/synapse/issues/12025)) - Upgrade Mypy to version 0.931. ([\#12030](https://github.com/matrix-org/synapse/issues/12030)) - Remove legacy `HomeServer.get_datastore()`. ([\#12031](https://github.com/matrix-org/synapse/issues/12031), [\#12070](https://github.com/matrix-org/synapse/issues/12070)) - Minor typing fixes. ([\#12034](https://github.com/matrix-org/synapse/issues/12034), [\#12069](https://github.com/matrix-org/synapse/issues/12069)) - After joining a room, create a dedicated logcontext to process the queued events. ([\#12041](https://github.com/matrix-org/synapse/issues/12041)) - Tidy up GitHub Actions config which builds distributions for PyPI. ([\#12051](https://github.com/matrix-org/synapse/issues/12051)) - Move configuration out of `setup.cfg`. ([\#12052](https://github.com/matrix-org/synapse/issues/12052), [\#12059](https://github.com/matrix-org/synapse/issues/12059)) - Fix error message when a worker process fails to talk to another worker process. ([\#12060](https://github.com/matrix-org/synapse/issues/12060)) - Fix using the `complement.sh` script without specifying a directory or a branch. Contributed by Nico on behalf of Famedly. ([\#12063](https://github.com/matrix-org/synapse/issues/12063)) - Add type hints to `tests/rest/client`. ([\#12066](https://github.com/matrix-org/synapse/issues/12066), [\#12072](https://github.com/matrix-org/synapse/issues/12072), [\#12084](https://github.com/matrix-org/synapse/issues/12084), [\#12094](https://github.com/matrix-org/synapse/issues/12094)) - Add some logging to `/sync` to try and track down #11916. ([\#12068](https://github.com/matrix-org/synapse/issues/12068)) - Inspect application dependencies using `importlib.metadata` or its backport. ([\#12088](https://github.com/matrix-org/synapse/issues/12088)) - Use `assertEqual` instead of the deprecated `assertEquals` in test code. ([\#12092](https://github.com/matrix-org/synapse/issues/12092)) - Move experimental support for [MSC3440](https://github.com/matrix-org/matrix-doc/pull/3440) to `/versions`. ([\#12099](https://github.com/matrix-org/synapse/issues/12099)) - Add `stop_cancellation` utility function to stop `Deferred`s from being cancelled. ([\#12106](https://github.com/matrix-org/synapse/issues/12106)) - Improve exception handling for concurrent execution. ([\#12109](https://github.com/matrix-org/synapse/issues/12109)) - Advertise support for Python 3.10 in packaging files. ([\#12111](https://github.com/matrix-org/synapse/issues/12111)) - Move CI checks out of tox, to facilitate a move to using poetry. ([\#12119](https://github.com/matrix-org/synapse/issues/12119)) -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE8SRSDO7gYkSP4chELS76LzL74EcFAmIffxUACgkQLS76LzL7 4EefXxAAvnJb1BxzWwlYyKaDULjmNfsKilRWlT/A1/7VaumB84H4gFQklLuMbJdR pyktlkmVZrnLG+Vz2JfgFm4wTXvLGieACvlAodQWztQX2szqPAHeq0A0vuMgJEay mVKVnU6b83CONBr021/lm6NOBetbUqOVyiFsnuBKlLPs4WdSt+3DvBRZ3hsQTrCV zEOSdzVM67yr0xo3/vmT+nzlfcegJ64EOT+dFwMfKnoWbRK0lMwnob1WZbiOE0+9 9hoqEucbmzf/4IKgURxmNmrUDIPGUlGq4BnKMGMNyrwWv9v+8pXuIqzOYEUnWVBh upvS88OBswk2EXIIk22/rf5gohNShQDmki41CVTH32G+dP72YxCfTGsafwUpS+Hm KlojCRccmo2y2sQnLzrhswsOPFiYP0AORPIp3hO1mVTMZ7EgjsP4Y8C/S54Oe03F 6U3M5pv6aqURiAHAnyC4KbPOVqUbEzthUuRINEDp5QhNSFyvtwV9DTaFixMpMdR0 OJU8tMaGmCtqdsqNOZ4vGhzPVD/1kJ0KapPyJbkVSGoRdlI01sqO7Nu+k8AZ1oEc nkoR5zMTysCAuGCIOtCWB8NOFBNyEgcCdz3356e+wvWx4PazIFsfyEXskzZY50iK dAIdr+w+kyf4d/e9JpK7YHrPP5uP2s0V8Y4MvDx3wUXJ6VZ834Y= =jw9M -----END PGP SIGNATURE----- Merge tag 'v1.54.0rc1' into develop Synapse 1.54.0rc1 (2022-03-02) ============================== Please note that this will be the last release of Synapse that is compatible with Mjolnir 1.3.1 and earlier. Administrators of servers which have the Mjolnir module installed are advised to upgrade Mjolnir to version 1.3.2 or later. Features -------- - Add support for [MSC3202](https://github.com/matrix-org/matrix-doc/pull/3202): sending one-time key counts and fallback key usage states to Application Services. ([\#11617](https://github.com/matrix-org/synapse/issues/11617)) - Improve the generated URL previews for some web pages. Contributed by @AndrewRyanChama. ([\#11985](https://github.com/matrix-org/synapse/issues/11985)) - Track cache invalidations in Prometheus metrics, as already happens for cache eviction based on size or time. ([\#12000](https://github.com/matrix-org/synapse/issues/12000)) - Implement experimental support for [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) (account status endpoints). ([\#12001](https://github.com/matrix-org/synapse/issues/12001), [\#12067](https://github.com/matrix-org/synapse/issues/12067)) - Enable modules to set a custom display name when registering a user. ([\#12009](https://github.com/matrix-org/synapse/issues/12009)) - Advertise Matrix 1.1 and 1.2 support on `/_matrix/client/versions`. ([\#12020](https://github.com/matrix-org/synapse/issues/12020), ([\#12022](https://github.com/matrix-org/synapse/issues/12022)) - Support only the stable identifier for [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069)'s `is_guest` on `/_matrix/client/v3/account/whoami`. ([\#12021](https://github.com/matrix-org/synapse/issues/12021)) - Use room version 9 as the default room version (per [MSC3589](https://github.com/matrix-org/matrix-doc/pull/3589)). ([\#12058](https://github.com/matrix-org/synapse/issues/12058)) - Add module callbacks to react to user deactivation status changes (i.e. deactivations and reactivations) and profile updates. ([\#12062](https://github.com/matrix-org/synapse/issues/12062)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where an edit of the latest event in a thread would not be properly applied to the thread summary. ([\#11992](https://github.com/matrix-org/synapse/issues/11992)) - Fix long-standing bug where the `get_rooms_for_user` cache was not correctly invalidated for remote users when the server left a room. ([\#11999](https://github.com/matrix-org/synapse/issues/11999)) - Fix a 500 error with Postgres when looking backwards with the [MSC3030](https://github.com/matrix-org/matrix-doc/pull/3030) `/timestamp_to_event?dir=b` endpoint. ([\#12024](https://github.com/matrix-org/synapse/issues/12024)) - Properly fix a long-standing bug where wrong data could be inserted into the `event_search` table when using SQLite. This could block running `synapse_port_db` with an `argument of type 'int' is not iterable` error. This bug was partially fixed by a change in Synapse 1.44.0. ([\#12037](https://github.com/matrix-org/synapse/issues/12037)) - Fix slow performance of `/logout` in some cases where refresh tokens are in use. The slowness existed since the initial implementation of refresh tokens in version 1.38.0. ([\#12056](https://github.com/matrix-org/synapse/issues/12056)) - Fix a long-standing bug where Synapse would make additional failing requests over federation for missing data. ([\#12077](https://github.com/matrix-org/synapse/issues/12077)) - Fix occasional `Unhandled error in Deferred` error message. ([\#12089](https://github.com/matrix-org/synapse/issues/12089)) - Fix a bug introduced in Synapse 1.51.0 where incoming federation transactions containing at least one EDU would be dropped if debug logging was enabled for `synapse.8631_debug`. ([\#12098](https://github.com/matrix-org/synapse/issues/12098)) - Fix a long-standing bug which could cause push notifications to malfunction if `use_frozen_dicts` was set in the configuration. ([\#12100](https://github.com/matrix-org/synapse/issues/12100)) - Fix an extremely rare, long-standing bug in `ReadWriteLock` that would cause an error when a newly unblocked writer completes instantly. ([\#12105](https://github.com/matrix-org/synapse/issues/12105)) - Make a `POST` to `/rooms/<room_id>/receipt/m.read/<event_id>` only trigger a push notification if the count of unread messages is different to the one in the last successfully sent push. This reduces server load and load on the receiving device. ([\#11835](https://github.com/matrix-org/synapse/issues/11835)) Updates to the Docker image --------------------------- - The Docker image no longer automatically creates a temporary volume at `/data`. This is not expected to affect normal usage. ([\#11997](https://github.com/matrix-org/synapse/issues/11997)) - Use Python 3.9 in Docker images by default. ([\#12112](https://github.com/matrix-org/synapse/issues/12112)) Improved Documentation ---------------------- - Document support for the `to_device`, `account_data`, `receipts`, and `presence` stream writers for workers. ([\#11599](https://github.com/matrix-org/synapse/issues/11599)) - Explain the meaning of spam checker callbacks' return values. ([\#12003](https://github.com/matrix-org/synapse/issues/12003)) - Clarify information about external Identity Provider IDs. ([\#12004](https://github.com/matrix-org/synapse/issues/12004)) Deprecations and Removals ------------------------- - Deprecate using `synctl` with the config option `synctl_cache_factor` and print a warning if a user still uses this option. ([\#11865](https://github.com/matrix-org/synapse/issues/11865)) - Remove support for the legacy structured logging configuration (please see the the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#legacy-structured-logging-configuration-removal) if you are using `structured: true` in the Synapse configuration). ([\#12008](https://github.com/matrix-org/synapse/issues/12008)) - Drop support for [MSC3283](https://github.com/matrix-org/matrix-doc/pull/3283) unstable flags now that the stable flags are supported. ([\#12018](https://github.com/matrix-org/synapse/issues/12018)) - Remove the unstable `/spaces` endpoint from [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946). ([\#12073](https://github.com/matrix-org/synapse/issues/12073)) Internal Changes ---------------- - Make the `get_room_version` method use `get_room_version_id` to benefit from caching. ([\#11808](https://github.com/matrix-org/synapse/issues/11808)) - Remove unnecessary condition on knock -> leave auth rule check. ([\#11900](https://github.com/matrix-org/synapse/issues/11900)) - Add tests for device list changes between local users. ([\#11972](https://github.com/matrix-org/synapse/issues/11972)) - Optimise calculating `device_list` changes in `/sync`. ([\#11974](https://github.com/matrix-org/synapse/issues/11974)) - Add missing type hints to storage classes. ([\#11984](https://github.com/matrix-org/synapse/issues/11984)) - Refactor the search code for improved readability. ([\#11991](https://github.com/matrix-org/synapse/issues/11991)) - Move common deduplication code down into `_auth_and_persist_outliers`. ([\#11994](https://github.com/matrix-org/synapse/issues/11994)) - Limit concurrent joins from applications services. ([\#11996](https://github.com/matrix-org/synapse/issues/11996)) - Preparation for faster-room-join work: when parsing the `send_join` response, get the `m.room.create` event from `state`, not `auth_chain`. ([\#12005](https://github.com/matrix-org/synapse/issues/12005), [\#12039](https://github.com/matrix-org/synapse/issues/12039)) - Preparation for faster-room-join work: parse MSC3706 fields in send_join response. ([\#12011](https://github.com/matrix-org/synapse/issues/12011)) - Preparation for faster-room-join work: persist information on which events and rooms have partial state to the database. ([\#12012](https://github.com/matrix-org/synapse/issues/12012)) - Preparation for faster-room-join work: Support for calling `/federation/v1/state` on a remote server. ([\#12013](https://github.com/matrix-org/synapse/issues/12013)) - Configure `tox` to use `venv` rather than `virtualenv`. ([\#12015](https://github.com/matrix-org/synapse/issues/12015)) - Fix bug in `StateFilter.return_expanded()` and add some tests. ([\#12016](https://github.com/matrix-org/synapse/issues/12016)) - Use Matrix v1.1 endpoints (`/_matrix/client/v3/auth/...`) in fallback auth HTML forms. ([\#12019](https://github.com/matrix-org/synapse/issues/12019)) - Update the `olddeps` CI job to use an old version of `markupsafe`. ([\#12025](https://github.com/matrix-org/synapse/issues/12025)) - Upgrade Mypy to version 0.931. ([\#12030](https://github.com/matrix-org/synapse/issues/12030)) - Remove legacy `HomeServer.get_datastore()`. ([\#12031](https://github.com/matrix-org/synapse/issues/12031), [\#12070](https://github.com/matrix-org/synapse/issues/12070)) - Minor typing fixes. ([\#12034](https://github.com/matrix-org/synapse/issues/12034), [\#12069](https://github.com/matrix-org/synapse/issues/12069)) - After joining a room, create a dedicated logcontext to process the queued events. ([\#12041](https://github.com/matrix-org/synapse/issues/12041)) - Tidy up GitHub Actions config which builds distributions for PyPI. ([\#12051](https://github.com/matrix-org/synapse/issues/12051)) - Move configuration out of `setup.cfg`. ([\#12052](https://github.com/matrix-org/synapse/issues/12052), [\#12059](https://github.com/matrix-org/synapse/issues/12059)) - Fix error message when a worker process fails to talk to another worker process. ([\#12060](https://github.com/matrix-org/synapse/issues/12060)) - Fix using the `complement.sh` script without specifying a directory or a branch. Contributed by Nico on behalf of Famedly. ([\#12063](https://github.com/matrix-org/synapse/issues/12063)) - Add type hints to `tests/rest/client`. ([\#12066](https://github.com/matrix-org/synapse/issues/12066), [\#12072](https://github.com/matrix-org/synapse/issues/12072), [\#12084](https://github.com/matrix-org/synapse/issues/12084), [\#12094](https://github.com/matrix-org/synapse/issues/12094)) - Add some logging to `/sync` to try and track down #11916. ([\#12068](https://github.com/matrix-org/synapse/issues/12068)) - Inspect application dependencies using `importlib.metadata` or its backport. ([\#12088](https://github.com/matrix-org/synapse/issues/12088)) - Use `assertEqual` instead of the deprecated `assertEquals` in test code. ([\#12092](https://github.com/matrix-org/synapse/issues/12092)) - Move experimental support for [MSC3440](https://github.com/matrix-org/matrix-doc/pull/3440) to `/versions`. ([\#12099](https://github.com/matrix-org/synapse/issues/12099)) - Add `stop_cancellation` utility function to stop `Deferred`s from being cancelled. ([\#12106](https://github.com/matrix-org/synapse/issues/12106)) - Improve exception handling for concurrent execution. ([\#12109](https://github.com/matrix-org/synapse/issues/12109)) - Advertise support for Python 3.10 in packaging files. ([\#12111](https://github.com/matrix-org/synapse/issues/12111)) - Move CI checks out of tox, to facilitate a move to using poetry. ([\#12119](https://github.com/matrix-org/synapse/issues/12119))	2022-03-02 15:26:43 +00:00
Erik Johnston	6d282a9c89	Make release script write correct no-op changelog (#12127 ) As we want to include the previous version in the "No new changes..." string.	2022-03-02 14:28:18 +00:00
Patrick Cloke	1103c5fe8a	Check if instances are lists, not sequences. (#12128 ) As a str is a sequence, the checks were not granular enough and would allow lists or strings, when only lists were valid.	2022-03-02 13:18:51 +00:00
David Robertson	f3f0ab10fe	Move scripts directory inside synapse, exposing as setuptools entry_points (#12118 ) * Two scripts are basically entry_points already * Move and rename scripts/* to synapse/_scripts/.py Delete sync_room_to_group.pl * Expose entry points in setup.py * Update linter script and config * Fixup scripts & docs mentioning scripts that moved Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2022-03-02 13:00:16 +00:00
Patrick Cloke	6adb89ff00	Improve and refactor the tests for relations. (#12113 ) * Modernizes code (f-strings, etc.) * Fixes incorrect comments. * Splits the test case into two. * Factors out some duplicated code.	2022-03-02 06:56:16 -05:00
Olivier Wilkinson (reivilibre)	879e4a7bd7	1.54.0rc1	2022-03-02 10:45:16 +00:00
Olivier Wilkinson (reivilibre)	a43a5ea5bf	Remove misleading newsfile from #12126 which backs out an unreleased change.	2022-03-02 10:38:10 +00:00
reivilibre	c7b2f1ccdc	Back out in-flight state caching changes. (#12126 )	2022-03-02 10:37:04 +00:00
lukasdenk	8e56a1b73c	Make get_room_version use cached get_room_version_id. (#11808 )	2022-03-02 10:35:34 +00:00
David Robertson	5f62a094de	Detox, part 1 of N (#12119 ) * Don't use `tox` for `check-sampleconfig` * Don't use `tox` for check-newsfragment	2022-03-01 19:47:02 +00:00
David Robertson	313581e4e9	Use importlib.metadata to read requirements (#12088 ) * Pull runtime dep checks into their own module * Reimplement `check_requirements` using `importlib` I've tried to make this clearer. We start by working out which of Synapse's requirements we need to be installed here and now. I was surprised that there wasn't an easier way to see which packages were installed by a given extra. I've pulled out the error messages into functions that deal with "is this for an extra or not". And I've rearranged the loop over two different sets of requirements into one loop with a "must be instaled" flag. I hope you agree that this is clearer. * Test cases	2022-03-01 17:44:41 +00:00
Sean Quah	4d6b6c17c8	Fix rare error in `ReadWriteLock` when writers complete immediately (#12105 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-01 15:27:15 +00:00
Brendan Abolivier	300ed0b8a6	Add module callbacks called for reacting to deactivation status change and profile update (#12062 )	2022-03-01 15:00:03 +00:00
Andrew Morgan	f26e390a40	Use Python 3.9 in Synapse dockerfiles by default (#12112 )	2022-03-01 13:55:18 +00:00
Sean Quah	91bc15c772	Add `stop_cancellation` utility function (#12106 )	2022-03-01 13:51:03 +00:00
reivilibre	c893632319	Order in-flight state group queries in biggest-first order (#11610 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-01 13:41:57 +00:00
Richard van der Hoff	e2e1d90a5e	Faster joins: persist to database (#12012 ) When we get a partial_state response from send_join, store information in the database about it: * store a record about the room as a whole having partial state, and stash the list of member servers too. * flag the join event itself as having partial state * also, for any new events whose prev-events are partial-stated, note that they will also be partial-stated. We don't yet make any attempt to interpret this data, so API calls (and a bunch of other things) are just going to get incorrect data.	2022-03-01 12:49:54 +00:00
Andrew Morgan	4ccc2d09aa	Advertise Python 3.10 support in setup.py (#12111 )	2022-03-01 12:35:32 +00:00
Richard van der Hoff	5458eb8551	Fix 'Unhandled error in Deferred' (#12089 ) * Fix 'Unhandled error in Deferred' Fixes a CRITICAL "Unhandled error in Deferred" log message which happened when a function wrapped with `@cachedList` failed * Minor optimisation to cachedListDescriptor we can avoid re-using `missing`, which saves looking up entries in `deferreds_map`, and means we don't need to copy it. * Improve type annotation on CachedListDescriptor	2022-03-01 09:51:38 +00:00
Richard van der Hoff	9d11fee8f2	Improve exception handling for concurrent execution (#12109 ) * fix incorrect unwrapFirstError import this was being imported from the wrong place * Refactor `concurrently_execute` to use `yieldable_gather_results` * Improve exception handling in `yieldable_gather_results` Try to avoid swallowing so many stack traces. * mark unwrapFirstError deprecated * changelog	2022-03-01 09:34:30 +00:00
Dirk Klimpel	952efd0bca	Add type hints to `tests/rest/client` (#12094 ) * Add type hints to `tests/rest/client` * update `mypy.ini` * newsfile * add `test_register.py`	2022-02-28 18:59:00 +00:00
Patrick Cloke	7754af24ab	Remove the unstable `/spaces` endpoint. (#12073 ) ...and various code supporting it. The /spaces endpoint was from an old version of MSC2946 and included both a Client-Server and Server-Server API. Note that the unstable /hierarchy endpoint (from the final version of MSC2946) is not yet removed.	2022-02-28 18:33:00 +00:00
Patrick Cloke	1866fb39d7	Move experimental support for MSC3440 to /versions. (#12099 ) Instead of being part of /capabilities, this matches a change to MSC3440 to properly use these endpoints.	2022-02-28 18:29:09 +00:00
Dirk Klimpel	1901cb1d4a	Add type hints to `tests/rest/client` (#12084 )	2022-02-28 17:47:37 +00:00
Richard van der Hoff	6c0b44a3d7	Fix `PushRuleEvaluator` and `Filter` to work on frozendicts (#12100 ) * Fix `PushRuleEvaluator` to work on frozendicts frozendicts do not (necessarily) inherit from dict, so this needs to handle them correctly. * Fix event filtering for frozen events Looks like this one was introduced by #11194.	2022-02-28 17:40:24 +00:00
David Robertson	5565f454e1	Actually fix bad debug logging rejecting device list & signing key transactions (#12098 )	2022-02-28 14:10:36 +00:00
Patrick Cloke	9e83521af8	Properly failover for unknown endpoints from Conduit/Dendrite. (#12077 ) Before this fix, a legitimate 404 from a federation endpoint (e.g. due to an unknown room) would be treated as an unknown endpoint. This could cause unnecessary federation traffic.	2022-02-28 07:52:44 -05:00
Patrick Cloke	02d708568b	Replace assertEquals and friends with non-deprecated versions. (#12092 )	2022-02-28 07:12:29 -05:00
lukasdenk	ab3ef49059	synctl: print warning if synctl_cache_factor is set in config (#11865 ) Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2022-02-28 11:42:13 +00:00
Sean Quah	b43c3ef8e2	Ensure that `get_datastores().main` is typed (#12070 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-02-25 10:20:40 +00:00
Sean Quah	f3fd8558cd	Minor typing fixes for `synapse/storage/persist_events.py` (#12069 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-02-25 10:19:49 +00:00
Dirk Klimpel	54e74cc15f	Add type hints to `tests/rest/client` (#12072 )	2022-02-24 13:56:38 -05:00
reivilibre	2cc5ea933d	Add support for MSC3202: sending one-time key counts and fallback key usage states to Application Services. (#11617 ) Co-authored-by: Erik Johnston <erik@matrix.org>	2022-02-24 17:55:45 +00:00
Sean Quah	41cf4c2cf6	Fix non-strings in the `event_search` table (#12037 ) Don't attempt to add non-string `value`s to `event_search` and add a background update to clear out bad rows from `event_search` when using sqlite. Signed-off-by: Sean Quah <seanq@element.io>	2022-02-24 11:52:28 +00:00
Patrick Cloke	c56bfb08bc	Add documentation for missing worker types. (#11599 ) And clean-up the endpoints which should be routed to workers.	2022-02-23 22:49:04 +00:00
Erik Johnston	a711ae78a8	Add logging to `/sync` for debugging #11916 (#12068 )	2022-02-23 14:22:22 +00:00
Dirk Klimpel	64c73c6ac8	Add type hints to `tests/rest/client` (#12066 )	2022-02-23 08:33:19 -05:00
Richard van der Hoff	5b2b36809f	Remove more references to `get_datastore` (#12067 ) These have snuck in since #12031 was started. Also a couple of other cleanups while we're in the area.	2022-02-23 12:35:53 +00:00
Richard van der Hoff	e24ff8ebe3	Remove `HomeServer.get_datastore()` (#12031 ) The presence of this method was confusing, and mostly present for backwards compatibility. Let's get rid of it. Part of #11733	2022-02-23 11:04:02 +00:00
Nicolas Werner	c1ac2a8135	Rename default branch of complement.sh to main (#12063 ) The complement.sh script relies on the name of the ref matching the name of the unpacked folder. The branch redirect from renaming the default branch breaks that assumption. Signed-off-by: Nicolas Werner <n.werner@famedly.com>	2022-02-23 10:06:18 +00:00
Travis Ralston	e3fe6347be	Remove excess condition on `knock->leave` check (#11900 )	2022-02-22 18:35:01 +00:00
Erik Johnston	6d14b3dabf	Better error message when failing to request from another process (#12060 )	2022-02-22 15:52:08 +00:00
Brendan Abolivier	250104d357	Implement account status endpoints (MSC3720) (#12001 ) See matrix-org/matrix-doc#3720 Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-02-22 15:10:10 +00:00
David Robertson	94a396e7c4	Prune setup.cfg some more (#12059 ) * Remove `trial` section from setup.cfg This was added in the initial commit from 2014. I can't see that it does anything. Maybe it's there so that you can run `trial` without any extra args, but if I do that then I just get the `--help` message. * Move flake8's config to its own file	2022-02-22 14:52:56 +00:00
reivilibre	dcb6a37837	Cap the number of in-flight requests for state from a single group (#11608 )	2022-02-22 14:24:31 +00:00
Patrick Cloke	7bcc28f82f	Use room version 9 as the default room version (per MSC3589). (#12058 )	2022-02-22 14:09:40 +00:00
Richard van der Hoff	81364db49b	Run `_handle_queued_pdus` as a background process (#12041 ) ... to ensure it gets a proper log context, mostly.	2022-02-22 13:33:22 +00:00
reivilibre	235d2916ce	Fix slow performance of `/logout` in some cases where refresh tokens are in use. The slowness existed since the initial implementation of refresh tokens. (#12056 )	2022-02-22 13:29:04 +00:00
Richard van der Hoff	7273011f60	Faster joins: Support for calling `/federation/v1/state` (#12013 ) This is an endpoint that we have server-side support for, but no client-side support. It's going to be useful for resyncing partial-stated rooms, so let's introduce it.	2022-02-22 12:17:10 +00:00
AndrewRyanChama	066171643b	Fetch images when previewing Twitter URLs. (#11985 ) By including "bot" in the User-Agent, which some sites use to decide whether to include additional Open Graph information.	2022-02-22 07:11:39 -05:00
reivilibre	546b9c9e64	Add more tests for in-flight state query duplication. (#12033 )	2022-02-22 11:44:11 +00:00
David Robertson	af2c1e3d2a	Tidy the building of sdists and wheels (#12051 ) * Don't build distribution pkgs in tests.yml * Run `release-artifacts` on release branches * Use backend-meta workflow for packaging	2022-02-22 11:33:37 +00:00
David Robertson	1ae492c8c0	Move isort config to `pyproject.toml` (#12052 )	2022-02-22 11:30:19 +00:00
Travis Ralston	d7cb0dcbaa	Use v3 endpoints for fallback auth (Matrix 1.1) (#12019 )	2022-02-22 11:20:45 +00:00
Richard van der Hoff	3070af4809	remote join processing: get create event from state, not auth_chain (#12039 ) A follow-up to #12005, in which I apparently missed that there are a bunch of other places that assume the create event is in the auth chain.	2022-02-21 19:27:35 +00:00
Richard van der Hoff	a85dde3445	Minor typing fixes (#12034 ) These started failing in https://github.com/matrix-org/synapse/pull/12031... I'm a bit mystified by how they ever worked.	2022-02-21 18:37:04 +00:00
Dirk Klimpel	7c82da27aa	Add type hints to `synapse/storage/databases/main` (#11984 )	2022-02-21 16:03:06 +00:00
Travis Ralston	99f6d79fe1	Advertise Matrix 1.2 in `/_matrix/client/versions` (#12022 ) Co-authored-by: Patrick Cloke <patrickc@matrix.org>	2022-02-21 08:59:29 -07:00
Patrick Cloke	444b04058b	Document why auth providers aren't validated in the admin API. (#12004 ) Since it is reasonable to give a future or past auth provider, which might not be in the current configuration.	2022-02-18 17:24:25 +00:00
reivilibre	284ea2025a	Track and deduplicate in-flight requests to `_get_state_for_groups`. (#10870 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-02-18 17:23:31 +00:00
Sean Quah	e6acd3cf4f	Upgrade mypy to version 0.931 (#12030 ) Upgrade mypy to 0.931, mypy-zope to 0.3.5 and fix new complaints.	2022-02-18 15:57:26 +00:00
reivilibre	eb609c65d0	Fix bug in `StateFilter.return_expanded()` and add some tests. (#12016 )	2022-02-18 14:54:31 +00:00
Travis Ralston	31a298fec7	Advertise Matrix 1.1 in `/_matrix/client/versions` (#12020 )	2022-02-18 07:49:53 -05:00
Travis Ralston	19bd9cff1a	Use stable MSC3069 `is_guest` flag on `/whoami`. (#12021 ) Keeping backwards compatibility with the unstable flag for now.	2022-02-18 07:48:23 -05:00
Eric Eastwood	5a6911598a	Fix 500 error with Postgres when looking backwards with the MSC3030 `/timestamp_to_event` endpoint (#12024 )	2022-02-18 12:11:18 +00:00
Brendan Abolivier	40e256e7aa	Update the olddeps CI check to use an old version of markupsafe (#12025 )	2022-02-18 11:38:48 +00:00
Erik Johnston	3f4d25a48b	Remove unstable MSC3283 flags (#12018 ) Fixes #11962	2022-02-17 17:22:55 +00:00
Brendan Abolivier	707049c6ff	Allow modules to set a display name on registration (#12009 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-02-17 16:54:16 +00:00
Richard van der Hoff	da0e9f8efd	Faster joins: parse msc3706 fields in send_join response (#12011 ) Part of my work on #11249: add code to handle the new fields added in MSC3706.	2022-02-17 16:11:59 +00:00
Richard van der Hoff	6127c4b9f1	Configure `tox` to use `venv` (#12015 ) As the comment says, virtualenv is a pile of fail.	2022-02-17 15:55:14 +00:00
Patrick Cloke	e69f8f0a8e	Remove support for the legacy structured logging configuration. (#12008 )	2022-02-17 13:32:18 +00:00
Richard van der Hoff	696acd3515	`send_join` response: get create event from `state`, not `auth_chain` (#12005 ) msc3706 proposes changing the `/send_join` response: > Any events returned within `state` can be omitted from `auth_chain`. Currently, we rely on `m.room.create` being returned in `auth_chain`, but since the `m.room.create` event must necessarily be part of the state, the above change will break this. In short, let's look for `m.room.create` in `state` rather than `auth_chain`.	2022-02-17 11:59:26 +00:00
lukasdenk	4077177390	Prevent duplicate push notifications for room reads (#11835 )	2022-02-17 10:23:54 +00:00
David Robertson	73fc488783	Explain the meaning of spam checker callbacks' return values (#12003 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-02-16 12:25:43 +00:00
Brendan Abolivier	130fd45393	Limit concurrent AS joins (#11996 ) Initially introduced in matrix-org-hotfixes by `e5537cf` (and tweaked by later commits). Fixes #11995 See also #4826	2022-02-16 11:16:48 +00:00
Erik Johnston	2b5643b3af	Optimise calculating device_list changes in `/sync`. (#11974 ) For users with large accounts it is inefficient to calculate the set of users they share a room with (and takes a lot of space in the cache). Instead we can look at users whose devices have changed since the last sync and check if they share a room with the syncing user.	2022-02-15 15:01:00 +00:00
Richard van der Hoff	bab2394aa9	`_auth_and_persist_outliers`: drop events we have already seen (#11994 ) We already have two copies of this code, in 2/3 of the callers of `_auth_and_persist_outliers`. Before I add a third, let's push it down.	2022-02-15 14:33:28 +00:00
Erik Johnston	0dbbe33a65	Track cache invalidations (#12000 ) Currently we only track evictions due to size or time constraints.	2022-02-15 14:31:04 +00:00
Erik Johnston	dc9fe61050	Fix incorrect `get_rooms_for_user` for remote user (#11999 ) When the server leaves a room the `get_rooms_for_user` cache is not correctly invalidated for the remote users in the room. This means that subsequent calls to `get_rooms_for_user` for the remote users would incorrectly include the room (it shouldn't be included because the server no longer knows anything about the room).	2022-02-15 14:26:28 +00:00
Richard van der Hoff	5598556b77	Docker: remove `VOLUME` directive (#11997 ) The driver for this is to stop Complement complaining about it, but as far as I can tell it was pointless and needed to go away anyway. I'm a bit unclear about what exactly VOLUME does, but I think what it means is that, if you don't override it with an explicit -v argument, then docker run will create a temporary volume, and copy things into it. The temporary volume is then deleted when the container finishes. That only sounds useful if your image has something to copy into it (otherwise you may as well just use the default root filesystem), and our image notably doesn't copy anything into /data. So... this wasn't doing anything, except annoying Complement?	2022-02-15 13:59:15 +00:00
Patrick Cloke	e44f91d678	Refactor search code to reduce function size. (#11991 ) Splits the search code into a few logical functions instead of a single unreadable function. There are also a few additional changes for readability. After refactoring it was clear to see there were some unused and unnecessary variables, which were simplified.	2022-02-15 13:47:05 +00:00
Patrick Cloke	45f45404de	Fix incorrect thread summaries when the latest event is edited. (#11992 ) If the latest event in a thread was edited than the original event content was included in bundled aggregation for threads instead of the edited event content.	2022-02-15 08:26:57 -05:00
Sean Quah	85e24d9d2b	Synapse 1.53.0rc1 (2022-02-15) ============================== Features -------- - Add experimental support for sending to-device messages to application services, as specified by [MSC2409](https://github.com/matrix-org/matrix-doc/pull/2409). ([\#11215](https://github.com/matrix-org/synapse/issues/11215), [\#11966](https://github.com/matrix-org/synapse/issues/11966)) - Remove account data (including client config, push rules and ignored users) upon user deactivation. ([\#11655](https://github.com/matrix-org/synapse/issues/11655)) - Experimental support for [MSC3666](https://github.com/matrix-org/matrix-doc/pull/3666): including bundled aggregations in server side search results. ([\#11837](https://github.com/matrix-org/synapse/issues/11837)) - Enable cache time-based expiry by default. The `expiry_time` config flag has been superseded by `expire_caches` and `cache_entry_ttl`. ([\#11849](https://github.com/matrix-org/synapse/issues/11849)) - Add a callback to allow modules to allow or forbid a 3PID (email address, phone number) from being associated to a local account. ([\#11854](https://github.com/matrix-org/synapse/issues/11854)) - Stabilize support and remove unstable endpoints for [MSC3231](https://github.com/matrix-org/matrix-doc/pull/3231). Clients must switch to the stable identifier and endpoint. See the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#stablisation-of-msc3231) for more information. ([\#11867](https://github.com/matrix-org/synapse/issues/11867)) - Allow modules to retrieve the current instance's server name and worker name. ([\#11868](https://github.com/matrix-org/synapse/issues/11868)) - Use a dedicated configurable rate limiter for 3PID invites. ([\#11892](https://github.com/matrix-org/synapse/issues/11892)) - Support the stable API endpoint for [MSC3283](https://github.com/matrix-org/matrix-doc/pull/3283): new settings in `/capabilities` endpoint. ([\#11933](https://github.com/matrix-org/synapse/issues/11933), [\#11989](https://github.com/matrix-org/synapse/issues/11989)) - Support the `dir` parameter on the `/relations` endpoint, per [MSC3715](https://github.com/matrix-org/matrix-doc/pull/3715). ([\#11941](https://github.com/matrix-org/synapse/issues/11941)) - Experimental implementation of [MSC3706](https://github.com/matrix-org/matrix-doc/pull/3706): extensions to `/send_join` to support reduced response size. ([\#11967](https://github.com/matrix-org/synapse/issues/11967)) Bugfixes -------- - Fix [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) historical messages backfilling in random order on remote homeservers. ([\#11114](https://github.com/matrix-org/synapse/issues/11114)) - Fix a bug introduced in Synapse 1.51.0 where incoming federation transactions containing at least one EDU would be dropped if debug logging was enabled for `synapse.8631_debug`. ([\#11890](https://github.com/matrix-org/synapse/issues/11890)) - Fix a long-standing bug where some unknown endpoints would return HTML error pages instead of JSON `M_UNRECOGNIZED` errors. ([\#11930](https://github.com/matrix-org/synapse/issues/11930)) - Implement an allow list of content types for which we will attempt to preview a URL. This prevents Synapse from making useless longer-lived connections to streaming media servers. ([\#11936](https://github.com/matrix-org/synapse/issues/11936)) - Fix a long-standing bug where pagination tokens from `/sync` and `/messages` could not be provided to the `/relations` API. ([\#11952](https://github.com/matrix-org/synapse/issues/11952)) - Require that modules register their callbacks using keyword arguments. ([\#11975](https://github.com/matrix-org/synapse/issues/11975)) - Fix a long-standing bug where `M_WRONG_ROOM_KEYS_VERSION` errors would not include the specced `current_version` field. ([\#11988](https://github.com/matrix-org/synapse/issues/11988)) Improved Documentation ---------------------- - Fix typo in User Admin API: unpind -> unbind. ([\#11859](https://github.com/matrix-org/synapse/issues/11859)) - Document images returned by the User List Media Admin API can include those generated by URL previews. ([\#11862](https://github.com/matrix-org/synapse/issues/11862)) - Remove outdated MSC1711 FAQ document. ([\#11907](https://github.com/matrix-org/synapse/issues/11907)) - Correct the structured logging configuration example. Contributed by Brad Jones. ([\#11946](https://github.com/matrix-org/synapse/issues/11946)) - Add information on the Synapse release cycle. ([\#11954](https://github.com/matrix-org/synapse/issues/11954)) - Fix broken link in the README to the admin API for password reset. ([\#11955](https://github.com/matrix-org/synapse/issues/11955)) Deprecations and Removals ------------------------- - Drop support for `webclient` listeners and configuring `web_client_location` to a non-HTTP(S) URL. Deprecated configurations are a configuration error. ([\#11895](https://github.com/matrix-org/synapse/issues/11895)) - Remove deprecated `user_may_create_room_with_invites` spam checker callback. See the [upgrade notes](https://matrix-org.github.io/synapse/latest/upgrade.html#removal-of-user_may_create_room_with_invites) for more information. ([\#11950](https://github.com/matrix-org/synapse/issues/11950)) - No longer build `.deb` packages for Ubuntu 21.04 Hirsute Hippo, which has now EOLed. ([\#11961](https://github.com/matrix-org/synapse/issues/11961)) Internal Changes ---------------- - Enhance user registration test helpers to make them more useful for tests involving application services and devices. ([\#11615](https://github.com/matrix-org/synapse/issues/11615), [\#11616](https://github.com/matrix-org/synapse/issues/11616)) - Improve performance when fetching bundled aggregations for multiple events. ([\#11660](https://github.com/matrix-org/synapse/issues/11660), [\#11752](https://github.com/matrix-org/synapse/issues/11752)) - Fix type errors introduced by new annotations in the Prometheus Client library. ([\#11832](https://github.com/matrix-org/synapse/issues/11832)) - Add missing type hints to replication code. ([\#11856](https://github.com/matrix-org/synapse/issues/11856), [\#11938](https://github.com/matrix-org/synapse/issues/11938)) - Ensure that `opentracing` scopes are activated and closed at the right time. ([\#11869](https://github.com/matrix-org/synapse/issues/11869)) - Improve opentracing for incoming federation requests. ([\#11870](https://github.com/matrix-org/synapse/issues/11870)) - Improve internal docstrings in `synapse.util.caches`. ([\#11876](https://github.com/matrix-org/synapse/issues/11876)) - Do not needlessly clear the `get_users_in_room` and `get_users_in_room_with_profiles` caches when any room state changes. ([\#11878](https://github.com/matrix-org/synapse/issues/11878)) - Convert `ApplicationServiceTestCase` to use `simple_async_mock`. ([\#11880](https://github.com/matrix-org/synapse/issues/11880)) - Remove experimental changes to the default push rules which were introduced in Synapse 1.19.0 but never enabled. ([\#11884](https://github.com/matrix-org/synapse/issues/11884)) - Disable coverage calculation for olddeps build. ([\#11888](https://github.com/matrix-org/synapse/issues/11888)) - Preparation to support sending device list updates to application services. ([\#11905](https://github.com/matrix-org/synapse/issues/11905)) - Add a test that checks users receive their own device list updates down `/sync`. ([\#11909](https://github.com/matrix-org/synapse/issues/11909)) - Run Complement tests sequentially. ([\#11910](https://github.com/matrix-org/synapse/issues/11910)) - Various refactors to the application service notifier code. ([\#11911](https://github.com/matrix-org/synapse/issues/11911), [\#11912](https://github.com/matrix-org/synapse/issues/11912)) - Tests: replace mocked `Authenticator` with the real thing. ([\#11913](https://github.com/matrix-org/synapse/issues/11913)) - Various refactors to the typing notifications code. ([\#11914](https://github.com/matrix-org/synapse/issues/11914)) - Use the proper type for the `Content-Length` header in the `UploadResource`. ([\#11927](https://github.com/matrix-org/synapse/issues/11927)) - Remove an unnecessary ignoring of type hints due to fixes in upstream packages. ([\#11939](https://github.com/matrix-org/synapse/issues/11939)) - Add missing type hints. ([\#11953](https://github.com/matrix-org/synapse/issues/11953)) - Fix an import cycle in `synapse.event_auth`. ([\#11965](https://github.com/matrix-org/synapse/issues/11965)) - Unpin `frozendict` but exclude the known bad version 2.1.2. ([\#11969](https://github.com/matrix-org/synapse/issues/11969)) - Prepare for rename of default Complement branch. ([\#11971](https://github.com/matrix-org/synapse/issues/11971)) - Fetch Synapse's version using a helper from `matrix-common`. ([\#11979](https://github.com/matrix-org/synapse/issues/11979)) -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEWMTnW8Z8khaaf90R+84KzgcyGG8FAmILmzYACgkQ+84Kzgcy GG8e7gwAsbDeek7v14ezJwETabXpw957fOe2CVA9DfU1yrORrATy38dIe1ppbzEQ OzSPehykBg7+z+eDRQ1b8tjfTfDlOSuBmjfBm1qdYYPTPwc1LP5K62uOG3QDbOVw YlxNB21Yp3m+yhp4VhSZzx2b5H+noYyll9rlamQ1tW3EOruJEdwAXyhlXfx2azLC qHVn1UF+q2htD65VaoF3XQSP6cmzWtEG7BFtmDCwIGCTdc+WENN9HJuWp1axwBs6 V6lVosiHxQzo38dk6ZYwsnHO5ObcuYsPzhuLgJVt9X9sE03YAXLknmQdizIJBy0f nz1GESZ1osuokU8v88k5Y5Z5RiCeauD/75RdORk9070sPyedY2rFVdyWcq42pjpP mWJ7DpQsGZQG5c2tPJTyfMpPg+KcXY02WpIvmUvced5iT/FGfCx7xSaA3JOsFrtp 2s8LWanaIKhU0XZ2MkXoH3ZdZPfQmzyVSCwIQOE04kio/3tmbRE90Fn1DAK9a+O6 WVOTWMGK =8tcJ -----END PGP SIGNATURE----- Merge tag 'v1.53.0rc1' into develop Synapse 1.53.0rc1 (2022-02-15) ============================== Features -------- - Add experimental support for sending to-device messages to application services, as specified by [MSC2409](https://github.com/matrix-org/matrix-doc/pull/2409). ([\#11215](https://github.com/matrix-org/synapse/issues/11215), [\#11966](https://github.com/matrix-org/synapse/issues/11966)) - Remove account data (including client config, push rules and ignored users) upon user deactivation. ([\#11655](https://github.com/matrix-org/synapse/issues/11655)) - Experimental support for [MSC3666](https://github.com/matrix-org/matrix-doc/pull/3666): including bundled aggregations in server side search results. ([\#11837](https://github.com/matrix-org/synapse/issues/11837)) - Enable cache time-based expiry by default. The `expiry_time` config flag has been superseded by `expire_caches` and `cache_entry_ttl`. ([\#11849](https://github.com/matrix-org/synapse/issues/11849)) - Add a callback to allow modules to allow or forbid a 3PID (email address, phone number) from being associated to a local account. ([\#11854](https://github.com/matrix-org/synapse/issues/11854)) - Stabilize support and remove unstable endpoints for [MSC3231](https://github.com/matrix-org/matrix-doc/pull/3231). Clients must switch to the stable identifier and endpoint. See the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#stablisation-of-msc3231) for more information. ([\#11867](https://github.com/matrix-org/synapse/issues/11867)) - Allow modules to retrieve the current instance's server name and worker name. ([\#11868](https://github.com/matrix-org/synapse/issues/11868)) - Use a dedicated configurable rate limiter for 3PID invites. ([\#11892](https://github.com/matrix-org/synapse/issues/11892)) - Support the stable API endpoint for [MSC3283](https://github.com/matrix-org/matrix-doc/pull/3283): new settings in `/capabilities` endpoint. ([\#11933](https://github.com/matrix-org/synapse/issues/11933), [\#11989](https://github.com/matrix-org/synapse/issues/11989)) - Support the `dir` parameter on the `/relations` endpoint, per [MSC3715](https://github.com/matrix-org/matrix-doc/pull/3715). ([\#11941](https://github.com/matrix-org/synapse/issues/11941)) - Experimental implementation of [MSC3706](https://github.com/matrix-org/matrix-doc/pull/3706): extensions to `/send_join` to support reduced response size. ([\#11967](https://github.com/matrix-org/synapse/issues/11967)) Bugfixes -------- - Fix [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) historical messages backfilling in random order on remote homeservers. ([\#11114](https://github.com/matrix-org/synapse/issues/11114)) - Fix a bug introduced in Synapse 1.51.0 where incoming federation transactions containing at least one EDU would be dropped if debug logging was enabled for `synapse.8631_debug`. ([\#11890](https://github.com/matrix-org/synapse/issues/11890)) - Fix a long-standing bug where some unknown endpoints would return HTML error pages instead of JSON `M_UNRECOGNIZED` errors. ([\#11930](https://github.com/matrix-org/synapse/issues/11930)) - Implement an allow list of content types for which we will attempt to preview a URL. This prevents Synapse from making useless longer-lived connections to streaming media servers. ([\#11936](https://github.com/matrix-org/synapse/issues/11936)) - Fix a long-standing bug where pagination tokens from `/sync` and `/messages` could not be provided to the `/relations` API. ([\#11952](https://github.com/matrix-org/synapse/issues/11952)) - Require that modules register their callbacks using keyword arguments. ([\#11975](https://github.com/matrix-org/synapse/issues/11975)) - Fix a long-standing bug where `M_WRONG_ROOM_KEYS_VERSION` errors would not include the specced `current_version` field. ([\#11988](https://github.com/matrix-org/synapse/issues/11988)) Improved Documentation ---------------------- - Fix typo in User Admin API: unpind -> unbind. ([\#11859](https://github.com/matrix-org/synapse/issues/11859)) - Document images returned by the User List Media Admin API can include those generated by URL previews. ([\#11862](https://github.com/matrix-org/synapse/issues/11862)) - Remove outdated MSC1711 FAQ document. ([\#11907](https://github.com/matrix-org/synapse/issues/11907)) - Correct the structured logging configuration example. Contributed by Brad Jones. ([\#11946](https://github.com/matrix-org/synapse/issues/11946)) - Add information on the Synapse release cycle. ([\#11954](https://github.com/matrix-org/synapse/issues/11954)) - Fix broken link in the README to the admin API for password reset. ([\#11955](https://github.com/matrix-org/synapse/issues/11955)) Deprecations and Removals ------------------------- - Drop support for `webclient` listeners and configuring `web_client_location` to a non-HTTP(S) URL. Deprecated configurations are a configuration error. ([\#11895](https://github.com/matrix-org/synapse/issues/11895)) - Remove deprecated `user_may_create_room_with_invites` spam checker callback. See the [upgrade notes](https://matrix-org.github.io/synapse/latest/upgrade.html#removal-of-user_may_create_room_with_invites) for more information. ([\#11950](https://github.com/matrix-org/synapse/issues/11950)) - No longer build `.deb` packages for Ubuntu 21.04 Hirsute Hippo, which has now EOLed. ([\#11961](https://github.com/matrix-org/synapse/issues/11961)) Internal Changes ---------------- - Enhance user registration test helpers to make them more useful for tests involving application services and devices. ([\#11615](https://github.com/matrix-org/synapse/issues/11615), [\#11616](https://github.com/matrix-org/synapse/issues/11616)) - Improve performance when fetching bundled aggregations for multiple events. ([\#11660](https://github.com/matrix-org/synapse/issues/11660), [\#11752](https://github.com/matrix-org/synapse/issues/11752)) - Fix type errors introduced by new annotations in the Prometheus Client library. ([\#11832](https://github.com/matrix-org/synapse/issues/11832)) - Add missing type hints to replication code. ([\#11856](https://github.com/matrix-org/synapse/issues/11856), [\#11938](https://github.com/matrix-org/synapse/issues/11938)) - Ensure that `opentracing` scopes are activated and closed at the right time. ([\#11869](https://github.com/matrix-org/synapse/issues/11869)) - Improve opentracing for incoming federation requests. ([\#11870](https://github.com/matrix-org/synapse/issues/11870)) - Improve internal docstrings in `synapse.util.caches`. ([\#11876](https://github.com/matrix-org/synapse/issues/11876)) - Do not needlessly clear the `get_users_in_room` and `get_users_in_room_with_profiles` caches when any room state changes. ([\#11878](https://github.com/matrix-org/synapse/issues/11878)) - Convert `ApplicationServiceTestCase` to use `simple_async_mock`. ([\#11880](https://github.com/matrix-org/synapse/issues/11880)) - Remove experimental changes to the default push rules which were introduced in Synapse 1.19.0 but never enabled. ([\#11884](https://github.com/matrix-org/synapse/issues/11884)) - Disable coverage calculation for olddeps build. ([\#11888](https://github.com/matrix-org/synapse/issues/11888)) - Preparation to support sending device list updates to application services. ([\#11905](https://github.com/matrix-org/synapse/issues/11905)) - Add a test that checks users receive their own device list updates down `/sync`. ([\#11909](https://github.com/matrix-org/synapse/issues/11909)) - Run Complement tests sequentially. ([\#11910](https://github.com/matrix-org/synapse/issues/11910)) - Various refactors to the application service notifier code. ([\#11911](https://github.com/matrix-org/synapse/issues/11911), [\#11912](https://github.com/matrix-org/synapse/issues/11912)) - Tests: replace mocked `Authenticator` with the real thing. ([\#11913](https://github.com/matrix-org/synapse/issues/11913)) - Various refactors to the typing notifications code. ([\#11914](https://github.com/matrix-org/synapse/issues/11914)) - Use the proper type for the `Content-Length` header in the `UploadResource`. ([\#11927](https://github.com/matrix-org/synapse/issues/11927)) - Remove an unnecessary ignoring of type hints due to fixes in upstream packages. ([\#11939](https://github.com/matrix-org/synapse/issues/11939)) - Add missing type hints. ([\#11953](https://github.com/matrix-org/synapse/issues/11953)) - Fix an import cycle in `synapse.event_auth`. ([\#11965](https://github.com/matrix-org/synapse/issues/11965)) - Unpin `frozendict` but exclude the known bad version 2.1.2. ([\#11969](https://github.com/matrix-org/synapse/issues/11969)) - Prepare for rename of default Complement branch. ([\#11971](https://github.com/matrix-org/synapse/issues/11971)) - Fetch Synapse's version using a helper from `matrix-common`. ([\#11979](https://github.com/matrix-org/synapse/issues/11979))	2022-02-15 13:14:52 +00:00
Andrew Morgan	87f2005713	Add some tests for propagation of device list changes between local users (#11972 )	2022-02-15 11:27:56 +00:00
Sean Quah	7c05599041	1.53.0rc1	2022-02-15 10:44:24 +00:00
Pascal Bach	c4c98c7518	Revert "Pin to frozendict<2.1.2 (#11625 )" and allow frozendict>2.1.2 (#11969 ) This reverts commit `2bf31f7807`. Signed-off-by: Pascal Bach <pascal.bach@nextrem.ch>	2022-02-14 21:18:01 +00:00
Michael Telatynski	54e74f8bde	Fix M_WRONG_ROOM_KEYS_VERSION error not including `current_version` field (#11988 ) Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>	2022-02-14 19:28:00 +00:00
Andrew Morgan	7812fe9edd	Note when unstable MSC3283 prefixes will be removed (#11989 )	2022-02-14 19:07:59 +00:00
H. Shay	9c4563c5cd	remove empty file, reword/rename newsfragment, and add line to upgrade doc	2022-02-14 10:21:00 -08:00
Patrick Cloke	738e569ed2	Require that modules register their callbacks using keyword arguments. (#11975 ) To allow for easier backwards/forwards compatibility by making it easier to add/remove callbacks.	2022-02-14 09:18:44 -05:00
David Robertson	4ae956c8bb	Use version string helper from matrix-common (#11979 ) * Require latest matrix-common * Use the common function	2022-02-14 13:12:22 +00:00
Andrew Morgan	55113dd5e8	Notify users, rather than rooms, of device list updates (#11905 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-02-12 09:33:49 -05:00
Richard van der Hoff	63c46349c4	Implement MSC3706: partial state in `/send_join` response (#11967 ) * Make `get_auth_chain_ids` return a Set It has a set internally, and a set is often useful where it gets used, so let's avoid converting to an intermediate list. * Minor refactors in `on_send_join_request` A little bit of non-functional groundwork * Implement MSC3706: partial state in /send_join response	2022-02-12 10:44:16 +00:00
Shay	b2b971f28a	Enable cache time-based expiry by default (#11849 )	2022-02-11 11:05:20 -08:00
Patrick Cloke	4d7e74b2e5	Support the MSC3715 for `/relations`. (#11941 ) This adds an unstable org.matrix.msc3715.dir parameter which acts like dir on /mesages.	2022-02-11 11:20:27 -05:00
Patrick Cloke	b65acead42	Fetch thread summaries for multiple events in a single query (#11752 ) This should reduce database usage when fetching bundled aggregations as the number of individual queries (and round trips to the database) are reduced.	2022-02-11 09:50:14 -05:00
Richard van der Hoff	bb98c593a5	Prepare for rename of default complement branch (#11971 ) use `HEAD` rather than hardcoding `master`	2022-02-11 14:43:34 +00:00
Brendan Abolivier	0171fa5226	Remove deprecated user_may_create_room_with_invites callback (#11950 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-02-11 13:58:11 +00:00
Erik Johnston	086d1d6d0b	Fix Newsfile \#11966 fixes a bug introduced by #11215, which isn't in a released version.	2022-02-11 13:51:26 +00:00
Erik Johnston	705a439972	Fix Newsfile \#11966 fixes a bug introduced by #11215, which isn't in a released version.	2022-02-11 13:49:40 +00:00
Erik Johnston	79fb64e417	Fix to-device being dropped in limited sync in SQLite. (#11966 ) If ther are more than 100 to-device messages pending for a device `/sync` will only return the first 100, however the next batch token was incorrectly calculated and so all other pending messages would be dropped. This is due to `txn.rowcount` only returning the number of rows that changed, rather than the number selected in SQLite.	2022-02-11 13:38:05 +00:00
Richard van der Hoff	4ef39f3353	fix import cycle (#11965 )	2022-02-11 13:07:55 +00:00
Patrick Cloke	a121507cfe	Adds misc missing type hints (#11953 )	2022-02-11 07:20:16 -05:00
Richard van der Hoff	c3db7a0b59	Tests: replace mocked Authenticator with the real thing (#11913 ) If we prepopulate the test homeserver with a key for a remote homeserver, we can make federation requests to it without having to stub out the authenticator. This has two advantages: * means that what we are testing is closer to reality (ie, we now have complete tests for the incoming-request-authorisation flow) * some tests require that other objects be signed by the remote server (eg, the event in `/send_join`), and doing that would require a whole separate set of mocking out. It's much simpler just to use real keys.	2022-02-11 12:06:02 +00:00
Dirk Klimpel	d36943c4df	Support the stable API endpoint for MSC3283: new settings in `/capabilities` endpoint (#11933 )	2022-02-11 09:32:11 +00:00
Shay	1e12efa1b2	Drop support for EOL Ubuntu 21.04 (#11961 )	2022-02-10 13:59:42 -08:00
Patrick Cloke	df36945ff0	Support pagination tokens from /sync and /messages in the relations API. (#11952 )	2022-02-10 10:52:48 -05:00
Denis Kasak	337f38cac3	Implement a content type allow list for URL previews (#11936 ) This implements an allow list for content types for which Synapse will attempt URL preview. If a URL resolves to a resource with a content type which isn't in the list, the download will terminate immediately. This makes sense given that Synapse would never successfully generate a URL preview for such files in the first place, and helps prevent issues with streaming media servers, such as #8302. Signed-off-by: Denis Kasak dkasak@termina.org.uk	2022-02-10 15:43:01 +00:00
Alexander Mnich	06e5a76322	Fix broken link in README to admin API. (#11955 ) From when the documentation was converted from rst -> md.	2022-02-10 14:18:27 +00:00
Patrick Cloke	e4fdf459e2	Basic documentation for the release cycle. (#11954 )	2022-02-10 13:15:10 +00:00
Brad Jones	3914576b2b	Fix example for structured logging. (#11946 ) The StreamHandler takes a stream parameter, not location.	2022-02-09 20:56:33 +00:00
Patrick Cloke	0408d694ee	Update changelog from #11867 to be a single line.	2022-02-09 11:32:20 -05:00
Patrick Cloke	d0e78af35e	Add missing type hints to synapse.replication. (#11938 )	2022-02-08 11:03:08 -05:00
Patrick Cloke	8c94b3abe9	Experimental support to include bundled aggregations in search results (MSC3666) (#11837 )	2022-02-08 09:21:20 -05:00
Patrick Cloke	6c0984e3f0	Remove unnecessary ignores due to Twisted upgrade. (#11939 ) Twisted 22.1.0 fixed some internal type hints, allowing Synapse to remove ignore calls for parameters to connectTCP.	2022-02-08 09:15:59 -05:00
Patrick Cloke	63d90f10ec	Add missing type hints to synapse.replication.http. (#11856 )	2022-02-08 07:44:39 -05:00
Patrick Cloke	8b309adb43	Fetch edits for multiple events in a single query. (#11660 ) This should reduce database usage when fetching bundled aggregations as the number of individual queries (and round trips to the database) are reduced.	2022-02-08 07:43:30 -05:00
Patrick Cloke	380c3d40f4	Return JSON errors for unknown resources under /matrix/client. (#11930 ) Re-applies the changes from `3e0cfd447e` (#11602), reverting `d93ec0a0ba` (#11764) now that the conflict with the webclient listener was fixed in `119edf51eb` (#11895).	2022-02-08 07:06:25 -05:00
Andrew Morgan	3655585e85	Add a docstring to `add_device_change_to_streams` and fix some nearby types (#11912 )	2022-02-08 10:52:22 +00:00
Brendan Abolivier	0640f8ebaa	Add a callback to allow modules to deny 3PID (#11854 ) Part of the Tchap Synapse mainlining. This allows modules to implement extra logic to figure out whether a given 3PID can be added to the local homeserver. In the Tchap use case, this will allow a Synapse module to interface with the custom endpoint /internal_info.	2022-02-08 11:20:32 +01:00
Eric Eastwood	fef2e792be	Fix historical messages backfilling in random order on remote homeservers (MSC2716) (#11114 ) Fix https://github.com/matrix-org/synapse/issues/11091 Fix https://github.com/matrix-org/synapse/issues/10764 (side-stepping the issue because we no longer have to deal with `fake_prev_event_id`) 1. Made the `/backfill` response return messages in `(depth, stream_ordering)` order (previously only sorted by `depth`) - Technically, it shouldn't really matter how `/backfill` returns things but I'm just trying to make the `stream_ordering` a little more consistent from the origin to the remote homeservers in order to get the order of messages from `/messages` consistent ([sorted by `(topological_ordering, stream_ordering)`](https://github.com/matrix-org/synapse/blob/develop/docs/development/room-dag-concepts.md#depth-and-stream-ordering)). - Even now that we return backfilled messages in order, it still doesn't guarantee the same `stream_ordering` (and more importantly the [`/messages` order](https://github.com/matrix-org/synapse/blob/develop/docs/development/room-dag-concepts.md#depth-and-stream-ordering)) on the other server. For example, if a room has a bunch of history imported and someone visits a permalink to a historical message back in time, their homeserver will skip over the historical messages in between and insert the permalink as the next message in the `stream_order` and totally throw off the sort. - This will be even more the case when we add the [MSC3030 jump to date API endpoint](https://github.com/matrix-org/matrix-doc/pull/3030) so the static archives can navigate and jump to a certain date. - We're solving this in the future by switching to [online topological ordering](https://github.com/matrix-org/gomatrixserverlib/issues/187) and [chunking](https://github.com/matrix-org/synapse/issues/3785) which by its nature will apply retroactively to fix any inconsistencies introduced by people permalinking 2. As we're navigating `prev_events` to return in `/backfill`, we order by `depth` first (newest -> oldest) and now also tie-break based on the `stream_ordering` (newest -> oldest). This is technically important because MSC2716 inserts a bunch of historical messages at the same `depth` so it's best to be prescriptive about which ones we should process first. In reality, I think the code already looped over the historical messages as expected because the database is already in order. 3. Making the historical state chain and historical event chain float on their own by having no `prev_events` instead of a fake `prev_event` which caused backfill to get clogged with an unresolvable event. Fixes https://github.com/matrix-org/synapse/issues/11091 and https://github.com/matrix-org/synapse/issues/10764 4. We no longer find connected insertion events by finding a potential `prev_event` connection to the current event we're iterating over. We now solely rely on marker events which when processed, add the insertion event as an extremity and the federating homeserver can ask about it when time calls. - Related discussion, https://github.com/matrix-org/synapse/pull/11114#discussion_r741514793 Before \| After --- \| --- ![](https://user-images.githubusercontent.com/558581/139218681-b465c862-5c49-4702-a59e-466733b0cf45.png) \| ![](https://user-images.githubusercontent.com/558581/146453159-a1609e0a-8324-439d-ae44-e4bce43ac6d1.png) #### Why aren't we sorting topologically when receiving backfill events? > The main reason we're going to opt to not sort topologically when receiving backfill events is because it's probably best to do whatever is easiest to make it just work. People will probably have opinions once they look at [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) which could change whatever implementation anyway. > > As mentioned, ideally we would do this but code necessary to make the fake edges but it gets confusing and gives an impression of “just whyyyy” (feels icky). This problem also dissolves with online topological ordering. > > -- https://github.com/matrix-org/synapse/pull/11114#discussion_r741517138 See https://github.com/matrix-org/synapse/pull/11114#discussion_r739610091 for the technical difficulties	2022-02-07 15:54:13 -06:00
Andrew Morgan	cf06783d54	Remove optional state of `ApplicationService.is_interested`'s `store` parameter (#11911 )	2022-02-07 18:26:42 +00:00
Patrick Cloke	314ca4c86d	Pass the proper type when uploading files. (#11927 ) The Content-Length header should be treated as an int, not a string. This shouldn't have any user-facing change.	2022-02-07 10:06:52 -05:00
Andrew Morgan	e03dde259b	Clean up an indirect reference to the homeserver datastore (#11914 )	2022-02-07 13:25:09 +00:00
Andrew Morgan	0c4878caf2	Add a unit test for users receiving their own device list updates (#11909 )	2022-02-07 13:21:19 +00:00
Dirk Klimpel	65ef21b1c7	Clarify that users' media are also preview images (#11862 )	2022-02-04 14:39:14 +00:00
kegsay	a3865ed525	Run Complement tests sequentially (#11910 ) Since #11811 there has been general Complement flakiness around networking. It seems like tests are hitting the wrong containers. In an effort to diagnose the cause of this, as well as reduce its impact on this project, set the parallelsim to 1 (no parallelism) when running tests. If this fixes the flakiness then this indicates the cause and I can diagnose this further. If this doesn't fix the flakiness then that implies some kind of test pollution which also helps to diagnose this further.	2022-02-04 13:04:57 +00:00
Jonathan de Jong	02632b3504	Stabilise MSC3231 (Token Based Registration) (#11867 )	2022-02-04 12:15:13 +00:00
Richard van der Hoff	b3d155a749	Delete MSC1711_certificates_FAQ.md (#11907 ) This document isn't really relevant any more, and its existence is more confusing than helpful.	2022-02-04 11:27:00 +00:00
Patrick Cloke	119edf51eb	Remove support for the webclient listener. (#11895 ) Also remove support for non-HTTP(S) web_client_location.	2022-02-03 18:36:49 +00:00
Christian Paul	6b1c265c21	Fix typo: unpind -> unbind (#11859 ) Co-authored-by: reivilibre <olivier@librepush.net>	2022-02-03 17:20:44 +00:00
Brendan Abolivier	d80d39b035	Add a ratelimiter for 3pid invite (#11892 )	2022-02-03 14:28:15 +01:00
reivilibre	833247553f	Allow specifying the application service-specific `user_id` parameter in the `join` test helper. (#11616 )	2022-02-03 13:09:22 +00:00
Richard van der Hoff	964f5b9324	Improve opentracing for federation requests (#11870 ) The idea here is to set the parent span for incoming federation requests to the outgoing span on the other end. That means that you can see (most of) the full end-to-end flow when you have a process that includes federation requests. However, in order not to lose information, we still want a link to the `incoming-federation-request` span from the servlet, so we have to create another span to do exactly that.	2022-02-03 12:29:16 +00:00
Richard van der Hoff	31b554c297	Fixes for opentracing scopes (#11869 ) `start_active_span` was inconsistent as to whether it would activate the span immediately, or wait for `scope.__enter__` to happen (it depended on whether the current logcontext already had an associated scope). The inconsistency was rather confusing if you were hoping to set up a couple of separate spans before activating either. Looking at the other implementations of opentracing `ScopeManager`s, the intention is that it should be activated immediately, as the name implies. Indeed, the idea is that you don't have to use the scope as a contextmanager at all - you can just call `.close` on the result. Hence, our cleanup has to happen in `.close` rather than `.__exit__`. So, the main change here is to ensure that `start_active_span` does activate the span, and that `scope.close()` does close the scope. We also add some tests, which requires a `tracer` param so that we don't have to rely on the global variable in unit tests.	2022-02-02 22:41:57 +00:00
Patrick Cloke	a8da046907	Invalidate the get_users_in_room{_with_profile} caches only when necessary. (#11878 ) The get_users_in_room and get_users_in_room_with_profiles are now only invalidated when the membership of a room changes, instead of during any state change in the room.	2022-02-02 12:24:07 -05:00
reivilibre	41818cda1f	Fix type errors introduced by new annotations in the Prometheus Client library. (#11832 ) Co-authored-by: David Robertson <davidr@element.io>	2022-02-02 16:51:00 +00:00
David Robertson	dd7f825118	Fix losing incoming EDUs if debug logging enabled (#11890 ) * Fix losing incoming EDUs if debug logging enabled Fixes #11889. Homeservers should only be affected if the `synapse.8631_debug` logger was enabled for DEBUG mode. I am not sure if this merits a bugfix release: I think the logging can be disabled in config if anyone is affected? But it is still pretty bad.	2022-02-02 16:25:17 +00:00
Richard van der Hoff	23a698f5e6	Disable coverage calculation for olddeps build. (#11888 ) We disabled coverage calculation for most of CI in #11017, but the olddeps build uses a separate script and got forgotten.	2022-02-02 15:59:33 +00:00
David Robertson	f510fba4ba	Describe `prune_unread_entries` in docstrings (#11876 ) Should have been caught in #10826.	2022-02-02 15:11:23 +00:00
Patrick Cloke	acda9f07c8	Revert experimental push rules from #7997 . (#11884 ) Manually reverts the merge from `cdbb8e6d6e`.	2022-02-02 09:49:31 -05:00
reivilibre	af795173be	Add a background database update to purge account data for deactivated users. (#11655 )	2022-02-02 11:37:18 +00:00
reivilibre	513913cc6b	Expose the registered device ID from the `register_appservice_user` test helper. (#11615 )	2022-02-02 09:59:55 +00:00
Andrew Morgan	3f72c2a322	Convert `ApplicationServiceTestCase` to use `simple_async_mock` (#11880 )	2022-02-01 17:45:13 +00:00
Brendan Abolivier	5c16c33021	Allow modules to retrieve server and worker names (#11868 ) Fixes #10701	2022-02-01 16:23:55 +01:00
Andrew Morgan	64ec45fc1b	Send to-device messages to application services (#11215 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-02-01 14:13:38 +00:00
David Robertson	a35e9db9be	1.52.0rc1	2022-02-01 11:04:17 +00:00
Dirk Klimpel	901b264c0c	Add type hints to `tests/rest/admin` (#11851 )	2022-01-31 14:20:05 -05:00
Dirk Klimpel	0da2301b21	Consolidate the `access_token` information in the admin api (#11861 ) Co-authored-by: reivilibre <olivier@librepush.net>	2022-01-31 16:24:29 +00:00
Patrick Cloke	02755c3188	Remove the obsolete MSC1849 configuration flag. (#11843 ) MSC1849 was replaced by MSC2675, which was merged. The configuration flag, which defaulted to true, is no longer useful.	2022-01-31 10:13:32 -05:00
Dirk Klimpel	7eb198ddc8	Remove not needed old table of contents in documentation (#11860 )	2022-01-31 14:40:20 +00:00
Brendan Abolivier	bf60da1a60	Configurable limits on avatars (#11846 ) Only allow files which file size and content types match configured limits to be set as avatar. Most of the inspiration from the non-test code comes from matrix-org/synapse-dinsic#19	2022-01-28 15:41:33 +01:00
Brendan Abolivier	6d482ba259	Pass `isolation_level` to `runWithConnection` (#11847 ) This was missed in https://github.com/matrix-org/synapse/pull/11799	2022-01-27 17:45:39 +00:00
Richard van der Hoff	57e4786e90	Create singletons for `StateFilter.{all,none}()` (#11836 ) No point recreating these for each call, since they are frozen	2022-01-27 10:54:27 +00:00
Dirk Klimpel	fd65139714	Fix some indentation inconsistencies in the sample config (modules) (#11838 )	2022-01-27 10:06:29 +00:00
Shay	ec07062e31	Update installation docs to indicate that we support Python 3.10 (#11820 )	2022-01-26 16:05:29 -08:00
Vaishnav Nair	cef0d5d90a	Include `prev_content` field in AS events (#11798 ) * Include 'prev_content' field in AS events Signed-off-by: Vaishnav Nair <nairvaishnav007@icloud.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-01-26 14:48:27 +00:00
Brendan Abolivier	2d3bd9aa67	Add a module callback to set username at registration (#11790 ) This is in the context of mainlining the Tchap fork of Synapse. Currently in Tchap usernames are derived from the user's email address (extracted from the UIA results, more specifically the m.login.email.identity step). This change also exports the check_username method from the registration handler as part of the module API, so that a module can check if the username it's trying to generate is correct and doesn't conflict with an existing one, and fallback gracefully if not. Co-authored-by: David Robertson <davidr@element.io>	2022-01-26 14:21:13 +00:00
Patrick Cloke	2897fb6b4f	Improvements to bundling aggregations. (#11815 ) This is some odds and ends found during the review of #11791 and while continuing to work in this code: * Return attrs classes instead of dictionaries from some methods to improve type safety. * Call `get_bundled_aggregations` fewer times. * Adds a missing assertion in the tests. * Do not return empty bundled aggregations for an event (preferring to not include the bundle at all, as the docstring states).	2022-01-26 08:27:04 -05:00
David Robertson	d8df8e6c14	Don't print HTTPStatus.* in "Processed..." logs (#11827 ) * Don't print HTTPStatus.* in "Processed..." logs Fixes #11812. See also #7118 and https://github.com/matrix-org/synapse/pull/7188#r401719326 in particular. Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-01-26 12:47:34 +00:00
David Robertson	c5815567a4	Avoid type annotation problems in prom-client (#11834 )	2022-01-26 12:06:56 +00:00
Brendan Abolivier	95b3f952fa	Add a config flag to inhibit `M_USER_IN_USE` during registration (#11743 ) This is mostly motivated by the tchap use case, where usernames are automatically generated from the user's email address (in a way that allows figuring out the email address from the username). Therefore, it's an issue if we respond to requests on /register and /register/available with M_USER_IN_USE, because it can potentially leak email addresses (which include the user's real name and place of work). This commit adds a flag to inhibit the M_USER_IN_USE errors that are raised both by /register/available, and when providing a username early into the registration process. This error will still be raised if the user completes the registration process but the username conflicts. This is particularly useful when using modules (https://github.com/matrix-org/synapse/pull/11790 adds a module callback to set the username of users at registration) or SSO, since they can ensure the username is unique. More context is available in the PR that introduced this behaviour to synapse-dinsic: matrix-org/synapse-dinsic#48 - as well as the issue in the matrix-dinsic repo: matrix-org/matrix-dinsic#476	2022-01-26 13:02:54 +01:00
David Robertson	74e4419eb4	Fix another jsonschema typecheck error (#11830 ) Similar to #11817. In `_create_power_level_validator` we - retrieve `validator`. This is a class implementing the `jsonschema.protocols.Validator` interface. In other words, `validator: Type[jsonschema.protocols.Validator]`. - we then create an second validator class by modifying the original `validator`. We return that class, which is also of type `Type[jsonschema.protocols.Validator]`. So the original annotation was incorrect: it claimed we were returning an instance of jsonSchema.Draft7Validator, not the class (or a subclass) itself. (Strictly speaking this is incorrect, because `POWER_LEVELS_SCHEMA` isn't pinned to a particular version of JSON Schema. But there are other complications with the type stubs if you try to fix this; I felt like the change herein was a decent compromise that better expresses intent). (I suspect/hope the typeshed project would welcome an effort to improve the jsonschema stubs. Let's see if I get some spare time.)	2022-01-25 15:29:28 -05:00
Shay	b8bf600700	Check that `gc` method is available before using in `synapse/app/_base` (#11816 ) * add check that gc.freeze is available before calling * newsfragment * lint * Update comment Co-authored-by: Dan Callahan <danc@element.io> Co-authored-by: Dan Callahan <danc@element.io>	2022-01-25 10:35:18 -08:00
Dirk Klimpel	6a72c910f1	Add admin API to get a list of federated rooms (#11658 )	2022-01-25 16:11:40 +00:00
kegsay	0938f32e93	CI: run Complement on the VM, not inside Docker (#11811 ) * CI: run Complement on the VM, not inside Docker This requires https://github.com/matrix-org/complement/pull/289 We now run Complement on the VM instead of inside a Docker container. This is to allow Complement to bind to any high-numbered port when it starts up its own federation servers. We want to do this to allow for more concurrency when running complement tests. Previously, Complement only ever bound to `:8448` when running its own federation server. This prevented multiple federation tests running at the same time as they would fight each other on the port. This did however allow Complement to run in Docker, as the host could just port forward `:8448` to allow homeserver containers to communicate to Complement. Now that we are using random ports however, we cannot use Docker to run Complement. This ends up being a good thing because: - Running Complement tests locally is closer to how they run in CI. - Allows the `CI` env var to be removed in Complement. - Slightly speeds up runs as we don't need to pull down the Complement image prior to running tests. This assumes GHA caches actions sensibly. * Changelog * Full stop * Update .github/workflows/tests.yml Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Review comments * Update .github/workflows/tests.yml Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-01-25 15:05:22 +00:00
Brendan Abolivier	1d5f7b2cc6	Log modules at startup (#11813 )	2022-01-25 15:35:35 +01:00
Nick Barrett	b59d285f7c	Db txn set isolation level (#11799 ) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-01-25 15:14:46 +01:00
Richard van der Hoff	fc8598bc87	Minor updates, and docs, for schema delta files (#11823 ) * Make functions in python deltas optional It's annoying to always have to write stubs for these. * Documentation for delta files * changelog	2022-01-25 14:11:13 +00:00
Forest Johnson	4210143f53	Docs: add missing PR submission process how-tos (#11821 ) * Docs: add missing PR submission process how-tos The documentation says that in order to submit a pull request you have to run the linter and links to [Run the linters](https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#run-the-linters). IMO "Run the linters" should explain that development dependencies are a pre-requisite. I also included `pip install wheel` which I had to run inside my virtual environment on ubuntu before I `pip install -e ".[all,dev]"` would succeed.	2022-01-25 14:09:56 +00:00
Dirk Klimpel	0d6cfea9b8	Add admin API to reset connection timeouts for remote server (#11639 ) * Fix get federation status of destination if no error occured	2022-01-25 12:06:29 +00:00
Patrick Cloke	15c2a6a106	Ignore the jsonschema type. (#11817 )	2022-01-25 12:07:10 +01:00
Richard van der Hoff	2d327d25bf	Skip the initial amd64-only Docker build (#11810 ) PyNaCl's recent 1.5.0 release on PyPi includes arm64 wheels, which means our arm64 docker images now build in a sensible amount of time, so we can skip the amd64-only build.	2022-01-24 18:31:23 +00:00
Patrick Cloke	02d99f044e	Apply a timeout to reading the body when fetching a file. (#11784 ) This prevents the URL preview code from reading a stream forever.	2022-01-24 14:38:37 +00:00
Patrick Cloke	807efd26ae	Support rendering previews with data: URLs in them (#11767 ) Images which are data URLs will no longer break URL previews and will properly be "downloaded" and thumbnailed.	2022-01-24 08:58:18 -05:00
reivilibre	df54c8485a	Remove account data (including client config, push rules and ignored users) upon user deactivation. (#11621 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-01-24 13:37:00 +00:00
Shay	9006ee36d1	Drop support for and remove references to EOL Python 3.6 (#11683 ) * remove reference in comments to python3.6 * upgrade tox python env in script * bump python version in example for completeness * upgrade python version requirement in setup doc * upgrade necessary python version in __init__.py * upgrade python version in setup.py * newsfragment * drops refs to bionic and replace with focal * bump refs to postgres 9.6 to 10 * fix hanging ci * try installing tzdata first * revert change made in b979f336 * ignore new random mypy error while debugging other error * fix lint error for temporary workaround * revert change to install list * try passing env var * export debian frontend var? * move line and add comment * bump pillow dependency * bump lxml depenency * install libjpeg-dev for pillow * bump automat version to one compatible with py3.8 * add libwebp for pillow * bump twisted trunk python version * change suffix of newsfragment * remove redundant python 3.7 checks * lint	2022-01-21 14:23:26 -08:00
Olivier Wilkinson (reivilibre)	f8cf02b200	Remove obsolete newsfile The PR was cherrypicked into v1.51.0rc1.	2022-01-21 14:05:27 +00:00
Olivier Wilkinson (reivilibre)	ffc61d1b69	Synapse 1.51.0rc1 (2022-01-21) ============================== Features -------- - Add `track_puppeted_user_ips` config flag to record client IP addresses against puppeted users, and include the puppeted users in monthly active user counts. ([\#11561](https://github.com/matrix-org/synapse/issues/11561), [\#11749](https://github.com/matrix-org/synapse/issues/11749), [\#11757](https://github.com/matrix-org/synapse/issues/11757)) - Include whether the requesting user has participated in a thread when generating a summary for [MSC3440](https://github.com/matrix-org/matrix-doc/pull/3440). ([\#11577](https://github.com/matrix-org/synapse/issues/11577)) - Return an `M_FORBIDDEN` error code instead of `M_UNKNOWN` when a spam checker module prevents a user from creating a room. ([\#11672](https://github.com/matrix-org/synapse/issues/11672)) - Add a flag to the `synapse_review_recent_signups` script to ignore and filter appservice users. ([\#11675](https://github.com/matrix-org/synapse/issues/11675), [\#11770](https://github.com/matrix-org/synapse/issues/11770)) Bugfixes -------- - Fix a long-standing issue which could cause Synapse to incorrectly accept data in the unsigned field of events received over federation. ([\#11530](https://github.com/matrix-org/synapse/issues/11530)) - Fix a long-standing bug where Synapse wouldn't cache a response indicating that a remote user has no devices. ([\#11587](https://github.com/matrix-org/synapse/issues/11587)) - Fix an error that occurs whilst trying to get the federation status of a destination server that was working normally. This admin API was newly introduced in Synapse v1.49.0. ([\#11593](https://github.com/matrix-org/synapse/issues/11593)) - Fix bundled aggregations not being included in the `/sync` response, per [MSC2675](https://github.com/matrix-org/matrix-doc/pull/2675). ([\#11612](https://github.com/matrix-org/synapse/issues/11612), [\#11659](https://github.com/matrix-org/synapse/issues/11659), [\#11791](https://github.com/matrix-org/synapse/issues/11791)) - Fix the `/_matrix/client/v1/room/{roomId}/hierarchy` endpoint returning incorrect fields which have been present since Synapse 1.49.0. ([\#11667](https://github.com/matrix-org/synapse/issues/11667)) - Fix preview of some GIF URLs (like tenor.com). Contributed by Philippe Daouadi. ([\#11669](https://github.com/matrix-org/synapse/issues/11669)) - Fix a bug where only the first 50 rooms from a space were returned from the `/hierarchy` API. This has existed since the introduction of the API in Synapse v1.41.0. ([\#11695](https://github.com/matrix-org/synapse/issues/11695)) - Fix a bug introduced in Synapse v1.18.0 where password reset and address validation emails would not be sent if their subject was configured to use the 'app' template variable. Contributed by @br4nnigan. ([\#11710](https://github.com/matrix-org/synapse/issues/11710), [\#11745](https://github.com/matrix-org/synapse/issues/11745)) - Make the 'List Rooms' Admin API sort stable. Contributed by Daniël Sonck. ([\#11737](https://github.com/matrix-org/synapse/issues/11737)) - Fix a long-standing bug where space hierarchy over federation would only work correctly some of the time. ([\#11775](https://github.com/matrix-org/synapse/issues/11775)) - Fix a bug introduced in Synapse v1.46.0 that prevented `on_logged_out` module callbacks from being correctly awaited by Synapse. ([\#11786](https://github.com/matrix-org/synapse/issues/11786)) Improved Documentation ---------------------- - Warn against using a Let's Encrypt certificate for TLS/DTLS TURN server client connections, and suggest using ZeroSSL certificate instead. This works around client-side connectivity errors caused by WebRTC libraries that reject Let's Encrypt certificates. Contibuted by @AndrewFerr. ([\#11686](https://github.com/matrix-org/synapse/issues/11686)) - Document the new `SYNAPSE_TEST_PERSIST_SQLITE_DB` environment variable in the contributing guide. ([\#11715](https://github.com/matrix-org/synapse/issues/11715)) - Document that the minimum supported PostgreSQL version is now 10. ([\#11725](https://github.com/matrix-org/synapse/issues/11725)) - Fix typo in demo docs: differnt. ([\#11735](https://github.com/matrix-org/synapse/issues/11735)) - Update room spec URL in config files. ([\#11739](https://github.com/matrix-org/synapse/issues/11739)) - Mention `python3-venv` and `libpq-dev` dependencies in the contribution guide. ([\#11740](https://github.com/matrix-org/synapse/issues/11740)) - Update documentation for configuring login with Facebook. ([\#11755](https://github.com/matrix-org/synapse/issues/11755)) - Update installation instructions to note that Python 3.6 is no longer supported. ([\#11781](https://github.com/matrix-org/synapse/issues/11781)) Deprecations and Removals ------------------------- - Remove the unstable `/send_relation` endpoint. ([\#11682](https://github.com/matrix-org/synapse/issues/11682)) - Remove `python_twisted_reactor_pending_calls` Prometheus metric. ([\#11724](https://github.com/matrix-org/synapse/issues/11724)) - Remove the `password_hash` field from the response dictionaries of the [Users Admin API](https://matrix-org.github.io/synapse/latest/admin_api/user_admin_api.html). ([\#11576](https://github.com/matrix-org/synapse/issues/11576)) - Deprecate support for `webclient` listeners and non-HTTP(S) `web_client_location` configuration. ([\#11774](https://github.com/matrix-org/synapse/issues/11774), [\#11783](https://github.com/matrix-org/synapse/issues/11783)) Internal Changes ---------------- - Run `pyupgrade --py37-plus --keep-percent-format` on Synapse. ([\#11685](https://github.com/matrix-org/synapse/issues/11685)) - Use buildkit's cache feature to speed up docker builds. ([\#11691](https://github.com/matrix-org/synapse/issues/11691)) - Use `auto_attribs` and native type hints for attrs classes. ([\#11692](https://github.com/matrix-org/synapse/issues/11692), [\#11768](https://github.com/matrix-org/synapse/issues/11768)) - Remove debug logging for #4422, which has been closed since Synapse 0.99. ([\#11693](https://github.com/matrix-org/synapse/issues/11693)) - Remove fallback code for Python 2. ([\#11699](https://github.com/matrix-org/synapse/issues/11699)) - Add a test for [an edge case](https://github.com/matrix-org/synapse/pull/11532#discussion_r769104461) in the `/sync` logic. ([\#11701](https://github.com/matrix-org/synapse/issues/11701)) - Add the option to write SQLite test dbs to disk when running tests. ([\#11702](https://github.com/matrix-org/synapse/issues/11702)) - Improve Complement test output for Gitub Actions. ([\#11707](https://github.com/matrix-org/synapse/issues/11707)) - Fix docstring on `add_account_data_for_user`. ([\#11716](https://github.com/matrix-org/synapse/issues/11716)) - Complement environment variable name change and update `.gitignore`. ([\#11718](https://github.com/matrix-org/synapse/issues/11718)) - Simplify calculation of Prometheus metrics for garbage collection. ([\#11723](https://github.com/matrix-org/synapse/issues/11723)) - Improve accuracy of `python_twisted_reactor_tick_time` Prometheus metric. ([\#11724](https://github.com/matrix-org/synapse/issues/11724), [\#11771](https://github.com/matrix-org/synapse/issues/11771)) - Minor efficiency improvements when inserting many values into the database. ([\#11742](https://github.com/matrix-org/synapse/issues/11742)) - Invite PR authors to give themselves credit in the changelog. ([\#11744](https://github.com/matrix-org/synapse/issues/11744)) - Add optional debugging to investigate [issue 8631](https://github.com/matrix-org/synapse/issues/8631). ([\#11760](https://github.com/matrix-org/synapse/issues/11760)) - Remove `log_function` utility function and its uses. ([\#11761](https://github.com/matrix-org/synapse/issues/11761)) - Add a unit test that checks both `client` and `webclient` resources will function when simultaneously enabled. ([\#11765](https://github.com/matrix-org/synapse/issues/11765)) - Allow overriding complement commit using `COMPLEMENT_REF`. ([\#11766](https://github.com/matrix-org/synapse/issues/11766)) - Add some comments and type annotations for `_update_outliers_txn`. ([\#11776](https://github.com/matrix-org/synapse/issues/11776)) -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE8SRSDO7gYkSP4chELS76LzL74EcFAmHqtzcACgkQLS76LzL7 4EdcnBAAso20F98jQf9f9NFneD8FPk6HfuDSJ1d162Ibc2Ikvs/QfsFhvUjChDR0 VpfcM4+APSqFvOV82Km3XYiL9bbqdwx3S6KCxyq+bEZapiJUfmfywa9c/tEnSap6 c8sMWH+3NOC6KJGuJ4NIck2IZa560tOg1nIHkX8STy/YFQhw9HXpYv8cpPP+JajI hFfd4DHE9MXb028tFnl7eIDm+8XuU7tohW/nkIGbM+NTl2wrUNN0LCLnHajN6MoQ MscNZjWX0zds1JHNj9BT29opp7zETf699MGQDPpMdtlXJrqsazWuyjE12lz4rdNm D4XY4c3JnE6f3QEapBzVoDAsSnyeCC3CEK3etYqcZRGwyeLvtO3BuGvYM91XfeVd kFDZ5ZscHhdQJZBRWzJk7rM9rw211KYRrKcntRwtlJI+qHVap2uRJSBbf46WFPwp /d9mPe2zOEaF1S5H7pmLl1N4JmmcNtkJuKbMpkJ/M4GBBXsNEjuUtZ5JwnpfBFxx GFSPIsWlNyJ7GdJaepb43W6uSdlVSfdqZ42Tylzr0g/4ZTHocz/iWBtAtoUy1WqM C3NhpQr2e4dYkpKZhDKzZwaChIhCUH+AYJc5XpWYnDP0Pu71enSCFAYq3y5Exkk7 lEsP2oEUyKq0Zb2Yh1wHxZANvk1NK7VnnS80FpSICAauAuVHaM0= =qD4v -----END PGP SIGNATURE----- Merge tag 'v1.51.0rc1' into develop Synapse 1.51.0rc1 (2022-01-21) ============================== Features -------- - Add `track_puppeted_user_ips` config flag to record client IP addresses against puppeted users, and include the puppeted users in monthly active user counts. ([\#11561](https://github.com/matrix-org/synapse/issues/11561), [\#11749](https://github.com/matrix-org/synapse/issues/11749), [\#11757](https://github.com/matrix-org/synapse/issues/11757)) - Include whether the requesting user has participated in a thread when generating a summary for [MSC3440](https://github.com/matrix-org/matrix-doc/pull/3440). ([\#11577](https://github.com/matrix-org/synapse/issues/11577)) - Return an `M_FORBIDDEN` error code instead of `M_UNKNOWN` when a spam checker module prevents a user from creating a room. ([\#11672](https://github.com/matrix-org/synapse/issues/11672)) - Add a flag to the `synapse_review_recent_signups` script to ignore and filter appservice users. ([\#11675](https://github.com/matrix-org/synapse/issues/11675), [\#11770](https://github.com/matrix-org/synapse/issues/11770)) Bugfixes -------- - Fix a long-standing issue which could cause Synapse to incorrectly accept data in the unsigned field of events received over federation. ([\#11530](https://github.com/matrix-org/synapse/issues/11530)) - Fix a long-standing bug where Synapse wouldn't cache a response indicating that a remote user has no devices. ([\#11587](https://github.com/matrix-org/synapse/issues/11587)) - Fix an error that occurs whilst trying to get the federation status of a destination server that was working normally. This admin API was newly introduced in Synapse v1.49.0. ([\#11593](https://github.com/matrix-org/synapse/issues/11593)) - Fix bundled aggregations not being included in the `/sync` response, per [MSC2675](https://github.com/matrix-org/matrix-doc/pull/2675). ([\#11612](https://github.com/matrix-org/synapse/issues/11612), [\#11659](https://github.com/matrix-org/synapse/issues/11659), [\#11791](https://github.com/matrix-org/synapse/issues/11791)) - Fix the `/_matrix/client/v1/room/{roomId}/hierarchy` endpoint returning incorrect fields which have been present since Synapse 1.49.0. ([\#11667](https://github.com/matrix-org/synapse/issues/11667)) - Fix preview of some GIF URLs (like tenor.com). Contributed by Philippe Daouadi. ([\#11669](https://github.com/matrix-org/synapse/issues/11669)) - Fix a bug where only the first 50 rooms from a space were returned from the `/hierarchy` API. This has existed since the introduction of the API in Synapse v1.41.0. ([\#11695](https://github.com/matrix-org/synapse/issues/11695)) - Fix a bug introduced in Synapse v1.18.0 where password reset and address validation emails would not be sent if their subject was configured to use the 'app' template variable. Contributed by @br4nnigan. ([\#11710](https://github.com/matrix-org/synapse/issues/11710), [\#11745](https://github.com/matrix-org/synapse/issues/11745)) - Make the 'List Rooms' Admin API sort stable. Contributed by Daniël Sonck. ([\#11737](https://github.com/matrix-org/synapse/issues/11737)) - Fix a long-standing bug where space hierarchy over federation would only work correctly some of the time. ([\#11775](https://github.com/matrix-org/synapse/issues/11775)) - Fix a bug introduced in Synapse v1.46.0 that prevented `on_logged_out` module callbacks from being correctly awaited by Synapse. ([\#11786](https://github.com/matrix-org/synapse/issues/11786)) Improved Documentation ---------------------- - Warn against using a Let's Encrypt certificate for TLS/DTLS TURN server client connections, and suggest using ZeroSSL certificate instead. This works around client-side connectivity errors caused by WebRTC libraries that reject Let's Encrypt certificates. Contibuted by @AndrewFerr. ([\#11686](https://github.com/matrix-org/synapse/issues/11686)) - Document the new `SYNAPSE_TEST_PERSIST_SQLITE_DB` environment variable in the contributing guide. ([\#11715](https://github.com/matrix-org/synapse/issues/11715)) - Document that the minimum supported PostgreSQL version is now 10. ([\#11725](https://github.com/matrix-org/synapse/issues/11725)) - Fix typo in demo docs: differnt. ([\#11735](https://github.com/matrix-org/synapse/issues/11735)) - Update room spec URL in config files. ([\#11739](https://github.com/matrix-org/synapse/issues/11739)) - Mention `python3-venv` and `libpq-dev` dependencies in the contribution guide. ([\#11740](https://github.com/matrix-org/synapse/issues/11740)) - Update documentation for configuring login with Facebook. ([\#11755](https://github.com/matrix-org/synapse/issues/11755)) - Update installation instructions to note that Python 3.6 is no longer supported. ([\#11781](https://github.com/matrix-org/synapse/issues/11781)) Deprecations and Removals ------------------------- - Remove the unstable `/send_relation` endpoint. ([\#11682](https://github.com/matrix-org/synapse/issues/11682)) - Remove `python_twisted_reactor_pending_calls` Prometheus metric. ([\#11724](https://github.com/matrix-org/synapse/issues/11724)) - Remove the `password_hash` field from the response dictionaries of the [Users Admin API](https://matrix-org.github.io/synapse/latest/admin_api/user_admin_api.html). ([\#11576](https://github.com/matrix-org/synapse/issues/11576)) - Deprecate support for `webclient` listeners and non-HTTP(S) `web_client_location` configuration. ([\#11774](https://github.com/matrix-org/synapse/issues/11774), [\#11783](https://github.com/matrix-org/synapse/issues/11783)) Internal Changes ---------------- - Run `pyupgrade --py37-plus --keep-percent-format` on Synapse. ([\#11685](https://github.com/matrix-org/synapse/issues/11685)) - Use buildkit's cache feature to speed up docker builds. ([\#11691](https://github.com/matrix-org/synapse/issues/11691)) - Use `auto_attribs` and native type hints for attrs classes. ([\#11692](https://github.com/matrix-org/synapse/issues/11692), [\#11768](https://github.com/matrix-org/synapse/issues/11768)) - Remove debug logging for #4422, which has been closed since Synapse 0.99. ([\#11693](https://github.com/matrix-org/synapse/issues/11693)) - Remove fallback code for Python 2. ([\#11699](https://github.com/matrix-org/synapse/issues/11699)) - Add a test for [an edge case](https://github.com/matrix-org/synapse/pull/11532#discussion_r769104461) in the `/sync` logic. ([\#11701](https://github.com/matrix-org/synapse/issues/11701)) - Add the option to write SQLite test dbs to disk when running tests. ([\#11702](https://github.com/matrix-org/synapse/issues/11702)) - Improve Complement test output for Gitub Actions. ([\#11707](https://github.com/matrix-org/synapse/issues/11707)) - Fix docstring on `add_account_data_for_user`. ([\#11716](https://github.com/matrix-org/synapse/issues/11716)) - Complement environment variable name change and update `.gitignore`. ([\#11718](https://github.com/matrix-org/synapse/issues/11718)) - Simplify calculation of Prometheus metrics for garbage collection. ([\#11723](https://github.com/matrix-org/synapse/issues/11723)) - Improve accuracy of `python_twisted_reactor_tick_time` Prometheus metric. ([\#11724](https://github.com/matrix-org/synapse/issues/11724), [\#11771](https://github.com/matrix-org/synapse/issues/11771)) - Minor efficiency improvements when inserting many values into the database. ([\#11742](https://github.com/matrix-org/synapse/issues/11742)) - Invite PR authors to give themselves credit in the changelog. ([\#11744](https://github.com/matrix-org/synapse/issues/11744)) - Add optional debugging to investigate [issue 8631](https://github.com/matrix-org/synapse/issues/8631). ([\#11760](https://github.com/matrix-org/synapse/issues/11760)) - Remove `log_function` utility function and its uses. ([\#11761](https://github.com/matrix-org/synapse/issues/11761)) - Add a unit test that checks both `client` and `webclient` resources will function when simultaneously enabled. ([\#11765](https://github.com/matrix-org/synapse/issues/11765)) - Allow overriding complement commit using `COMPLEMENT_REF`. ([\#11766](https://github.com/matrix-org/synapse/issues/11766)) - Add some comments and type annotations for `_update_outliers_txn`. ([\#11776](https://github.com/matrix-org/synapse/issues/11776))	2022-01-21 14:04:23 +00:00
Richard van der Hoff	2aa37a4250	Add `state_key` and `rejection_reason` to `events` (#11792 ) ... and start populating them for new events	2022-01-21 12:21:28 +00:00
Olivier Wilkinson (reivilibre)	266df5c908	1.51.0rc1	2022-01-21 10:47:03 +00:00
Patrick Cloke	7a11509d17	Do not try to serialize raw aggregations dict. (#11791 )	2022-01-21 10:40:34 +00:00
Patrick Cloke	b784299cbc	Do not try to serialize raw aggregations dict. (#11791 )	2022-01-21 10:31:31 +00:00
Richard van der Hoff	9f2016e96e	Drop unused table `public_room_list_stream`. (#11795 ) This is a follow-up to #10565.	2022-01-21 09:19:56 +00:00
Richard van der Hoff	2277275485	Stop reading from `event_reference_hashes` (#11794 ) Preparation for dropping this table altogether. Part of #6574.	2022-01-21 09:18:10 +00:00
Richard van der Hoff	c027bc0e4b	Add `FrozenEvent.get_state_key` and use it in a couple of places (#11793 ) This is more efficient, since we only have to look up `state_key` in the event dict once, rather than three (!) times.	2022-01-21 09:10:01 +00:00
reivilibre	4c2096599c	Make the `get_global_account_data_by_type_for_user` cache be a tree-cache whose key is prefixed with the user ID (#11788 )	2022-01-21 08:38:36 +00:00
reivilibre	e83520cc42	Make `get_account_data_for_room_and_type` a tree cache (#11789 )	2022-01-21 08:01:37 +00:00
Brendan Abolivier	bfe6d5553a	Correctly await on_logged_out callbacks (#11786 )	2022-01-20 19:19:40 +01:00
Patrick Cloke	d09099642e	Fix redirecting to the webclient for non-HTTP(S) web_client_location. (#11783 ) To not change the behaviour during the deprecation period. Follow-up to #11774.	2022-01-20 15:34:45 +00:00
Andrew Morgan	121b9e2475	Add a regression test for using both webclient and client resources simultaneously (#11765 )	2022-01-20 09:47:29 -05:00
Andrew Morgan	7bf2d6c268	Partially revert #11675 ; prevent attempting to create pushers on workers (#11770 )	2022-01-20 09:37:34 -05:00
Richard van der Hoff	56834ab779	installation.md: drop python 3.6 support (#11781 ) #11595 dropped support for python 3.6, but forgot to update this doc.	2022-01-20 14:37:11 +00:00
Patrick Cloke	91221b6961	Add deprecation warnings for `webclient` listener and non-HTTP(S) `web_client_location`. (#11774 ) This changes the behaviour of the root endpoint to redirect directly to the configuration of `web_client_location` if it is given an HTTP(S) URL.	2022-01-20 14:21:06 +00:00
David Robertson	f160fe18e3	Debug for device lists updates (#11760 ) Debug for #8631. I'm having a hard time tracking down what's going wrong in that issue. In the reported example, I could see server A sending federation traffic to server B and all was well. Yet B reports out-of-sync device updates from A. I couldn't see what was _in_ the events being sent from A to B. So I have added some crude logging to track - when we have updates to send to a remote HS - the edus we actually accumulate to send - when a federation transaction includes a device list update edu - when such an EDU is received This is a bit of a sledgehammer.	2022-01-20 13:38:44 +00:00
Nicolas Werner	fa583c2198	Allow overriding the complement ref. (#11766 ) Updates complement.sh to read the ref from an environment variable (defaulting to master) when downloading a complement bundle for testing.	2022-01-20 13:04:58 +00:00
Sean Quah	af13a3be29	Fix a bug that corrupted the cache of federated space hierarchies (#11775 ) `FederationClient.get_room_hierarchy()` caches its return values, so refactor the code to avoid modifying the returned room summary.	2022-01-20 11:03:42 +00:00
Richard van der Hoff	5572e6cc4b	Comments and typing for `_update_outliers_txn` (#11776 ) A couple of surprises for me here, so thought I'd document them	2022-01-19 19:45:36 +00:00
Patrick Cloke	c072c0b829	Fix mypy for platforms without epoll support. (#11771 )	2022-01-19 16:50:09 +00:00
Andrew Morgan	7ad7a47e5a	Add missing `auto_attribs=True` to the `_WrappedRustReporter` class (#11768 )	2022-01-19 12:39:11 +00:00
Philippe Daouadi	15ffc4143c	Fix preview of imgur and Tenor URLs. (#11669 ) By scraping Open Graph information from the HTML even when an autodiscovery endpoint is found. The results are then combined to capture as much information as possible from the page.	2022-01-18 13:20:24 -05:00
Patrick Cloke	68acb0a29d	Include whether the requesting user has participated in a thread. (#11577 ) Per updates to MSC3440. This is implement as a separate method since it needs to be cached on a per-user basis, instead of a per-thread basis.	2022-01-18 11:38:57 -05:00
Richard van der Hoff	251b5567ec	Remove `log_function` and its uses (#11761 ) I've never found this terribly useful. I think it was added in the early days of Synapse, without much thought as to what would actually be useful to log, and has just been cargo-culted ever since. Rather, it tends to clutter up debug logs with useless information.	2022-01-18 13:06:04 +00:00
lukasdenk	d8be9924ef	Add a flag to the `synapse_review_recent_signups` script to ignore and filter appservice users. (#11675 )	2022-01-17 16:43:25 +00:00
AndrewFerr	cefd4b87a3	Warn against using Let's Encrypt certs for encrypted TURN (#11686 ) * Warn against using Let's Encrypt certs for encrypted TURN This helps to avoid client-side issues: * https://github.com/vector-im/element-android/issues/1533 * https://github.com/vector-im/element-ios/issues/2712 Signed-off-by: Andrew Ferrazzutti <fair@miscworks.net>	2022-01-17 15:13:09 +00:00
Richard van der Hoff	86615aa965	Fix up docs for `track_puppeted_user_ips` (again) (#11757 ) Fixes #11741	2022-01-17 14:55:30 +00:00
Richard van der Hoff	b0352f9c08	Update documentation for configuring facebook login (#11755 ) ... and a minor thinko fix in the sample config.	2022-01-17 12:35:00 +00:00
Richard van der Hoff	6a78ede569	Improve `reactor_tick_time` metric (#11724 ) The existing implementation of the `python_twisted_reactor_tick_time` metric is pretty useless, because it only measures the time taken to execute timed calls and callbacks from threads. That neglects everything that happens off the back of I/O, which is obviously quite a lot for us. To improve this, I've hooked into a different place in the reactor - in particular, where it calls `epoll`. That call is the only place it should wait for something to happen - the rest of the loop should be quick. I've also removed `python_twisted_reactor_pending_calls`, because I don't believe anyone ever looks at it, and it's a nuisance to populate.	2022-01-17 12:14:40 +00:00
Daniel Sonck	6b241f5286	Make pagination of rooms in admin api stable (#11737 ) Always add state.room_id after the configurable ORDER BY. Otherwise, for any sort, certain pages can contain results from other pages. (Especially when sorting by creator, since there may be many rooms by the same creator) * Document different order direction of numerical fields "joined_members", "joined_local_members", "version" and "state_events" are ordered in descending direction by default (dir=f). Added a note in tests to explain the differences in ordering. Signed-off-by: Daniël Sonck <daniel@sonck.nl>	2022-01-17 11:42:51 +00:00
Andrew Morgan	18862f20b5	Remove the 'password_hash' from the Users Admin API endpoint response dictionary (#11576 )	2022-01-14 14:53:33 +00:00
Jason Robinson	904bb04409	Fix sample_config.yaml in regards track_puppeted_user_ips (#11749 ) * Fix sample_config.yaml in regards track_puppeted_user_ips Closes #11741 Signed-off-by: Jason Robinson <jasonr@matrix.org>	2022-01-14 14:11:55 +00:00
Patrick Cloke	3e0536cd2a	Replace uses of simple_insert_many with simple_insert_many_values. (#11742 ) This should be (slightly) more efficient and it is simpler to have a single method for inserting multiple values.	2022-01-13 19:44:18 -05:00
David Robertson	d70169bf9b	Fix missing app variable in mail subject (#11745 ) documentation claims that you can use the %(app)s variable in password_reset and email_validation subjects, but if you do you end up with an error 500 Co-authored-by: br4nnigan <10244835+br4nnigan@users.noreply.github.com>	2022-01-13 20:19:10 +00:00
David Robertson	4ca8fcdd5a	Invite PR submitters to credit themselves (#11744 ) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-01-13 18:12:59 +00:00
qwertyforce	b9632046fb	update room spec url in config files (#11739 ) * change spec url in config files * Create 11739.txt * .txt -> .doc	2022-01-13 17:09:15 +00:00
Andy Balaam	5ff5f17377	Mention python3-venv and libpq-dev dependencies in contribution guide (#11740 )	2022-01-13 16:33:37 +00:00
Patrick Cloke	0c40c619aa	Include bundled aggregations in the sync response cache. (#11659 )	2022-01-13 10:45:28 -05:00
Richard van der Hoff	20c6d85c6e	Simplify GC prometheus metrics (#11723 ) Rather than hooking into the reactor loop, just add a timed task that runs every 100 ms to do the garbage collection. Part 1 of a quest to simplify the reactor monkey-patching.	2022-01-13 14:35:52 +00:00
Patrick Cloke	10a88ba91c	Use auto_attribs/native type hints for attrs classes. (#11692 )	2022-01-13 13:49:28 +00:00
Andy Balaam	b92a2ff797	Fix typo in demo docs: differnt (#11735 )	2022-01-13 13:10:42 +00:00
Jason Robinson	2560b1b6b2	Allow tracking puppeted users for MAU (#11561 ) Currently when puppeting another user, the user doing the puppeting is tracked for client IPs and MAU (if configured). When tracking MAU is important, it becomes necessary to be possible to also track the client IPs and MAU of puppeted users. As an example a client that manages user creation and creation of tokens via the Synapse admin API, passing those tokens for the client to use. This PR adds optional configuration to enable tracking of puppeted users into monthly active users. The default behaviour stays the same. Signed-off-by: Jason Robinson <jasonr@matrix.org>	2022-01-12 16:09:36 +00:00
haslersn	99ba5ae7b7	Fix documentation of supported PostgreSQL version (#11725 ) Signed-off-by: Sebastian Hasler <sebastian.hasler@stuvus.uni-stuttgart.de>	2022-01-12 14:43:48 +00:00
Richard van der Hoff	d41c4654db	Use buildkit's cache feature to speed up docker builds (#11691 ) Having spent much of the last week attempting to run complement tests from somewhere with damp string instead of internet... something had to be done.	2022-01-12 10:37:57 +00:00
Michael Kaye	338e70c617	Complement environment variable name change and update .gitignore. (#11718 )	2022-01-10 23:18:56 +00:00
Andrew Morgan	7c3408d1a8	Document the `SYNAPSE_TEST_PERSIST_SQLITE_DB` unit test env var (#11715 )	2022-01-10 17:06:42 +00:00
reivilibre	ffd227c382	Fix docstring on `add_account_data_for_user`. (#11716 )	2022-01-10 15:38:22 +00:00
David Robertson	c43dd4d01b	Deal with mypy errors w/ type-hinted pynacl 1.5.0 (#11714 ) * Deal with mypy errors w/ type-hinted pynacl 1.5.0 Fixes #11644. I really don't like that we're monkey patching pynacl SignedKey instances with alg and version objects. But I'm too scared to make the changes necessary right now. (Ideally I would replace `signedjson.types.SingingKey` with a runtime class which wraps or inherits from `nacl.signing.SigningKey`.) C.f. https://github.com/matrix-org/python-signedjson/issues/16	2022-01-10 13:40:46 +00:00
kegsay	3be63654e4	Prettier complement logs (#11707 ) * Prettier complement logs * Changelog	2022-01-10 11:46:40 +00:00
Patrick Cloke	8e57584a58	Support spaces with > 50 rooms in the /hierarchy endpoint. (#11695 ) By returning all of the m.space.child state of the space, not just the first 50. The number of rooms returned is still capped at 50. For the federation API this implies that the requesting server will need to individually query for any other rooms it is not joined to.	2022-01-07 19:27:58 -05:00
David Robertson	d3cf0730f8	Optionally use an on-disk sqlite db in tests (#11702 ) * Optionally use an on-disk sqlite db in tests When debugging a test it is sometimes useful to inspect the state of the DB. This is not easy when the db is in-memory: one cannot attach the sqlite CLI to another process's DB. With this change, if SYNAPSE_TEST_PERSIST_SQLITE_DB is set, we use `_trial_temp/test.db` as our sqlite database. One can then use `sqlite3 _trial_temp/test.db` and query to your heart's content. The DB is destroyed and recreated between different test cases. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-01-07 19:13:41 +00:00
David Robertson	2bb4bd1269	Test that bans win a join against a race when computing `/sync` response (#11701 )	2022-01-07 16:43:21 +00:00
Olivier Wilkinson (reivilibre)	6a04767439	Merge branch 'release-v1.50' into develop	2022-01-07 14:22:13 +00:00
Patrick Cloke	6bf81a7a61	Bundle aggregations outside of the serialization method. (#11612 ) This makes the serialization of events synchronous (and it no longer access the database), but we must manually calculate and provide the bundled aggregations. Overall this should cause no change in behavior, but is prep work for other improvements.	2022-01-07 09:10:46 -05:00
Patrick Cloke	6c68e874b1	Remove the /send_relation endpoint. (#11682 ) This was removed from MSC2674 before that was approved and is not used by any known clients.	2022-01-06 19:00:34 +00:00
Patrick Cloke	201c48c8de	Remove a Python 2-ism and improve type hints. (#11699 ) On Python 2, indexing a byte-string gives back a byte-string, while on Python 3 it gives back the ASCII equivalent as an int.	2022-01-06 18:08:48 +00:00
Olivier Wilkinson (reivilibre)	e87540abb1	Re-run Towncrier to add in the changelog entry for the Mjolnir workaround	2022-01-06 17:54:21 +00:00
Shay	70ce9aea71	Strip unauthorized fields from `unsigned` object in events received over federation (#11530 ) * add some tests to verify we are stripping unauthorized fields out of unsigned * add function to strip unauthorized fields from the unsigned object of event * newsfragment * update newsfragment number * add check to on_send_membership_event * refactor tests * fix lint error * slightly refactor tests and add some comments * slight refactor * refactor tests * fix import error * slight refactor * remove unsigned filtration code from synapse/handlers/federation_event.py * lint * move unsigned filtering code to event base * refactor tests * update newsfragment * requested changes * remove unused retun values	2022-01-06 09:09:30 -08:00
reivilibre	eec34b1f2a	Work around Mjolnir compatibility issue by adding an import for `glob_to_regex` in `synapse.util`, where it moved from. (#11696 )	2022-01-06 16:36:26 +00:00
lukasdenk	2ef1fea8d2	Make room creations denied by `user_may_create_room` cause an `M_FORBIDDEN` error to be returned, not `M_UNKNOWN` (#11672 ) Co-authored-by: reivilibre <olivier@librepush.net>	2022-01-06 13:16:42 +00:00
David Robertson	c9eb678b73	Remove debug logging for #4422 (#11693 ) as per https://github.com/matrix-org/synapse/pull/11532#discussion_r769123269	2022-01-06 12:44:36 +00:00
Travis Ralston	feb3e006d7	Fix space hierarchy endpoint to match MSC2946 (#11667 ) Fixes minor discrepancies between the /hierarchy endpoint described in MSC2946 and the implementation. Note that the changes impact the stable and unstable /hierarchy and unstable /spaces endpoints for both client and federation APIs.	2022-01-05 20:33:43 +00:00
Dirk Klimpel	3b51c763ba	Fix get federation status of destination if no error occured (#11593 )	2022-01-05 14:46:50 -05:00
Shay	d8f94eeec2	Run `pyupgrade --py37-plus --keep-percent-format` on Synapse (#11685 ) * newsfragment * fix newsfragment number * update changelog * remove extra space	2022-01-05 09:53:05 -08:00
Patrick Cloke	83acdb23fe	Re-run towncrier.	2022-01-05 12:09:15 -05:00
Patrick Cloke	877b45e812	Include `io.element.thread` capability for MSC3440. (#11690 )	2022-01-05 12:08:03 -05:00
David Robertson	88a78c6577	Cache empty responses from `/user/devices` (#11587 ) If we've never made a request to a remote homeserver, we should cache the response---even if the response is "this user has no devices".	2022-01-05 13:33:28 +00:00
Olivier Wilkinson (reivilibre)	9be5aacc2d	1.50.0rc1	2022-01-05 12:39:48 +00:00
Richard van der Hoff	0fb3dd0830	Refactor the way we set `outlier` (#11634 ) * `_auth_and_persist_outliers`: mark persisted events as outliers Mark any events that get persisted via `_auth_and_persist_outliers` as, well, outliers. Currently this will be a no-op as everything will already be flagged as an outlier, but I'm going to change that. * `process_remote_join`: stop flagging as outlier The events are now flagged as outliers later on, by `_auth_and_persist_outliers`. * `send_join`: remove `outlier=True` The events created here are returned in the result of `send_join` to `FederationHandler.do_invite_join`. From there they are passed into `FederationEventHandler.process_remote_join`, which passes them to `_auth_and_persist_outliers`... which sets the `outlier` flag. * `get_event_auth`: remove `outlier=True` stop flagging the events returned by `get_event_auth` as outliers. This method is only called by `_get_remote_auth_chain_for_event`, which passes the results into `_auth_and_persist_outliers`, which will flag them as outliers. * `_get_remote_auth_chain_for_event`: remove `outlier=True` we pass all the events into `_auth_and_persist_outliers`, which will now flag the events as outliers. * `_check_sigs_and_hash_and_fetch`: remove unused `outlier` parameter This param is now never set to True, so we can remove it. * `_check_sigs_and_hash_and_fetch_one`: remove unused `outlier` param This is no longer set anywhere, so we can remove it. * `get_pdu`: remove unused `outlier` parameter ... and chase it down into `get_pdu_from_destination_raw`. * `event_from_pdu_json`: remove redundant `outlier` param This is never set to `True`, so can be removed. * changelog * update docstring	2022-01-05 12:26:11 +00:00
Philipp Matthias Schäfer	eedb4527f1	Fix link from generated configuration file to documentation (#11678 ) Co-authored-by: reivilibre <olivier@librepush.net> Co-authored-by: reivilibre <oliverw@matrix.org>	2022-01-05 12:16:52 +00:00
Fr3shTea	0201c6371c	Fix SimpleHttpClient not sending Accept header in `get_json` (#11677 ) Co-authored-by: reivilibre <olivier@librepush.net>	2022-01-05 11:59:29 +00:00
Dirk Klimpel	7a1cefc6e3	Add admin API to get users' account data (#11664 ) Co-authored-by: reivilibre <olivier@librepush.net>	2022-01-05 11:49:06 +00:00
reivilibre	84bfe47b01	Re-apply: Move glob_to_regex and re_word_boundary to matrix-python-common #11505 (#11687 ) Co-authored-by: Sean Quah <seanq@element.io>	2022-01-05 11:41:49 +00:00
reivilibre	84d790a32e	Clarify SSO mapping provider documentation by writing `def` or `async def` before the names of methods, as appropriate. (#11681 )	2022-01-05 11:25:32 +00:00
Callum Macdonald	7013e06e2f	Improve Docker docs for use with Postgres (#11640 )	2022-01-05 10:50:28 +00:00
Donny Johnson	0715e77b06	Correct Synapse install command for FreeBSD. (#11267 ) Co-authored-by: reivilibre <olivier@librepush.net>	2022-01-05 10:38:51 +00:00
Richard van der Hoff	79f6d3550a	update ngnix reverse-proxy example (#11680 ) this should not be a case-insensitive match.	2022-01-04 22:31:45 +00:00
Richard van der Hoff	b38bdae3a2	Fix AssertionErrors after purging events (#11642 ) * Fix AssertionErrors after purging events If you purged a bunch of events from your database, and then restarted synapse without receiving more events, then you would get a bunch of AssertionErrors on restart. This fixes the situation by rewinding the stream processors. * `check-newsfragment`: ignore deleted newsfiles	2022-01-04 16:36:33 +00:00
Richard van der Hoff	878aa55293	`FederationClient.backfill`: stop flagging events as outliers (#11632 ) Events returned by `backfill` should not be flagged as outliers. Fixes: ``` AssertionError: null File "synapse/handlers/federation.py", line 313, in try_backfill dom, room_id, limit=100, extremities=extremities File "synapse/handlers/federation_event.py", line 517, in backfill await self._process_pulled_events(dest, events, backfilled=True) File "synapse/handlers/federation_event.py", line 642, in _process_pulled_events await self._process_pulled_event(origin, ev, backfilled=backfilled) File "synapse/handlers/federation_event.py", line 669, in _process_pulled_event assert not event.internal_metadata.is_outlier() ``` See https://sentry.matrix.org/sentry/synapse-matrixorg/issues/231992 Fixes #8894.	2022-01-04 16:31:32 +00:00
Richard van der Hoff	2359ee3864	Remove redundant `get_current_events_token` (#11643 ) * Push `get_room_{min,max_stream_ordering}` into StreamStore Both implementations of this are identical, so we may as well push it down and get rid of the abstract base class nonsense. * Remove redundant `StreamStore` class This is empty now * Remove redundant `get_current_events_token` This was an exact duplicate of `get_room_max_stream_ordering`, so let's get rid of it. * newsfile	2022-01-04 16:10:27 +00:00
Richard van der Hoff	bd9821f7f1	Better error messages from `get_create_event_for_room` (#11638 ) "Unknown room" can mean a multitude of things here. To help with debugging, add some more words to the exception text.	2022-01-04 16:10:05 +00:00
Patrick Cloke	8422a7f7f6	Include the topic event in the prejoin state, per MSC3173. (#11666 ) Invites and knocks will now include the topic in the stripped state send to clients before joining the room.	2022-01-04 11:08:08 -05:00
Shay	13c974ed35	Drop Bionic from Debian builds (#11633 ) * update Trove classifiers to remove py36 * stop building bionic * update dh-virtualenv * newsfragment * fix newsfragment * update version refs * another try at correct tag * Update changelog	2022-01-03 11:17:16 -08:00
Patrick Cloke	cbd82d0b2d	Convert all namedtuples to attrs. (#11665 ) To improve type hints throughout the code.	2021-12-30 18:47:12 +00:00
Dirk Klimpel	07a3b5daba	Add type hints to `synapse/storage/databases/main/events_bg_updates.py` (#11654 )	2021-12-30 07:22:31 -05:00
reivilibre	2c7f5e74e5	Fix a type annotation in `test_account_data.py` and remove it from the Mypy exclusion list. (#11657 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2021-12-29 15:12:30 +00:00
Dirk Klimpel	f82d38ed2e	Improve type hints in storage classes. (#11652 ) By using cast and making ignores more specific.	2021-12-29 13:04:28 +00:00
Patrick Cloke	f58b300d27	Do not attempt to bundled aggregations for /members and /state. (#11623 ) Both of those APIs return state events, which will not have bundled aggregations added anyway.	2021-12-29 08:02:03 -05:00
Dirk Klimpel	15bb1c8511	Add type hints to `synapse/storage/databases/main/stats.py` (#11653 )	2021-12-29 08:01:13 -05:00
Shay	fcfe67578f	Update to the current version of Black and run it on Synapse codebase (#11596 ) * update black version * run updated version of black on code * newsfragment * enumerate python versions	2021-12-23 20:22:15 -08:00
Patrick Cloke	66d7aa783a	Fix mypy error with opentracing.tags. (#11622 )	2021-12-23 11:47:24 +00:00
AndrewFerr	c500bf37d6	Add details for how to set up TURN behind NAT (#11553 ) Signed-off-by: Andrew Ferrazzutti <fair@miscworks.net>	2021-12-23 10:42:50 +00:00
Shay	87da37374a	Drop EOL python 3.6 from CI (#11595 ) * remove python 3.6 and postgres 9.6 from github workflow * remove python 3.6 env from tox * newsfragment * correct postgres version * add py310 to tox env list	2021-12-21 11:37:04 -08:00
Richard van der Hoff	144b9ede89	Merge branch 'master' into develop	2021-12-21 18:13:05 +00:00
reivilibre	e6897e7383	Refactor `tests.util.setup_test_homeserver` and `tests.server.setup_test_homeserver`. (#11503 )	2021-12-21 16:12:05 +00:00
Patrick Cloke	b6102230a7	Add type hints to event_push_actions. (#11594 )	2021-12-21 13:25:34 +00:00
Richard van der Hoff	2215954147	Various opentracing enhancements (#11619 ) * Wrap `auth.get_user_by_req` in an opentracing span give `get_user_by_req` its own opentracing span, since it can result in a non-trivial number of sub-spans which it is useful to group together. This requires a bit of reorganisation because it also sets some tags (and may force tracing) on the servlet span. * Emit opentracing span for encoding json responses This can be a significant time sink. * Rename all sync spans with a prefix * Write an opentracing span for encoding sync response * opentracing span to group generate_room_entries * opentracing spans within sync.encode_response * changelog * Use the `trace` decorator instead of context managers	2021-12-21 11:10:36 +00:00
Patrick Cloke	dd47788752	Do not bundle aggregations for APIs which shouldn't include them. (#11592 ) And make bundling aggregations opt-in, instead of opt-out to avoid having APIs to include extraneous data (and being much heavier than necessary).	2021-12-20 14:14:38 -05:00
Richard van der Hoff	c3e38b88f2	Improve opentracing support for `ResponseCache` (#11607 ) This adds some opentracing annotations to ResponseCache, to make it easier to see what's going on; in particular, it adds a link back to the initial trace which is actually doing the work of generating the response.	2021-12-20 18:12:08 +00:00
Richard van der Hoff	60fa4935b5	Improve opentracing for incoming HTTP requests (#11618 ) * remove `start_active_span_from_request` Instead, pull out a separate function, `span_context_from_request`, to extract the parent span, which we can then pass into `start_active_span` as normal. This seems to be clearer all round. * Remove redundant tags from `incoming-federation-request` These are all wrapped up inside a parent span generated in AsyncResource, so there's no point duplicating all the tags that are set there. * Leave request spans open until the request completes It may take some time for the response to be encoded into JSON, and that JSON to be streamed back to the client, and really we want that inside the top-level span, so let's hand responsibility for closure to the SynapseRequest. * opentracing logs for HTTP request events * changelog	2021-12-20 17:45:03 +00:00
Richard van der Hoff	8e4083e2f6	Merge remote-tracking branch 'origin/release-v1.49' into develop	2021-12-20 16:34:01 +00:00
Richard van der Hoff	76aa5537ad	Disable aggregation bundling on `/sync` responses (#11583 ) * Disable aggregation bundling on `/sync` responses A partial revert of #11478. This turns out to have had a significant CPU impact on initial-sync handling. For now, let's disable it, until we find a more efficient way of achieving this. * Fix tests. Co-authored-by: Patrick Cloke <patrickc@matrix.org>	2021-12-20 16:33:35 +00:00
Patrick Cloke	3e0cfd447e	Return JSON errors for unknown resources under /matrix/client. (#11602 ) Instead of returning 404 errors with HTML bodies when an unknown prefix was requested (e.g. /matrix/client/v1 before Synapse v1.49.0).	2021-12-20 16:00:13 +00:00
V02460	7a7ca8f226	Use mock from standard library (#11588 ) Instead of the backported version.	2021-12-20 10:34:46 -05:00
Shay	8ad39438fa	Add opentracing types (#11603 )	2021-12-20 12:18:09 +00:00
Dirk Klimpel	8428ef66c7	Add type hints to `synapse/tests/rest/admin` (#11590 )	2021-12-16 14:59:56 -05:00
Dirk Klimpel	1847d027e6	Add type hints to `synapse/storage/databases/main/transactions.py` (#11589 )	2021-12-16 14:59:35 -05:00
Eric Eastwood	43f5cc7adc	Add MSC2716 and MSC3030 to `/versions` -> `unstable_features` (#11582 ) As suggested in https://github.com/matrix-org/matrix-react-sdk/pull/7372#discussion_r769523369	2021-12-16 11:25:37 -06:00
Sean Quah	c7fe32edb4	Add type hints to `synapse/storage/databases/main/room.py` (#11575 )	2021-12-15 18:00:48 +00:00
Patrick Cloke	f901f8b70e	Require Collections as the parameters for simple_* methods. (#11580 ) Instead of Iterable since the generators are not allowed due to the potential for their re-use.	2021-12-15 17:00:50 +00:00
Patrick Cloke	323151b787	Convert EventStreamResult to attrs. (#11574 )	2021-12-15 11:10:02 -05:00
reivilibre	17886d2603	Add experimental support for MSC3202: allowing application services to masquerade as specific devices. (#11538 )	2021-12-15 10:40:52 +00:00
Sean Quah	ecfcd9bbbe	Add type hints to `synapse/storage/databases/main/e2e_room_keys.py` (#11549 )	2021-12-14 17:46:47 +00:00
Sean Quah	0147b3de20	Add missing type hints to `synapse.logging.context` (#11556 )	2021-12-14 17:35:28 +00:00
Patrick Cloke	2519beaad2	Add missing type hints to `synapse.appservice` (#11360 )	2021-12-14 17:02:46 +00:00
Sean Quah	a4dce5b53d	Remove redundant `COALESCE()`s around `COUNT()`s in database queries (#11570 ) `COUNT()` never returns `NULL`. A `COUNT(*)` over 0 rows is 0 and a `COUNT(NULL)` is also 0.	2021-12-14 12:34:30 +00:00
Patrick Cloke	33abbc3278	Add missing type hints to synapse.http. (#11571 )	2021-12-14 07:00:47 -05:00
Richard van der Hoff	ff6fd52160	checks for generators in database functions (#11564 ) A couple of safety-checks to hopefully stop people doing what I just did, and create a storage function which only works the first time it is called (and not when it is re-run due to a database concurrency error or similar).	2021-12-13 19:01:27 +00:00
Patrick Cloke	eb39da6782	Move HTML parsing to a separate file for URL previews. (#11566 ) * Splits the logic for parsing HTML from the resource handling code. * Fix a circular import in the oEmbed code (which uses the HTML parsing code). * Renames some of the HTML parsing methods to: * Make it clear which methods are "internal" to the module. * Clarify what the methods do.	2021-12-13 17:55:07 +00:00
Sean Quah	5305a5e881	Type hint the constructors of the data store classes (#11555 )	2021-12-13 17:05:00 +00:00
Sean Quah	1abfb15f07	Add type hints to `synapse/storage/databases/main/end_to_end_keys.py` (#11551 )	2021-12-13 16:28:26 +00:00
Sean Quah	6da8591f2e	Add type hints to `synapse/storage/databases/main/account_data.py` (#11546 )	2021-12-13 16:28:10 +00:00
reivilibre	e5cdb9e233	Make `get_device` return None if the device doesn't exist rather than raising an exception. (#11565 ) Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2021-12-13 15:39:43 +00:00
Eric Eastwood	aa8708ebed	Allow events to be created with no `prev_events` (MSC2716) (#11243 ) The event still needs to have `auth_events` defined to be valid. Split out from https://github.com/matrix-org/synapse/pull/11114	2021-12-10 23:08:51 -06:00
Eric Eastwood	8391bd6ab5	Test to ensure we share the same `state_group` across the whole historical batch (MSC2716) (#11487 ) Part of MSC2716: https://github.com/matrix-org/matrix-doc/pull/2716 We did some work on making sure the `state_groups` were shared in https://github.com/matrix-org/synapse/pull/10975	2021-12-10 20:59:20 -06:00
David Robertson	fd2dadb815	Adjust _get_rooms_changed comments (#11550 ) C.f. https://github.com/matrix-org/synapse/pull/11494#pullrequestreview-827780886	2021-12-10 19:19:48 +00:00
Richard van der Hoff	f0562183e7	skip some dict munging in event persistence (#11560 ) Create a new dict helper method `simple_insert_many_values_txn`, which takes raw row values, rather than {key=>value} dicts. This saves us a bunch of dict munging, and makes it easier to use generators rather than creating intermediate lists and dicts.	2021-12-10 15:02:33 +00:00
Richard van der Hoff	86e7a6d16e	Stop populating `state_events.prev_state` (#11558 ) this field is never read, so we may as well stop populating it.	2021-12-10 14:13:23 +00:00
Patrick Cloke	9562f0c2f1	Ensure emails are canonicalized before fetching associated user. (#11547 ) This should fix pushers with an email in non-canonical form is used as the pushkey.	2021-12-10 07:17:28 -05:00
Patrick Cloke	3b8872299a	Do not allow cross-room relations, per MSC2674. (#11516 )	2021-12-09 13:16:01 -05:00
Patrick Cloke	0cc3bf97b4	Additional type hints for the config module, part 2. (#11480 )	2021-12-09 16:15:46 +00:00
Dirk Klimpel	941ebe49ff	Use HTTPStatus constants in place of literals in `synapse.http` (#11543 )	2021-12-09 11:58:25 +00:00
Hubert Chathi	b47d10dc46	Support unprefixed versions of fallback key property names. (#11541 )	2021-12-09 11:41:27 +00:00
Dirk Klimpel	b3bcacf3c1	Add missing `errcode` to `parse_string` and `parse_boolean` (#11542 )	2021-12-09 11:23:34 +00:00
Robert Long	afa0a5e4fc	Allow guests to send state events (#11378 )	2021-12-09 11:02:05 +00:00
Patrick Cloke	d93362d87f	Add a constant for receipt types (m.read). (#11531 ) And expand some type hints in the receipts storage module.	2021-12-08 12:26:29 -05:00
Dirk Klimpel	7ecaa3b976	Clean up `synapse.rest.admin` (#11535 )	2021-12-08 16:59:40 +00:00
reivilibre	83a74d9350	Document the usage of refresh tokens. (#11427 ) Co-authored-by: David Robertson <davidr@element.io>	2021-12-08 15:31:17 +00:00
reivilibre	365e9482fe	Use HTTPStatus constants in place of literals in `tests.rest.client.test_auth`. (#11520 )	2021-12-08 14:54:47 +00:00
Richard van der Hoff	ff7cc17b57	Improve log messages for stream ids (#11536 ) Somehow I'd managed to get my database in a pickle with stream ids. These changes were useful to debug.	2021-12-08 14:15:14 +00:00
Hubert Chathi	8541809cb9	Send and handle cross-signing messages using the stable prefix. (#10520 )	2021-12-08 10:01:38 +00:00
Andrew Morgan	d6fb96e056	Fix case in `wait_for_background_updates` where `self.store` does not exist (#11331 ) Pull the DataStore from the HomeServer instance, which always exists.	2021-12-07 11:51:53 -05:00
Sean Quah	966b5d0fa0	1.49.0rc1	2021-12-07 13:56:09 +00:00
Sean Quah	088d748f2c	Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505 ) (#11527 ) This reverts commit `a77c369897`.	2021-12-07 13:51:11 +00:00
David Robertson	14d593f72d	Refactors in `_generate_sync_entry_for_rooms` (#11515 ) * Move sync_token up to the top * Pull out _get_ignored_users * Try to signpost the body of `_generate_sync_entry_for_rooms` * Pull out _calculate_user_changes Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2021-12-07 12:42:05 +00:00
David Robertson	2a3ec6facf	Correctly register shutdown handler for presence workers (#11518 ) Fixes #11517	2021-12-07 12:34:38 +00:00
Sean Quah	eccc49d755	Fix `ModuleApi.looping_background_call` for non-async functions (#11524 ) After #10847, `looping_background_call` would print an error in the logs every time a non-async function was called. Since the error would be caught and ignored immediately, there were no other side effects.	2021-12-07 11:41:31 +00:00
Richard van der Hoff	b1ecd19c5d	Fix 'delete room' admin api to work on incomplete rooms (#11523 ) If, for some reason, we don't have the create event, we should still be able to purge a room.	2021-12-07 11:37:54 +00:00
David Robertson	9c55dedc8c	Correctly ignore invites from ignored users (#11511 )	2021-12-07 11:24:31 +00:00
reivilibre	2d42e586a8	Fix the test breakage introduced by #11435 as a result of concurrent PRs (#11522 )	2021-12-07 10:49:39 +00:00
reivilibre	2f053f3f82	Stabilise support for MSC2918 refresh tokens as they have now been merged into the Matrix specification. (#11435 )	2021-12-06 19:11:43 +00:00
Quentin Gliech	a15a893df8	Save the OIDC session ID (sid) with the device on login (#11482 ) As a step towards allowing back-channel logout for OIDC.	2021-12-06 12:43:06 -05:00
Dirk Klimpel	8b4b153c9e	Add admin API to get some information about federation status (#11407 )	2021-12-06 16:59:50 +00:00
Patrick Cloke	494ebd7347	Include bundled aggregations in /sync and related fixes (#11478 ) Due to updates to MSC2675 this includes a few fixes: * Include bundled aggregations for /sync. * Do not include bundled aggregations for /initialSync and /events. * Do not bundle aggregations for state events. * Clarifies comments and variable names.	2021-12-06 15:51:15 +00:00
Sean Quah	a77c369897	Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505 )	2021-12-06 11:36:08 +00:00
Eric Eastwood	4eb77965cd	Update backward extremity docs to make it clear that it does not indicate whether we have fetched an events' `prev_events` (#11469 ) Spawning from https://github.com/matrix-org/synapse/pull/9445#discussion_r758958181 Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2021-12-03 18:25:04 -06:00
reivilibre	637df95de6	Support configuring the lifetime of non-refreshable access tokens separately to refreshable access tokens. (#11445 )	2021-12-03 16:42:44 +00:00
Dirk Klimpel	e5f426cd54	Add type hints to `synapse/tests/rest/admin` (#11501 )	2021-12-03 13:57:13 +00:00
Olivier Wilkinson (reivilibre)	8cd68b8102	Revert accidental commits to develop.	2021-12-03 12:31:28 +00:00
Olivier Wilkinson (reivilibre)	6cae125e20	Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>	2021-12-03 12:25:37 +00:00
Richard van der Hoff	5640992d17	Disambiguate queries on `state_key` (#11497 ) We're going to add a `state_key` column to the `events` table, so we need to add some disambiguation to queries which use it.	2021-12-02 22:42:58 +00:00
David Robertson	d26808dd85	Comments on the /sync tentacles (#11494 ) This mainly consists of docstrings and inline comments. There are one or two type annotations and variable renames thrown in while I was here. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2021-12-02 20:58:32 +00:00
reivilibre	f91624a595	Clean up tests.storage.test_appservice (#11492 )	2021-12-02 18:43:33 +00:00
reivilibre	16d39a5490	Clean up `tests.storage.test_main` to remove use of legacy code. (#11493 )	2021-12-02 18:13:43 +00:00
reivilibre	8a4c296987	Clean up `tests.test_visibility` to remove legacy code. (#11495 )	2021-12-02 18:13:30 +00:00
Shay	49e1356ee3	Minor cleanup on recently ported doc pages (#11466 ) * move wiki pages to synapse/docs and add a few titles where necessary * update SUMMARY.md with added pages * add changelog * move incorrectly located newsfragment * update changelog number * snake case added files and update summary.md accordingly * update issue/pr links * update relative links to docs * update changelog to indicate that we moved wiki pages to the docs and state reasoning * requested changes to admin_faq.md * requested changes to database_maintenance_tools.md * requested changes to understanding_synapse_through_graphana_graphs.md * add changelog * fix leftover merge errata * fix unwanted changes from merge * use two spaces between entries * outdent code blocks	2021-12-02 09:46:20 -08:00
Patrick Cloke	d2279f471b	Add most of the missing type hints to `synapse.federation`. (#11483 ) This skips a few methods which are difficult to type.	2021-12-02 16:18:10 +00:00
Sean Quah	b50e39df57	Avoid waiting for zombie processes in `synctl stop` (#11490 )	2021-12-02 16:07:06 +00:00
Sean Quah	858d80bf0f	Fix media repository failing when media store path contains symlinks (#11446 )	2021-12-02 16:05:24 +00:00
reivilibre	435f044807	Add type annotations to `tests.storage.test_appservice`. (#11488 )	2021-12-02 15:30:05 +00:00
Richard van der Hoff	f61462e1be	`scripts-dev/sign_json`: support for signing events (#11486 )	2021-12-02 15:18:40 +00:00
Eric Eastwood	a6f1a3abec	Add MSC3030 experimental client and federation API endpoints to get the closest event to a given timestamp (#9445 ) MSC3030: https://github.com/matrix-org/matrix-doc/pull/3030 Client API endpoint. This will also go and fetch from the federation API endpoint if unable to find an event locally or we found an extremity with possibly a closer event we don't know about. ``` GET /_matrix/client/unstable/org.matrix.msc3030/rooms/<roomID>/timestamp_to_event?ts=<timestamp>&dir=<direction> { "event_id": ... "origin_server_ts": ... } ``` Federation API endpoint: ``` GET /_matrix/federation/unstable/org.matrix.msc3030/timestamp_to_event/<roomID>?ts=<timestamp>&dir=<direction> { "event_id": ... "origin_server_ts": ... } ``` Co-authored-by: Erik Johnston <erik@matrix.org>	2021-12-02 01:02:20 -06:00
Shay	84dc50e160	Port wiki pages to documentation website (#11402 ) * move wiki pages to synapse/docs and add a few titles where necessary * update SUMMARY.md with added pages * add changelog * move incorrectly located newsfragment * update changelog number * snake case added files and update summary.md accordingly * update issue/pr links * update relative links to docs * update changelog to indicate that we moved wiki pages to the docs and state reasoning * revert unintentional change to CHANGES.md * add link Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Update CHANGES.md Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2021-12-01 10:12:19 -08:00
Patrick Cloke	ed635d3285	Add a license header and comment. (#11479 )	2021-12-01 12:51:14 -05:00
Patrick Cloke	7b62791e00	Clean-up get_version_string (#11468 )	2021-12-01 12:43:32 -05:00
Brendan Abolivier	153194c771	Link background update controller docs to summary (#11475 )	2021-12-01 14:13:01 +00:00
Patrick Cloke	f44d729d4c	Additional type hints for config module. (#11465 ) This adds some misc. type hints to helper methods used in the `synapse.config` module.	2021-12-01 07:28:23 -05:00
Patrick Cloke	a265fbd397	Register the login redirect endpoint for v3. (#11451 ) As specified for Matrix v1.1.	2021-12-01 07:25:58 -05:00
Shay	f1795463bf	Add a note about huge pages to our Postgres doc (#11467 ) * Add note to postgres doc about hugepages * Newsfragment	2021-11-30 19:05:20 -08:00
Shay	70cbb1a5e3	Don't start Synapse master process if `worker_app` is set (#11416 ) * Add check to catch syanpse master process starting when workers are configured * add test to verify that starting master process with worker config raises error * newsfragment * specify config.worker.worker_app in check * update test * report specific config option that triggered the error Co-authored-by: reivilibre <oliverw@matrix.org> * clarify error message Co-authored-by: reivilibre <oliverw@matrix.org> Co-authored-by: reivilibre <oliverw@matrix.org>	2021-11-30 10:12:18 -08:00
Maximilian Bosch	42bf020463	Expose worker & homeserver as entrypoints in `setup.py` (#11449 ) Co-authored-by: reivilibre <oliverw@matrix.org>	2021-11-30 16:52:45 +00:00
Patrick Cloke	379f2650cf	Bundle relations of relations into the `/relations` result. (#11284 ) Per updates to MSC2675 which now states that bundled aggregations should be included from the `/relations` endpoint.	2021-11-30 11:33:33 -05:00
Sean Quah	7ff22d6da4	Fix `LruCache` corruption bug with a `size_callback` that can return 0 (#11454 ) When all entries in an `LruCache` have a size of 0 according to the provided `size_callback`, and `drop_from_cache` is called on a cache node, the node would be unlinked from the LRU linked list but remain in the cache dictionary. An assertion would be later be tripped due to the inconsistency. Avoid unintentionally calling `__len__` and use a strict `is None` check instead when unwrapping the weak reference.	2021-11-30 16:28:02 +00:00
Sean Quah	5a0b652d36	Eliminate a few `Any`s in `LruCache` type hints (#11453 )	2021-11-30 15:39:07 +00:00
Dirk Klimpel	432a174bc1	Remove unnecessary `json.dumps` from `tests.rest.admin` (#11461 ) The tests helpers automatically convert dictionaries to JSON payloads, no need to do it manually for each test.	2021-11-30 14:51:04 +00:00
Brendan Abolivier	b14f8a1baf	Merge branch 'master' into develop	2021-11-30 14:28:30 +00:00
Patrick Cloke	28f5252c1f	Add missing copyright header. (#11460 )	2021-11-30 13:23:53 +00:00
Richard van der Hoff	f13a8d1c69	synctl stop: wait for processes to exit (#11459 ) If you're trying to shut down Synapse, it's rather handy if it actually shuts down before you move on.	2021-11-30 11:51:12 +00:00
Marcus	a9481223d1	Improved push typing (#11409 ) Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2021-11-30 11:49:20 +00:00
Dirk Klimpel	35b1900f00	Convert status codes to `HTTPStatus` in `tests.rest.admin` (#11455 )	2021-11-30 09:53:54 +00:00
Dirk Klimpel	e8ae94a223	Convert status codes to `HTTPStatus` in `synapse.rest.admin` (#11452 )	2021-11-29 22:19:45 +00:00
Eric Eastwood	fb58611d21	Refactor `backfilled` into specific behavior function arguments (`_persist_events_and_state_updates`) (#11417 ) Part of https://github.com/matrix-org/synapse/issues/11300 Call stack: - `_persist_events_and_state_updates` (added `use_negative_stream_ordering`) - `_persist_events_txn` - `_update_room_depths_txn` (added `update_room_forward_stream_ordering`) - `_update_metadata_tables_txn` - `_store_room_members_txn` (added `inhibit_local_membership_updates`) Using keyword-only arguments (`*`) to reduce the mistakes from `backfilled` being left as a positional argument somewhere and being interpreted wrong by our new arguments.	2021-11-29 16:01:54 -06:00
Patrick Cloke	a4521ce0a8	Support the stable /hierarchy endpoint from MSC2946 (#11329 ) This also makes additional updates where the implementation had drifted from the approved MSC. Unstable endpoints will be removed at a later data.	2021-11-29 14:32:20 -05:00
Erik Johnston	d08ef6f155	Make background updates controllable via a plugin (#11306 ) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2021-11-29 17:57:06 +01:00
Patrick Cloke	9d1971a5c4	Return the stable `event` field from `/send_join` per MSC3083. (#11413 ) This does not remove the unstable field and still parses both. Handling of the unstable field will need to be removed in the future.	2021-11-29 15:43:20 +00:00
Sean Quah	7564b8e118	Update the media repository documentation (#11415 )	2021-11-29 15:37:56 +00:00
reivilibre	a82b90ab32	Add type annotations to some of the configuration surrounding refresh tokens. (#11428 )	2021-11-29 13:34:14 +00:00
Richard van der Hoff	9cd13c5f63	Fix perspectives requests for multiple keys for the same server (#11440 ) If we tried to request multiple keys for the same server, we would end up dropping some of those requests.	2021-11-29 13:15:36 +00:00
Tulir Asokan	7b4e228e41	Fix using MSC2716 batch sending with event persistence workers (#11220 ) Signed-off-by: Tulir Asokan <tulir@beeper.com>	2021-11-29 13:13:23 +00:00
David Robertson	dc0a3cd596	disallow-untyped-defs for the module_api (#11029 )	2021-11-29 11:28:12 +00:00
David Robertson	aa457b625e	Fix changelog filename in #11441	2021-11-29 11:15:28 +00:00
David Robertson	776ad3e5e9	Add a test case for the SendJoinParser (#11441 ) This would have caught the bug #11438 introduced in #11217 and fixed in #11439.	2021-11-29 11:11:46 +00:00
Daniel Molkentin	e5c5e213ea	Bump ijson dependency to 3.1 (#11438 ) (#11439 ) Since `e81fa92648`, Synapse depends on the use_float flag which has been introduced in ijson 3.1 and is not available in 3.0. This is known to cause runtime errors with send_join. Signed-off-by: Daniel Molkentin <danimo@infra.run> Co-authored-by: Daniel Molkentin <danimo@infra.run>	2021-11-26 20:51:22 +00:00
reivilibre	1b6691dce4	Update MSC2918 refresh token support to confirm with the latest revision: accept the `refresh_tokens` parameter in the request body rather than in the URL parameters. (#11430 )	2021-11-26 19:06:16 +00:00
Sean Quah	ffd858aa68	Add type hints to `synapse/storage/databases/main/events_worker.py` (#11411 ) Also refactor the stream ID trackers/generators a bit and try to document them better.	2021-11-26 18:41:31 +00:00
reivilibre	1d8b80b334	Support expiry of refresh tokens and expiry of the overall session when refresh tokens are in use. (#11425 )	2021-11-26 14:27:14 +00:00
Michael Kaye	e2c300e7e4	Create healthcheck script for synapse-workers container (#11429 ) The intent is to iterate through all the worker ports and only report healthy when all are healthy, starting with the main process.	2021-11-26 14:05:20 +00:00
Sean Quah	c675a18071	Track ongoing event fetches correctly (again) (#11376 ) The previous fix for the ongoing event fetches counter (`8eec25a1d9`) was both insufficient and incorrect. When the database is unreachable, `_do_fetch` never gets run and so `_event_fetch_ongoing` is never decremented. The previous fix also moved the `_event_fetch_ongoing` decrement outside of the `_event_fetch_lock` which allowed race conditions to corrupt the counter.	2021-11-26 13:47:24 +00:00
Sean Quah	7862f821de	Annotate string constants in `synapse.api.constants` with `Final` (#11356 ) This change makes mypy complain if the constants are ever reassigned, and, more usefully, makes mypy type them as `Literal`s instead of `str`s, allowing code of the following form to pass mypy: ```py def do_something(membership: Literal["join", "leave"], ...): ... do_something(Membership.JOIN, ...) ```	2021-11-25 16:14:23 +00:00
Brendan Abolivier	946c102ac9	1.48.0rc1	2021-11-25 15:57:04 +00:00
Brendan Abolivier	0d88c4f903	Improve performance of `remove_{hidden,deleted}_devices_from_device_inbox` (#11421 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2021-11-25 15:14:54 +00:00
Brendan Abolivier	7f9841bdec	Lower minumum batch size to 1 for background updates (#11422 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2021-11-24 19:21:44 +00:00
reivilibre	f25c75d376	Rename unstable `access_token_lifetime` configuration option to `refreshable_access_token_lifetime` to make it clear it only concerns refreshable access tokens. (#11388 )	2021-11-23 17:01:34 +00:00
Patrick Cloke	55669bd3de	Add missing type hints to config base classes (#11377 )	2021-11-23 15:21:19 +00:00
Shay	7cebaf9644	Remove code invalidated by deprecated config flag 'trust_identity_servers_for_password_resets' (#11395 ) * remove background update code related to deprecated config flag * changelog entry * update changelog * Delete 11394.removal Duplicate, wrong number * add no-op background update and change newfragment so it will be consolidated with associated work * remove unused code * Remove code associated with deprecated flag from legacy docker dynamic config file Co-authored-by: reivilibre <oliverw@matrix.org>	2021-11-23 06:46:40 -08:00
Patrick Cloke	6a5dd485bd	Refactor the code to inject bundled relations during serialization. (#11408 )	2021-11-23 06:43:56 -05:00
Kostas	1035663833	Add config for customizing the claim used for JWT logins. (#11361 ) Allows specifying a different claim (from the default "sub") to use when calculating the localpart of the Matrix ID used during the JWT login.	2021-11-22 13:01:03 -05:00
Patrick Cloke	3d893b8cf2	Store arbitrary relations from events. (#11391 ) Instead of only known relation types. This also reworks the background update for thread relations to crawl events and search for any relation type, not just threaded relations.	2021-11-22 12:01:47 -05:00
Dirk Klimpel	ea20937084	Add an admin API to run background jobs. (#11352 ) Instead of having admins poke into the database directly. Can currently run jobs to populate stats and to populate the user directory.	2021-11-19 19:39:46 +00:00
Patrick Cloke	7ae559944a	Fix checking whether a room can be published on creation. (#11392 ) If `room_list_publication_rules` was configured with a rule with a non-wildcard alias and a room was created with an alias then an internal server error would have been thrown. This fixes the error and properly applies the publication rules during room creation.	2021-11-19 15:19:32 +00:00
Patrick Cloke	4d6d38ac2f	Remove dead code from acme support. (#11393 )	2021-11-19 07:07:22 -05:00
Patrick Cloke	5505da2109	Remove msc2716 from the list of tests for complement. (#11389 ) As the tests are currently failing and not run in CI.	2021-11-19 07:06:16 -05:00
Hubert Chathi	eca7cffb73	Keep fallback key marked as used if it's re-uploaded (#11382 )	2021-11-19 11:40:12 +00:00
Richard van der Hoff	e2e9bea1ce	Publish a `develop` docker image (#11380 ) I'd find it helpful to have a docker image corresponding to current develop, without having to build my own.	2021-11-19 10:56:59 +00:00
Richard van der Hoff	a6f7f84570	Fix verification of objects signed with old local keys (#11379 ) Fixes a bug introduced in #11129: objects signed by the local server, but with keys other than the current one, could not be successfully verified. We need to check the key id in the signature, and track down the right key.	2021-11-19 10:55:09 +00:00
Eric Eastwood	7ffddd819c	Prevent historical state from being pushed to an application service via `/transactions` (MSC2716) (#11265 ) Mark historical state from the MSC2716 `/batch_send` endpoint as `historical` which makes it `backfilled` and have a negative `stream_ordering` so it doesn't get queried by `/transactions`. Fix https://github.com/matrix-org/synapse/issues/11241 Complement tests: https://github.com/matrix-org/complement/pull/221	2021-11-18 14:16:08 -06:00
Shay	92b75388f5	Remove legacy code related to deprecated `trust_identity_server_for_password_resets` config flag (#11333 ) * remove code legacy code related to deprecated config flag "trust_identity_server_for_password_resets" from synapse/config/emailconfig.py * remove legacy code supporting depreciated config flag "trust_identity_server_for_password_resets" from synapse/config/registration.py * remove legacy code supporting depreciated config flag "trust_identity_server_for_password_resets" from synapse/handlers/identity.py * add tests to ensure config error is thrown and synapse refuses to start when depreciated config flag is found * add changelog * slightly change behavior to only check for deprecated flag if set to 'true' * Update changelog.d/11333.misc Co-authored-by: reivilibre <oliverw@matrix.org> Co-authored-by: reivilibre <oliverw@matrix.org>	2021-11-18 10:56:32 -08:00
Dirk Klimpel	81b18fe5c0	Add dedicated admin API for blocking a room (#11324 )	2021-11-18 17:43:49 +00:00
reivilibre	5f81c0ce9c	Add/Unerase annotations to Module API (#11341 )	2021-11-18 16:55:33 +00:00
reivilibre	433ee159cb	Rename `get_refresh_token_for_user_id` to `create_refresh_token_for_user_id` (#11370 )	2021-11-18 14:45:38 +00:00
reivilibre	539e441399	Use auto_attribs for RefreshTokenLookupResult (#11386 )	2021-11-18 14:40:26 +00:00
Patrick Cloke	4bd54b263e	Do not allow MSC3440 threads to fork threads (#11161 ) Adds validation to the Client-Server API to ensure that the potential thread head does not relate to another event already. This results in not allowing a thread to "fork" into other threads. If the target event is unknown for some reason (maybe it isn't visible to your homeserver), but is the target of other events it is assumed that the thread can be created from it. Otherwise, it is rejected as an unknown event.	2021-11-18 13:43:09 +00:00
Nicolai Søborg	e2dabec996	Docs: Quote wildcard `federation_certificate_verification_whitelist` (#11381 ) Otherwise I get this beautiful stacktrace: ``` python3 -m synapse.app.homeserver --config-path /etc/matrix/homeserver.yaml Traceback (most recent call last): File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main return _run_code(code, main_globals, None, File "/usr/lib/python3.8/runpy.py", line 87, in _run_code exec(code, run_globals) File "/root/synapse/synapse/app/homeserver.py", line 455, in <module> main() File "/root/synapse/synapse/app/homeserver.py", line 445, in main hs = setup(sys.argv[1:]) File "/root/synapse/synapse/app/homeserver.py", line 345, in setup config = HomeServerConfig.load_or_generate_config( File "/root/synapse/synapse/config/_base.py", line 671, in load_or_generate_config config_dict = read_config_files(config_files) File "/root/synapse/synapse/config/_base.py", line 717, in read_config_files yaml_config = yaml.safe_load(file_stream) File "/root/synapse/env/lib/python3.8/site-packages/yaml/__init__.py", line 125, in safe_load return load(stream, SafeLoader) File "/root/synapse/env/lib/python3.8/site-packages/yaml/__init__.py", line 81, in load return loader.get_single_data() File "/root/synapse/env/lib/python3.8/site-packages/yaml/constructor.py", line 49, in get_single_data node = self.get_single_node() File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 36, in get_single_node document = self.compose_document() File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 55, in compose_document node = self.compose_node(None, None) File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 84, in compose_node node = self.compose_mapping_node(anchor) File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 133, in compose_mapping_node item_value = self.compose_node(node, item_key) File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 82, in compose_node node = self.compose_sequence_node(anchor) File "/root/synapse/env/lib/python3.8/site-packages/yaml/composer.py", line 110, in compose_sequence_node while not self.check_event(SequenceEndEvent): File "/root/synapse/env/lib/python3.8/site-packages/yaml/parser.py", line 98, in check_event self.current_event = self.state() File "/root/synapse/env/lib/python3.8/site-packages/yaml/parser.py", line 379, in parse_block_sequence_first_entry return self.parse_block_sequence_entry() File "/root/synapse/env/lib/python3.8/site-packages/yaml/parser.py", line 384, in parse_block_sequence_entry if not self.check_token(BlockEntryToken, BlockEndToken): File "/root/synapse/env/lib/python3.8/site-packages/yaml/scanner.py", line 116, in check_token self.fetch_more_tokens() File "/root/synapse/env/lib/python3.8/site-packages/yaml/scanner.py", line 227, in fetch_more_tokens return self.fetch_alias() File "/root/synapse/env/lib/python3.8/site-packages/yaml/scanner.py", line 610, in fetch_alias self.tokens.append(self.scan_anchor(AliasToken)) File "/root/synapse/env/lib/python3.8/site-packages/yaml/scanner.py", line 922, in scan_anchor raise ScannerError("while scanning an %s" % name, start_mark, yaml.scanner.ScannerError: while scanning an alias in "/etc/matrix/homeserver.yaml", line 614, column 5 expected alphabetic or numeric character, but found '.' in "/etc/matrix/homeserver.yaml", line 614, column 6 ``` Signed-off-by: Nicolai Søborg <git@xn--sb-lka.org>	2021-11-18 12:24:40 +00:00
Sean Quah	84fac0f814	Add type annotations to `synapse.metrics` (#10847 )	2021-11-17 19:07:02 +00:00
Aaron R	d993c3bb1e	Add support for `/_matrix/media/v3` APIs (#11371 ) * Add support for `/_matrix/media/v3` APIs Signed-off-by: Aaron Raimist <aaron@raim.ist> * Update `workers.md` to use v3 client and media APIs Signed-off-by: Aaron Raimist <aaron@raim.ist> * Add changelog Signed-off-by: Aaron Raimist <aaron@raim.ist>	2021-11-17 15:30:24 +00:00
reivilibre	0d86f6334a	Rename `get_access_token_for_user_id` method to `create_access_token_for_user_id` (#11369 )	2021-11-17 14:10:57 +00:00
Patrick Cloke	60ecb6b4d4	Fix running complement.sh script. (#11368 ) By reverting changes from #11166 in this script. Specifically commit `13f084eb58`.	2021-11-17 09:04:50 -05:00
Patrick Cloke	319dcb955e	Fix incorrect return value in tests. (#11359 )	2021-11-16 16:36:46 +00:00
Sean Quah	88375beeaa	Avoid sharing room hierarchy responses between users (#11355 ) Different users may be allowed to see different rooms within a space, so sharing responses between users is inadvisable.	2021-11-16 15:40:47 +00:00
Aaron R	dfa536490e	Add support for `/_matrix/client/v3` APIs (#11318 ) This is one of the changes required to support Matrix 1.1 Signed-off-by: Aaron Raimist <aaron@raim.ist>	2021-11-16 14:47:58 +01:00
Patrick Cloke	7468723697	Add most missing type hints to synapse.util (#11328 )	2021-11-16 08:47:36 -05:00
reivilibre	3a1462f7e0	Properly register all callback hooks for legacy password authentication providers (#11340 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2021-11-16 12:53:31 +00:00
Patrick Cloke	24b61f379a	Add ability to un-shadow-ban via the admin API. (#11347 )	2021-11-16 12:43:53 +00:00
David Robertson	0dda1a7968	Misc typing fixes for tests, part 2 of N (#11330 )	2021-11-16 10:41:35 +00:00
Ashwin Nair	e72135b9d3	change 'Home Server' to one word 'homeserver' (#11320 ) Signed-off-by: Ashwin S. Nair <58840757+Ashwin-exe@users.noreply.github.com>	2021-11-16 10:21:01 +00:00
David Robertson	e605e4b8f2	Database storage profile passes mypy (#11342 ) It already seems to pass mypy. I wonder what changed, given that it was on the exclusion list. So this commit consists of me ensuring `--disallow-untyped-defs` passes and a minor fixup to a function that returned either `True` or `None`.	2021-11-15 12:59:33 +00:00
David Robertson	5562ce6a53	Get directory db file to pass mypy (#11339 )	2021-11-15 12:59:05 +00:00
Tulir Asokan	6f862c5c28	Add support for the stable version of MSC2778 (#11335 ) * Add support for the stable version of MSC2778 Signed-off-by: Tulir Asokan <tulir@maunium.net> * Expect m.login.application_service in login and password provider tests Signed-off-by: Tulir Asokan <tulir@maunium.net>	2021-11-15 10:31:22 +00:00
Shay	605921bc6b	Remove unused tables `room_stats_historical` and `user_stats_historical` (#11280 ) * remove unused tables room_stats_historical and user_stats_historical * update changelog number * Bump schema compat version comment * make linter happy * Update comment to give more info Co-authored-by: reivilibre <oliverw@matrix.org> Co-authored-by: reivilibre <oliverw@matrix.org>	2021-11-12 16:47:56 -08:00
David Robertson	fe58672546	Annotations for state_deltas.py (#11316 ) I was sad that I couldn't do better for `_curr_state_delta_stream_cache`. At least it's explicitly called out in a comment with #TODO.	2021-11-12 20:24:12 +00:00
Patrick Cloke	3fad4e3fe5	Rollback #11322 due to wrong syntax in mypy.ini. (#11332 ) This was only checking the __init__ files in modules instead of all files in a module, which don't pass yet.	2021-11-12 20:10:03 +00:00
David Robertson	bea815cec8	Test room alias deletion (#11327 ) * Prefer `HTTPStatus` over plain `int` This is an Opinion that no-one has seemed to object to yet. * `--disallow-untyped-defs` for `tests.rest.client.test_directory` * Improve synapse's annotations for deleting aliases * Test case for deleting a room alias * Changelog	2021-11-12 19:56:00 +00:00
Shay	0bcae8ad56	Change display names/avatar URLs to None if they contain null bytes before storing in DB (#11230 ) * change display names/avatar URLS to None if they contain null bytes * add changelog * add POC test, requested changes * add a saner test and remove old one * update test to verify that display name has been changed to None * make test less fragile	2021-11-12 10:38:24 -08:00
Patrick Cloke	9b90b9454b	Add type hints to media repository storage module (#11311 )	2021-11-12 11:05:26 -05:00
David Robertson	6f8f3d4bc5	Attempt to annotate events_forward_extremities (#11314 ) * Make DataStore inherit from EventForwardExtremitiesStore before CacheInvalidationWorkerStore the former implicitly inherits from the latter, so they should be ordered like this when used.	2021-11-12 15:58:17 +00:00
David Robertson	4c96ce396e	Misc typing fixes for `tests`, part 1 of N (#11323 ) * Annotate HomeserverTestCase.servlets * Correct annotation of federation_auth_origin * Use AnyStr custom_headers instead of a Union This allows (str, str) and (bytes, bytes). This disallows (str, bytes) and (bytes, str) * DomainSpecificString.SIGIL is a ClassVar	2021-11-12 15:50:54 +00:00
Patrick Cloke	95547e5300	Generalize the disallowed_untyped_defs in mypy.ini (#11322 )	2021-11-12 14:27:45 +00:00
Patrick Cloke	b64b6d12d4	Add more type hints to synapse.util. (#11321 )	2021-11-12 13:43:06 +00:00
reivilibre	2fffcb24d8	Suggest using `/etc/matrix-synapse/conf.d/` for configuration with Debian packages (#11281 )	2021-11-12 13:17:06 +00:00
Dirk Klimpel	8840a7b7f1	Convert delete room admin API to async endpoint (#11223 ) Signed-off-by: Dirk Klimpel dirk@klimpel.org	2021-11-12 12:35:31 +00:00
David Robertson	c99da2d079	Annotations for user_erasure_store (#11313 ) I'm not sure why this was excluded---it seemed to be passing for me. But it's easy enough to fixup.	2021-11-11 19:22:19 +00:00
David Robertson	6a605f4a77	Get db signatures file to pass mypy (#11312 )	2021-11-11 17:04:44 +00:00
David Robertson	8dc666f785	Correct type hint for room_batch.py (#11310 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2021-11-11 16:49:28 +00:00
Dirk Klimpel	48278a0d09	Move sql file for `remove_deleted_devices_from_device_inbox` into v65 (#11303 )	2021-11-11 15:01:13 +00:00
Patrick Cloke	64ef25391d	Add type hints to some storage classes (#11307 )	2021-11-11 08:47:31 -05:00
Neeeflix	6ce19b94e8	Fix error in thumbnail generation (#11288 ) Signed-off-by: Jonas Zeunert <jonas@zeunert.org>	2021-11-10 20:49:43 +00:00

... 15 16 17 18 19 ...

6718 commits