Patrick Cloke
455ef04187
Avoid updating the same rows multiple times with simple_update_many_txn. ( #16609 )
...
simple_update_many_txn had a bug in it which would cause each
update to be applied twice.
2023-11-07 14:02:09 -05:00
Patrick Cloke
9738b1c497
Avoid executing no-op queries. ( #16583 )
...
If simple_{insert,upsert,update}_many_txn is called without any data
to modify then return instead of executing the query.
This matches the behavior of simple_{select,delete}_many_txn.
2023-11-07 14:00:25 -05:00
Patrick Cloke
ec9ff389f4
More tests for the simple_* methods. ( #16596 )
...
Expand tests for the simple_* database methods, additionally
test against both PostgreSQL and SQLite variants.
2023-11-07 09:34:23 -05:00
Patrick Cloke
7e5d3b06fa
Collect information for PushRuleEvaluator in parallel. ( #16590 )
...
Fetch information needed for push rule evaluation in parallel.
Ideally this would use query pipelining, but this is not
available in psycopg2.
Due to the database thread pool this may result in little
to no parallelization.
2023-11-06 15:41:57 -05:00
Patrick Cloke
1dd3074629
Bump setuptools_rust to match pinned version. ( #16605 )
2023-11-06 09:13:53 -05:00
Patrick Cloke
cc4fe68adf
Support reactor timing metric on more reactors. ( #16532 )
...
Previously only Twisted's EPollReactor was compatible with the
reactor timing metric, notably not working when asyncio was used.
After this change, the following configurations support the reactor
timing metric:
* poll, epoll, or select reactors
* asyncio reactor with a poll, epoll, select, /dev/poll, or kqueue event loop.
2023-11-06 08:31:22 -05:00
Patrick Cloke
92828a7f95
Simplify event persistence code ( #16584 )
...
The event persistence code used to handle multiple rooms
at a time, but was simplified to only ever be called with a
single room at a time (different rooms are now handled in
parallel). The code is still generic to multiple rooms causing
a lot of work that is unnecessary (e.g. unnecessary loops, and
partitioning data by room).
This strips out the ability to handle multiple rooms at once, greatly
simplifying the code.
2023-11-03 07:30:31 -04:00
Patrick Cloke
0afbef30cf
Use simple_select_many_txn in event persistance code. ( #16585 )
...
Just to standardize on the normal helpers, it might also have
a slight perf improvement on PostgreSQL which will now use
`ANY (?)` instead of `IN (?, ?, ...)`.
2023-11-02 09:41:00 -04:00
dependabot[bot]
c812f43bd7
Bump twisted from 23.8.0 to 23.10.0 ( #16588 )
2023-11-01 10:23:13 +00:00
Patrick Cloke
ed1b879576
Do not call getfullargspec on every call. ( #16589 )
...
getfullargspec is relatively expensive and the results will
not change between calls, so precalculate it outside the
wrapper.
2023-10-31 20:16:17 +00:00
Patrick Cloke
cfb6d38c47
Remove remaining usage of cursor_to_dict. ( #16564 )
2023-10-31 13:13:28 -04:00
Erik Johnston
4bb2b4aa9a
1.96.0rc1
2023-10-31 14:09:13 +00:00
Erik Johnston
60c5e8d79b
Revert "1.96.0rc1"
...
This reverts commit 4724a6ded1
2023-10-31 14:08:45 +00:00
Erik Johnston
4724a6ded1
1.96.0rc1
2023-10-31 13:47:08 +00:00
David Robertson
de981ae567
Claim local one-time-keys in bulk ( #16565 )
...
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
2023-10-30 21:25:21 +00:00
Niranjan Kurhade
91aa52c911
Clients link fixed in README ( #16569 )
2023-10-30 16:05:34 +00:00
Erik Johnston
408c13801a
Add fast path for replication events stream fetch ( #16580 )
...
We can bail early if the from token is greater than or equal to the
current token.
2023-10-30 14:47:57 +00:00
David Robertson
fdce83ee60
Claim fallback keys in bulk ( #16570 )
2023-10-30 14:34:37 +00:00
dependabot[bot]
a3f6200d65
Bump setuptools-rust from 1.7.0 to 1.8.0 ( #16574 )
...
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: David Robertson <davidr@element.io>
2023-10-30 13:40:17 +00:00
David Robertson
4e1a19d375
Run actions/setup-go after checking out complement ( #16567 )
2023-10-30 13:07:08 +00:00
Erik Johnston
8c63e93286
Fix HTTP repl response to use minimum token ( #16578 )
2023-10-30 12:27:14 +00:00
David Robertson
747416e94c
Portdb: don't copy a table that gets rebuilt ( #16563 )
2023-10-27 20:14:02 +01:00
kegsay
11a8ae0632
complement: enable dirty runs ( #16520 )
...
* complement: enable dirty runs
* Add changelog
* Set a low connpool limit when running in Complement
Dirty runs can cause many containers to be running concurrently,
which seems to easily exhaust resources on the host. The increased
speedup from dirty runs also seems to use more db connections on
workers, which are misconfigured currently to have
`SUM(workers * cp_max) > max_connections`, causing
```
FATAL: sorry, too many clients already
```
which results in tests failing.
* Try p=2 concurrency to restrict slowness of servers which causes partial state join tests to flake
* Debug logging
* Only run flakey tests
* Only adjust connection pool limits in worker mode
* Move cp vars to somewhere where they get executed in CI
* Move cp values back to where they actually work
* Debug logging
* Try p=1 to see if this makes worker mode happier
* Remove debug logging
2023-10-27 18:29:20 +01:00
Patrick Cloke
2bf9341406
Ensure local invited & knocking users leave before purge. ( #16559 )
...
This is mostly useful for federated rooms where some users
would get stuck in the invite or knock state when the room
was purged from their homeserver.
2023-10-27 12:50:50 -04:00
Erik Johnston
5413cefe32
Reduce amount of caches POSITIONS we send ( #16561 )
...
Follow on from / actually correctly does #16557
2023-10-27 16:07:11 +01:00
Erik Johnston
89dbbd68e1
Reduce spurious replication catchup ( #16555 )
2023-10-27 13:27:20 +00:00
Erik Johnston
928e964857
Fix cross-worker ratelimiting ( #16558 )
...
c.f. #16481
2023-10-27 12:52:40 +01:00
Erik Johnston
0680d76659
Reduce replication traffic due to reflected cache stream POSITION ( #16557 )
2023-10-27 12:51:08 +01:00
Erik Johnston
c02406ac71
Add new module API for adding custom fields to events unsigned section ( #16549 )
2023-10-27 09:04:08 +00:00
Patrick Cloke
679c691f6f
Remove more usages of cursor_to_dict. ( #16551 )
...
Mostly to improve type safety.
2023-10-26 15:12:28 -04:00
Patrick Cloke
85e5f2dc25
Add a new module API to update user presence state. ( #16544 )
...
This adds a module API which allows a module to update a user's
presence state/status message. This is useful for controlling presence
from an external system.
To fully control presence from the module the presence.enabled config
parameter gains a new state of "untracked" which disables internal tracking
of presence changes via user actions, etc. Only updates from the module will
be persisted and sent down sync properly).
2023-10-26 15:11:24 -04:00
Patrick Cloke
9407d5ba78
Convert simple_select_list and simple_select_list_txn to return lists of tuples ( #16505 )
...
This should use fewer allocations and improves type hints.
2023-10-26 13:01:36 -04:00
David Robertson
c14a7de6af
Pin the recommended poetry version in contributors' guide ( #16550 )
2023-10-25 16:31:15 +01:00
Erik Johnston
ba47fea528
Allow multiple workers to write to receipts stream. ( #16432 )
...
Fixes #16417
2023-10-25 16:16:19 +01:00
Patrick Cloke
e182dbb5b9
Fix tests on Twisted trunk. ( #16528 )
...
Twisted trunk makes a change to the `TLSMemoryBIOFactory` where
the underlying protocol is changed from `TLSMemoryBIOProtocol` to
`BufferingTLSTransport` to improve performance of TLS code (see
https://github.com/twisted/twisted/issues/11989 ).
In order to properly hook this code up in tests we need to pass the test
reactor's clock into `TLSMemoryBIOFactory` to avoid the global (trial)
reactor being used by default.
Twisted does something similar internally for tests:
157cd8e659/src/twisted/web/test/test_agent.py (L871-L874)
2023-10-25 07:39:45 -04:00
Richard Brežák
95076f77c1
Fix http/s proxy authentication with long username/passwords ( #16504 )
2023-10-24 13:45:21 +00:00
David Robertson
6ec98810e3
Rework alias and public room list rules docs ( #16541 )
2023-10-24 13:26:41 +01:00
Jason Little
ffbe9b7666
Remove duplicate call to wake a remote destination when using federation sending worker ( #16515 )
2023-10-24 08:09:59 -04:00
Michael Sasser
3df70aa800
Replace all Prometheus datasource UIDs of the Grafana Dashboard with the variable ${DS_PROMETHEUS} and remove __inputs ( #16471 )
2023-10-23 19:50:50 +01:00
Patrick Cloke
3ab861ab9e
Fix type hint errors from Twisted trunk ( #16526 )
2023-10-23 14:28:05 -04:00
Erik Johnston
8f35f8148e
Fix bug where a new writer advances their token too quickly ( #16473 )
...
* Fix bug where a new writer advances their token too quickly
When starting a new writer (for e.g. persisting events), the
`MultiWriterIdGenerator` doesn't have a minimum token for it as there
are no rows matching that new writer in the DB.
This results in the the first stream ID it acquired being announced as
persisted *before* it actually finishes persisting, if another writer
gets and persists a subsequent stream ID. This is due to the logic of
setting the minimum persisted position to the minimum known position of
across all writers, and the new writer starts off not being considered.
* Fix sending out POSITIONs when our token advances without update
Broke in #14820
* For replication HTTP requests, only wait for minimal position
2023-10-23 16:57:30 +01:00
Erik Johnston
3bc23cc45c
Fix bug that could cause a /sync to tightloop with sqlite after restart ( #16540 )
...
This could happen if the last rows in the account data stream were inserted into `account_data`. After a restart the max account ID would be calculated without looking at the `account_data` table, and so have an old ID.
2023-10-23 13:39:25 +00:00
Marcel
3bcb6a059f
Mention how to redirect the Jaeger traces to a specific Jaeger instance ( #16531 )
2023-10-23 11:55:36 +00:00
Denis Kasak
3a0aa6fe76
Force TLS certificate verification in registration script. ( #16530 )
...
If using the script remotely, there's no particularly convincing reason
to disable certificate verification, as this makes the connection
interceptible.
If on the other hand, the script is used locally (the most common use
case), you can simply target the HTTP listener and avoid TLS altogether.
This is what the script already attempts to do if passed a homeserver
configuration YAML file.
2023-10-23 07:38:51 -04:00
Patrick Cloke
12ca87f5ea
Remove the last reference to event_txn_id. ( #16521 )
...
This table was no longer used, except for a background process
which purged old entries in it.
2023-10-23 07:37:45 -04:00
David Robertson
478a6c65eb
Bump matrix-synapse-ldap3 from 0.2.2 to 0.3.0 ( #16539 )
2023-10-23 12:28:29 +01:00
Patrick Cloke
d2eab22de7
Clarify presence router docs. ( #16529 )
2023-10-20 11:40:26 -04:00
Erik Johnston
e9069c9f91
Mark sync as limited if there is a gap in the timeline ( #16485 )
...
This splits thinsg into two queries, but most of the time we won't have
new event backwards extremities so this shouldn't actually add an extra
RTT for the majority of cases.
Note this removes the check for events with no prev events, but that was
part of MSC2716 work that has since been removed.
2023-10-19 15:04:18 +01:00
Patrick Cloke
49c9745b45
Avoid sending massive replication updates when purging a room. ( #16510 )
2023-10-18 12:26:01 -04:00
Mathieu Velten
bcff01b406
Improve performance of delete device messages query ( #16492 )
2023-10-18 16:42:01 +01:00
Patrick Cloke
8841db4d27
Run trial/integration tests if .ci is modified. ( #16512 )
2023-10-18 07:19:53 -04:00
Patrick Cloke
68d9559fef
Test against Python 3.12 release ( #16511 )
2023-10-17 14:41:10 -04:00
Patrick Cloke
6e6d611f55
1.95.0rc1
2023-10-17 11:54:45 -04:00
Patrick Cloke
6ad1f9eac2
Convert DeviceLastConnectionInfo to attrs. ( #16507 )
...
To improve type safety & memory usage.
2023-10-17 12:47:42 +00:00
Patrick Cloke
77dfc1f939
Fix a bug where servers could be marked as up when they were failing ( #16506 )
...
After this change a server will only be reported as back online
if they were previously having requests fail.
2023-10-17 07:32:40 -04:00
reivilibre
7291c68eea
Update the release script to remind releaser to check for special release notes. ( #16461 )
...
* Add reminder to check special release notes board in release script
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Update release.py
* Bah, black
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-10-16 15:22:50 +01:00
Patrick Cloke
e3e0ae4ab1
Convert state delta processing from a dict to attrs. ( #16469 )
...
For improved type checking & memory usage.
2023-10-16 07:35:22 -04:00
Mathieu Velten
eee6474bce
Remove useless async job to delete device messages on sync ( #16491 )
2023-10-16 11:06:27 +01:00
Richard van der Hoff
109882230c
Clean up logging on event persister endpoints ( #16488 )
2023-10-14 17:57:27 +01:00
Laurence Gill
166ffc0f23
Fix typo in useful_sql_for_admins.md ( #16477 )
2023-10-12 16:18:32 +01:00
Patrick Cloke
4cc729d480
Revert "Drop unused tables & unneeded access token ID for events. ( #16268 )" ( #16465 )
...
This reverts commit cabd577460
2023-10-12 08:56:10 -04:00
kegsay
f710d5480b
Update complement.sh to match new public API shape ( #16466 )
...
* Update complement.sh to match new public API shape
Sister PR to https://github.com/matrix-org/complement/pull/666
Context: https://github.com/matrix-org/complement/issues/654#issuecomment-1746613495
* Changelog
* Pedantry
* Run complement plz
2023-10-12 11:33:14 +01:00
Patrick Cloke
cc865fffc0
Convert user_get_threepids response to attrs. ( #16468 )
...
This improves type annotations by not having a dictionary of Any values.
2023-10-11 20:08:11 -04:00
Patrick Cloke
a4904dcb04
Convert simple_select_many_batch, simple_select_many_txn to tuples. ( #16444 )
2023-10-11 13:24:56 -04:00
Patrick Cloke
d6b7d49a61
Handle content types with parameters. ( #16440 )
2023-10-11 07:50:34 -04:00
Patrick Cloke
f1e43018b7
Inline simple_search_list/simple_search_list_txn. ( #16434 )
...
This only has a single use and is over abstracted. Inline it so that
we can improve type hints.
2023-10-10 12:16:36 -04:00
David Robertson
28fd28e92e
Add DB indices to speed up purging rooms ( #16457 )
2023-10-10 10:33:39 +01:00
reivilibre
8902b3031d
Disable statement timeout whilst purging rooms ( #16455 )
...
* Disable statement timeout whilst purging rooms
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Note the introduction version
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-10-09 15:41:17 +01:00
Erik Johnston
a6abee36bc
Don't block CI on sign-off ( #16454 )
...
As this doesn't work with the private sign off flow.
2023-10-09 12:22:54 +01:00
Christoph
32fd9bc673
Fix possible AttributeError when account-api is called over unix socket ( #16404 )
...
Fixes #16396
2023-10-09 10:16:07 +01:00
David Robertson
1f10c20806
Apply join rate limiter outside the lineariser ( #16441 )
2023-10-06 17:31:52 +00:00
Patrick Cloke
06bbf1029c
Convert simple_select_list_paginate_txn to return tuples. ( #16433 )
2023-10-06 11:41:57 -04:00
Patrick Cloke
7615e2bf48
Return ThumbnailInfo in more places ( #16438 )
...
Improves type hints by using concrete types instead of
dictionaries.
2023-10-06 10:12:43 -04:00
Patrick Cloke
cabd577460
Drop unused tables & unneeded access token ID for events. ( #16268 )
...
Drop the event_txn_id table and the tables related to MSC2716,
which is no longer supported in Synapse.
2023-10-06 08:29:33 -04:00
Patrick Cloke
fc31b495b3
Stop sending incorrect knock_state_events. ( #16403 )
...
Synapse was incorrectly implemented with a knock_state_events
property on some APIs (instead of knock_room_state). This was
correct in Synapse 1.70.0, but *both* fields were sent to also be
compatible with Synapse versions expecting the wrong field.
Enough time has passed that only the correct field needs to be
included/handled.
2023-10-06 07:27:35 -04:00
Patrick Cloke
ae5b997cfa
Fix comments related to replication. ( #16428 )
2023-10-06 07:25:44 -04:00
Patrick Cloke
694802eecd
Add documentation on background updates. ( #16420 )
2023-10-06 07:23:20 -04:00
Patrick Cloke
26b960b08b
Register media servlets via regex. ( #16419 )
...
This converts the media servlet URLs in the same way as
(most) of the rest of Synapse. This will give more flexibility
in the versions each endpoint exists under.
2023-10-06 07:22:55 -04:00
V02460
5946074d69
Bump pyo3 from 0.17.1 to 0.19.2 ( #16162 )
...
Signed-off-by: Kai A. Hiller <V02460@gmail.com>
2023-10-06 11:27:59 +01:00
Patrick Cloke
3555790b27
Remove unused method. ( #16435 )
2023-10-05 17:42:44 -04:00
Patrick Cloke
fa907025f4
Remove manys calls to cursor_to_dict ( #16431 )
...
This avoids calling cursor_to_dict and then immediately
unpacking the values in the dict for other users. By not
creating the intermediate dictionary we can avoid allocating
the dictionary and strings for the keys, which should generally
be more performant.
Additionally this improves type hints by avoid Dict[str, Any]
dictionaries coming out of the database layer.
2023-10-05 11:07:38 -04:00
Patrick Cloke
4e302b30b6
Add __slots__ to replication commands. ( #16429 )
...
To slightly reduce the amount of memory each command takes.
2023-10-05 07:38:55 -04:00
Erik Johnston
009b47badf
Factor out MultiWriter token from RoomStreamToken ( #16427 )
2023-10-05 10:46:28 +01:00
Patrick Cloke
ab9c1e8f39
Add type hints to synmark. ( #16421 )
2023-10-04 13:53:04 -04:00
Erik Johnston
80ec81dcc5
Some refactors around receipts stream ( #16426 )
2023-10-04 16:28:40 +01:00
David Robertson
8b50a9d01d
1.94.0rc1
2023-10-03 11:50:57 +01:00
Erik Johnston
1e67191a79
Add note to 'federation_domain_whitelist' option ( #16416 )
2023-10-03 09:55:29 +01:00
Patrick Cloke
127b940dc0
Clean-up old release notes ( #16418 )
...
Fixes some broken formatting from the reStructuedText to Markdown
conversion and fixes some typos.
2023-10-02 11:05:29 -04:00
David Robertson
1026776380
mypy plugin to check @cached return types ( #14911 )
...
Co-authored-by: David Robertson <davidr@element.io>
Co-authored-by: Patrick Cloke <patrickc@matrix.org>
Co-authored-by: Erik Johnston <erik@matrix.org>
Assert that the return type of callables wrapped in @cached
and @cachedList are cachable (aka immutable).
2023-10-02 14:22:36 +00:00
MomentQYC
5725712d47
Remove Python version from /_synapse/admin/v1/server_version ( #16380 )
...
There's no reason to expose the full Python version over what is
frequently a public API.
2023-10-02 09:07:53 -04:00
Erik Johnston
20fb08ec80
Downgrade repl stream time out error to warning ( #16401 )
...
This is because if a worker reaches ~100% CPU then everything starts
lagging and we hit the log line a lot. When at error we invoke sentry
and that has a lot of overhead, which then puts even more pressure on
the worker.
2023-09-29 11:52:48 +00:00
Will Hunt
79eb6c0cdc
Support rendering some media downloads as inline ( #15988 )
...
Use an `inline` Content-Disposition header when the media is
"safe" to display inline (some known text, image, video, audio
formats).
2023-09-29 07:19:38 -04:00
Patrick Cloke
fb664cf159
Remove warnings from the docs about using message retention. ( #16382 )
...
There are no known bugs in the message retention code, but
it is possible that there still exists race conditions. Additional
fixes will be made as reported.
2023-09-28 07:02:31 -04:00
Patrick Cloke
cdb89dcefe
Improve state types. ( #16395 )
2023-09-28 07:01:46 -04:00
Patrick Cloke
c690fd16c4
Use modern config for maturin. ( #16394 )
...
This allows maturin >= 0.15 to build the properly named
shared library object.
For now the old configuration is also kept to allow for
older maturin installs to be used.
2023-09-28 07:01:16 -04:00
Patrick Cloke
f84da3c32e
Add a cache around server ACL checking ( #16360 )
...
* Pre-compiles the server ACLs onto an object per room and
invalidates them when new events come in.
* Converts the server ACL checking into Rust.
2023-09-26 11:57:50 -04:00
Patrick Cloke
17800a0e97
Implement MSC4028: push all encrypted events. ( #16361 )
...
This unstable push rule is implemented behind an experimental
configuration flag.
2023-09-26 11:52:19 -04:00
David Robertson
06f650f5f4
Skip export-data on non-code (e.g. docs) PRs ( #16387 )
2023-09-26 15:21:07 +01:00
Patrick Cloke
ec1c709440
Add documentation about the user directory search algorithm ( #16320 )
2023-09-26 13:44:38 +00:00
Erik Johnston
47ffc7e548
Reduce calls to send_presence_to_destinations ( #16385 )
2023-09-26 11:49:44 +01:00
Patrick Cloke
2763c49eca
Improve comments in StateGroupBackgroundUpdateStore. ( #16383 )
2023-09-25 18:50:47 +00:00
reivilibre
9fd18e9b06
Add developer documentation concerning gradual schema migrations with column alterations. ( #15691 )
...
Co-authored-by: Eric Eastwood <erice@element.io>
2023-09-25 17:43:09 +00:00
reivilibre
525d9d6e11
Avoid running CI steps when the files they check have not been changed. ( #14745 )
2023-09-25 16:59:40 +00:00
dependabot[bot]
b225acf3e6
Bump types-psycopg2 from 2.9.21.11 to 2.9.21.14 ( #16381 )
...
* Bump types-psycopg2 from 2.9.21.11 to 2.9.21.14
Bumps [types-psycopg2](https://github.com/python/typeshed ) from 2.9.21.11 to 2.9.21.14.
- [Commits](https://github.com/python/typeshed/commits )
---
updated-dependencies:
- dependency-name: types-psycopg2
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
* Relax the annotation of Cursor.description
See
https://github.com/matrix-org/synapse/pull/16343#issuecomment-1726083384
for rationale.
* Changelog
* Changelog
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: David Robertson <davidr@element.io>
2023-09-25 17:48:42 +01:00
Maxwell G
12611bfcdd
Add support for pydantic v2 via pydantic.v1 compat module ( #16332 )
...
While maintaining support with pydantic v1.
2023-09-25 15:19:08 +00:00
David Robertson
fad4c63d25
Get CI to check PRs have been signed-off ( #16348 )
2023-09-25 14:45:17 +00:00
Patrick Cloke
c9a0e1673a
Add missing license header. ( #16359 )
2023-09-21 09:47:29 -04:00
Patrick Cloke
7ec0a141b4
Convert more cached return values to immutable types ( #16356 )
2023-09-20 07:48:55 -04:00
Patrick Cloke
d7c89c5908
Return immutable objects for cachedList decorators ( #16350 )
2023-09-19 15:26:44 -04:00
Patrick Cloke
5a66ff2f5c
Merge branch 'release-v1.93' into develop
2023-09-19 10:33:22 -04:00
Patrick Cloke
9fabde6ead
Fix-up deactivated notes in docs. ( #16355 )
2023-09-19 08:05:33 -04:00
Patrick Cloke
9caeb9be10
1.93.0rc1
2023-09-19 07:56:49 -04:00
Jan Christian Grünhage
3d60b07cde
Use string for federation_client_minimum_tls_version documentation examples ( #16353 )
2023-09-19 07:24:47 -04:00
Patrick Cloke
118036eeab
Test against PostgreSQL 16. ( #16351 )
2023-09-18 13:21:00 -04:00
Patrick Cloke
47d4bb6057
Stop patching EventBase.__eq__ in tests. ( #16349 )
...
It is clearer to directly test equality instead of doing indirect
assertions via patching __eq__.
2023-09-18 14:48:02 +00:00
Hanadi
eef2b9e344
Filter locked users in the admin API ( #16328 )
...
Co-authored-by: Hanadi Tamimi <hanadi.tamimi@sdui.de>
2023-09-18 15:37:51 +01:00
Patrick Cloke
c1e244c8f7
Make cached account data/tags/admin types immutable ( #16325 )
2023-09-18 09:55:04 -04:00
Patrick Cloke
85bfd4735e
Return an immutable value from get_latest_event_ids_in_room. ( #16326 )
2023-09-18 09:29:05 -04:00
Patrick Cloke
63d28a88c1
Additional validation of receipts ( #16327 )
...
Reject invalid receipts with a reasonable error message &
expands tests for receipts.
2023-09-18 13:02:12 +00:00
Mathieu Velten
4663d55502
Mandate Pillow>=10.0.1 because of libwebp CVE ( #16347 )
2023-09-18 15:01:23 +02:00
José Joaquín Atria
6946209e67
Set email charset as utf-8 rather than utf8 ( #16329 )
2023-09-18 07:32:01 -04:00
Mathieu Velten
dd44ee00b6
Add automatic purge after all users forget a room ( #15488 )
...
Also add restore of purge/shutdown rooms after a synapse restart.
Co-authored-by: Eric Eastwood <erice@matrix.org>
Co-authored-by: Erik Johnston <erikj@matrix.org>
2023-09-15 15:37:44 +02:00
Jason Little
2a0f86f88f
Convert _insert_graph_receipts_txn to simple_upsert ( #16299 )
2023-09-15 09:16:45 +01:00
Erik Johnston
edec0b93ca
Only use literal strings for process names ( #16315 )
2023-09-15 09:10:24 +01:00
Erik Johnston
329597022e
Some minor performance fixes for task schedular ( #16313 )
2023-09-14 16:20:47 +01:00
Erik Johnston
e9e2904eb2
Speed up deleting to-device messages task ( #16318 )
2023-09-14 14:56:07 +01:00
6543
39dc5de399
docs: Link to the Alpine Linux community package for Synapse ( #16304 )
2023-09-14 14:13:48 +01:00
Erik Johnston
954921736b
Refactor get_user_by_id ( #16316 )
2023-09-14 12:46:30 +01:00
Erik Johnston
032cf84f52
Remove a reference cycle in background process ( #16314 )
2023-09-13 16:17:06 +01:00
Hanadi
7afb5e0410
Fix using dehydrated devices (MSC2697) & refresh tokens ( #16288 )
...
Refresh tokens were not correctly moved to the rehydrated
device (similar to how the access token is currently handled).
This resulted in invalid refresh tokens after rehydration.
2023-09-13 08:33:39 -04:00
Patrick Cloke
d38d0dffc9
Use StrCollection in additional places. ( #16301 )
2023-09-13 07:57:19 -04:00
Erik Johnston
e9addf6a01
Don't schedule an async task on every sync ( #16312 )
2023-09-13 11:59:44 +01:00
Erik Johnston
be3c7b08a3
Fix deleting device inbox when using background worker ( #16311 )
...
Introduced in #16240
The action for the task was only defined on the "master" handler, rather than the base worker one.
2023-09-13 11:54:16 +01:00
Erik Johnston
ab13fb08bf
Improve logging of replication ( #16309 )
2023-09-13 09:51:50 +00:00
Mathieu Velten
12bee2dcc2
Merge branch 'master' into develop
2023-09-12 15:22:26 +02:00
Patrick Cloke
ba48c563c9
Bump mypy from 1.4.1 to 1.5.1. ( #16300 )
2023-09-12 07:16:09 -04:00
Patrick Cloke
16ef6f1e3c
Stop purging tables which are slated for removal. ( #16273 )
2023-09-12 07:12:31 -04:00
Erik Johnston
2b35626b6b
Refactor storing of server keys ( #16261 )
2023-09-12 11:08:04 +01:00
Mathieu Velten
efe778a0b8
1.92.0
2023-09-12 11:59:35 +02:00
Patrick Cloke
9400dc0535
Add the List-Unsubscribe header for notification emails. ( #16274 )
...
Adds both the List-Unsubscribe (RFC2369) and List-Unsubscribe-Post (RFC8058)
headers to push notification emails, which together should:
* Show an "Unsubscribe" link in the MUA UI when viewing Synapse notification emails.
* Enable "one-click" unsubscribe (the user never leaves their MUA, which automatically
makes a POST request to the specified endpoint).
2023-09-11 09:49:48 -04:00
Erik Johnston
151e4bbc45
Filter out down hosts when retrying fetching device lists ( #16298 )
2023-09-11 13:11:02 +01:00
David Robertson
edd83f23b7
Improve type hints for attrs classes ( #16276 )
2023-09-08 19:29:38 +01:00
V02460
a0ed55ef12
Upgrade CI run of Python 3.12 from rc1 to rc2 ( #16280 )
2023-09-08 12:55:43 -04:00
Patrick Cloke
aa483cb4c9
Update ruff config ( #16283 )
...
Enable additional checks & clean-up unneeded configuration.
2023-09-08 11:24:36 -04:00
David Robertson
c1c6c95d72
Log values at DEBUG level with execute_values ( #16281 )
2023-09-08 14:50:13 +01:00
Patrick Cloke
5c8870cb28
Fix-up incorrect spellings in docs. ( #16282 )
2023-09-08 09:47:36 -04:00
Erik Johnston
f43d994624
Fix bug with new task scheduler using lots of CPU. ( #16278 )
...
Using the new `TaskScheduler` meant that we'ed create lots of new
metrics (due to adding task ID to the desc of background process),
resulting in requests for metrics taking an increasing amount of CPU.
2023-09-08 14:43:01 +01:00
Patrick Cloke
69b74d9330
Avoid temporary storage of sensitive information. ( #16272 )
...
During the UI auth process, avoid storing sensitive information
into the database.
2023-09-08 08:57:56 -04:00
V02460
583d5963e6
Raise setuptools_rust version cap to 1.7.0 ( #16277 )
2023-09-08 08:10:26 -04:00
Erik Johnston
d23c394669
Reduce CPU overhead of change password endpoint ( #16264 )
2023-09-08 13:06:00 +01:00
Erik Johnston
1cd410a783
Recheck if remote device is cached before requesting it ( #16252 )
...
This fixes a bug where we could get stuck re-requesting the device over
replication again and again.
2023-09-07 12:45:43 +00:00
Patrick Cloke
7e98d382f9
Support releasing on macOS. ( #16266 )
2023-09-07 07:00:41 -04:00
Erik Johnston
8940d1b28e
Add /notifications endpoint to workers ( #16265 )
2023-09-07 09:26:07 +00:00
Marcel
13e9cad537
Send the opentracing span information to appservices ( #16227 )
2023-09-06 15:19:17 -04:00
Aurélien Grimpard
fe69e7f617
Handle "registration_enabled" parameter for CAS ( #16262 )
...
Similar to OIDC, CAS providers can now disable registration such
that only existing users are able to login via SSO.
2023-09-06 14:32:24 -04:00
Patrick Cloke
32fb264120
Merge remote-tracking branch 'origin/release-v1.92' into develop
2023-09-06 13:08:22 -04:00
Patrick Cloke
fd50a9b47c
Add back newsfile from #16258 .
2023-09-06 13:06:33 -04:00
reivilibre
51303035f2
Apply missed suggestions from the review of #16090 . ( #16263 )
...
* Suggestions from PR
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-09-06 16:15:56 +01:00
reivilibre
35934b02a9
Add GCC and GNU Make to the Nix flake development environment so that ruff can be compiled. ( #16090 )
...
* Add gcc and GNU make to the Nix flake
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* unset LD_LIBRARY_PATH
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-09-06 14:35:02 +01:00
Andrew Morgan
ffe4ea1302
Update rust in flake.nix: 1.70.0 -> 1.71.1 to address CVE-2023-38497 ( #16260 )
2023-09-06 14:34:01 +01:00
reivilibre
e937e2111a
Add the ability to use G (GiB) and T (TiB) suffixes in configuration options that refer to numbers of bytes. ( #16219 )
...
* Add more suffixes to `parse_size`
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-09-06 14:01:10 +01:00
reivilibre
698f6fa250
Allow modules to delete rooms. ( #15997 )
...
* Allow user_id to be optional for room deletion
* Add module API method to delete a room
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Don't worry about the case block=True && requester_user_id is None
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-09-06 11:50:07 +01:00
Mathieu Velten
4f1840a88a
Delete device messages asynchronously and in staged batches ( #16240 )
2023-09-06 09:30:53 +02:00
Will Hunt
1e571cd664
Fix appservices being unable to handle to_device messages for multiple users ( #16251 )
2023-09-05 15:46:57 -04:00
Travis Ralston
b1d71c687a
Add MSC4040 matrix-fed service lookups ( #16137 )
2023-09-05 15:45:39 -04:00
Erik Johnston
c9cec2daed
Fix bug where we kept re-requesting a remote server's key repeatedly. ( #16257 )
...
* Correctly handle multiple rows per server/key
* Newsfile
2023-09-05 20:27:41 +01:00
Patrick Cloke
a2b8814d64
Fix incorrect docstring for Ratelimiter. ( #16255 )
2023-09-05 12:11:05 -04:00
David Robertson
02bc5906ec
- Add configuration setting for CAS protocol version. Contributed by Aurélien Grimpard. ([\#15816]( https://github.com/matrix-org/synapse/issues/15816 ))
...
- Suppress notifications from message edits per [MSC3958](https://github.com/matrix-org/matrix-spec-proposals/pull/3958 ). ([\#16113](https://github.com/matrix-org/synapse/issues/16113 ))
- Return a `Retry-After` with `M_LIMIT_EXCEEDED` error responses. ([\#16136](https://github.com/matrix-org/synapse/issues/16136 ))
- Add `last_seen_ts` to the [admin users API](https://matrix-org.github.io/synapse/latest/admin_api/user_admin_api.html ). ([\#16218](https://github.com/matrix-org/synapse/issues/16218 ))
- Improve resource usage when sending data to a large number of remote hosts that are marked as "down". ([\#16223](https://github.com/matrix-org/synapse/issues/16223 ))
- Fix IPv6-related bugs on SMTP settings, adding groundwork to fix similar issues. Contributed by @evilham and @telmich (ungleich.ch). ([\#16155](https://github.com/matrix-org/synapse/issues/16155 ))
- Fix a spec compliance issue where requests to the `/publicRooms` federation API would specify `include_all_networks` as a string. ([\#16185](https://github.com/matrix-org/synapse/issues/16185 ))
- Fix inaccurate error message while attempting to ban or unban a user with the same or higher PL by spliting the conditional statements. Contributed by @leviosacz. ([\#16205](https://github.com/matrix-org/synapse/issues/16205 ))
- Fix a rare bug that broke looping calls, which could lead to e.g. linearly increasing memory usage. Introduced in v1.90.0. ([\#16210](https://github.com/matrix-org/synapse/issues/16210 ))
- Fix a long-standing bug where uploading images would fail if we could not generate thumbnails for them. ([\#16211](https://github.com/matrix-org/synapse/issues/16211 ))
- Fix a long-standing bug where we did not correctly back off from servers that had "gone" if they returned 4xx series error codes. ([\#16221](https://github.com/matrix-org/synapse/issues/16221 ))
- Update links to the [matrix.org blog](https://matrix.org/blog/ ). ([\#16008](https://github.com/matrix-org/synapse/issues/16008 ))
- Document which [admin APIs](https://matrix-org.github.io/synapse/latest/usage/administration/admin_api/index.html ) are disabled when experimental [MSC3861](https://github.com/matrix-org/matrix-spec-proposals/pull/3861 ) support is enabled. ([\#16168](https://github.com/matrix-org/synapse/issues/16168 ))
- Document [`exclude_rooms_from_sync`](https://matrix-org.github.io/synapse/v1.92/usage/configuration/config_documentation.html#exclude_rooms_from_sync ) configuration option. ([\#16178](https://github.com/matrix-org/synapse/issues/16178 ))
- Prepare unit tests for Python 3.12. ([\#16099](https://github.com/matrix-org/synapse/issues/16099 ))
- Fix nightly CI jobs. ([\#16121](https://github.com/matrix-org/synapse/issues/16121 ), [\#16213](https://github.com/matrix-org/synapse/issues/16213 ))
- Describe which rate limiter was hit in logs. ([\#16135](https://github.com/matrix-org/synapse/issues/16135 ))
- Simplify presence code when using workers. ([\#16170](https://github.com/matrix-org/synapse/issues/16170 ))
- Track per-device information in the presence code. ([\#16171](https://github.com/matrix-org/synapse/issues/16171 ), [\#16172](https://github.com/matrix-org/synapse/issues/16172 ))
- Stop using the `event_txn_id` table. ([\#16175](https://github.com/matrix-org/synapse/issues/16175 ))
- Use `AsyncMock` instead of custom code. ([\#16179](https://github.com/matrix-org/synapse/issues/16179 ), [\#16180](https://github.com/matrix-org/synapse/issues/16180 ))
- Improve error reporting of invalid data passed to `/_matrix/key/v2/query`. ([\#16183](https://github.com/matrix-org/synapse/issues/16183 ))
- Task scheduler: add replication notify for new task to launch ASAP. ([\#16184](https://github.com/matrix-org/synapse/issues/16184 ))
- Improve type hints. ([\#16186](https://github.com/matrix-org/synapse/issues/16186 ), [\#16188](https://github.com/matrix-org/synapse/issues/16188 ), [\#16201](https://github.com/matrix-org/synapse/issues/16201 ))
- Bump black version to 23.7.0. ([\#16187](https://github.com/matrix-org/synapse/issues/16187 ))
- Log the details of background update failures. ([\#16212](https://github.com/matrix-org/synapse/issues/16212 ))
- Cache device resync requests over replication. ([\#16241](https://github.com/matrix-org/synapse/issues/16241 ))
* Bump anyhow from 1.0.72 to 1.0.75. ([\#16141](https://github.com/matrix-org/synapse/issues/16141 ))
* Bump furo from 2023.7.26 to 2023.8.19. ([\#16238](https://github.com/matrix-org/synapse/issues/16238 ))
* Bump phonenumbers from 8.13.18 to 8.13.19. ([\#16237](https://github.com/matrix-org/synapse/issues/16237 ))
* Bump psycopg2 from 2.9.6 to 2.9.7. ([\#16196](https://github.com/matrix-org/synapse/issues/16196 ))
* Bump regex from 1.9.3 to 1.9.4. ([\#16195](https://github.com/matrix-org/synapse/issues/16195 ))
* Bump ruff from 0.0.277 to 0.0.286. ([\#16198](https://github.com/matrix-org/synapse/issues/16198 ))
* Bump sentry-sdk from 1.29.2 to 1.30.0. ([\#16236](https://github.com/matrix-org/synapse/issues/16236 ))
* Bump serde from 1.0.184 to 1.0.188. ([\#16194](https://github.com/matrix-org/synapse/issues/16194 ))
* Bump serde_json from 1.0.104 to 1.0.105. ([\#16140](https://github.com/matrix-org/synapse/issues/16140 ))
* Bump types-psycopg2 from 2.9.21.10 to 2.9.21.11. ([\#16200](https://github.com/matrix-org/synapse/issues/16200 ))
* Bump types-pyyaml from 6.0.12.10 to 6.0.12.11. ([\#16199](https://github.com/matrix-org/synapse/issues/16199 ))
-----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmT3RFIACgkQkD7OEIo5
3t1gGA/9HQwV3vNgZkQj9Y0TVEj/ECoASSOvaTWbsXmoyctEqUOF7yoin+e6rZdB
b5hrCMN8dGGny/Nqb7hF2/Zcz+zHOhNOshEE7VDnt2dLZY3MaaF7SOFVnfM6KDz5
UyKkSbvhO2wgZIu8YebxW9C7a3EUnI8ocnb2PsyNNCPYtOVdZ7h+JeV9T2OS78rG
dw/hFNBG8jQYwbbpaFtdCjDCaz67/GB9LnWcXwbE6kJr5lJ903uH0NPLdrdITsrH
wvvw1vQHFZtzuAjfnKA/dz42H1h/s3ogxBMQxS0rVdxvFDIJiLUpWyDdPxjixzRS
w96Pw4+hTlposAZT1qWRf0n263M5BZpoEQuZ/C4q088FrLubuaummW2IfMWx8ono
y556CLRg+yjv2MmGeYYabcSxj1OPc/FV3w73tbxrVjKP7x2fnfGqTJeDhIqXh2wj
DphMFBVHmvUEJv6TRfPV/V/ocoN3Tg1vXCPiY3JGcU9ihtHAjL0F9Af03nMKg594
ZQc/xbroEFln11Ip+q9LYxP8q0ptKZph/Fo10WaeYSLII2WO0dC+mP+QvDfQle3N
ftXJm+Utk/cg73gSYNqex4EmHkGAB0np8YjpA41mdVNcJlXGQ3WQn0FgqX7JZ1jQ
lc0YtGm8jqp045tU2WAcacOg8/udTL+UkbDSdkhzq3KRXbB5bE8=
=K4NS
-----END PGP SIGNATURE-----
gpgsig -----BEGIN PGP SIGNATURE-----
iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmT3T8IACgkQkD7OEIo5
3t3hyhAAoTswFfnZxfee5fk458OIe05KdpQ/oYSv+5iKeqe3SGrPPgPD58gGi6+c
vUccRAB7frZIdzjGnTuN98WMn2ll7LPvn1tHzRIQM78qoIwAyJrpe40BL5HQR6Iy
3weNug9ae2NGOqNaO816aDFOHvkE0lNDpU9fE4iZcyxs5b7kyD8CTmNv1DrRRtPV
DOcCqtRgSMZXC7aVI4c8f7q4WdzfjWSLrieeDaHwVBFPAm1jcg3WiWauFpCYScHg
sPq0D0zeRdkaNNw8+B4B6WOePL1lm31RRsjmxqf3+bgfyzEB8DzJw8JEv02BnkTi
yNzJKAouBahjgXEcGXmfm5APBbu1eW4hkHeZPWkM1aHHNnQ3MdRPGHt0Nb+cmsxO
AEu6GiFY2w14y6DwATXGpOpzlKHmYfdsncjpC17f35aqt94LnSXH39tt1idYABbI
uC4sfStXFN+bURYUbsIDTGXbe1/yjaTNGR0Cq8GvqWDWQGN2fy2z9dhgZzvr7SEL
3TRHtUOcuCHVBv/FxCl3jjWNFgDveemSVDqvBmtbvNjGaIP2jSpJD9tJTRWk+m3n
7c0T8UiryfAsgkme3cwjfnvIHaPRevLNqImNlQnJS42xjQaplx67aP4HZ1P3JiBU
lSC+JhKQ7TOxajFlmrB3LUkFaRpYt7i3ZCFvRZACWkDPxh285r8=
=WqeW
-----END PGP SIGNATURE-----
Merge tag 'v1.92.0rc1' into develop
- Add configuration setting for CAS protocol version. Contributed by Aurélien Grimpard. ([\#15816](https://github.com/matrix-org/synapse/issues/15816 ))
- Suppress notifications from message edits per [MSC3958](https://github.com/matrix-org/matrix-spec-proposals/pull/3958 ). ([\#16113](https://github.com/matrix-org/synapse/issues/16113 ))
- Return a `Retry-After` with `M_LIMIT_EXCEEDED` error responses. ([\#16136](https://github.com/matrix-org/synapse/issues/16136 ))
- Add `last_seen_ts` to the [admin users API](https://matrix-org.github.io/synapse/latest/admin_api/user_admin_api.html ). ([\#16218](https://github.com/matrix-org/synapse/issues/16218 ))
- Improve resource usage when sending data to a large number of remote hosts that are marked as "down". ([\#16223](https://github.com/matrix-org/synapse/issues/16223 ))
- Fix IPv6-related bugs on SMTP settings, adding groundwork to fix similar issues. Contributed by @evilham and @telmich (ungleich.ch). ([\#16155](https://github.com/matrix-org/synapse/issues/16155 ))
- Fix a spec compliance issue where requests to the `/publicRooms` federation API would specify `include_all_networks` as a string. ([\#16185](https://github.com/matrix-org/synapse/issues/16185 ))
- Fix inaccurate error message while attempting to ban or unban a user with the same or higher PL by spliting the conditional statements. Contributed by @leviosacz. ([\#16205](https://github.com/matrix-org/synapse/issues/16205 ))
- Fix a rare bug that broke looping calls, which could lead to e.g. linearly increasing memory usage. Introduced in v1.90.0. ([\#16210](https://github.com/matrix-org/synapse/issues/16210 ))
- Fix a long-standing bug where uploading images would fail if we could not generate thumbnails for them. ([\#16211](https://github.com/matrix-org/synapse/issues/16211 ))
- Fix a long-standing bug where we did not correctly back off from servers that had "gone" if they returned 4xx series error codes. ([\#16221](https://github.com/matrix-org/synapse/issues/16221 ))
- Update links to the [matrix.org blog](https://matrix.org/blog/ ). ([\#16008](https://github.com/matrix-org/synapse/issues/16008 ))
- Document which [admin APIs](https://matrix-org.github.io/synapse/latest/usage/administration/admin_api/index.html ) are disabled when experimental [MSC3861](https://github.com/matrix-org/matrix-spec-proposals/pull/3861 ) support is enabled. ([\#16168](https://github.com/matrix-org/synapse/issues/16168 ))
- Document [`exclude_rooms_from_sync`](https://matrix-org.github.io/synapse/v1.92/usage/configuration/config_documentation.html#exclude_rooms_from_sync ) configuration option. ([\#16178](https://github.com/matrix-org/synapse/issues/16178 ))
- Prepare unit tests for Python 3.12. ([\#16099](https://github.com/matrix-org/synapse/issues/16099 ))
- Fix nightly CI jobs. ([\#16121](https://github.com/matrix-org/synapse/issues/16121 ), [\#16213](https://github.com/matrix-org/synapse/issues/16213 ))
- Describe which rate limiter was hit in logs. ([\#16135](https://github.com/matrix-org/synapse/issues/16135 ))
- Simplify presence code when using workers. ([\#16170](https://github.com/matrix-org/synapse/issues/16170 ))
- Track per-device information in the presence code. ([\#16171](https://github.com/matrix-org/synapse/issues/16171 ), [\#16172](https://github.com/matrix-org/synapse/issues/16172 ))
- Stop using the `event_txn_id` table. ([\#16175](https://github.com/matrix-org/synapse/issues/16175 ))
- Use `AsyncMock` instead of custom code. ([\#16179](https://github.com/matrix-org/synapse/issues/16179 ), [\#16180](https://github.com/matrix-org/synapse/issues/16180 ))
- Improve error reporting of invalid data passed to `/_matrix/key/v2/query`. ([\#16183](https://github.com/matrix-org/synapse/issues/16183 ))
- Task scheduler: add replication notify for new task to launch ASAP. ([\#16184](https://github.com/matrix-org/synapse/issues/16184 ))
- Improve type hints. ([\#16186](https://github.com/matrix-org/synapse/issues/16186 ), [\#16188](https://github.com/matrix-org/synapse/issues/16188 ), [\#16201](https://github.com/matrix-org/synapse/issues/16201 ))
- Bump black version to 23.7.0. ([\#16187](https://github.com/matrix-org/synapse/issues/16187 ))
- Log the details of background update failures. ([\#16212](https://github.com/matrix-org/synapse/issues/16212 ))
- Cache device resync requests over replication. ([\#16241](https://github.com/matrix-org/synapse/issues/16241 ))
* Bump anyhow from 1.0.72 to 1.0.75. ([\#16141](https://github.com/matrix-org/synapse/issues/16141 ))
* Bump furo from 2023.7.26 to 2023.8.19. ([\#16238](https://github.com/matrix-org/synapse/issues/16238 ))
* Bump phonenumbers from 8.13.18 to 8.13.19. ([\#16237](https://github.com/matrix-org/synapse/issues/16237 ))
* Bump psycopg2 from 2.9.6 to 2.9.7. ([\#16196](https://github.com/matrix-org/synapse/issues/16196 ))
* Bump regex from 1.9.3 to 1.9.4. ([\#16195](https://github.com/matrix-org/synapse/issues/16195 ))
* Bump ruff from 0.0.277 to 0.0.286. ([\#16198](https://github.com/matrix-org/synapse/issues/16198 ))
* Bump sentry-sdk from 1.29.2 to 1.30.0. ([\#16236](https://github.com/matrix-org/synapse/issues/16236 ))
* Bump serde from 1.0.184 to 1.0.188. ([\#16194](https://github.com/matrix-org/synapse/issues/16194 ))
* Bump serde_json from 1.0.104 to 1.0.105. ([\#16140](https://github.com/matrix-org/synapse/issues/16140 ))
* Bump types-psycopg2 from 2.9.21.10 to 2.9.21.11. ([\#16200](https://github.com/matrix-org/synapse/issues/16200 ))
* Bump types-pyyaml from 6.0.12.10 to 6.0.12.11. ([\#16199](https://github.com/matrix-org/synapse/issues/16199 ))
2023-09-05 16:56:43 +01:00
Patrick Cloke
8b5013dcbc
Time out busy presence status & test multi-device busy ( #16174 )
...
Add a (long) timeout to when a "busy" device is considered not online.
This does *not* match MSC3026, but is a reasonable thing for an
implementation to do.
Expands tests for the (unstable) busy presence with multiple devices.
2023-09-05 10:39:38 -04:00
Patrick Cloke
ea75346f6a
Track presence state per-device and combine to a user state. ( #16066 )
...
Tracks presence on an individual per-device basis and combine
the per-device state into a per-user state. This should help in
situations where a user has multiple devices with conflicting status
(e.g. one is syncing with unavailable and one is syncing with online).
The tie-breaking is done by priority:
BUSY > ONLINE > UNAVAILABLE > OFFLINE
2023-09-05 09:58:51 -04:00
Erik Johnston
dfcfa9f0ed
Bump minimum supported Rust version to 1.61.0 ( #16248 )
2023-09-05 13:12:50 +01:00
dependabot[bot]
757010905e
Bump twisted from 22.10.0 to 23.8.0 ( #16235 )
...
* Bump twisted from 22.10.0 to 23.8.0
Bumps [twisted](https://github.com/twisted/twisted ) from 22.10.0 to 23.8.0.
- [Release notes](https://github.com/twisted/twisted/releases )
- [Changelog](https://github.com/twisted/twisted/blob/trunk/NEWS.rst )
- [Commits](https://github.com/twisted/twisted/compare/twisted-22.10.0...twisted-23.8.0 )
---
updated-dependencies:
- dependency-name: twisted
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
* Fix types
* Fix lint
* Newsfile
---------
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Erik Johnston <erik@matrix.org>
2023-09-05 11:14:14 +00:00
David Robertson
0425dd28f4
1.92.0rc1
2023-09-05 11:21:54 +01:00
Erik Johnston
d35bed8369
Don't wake up destination transaction queue if they're not due for retry. ( #16223 )
2023-09-04 17:14:09 +01:00
Mathieu Velten
dcb2778341
Add last_seen_ts to the admin users API ( #16218 )
2023-09-04 18:13:28 +02:00
Erik Johnston
f84baecb6f
Don't reset retry timers on "valid" error codes ( #16221 )
2023-09-04 14:04:43 +01:00
David Robertson
e9eb26e3af
Cache device resync requests over replication ( #16241 )
2023-09-04 11:57:59 +01:00
Erik Johnston
93f2fdd8d1
Fix typo where we ended up with multiple WorkerLocksHandler ( #16220 )
...
I don't think has caused any actual issues.
Introduced in #15891
2023-09-01 12:52:57 +00:00
David Robertson
6525fd65ee
Log the details of background update failures ( #16212 )
2023-09-01 12:41:56 +01:00
David Robertson
ed5e8a77ca
Ignore redundant casts in latest deps CI job ( #16213 )
2023-08-30 22:55:47 +01:00
Erik Johnston
3de82bb2af
Gracefully handle failing to thumbnail images ( #16211 )
2023-08-30 15:18:34 +01:00
Erik Johnston
a2e0d4cd60
Fix rare bug that broke looping calls ( #16210 )
...
* Fix rare bug that broke looping calls
We can't interact with the reactor from the main thread via looping
call.
Introduced in v1.90.0 / #15791 .
* Newsfile
2023-08-30 14:18:42 +01:00
Patrick Cloke
ebd8374fb5
Stop writing to the event_txn_id table ( #16175 )
2023-08-30 11:10:56 +01:00
David Robertson
62a1a9be52
Describe which rate limiter was hit in logs ( #16135 )
2023-08-30 00:39:39 +01:00
Patrick Cloke
e9235d92f2
Track currently syncing users by device for presence ( #16172 )
...
Refactoring to use both the user ID & the device ID when tracking
the currently syncing users in the presence handler.
This is done both locally and over replication. Note that the device
ID is discarded but will be used in a future change.
2023-08-29 11:44:07 -04:00
Patrick Cloke
9ec3da06da
Bump mypy-zope & mypy. ( #16188 )
2023-08-29 10:38:56 -04:00
Evilham
63b51ef3fb
Support IPv6-only SMTP servers ( #16155 )
...
Use Twisted HostnameEndpoint to connect to SMTP servers (instead
of connectTCP/connectSSL) which properly supports IPv6-only servers.
2023-08-29 09:33:58 -04:00
Patrick Cloke
2d72367367
Update black & fix the targeted Python versions. ( #16187 )
...
Black should target Python 3.8 to 3.11.
2023-08-29 08:34:53 -04:00
Chen Zhang
692ee2af19
Fix inaccurate error message while trying to ban or unban a user with the same or higher PL ( #16205 )
2023-08-29 10:37:09 +01:00
Patrick Cloke
40901af5e0
Pass the device ID around in the presence handler ( #16171 )
...
Refactoring to pass the device ID (in addition to the user ID) through
the presence handler (specifically the `user_syncing`, `set_state`,
and `bump_presence_active_time` methods and their replication
versions).
2023-08-28 13:08:49 -04:00
Patrick Cloke
1bf143699c
Combine logic about not overriding BUSY presence. ( #16170 )
...
Simplify some of the presence code by reducing duplicated code between
worker & non-worker modes.
The main change is to push some of the logic from `user_syncing` into
`set_state`. This is done by passing whether the user is setting the presence
via a `/sync` with a new `is_sync` flag to `set_state`. If this is `true` some
additional logic is performed:
* Don't override `busy` presence.
* Update the `last_user_sync_ts`.
* Never update the status message.
2023-08-28 11:03:23 -04:00
Mathieu Velten
501da8ecd8
Task scheduler: add replication notify for new task to launch ASAP ( #16184 )
2023-08-28 14:03:51 +00:00
Patrick Cloke
4379d3ef63
Bump setuptools-rust from 1.6.0 to 1.7.0. ( #16201 )
2023-08-28 09:04:15 -04:00
V02460
84f441f88f
Prepare unit tests for Python 3.12 ( #16099 )
2023-08-25 15:05:10 -04:00
Patrick Cloke
ed6de4b2d4
service-identity, incremental, and setuptools-rust now have type hints. ( #16186 )
2023-08-25 14:10:47 -04:00
Patrick Cloke
82699428e3
Validate input to POST /key/v2/query endpoint. ( #16183 )
...
To avoid 500 internal server errors with garbage input.
2023-08-25 14:10:31 -04:00
Patrick Cloke
fcf7a5759e
Send proper JSON POST data to /publicRooms ( #16185 )
...
The include_all_networks was previously sent in the JSON body as
string "true" and "false" instead of boolean true and false.
2023-08-25 12:11:40 -04:00
Patrick Cloke
a8a46b1336
Replace simple_async_mock with AsyncMock ( #16180 )
...
Python 3.8 has a native AsyncMock, use it instead of a custom
implementation.
2023-08-25 09:27:21 -04:00
Will Hunt
5c9402b9fd
Add warnings about MSC3861 on certain APIs. ( #16168 )
2023-08-25 07:25:34 -04:00
Patrick Cloke
daf11e26ef
Replace make_awaitable with AsyncMock ( #16179 )
...
Python 3.8 provides a native AsyncMock, we can replace the
homegrown version we have.
2023-08-24 19:38:46 -04:00
Shay
5856a8ba42
Document exclude_rooms_fom_sync configuration option ( #16178 )
2023-08-24 13:57:53 -07:00
Aurélien Grimpard
aeeca2a62e
Add configuration setting for CAS protocol version ( #15816 )
2023-08-24 16:11:23 -04:00
Amirreza Aflakparast
5427cc20b9
Update URLs to matrix.org blog categories. ( #16008 )
2023-08-24 11:06:06 -04:00
David Robertson
e691243e19
Fix typechecking with twisted trunk ( #16121 )
2023-08-24 14:53:07 +00:00
Will Hunt
0538e3e2db
Add Retry-After to M_LIMIT_EXCEEDED error responses ( #16136 )
...
Implements MSC4041 behind an experimental configuration flag.
2023-08-24 10:40:26 -04:00
H. Shay
851cbdcb57
Merge branch 'release-v1.91' into develop
2023-08-23 11:44:01 -07:00
Patrick Cloke
33fa82a34c
Stabilize support for MSC3958 (suppress notifications from edits). ( #16113 )
2023-08-23 13:22:34 -04:00
H. Shay
23f88f9c59
1.91.0rc1
2023-08-23 09:47:29 -07:00
Erik Johnston
18279631e9
Fix rare deadlock when using read/write locks ( #16169 )
2023-08-23 16:24:30 +01:00
Andrew Morgan
85118420a2
Switch devenv dependency in the nix development environment to the latest release (instead of the development branch) ( #16063 )
2023-08-23 16:16:14 +01:00
Neil Johnson
ec662bbe41
Filter out unwanted user_agents from udv. ( #16124 )
2023-08-23 14:00:34 +01:00
Erik Johnston
4adaba9acf
Fix rare deadlock when using read/write locks ( #16133 )
2023-08-23 13:45:25 +01:00
Erik Johnston
7cd79ce051
Reduce DB contention on worker locks ( #16160 )
2023-08-23 13:45:19 +01:00
Erik Johnston
86ecd341ec
Always update retry_last_ts ( #16164 )
2023-08-23 13:04:46 +01:00
Mathieu Velten
873971a8b9
Task scheduler: mark task as active if we are scheduling ASAP ( #16165 )
2023-08-23 13:37:51 +02:00
Patrick Cloke
da162cbe4e
Add tests for restoring the presence state after a restart. ( #16151 )
2023-08-23 07:31:00 -04:00
DeepBlueV7.X
19a1cda084
Properly update retry_last_ts when hitting the maximum retry interval ( #16156 )
...
* Properly update retry_last_ts when hitting the maximum retry interval
This was broken in 1.87 when the maximum retry interval got changed from
almost infinite to a week (and made configurable).
fixes #16101
Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
* Add changelog
* Change fix + add test
* Add comment
---------
Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>
Co-authored-by: Mathieu Velten <mathieuv@matrix.org>
2023-08-23 09:35:23 +01:00
Erik Johnston
dffe095642
Only lock when we're backfilling ( #16159 )
2023-08-23 09:23:41 +01:00
Erik Johnston
3b3fed7229
Increase perf of read/write locks ( #16149 )
...
We do this by marking the tables as `UNLOGGED` in PostgreSQL.
2023-08-23 09:23:22 +01:00
Patrick Cloke
3f17178728
Clean-up presence tests ( #16158 )
...
Reduce duplicated code & remove unused variables.
2023-08-22 11:43:44 -04:00
Erik Johnston
803f63df1c
Fix perf of wait_for_stream_positions ( #16148 )
2023-08-22 15:11:22 +00:00
Mathieu Velten
0ba17777be
Disable m.3pid_changes capability when MSC3861 is enabled. ( #16134 )
2023-08-22 14:47:59 +00:00
Shay
69048f7b48
Add an admin endpoint to allow authorizing server to signal token revocations ( #16125 )
2023-08-22 14:15:34 +00:00
Patrick Cloke
b657e89005
Fix user directory test for deactivated support user. ( #16157 )
...
Support users should not be added to the user directory after
being deactivated.
2023-08-22 09:08:24 -04:00
Theodore Ni
bc72d803d5
Raise poetry-core version cap to 1.7.0 ( #16152 )
2023-08-22 13:51:35 +01:00
Patrick Cloke
6d7c63fcc6
Properly call setup_background_tasks in unit tests. ( #16150 )
...
This should only be called on HomeServer objects which are configured
to run background tasks, which is automatically (and properly) done via
the call to setup().
2023-08-22 07:46:32 -04:00
Hugh Nimmo-Smith
7dbac123f9
Disallow user_consent where experimental MSC3861 is enabled ( #16127 )
2023-08-22 07:42:08 -04:00
Maximilian Bosch
d6ae4041a4
Add client_secret_path as alternative for client_secret for OIDC config ( #16030 )
2023-08-21 19:32:17 +00:00
Mathieu Velten
358896e1b8
Implements a task scheduler for resumable potentially long running tasks ( #15891 )
2023-08-21 14:17:13 +02:00
Erik Johnston
bd558a6dc3
Speed up state res in rare case we don't have all events ( #16116 )
...
If we don't have all the auth events in a room then not all state events will have a chain cover index. Even so, we can still use the chain cover index on the events that do have it, rather than bailing and using the slower functions.
This situation should not arise for newly persisted rooms, as we check we have the full auth chain for each event, but can happen for existing rooms.
c.f. #15245
2023-08-18 15:32:06 +01:00
Mathieu Velten
2d15e39684
MSC3861: allow impersonation by an admin using a query param ( #16132 )
2023-08-18 15:46:46 +02:00
Alexander Fechler
54317d34b7
Allow filtering for admins in the list accounts admin API ( #16114 )
2023-08-18 12:26:38 +01:00
Erik Johnston
6130afb862
Add response time metrics for introspection requests ( #16131 )
...
See #16119
2023-08-18 12:16:00 +01:00
Erik Johnston
0aba4a4eaa
Add cache to get_server_keys_json_for_remote ( #16123 )
2023-08-18 11:05:01 +01:00
Shay
54a51ff6c1
Cache token introspection response from OIDC provider ( #16117 )
2023-08-17 10:53:10 -07:00
Erik Johnston
eb0dbab15b
Fix database performance of read/write worker locks ( #16061 )
...
We were seeing serialization errors when taking out multiple read locks.
The transactions were retried, so isn't causing any failures.
Introduced in #15782 .
2023-08-17 14:07:57 +01:00
Shay
0377cb4fab
Override global statement timeout when creating indexes in Postgres ( #16085 )
2023-08-17 10:30:02 +01:00
Matthew Ma
8a4fb7a6ba
Disable caching in /sync corner case ( #16080 )
...
Fixes #15502
2023-08-17 10:22:50 +01:00
Mathieu Velten
8c3bcea2da
Rename pagination&purge locks and add comments explaining them ( #16112 )
2023-08-16 16:19:54 +02:00
axel simon
4513b36a75
Add link explaining ELK stack to structured_logging.md ( #16091 )
2023-08-16 14:08:35 +01:00
David Robertson
47c629bb27
Attempt to fix twisted trunk ( #16115 )
2023-08-15 16:07:13 +00:00
Patrick Cloke
ad3f43be9a
Run pyupgrade for python 3.7 & 3.8. ( #16110 )
2023-08-15 08:11:20 -04:00
Gabriel Rodríguez
9ff84bccbb
Allow customizing IdP name and icon for SAML and CAS ( #16094 )
2023-08-11 20:15:17 +00:00
Nick Mills-Barrett
614efc488b
Add linearizer on user ID to push rule PUT/DELETE requests ( #16052 )
...
See: #16053
Signed off by Nick @ Beeper (@Fizzadar)
2023-08-11 11:37:09 +00:00
reivilibre
7f4b413690
Fix the type annotation on run_db_interaction in the Module API. ( #16089 )
...
* Fix the method signature of `run_db_interaction` on the module API
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-08-10 18:28:31 +01:00
Patrick Cloke
efd4d06d76
Clean-up presence code ( #16092 )
...
Misc. clean-ups to:
* Use keyword arguments.
* Return early (reducing indentation) of some functions.
* Removing duplicated / unused code.
* Use wrap_as_background_process.
2023-08-10 07:39:46 -04:00
Mathieu Velten
dac97642e4
Implements admin API to lock an user (MSC3939) ( #15870 )
2023-08-10 09:10:55 +00:00
Shay
0328b56468
Support MSC3814: Dehydrated Devices Part 2 ( #16010 )
2023-08-08 12:04:46 -07:00
Erik Johnston
8e09b8aecb
1.90.0rc1
2023-08-08 15:29:44 +01:00
reivilibre
a476d5048b
Allow modules to schedule delayed background calls. ( #15993 )
...
* Add a module API function to provide `call_later`
* Newsfile
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
* Add comments
* Update version number
---------
Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
2023-08-08 11:53:49 +01:00
