Commit graph

42255 commits

Author SHA1 Message Date
Matt Clay
35caebd036 Fix ansible-test dependency processing.
Previously, the following dependencies:

A used by B
B used by C

Would have been converted to:

A used by C
B used by C

Intead of being expanded to:

A used by B
A used by C
B used by C

This change preserves the existing dependency when expanding it.
2019-01-14 15:31:59 -08:00
Jordan Borean
2fcc3593cc
ansible-test setup_dep_repo trust package repo (#50795) 2019-01-15 09:02:32 +10:00
Bojan Vitnik
a69e9e3470 Updated test constraints for mock assert_called() and assert_called_once() 2019-01-14 14:17:01 -08:00
Jonas Schäfer
afb48414b6 jabber: Fix joining group chats (#50846)
The previous code was using the legacy Group Chat 1.0 (GC1.0)
protocol to join [XEP-0045 Multi User Chats][1]. The legacy
protocol is described in § 7.2.1 of that document, the current
protocol is described in § 7.2.2.

The legacy protocol has not been in active use for more than ten
years, and servers are fading out support for it because its
presence causes issues (see for example the lengthy discussion
in [2], particularly the part starting with "A MUC
misunderstanding a presence update for a GC1.0 join").

The effect of servers fading out GC1.0 is that jabber.py cannot
send messages to rooms on servers which have done that step any
more.

This commit implements the modern join protocol, restoring
functionality. The modern join protocol is, to my knowledge,
supported by all XMPP servers which are still in use.

Prosody 0.11 is an example of a server implementation which does
not support GC1.0 anymore.

   [1]: https://xmpp.org/extensions/xep-0045.html
   [2]: https://mail.jabber.org/pipermail/standards/2017-October/033501.html
2019-01-14 22:30:48 +01:00
Matt Clay
465df0ef8d
Fix encoding issues with file paths. (#50830)
* Fix encoding issues with file paths.

Discovered while testing with ANSIBLE_CONFIG env var set to a path
that contained unicode characters while LC_ALL=C.

* Fix unit tests.

* Fix another path encoding issue.
2019-01-14 13:06:47 -08:00
Matt Clay
15b1a31aa8 Use different test package in pip test.
This avoids conflicts with other tests such as firewalld,
which use the decorator package installed using OS packages.
2019-01-14 13:02:51 -08:00
Strahinja Kustudic
eb8294e6d9 Fix create home dir fallback (#49262)
When a user home dir is not created with `useradd`, the home dir will now
be created with umask from /etc/login.defs. Also fixed a bug in which
after a local user is deleted, and the same user exists in the central
user management system, the module would create that user's home.
2019-01-14 16:01:26 -05:00
Jacob Olsen
37960ccc87 check for chroot in systemd module (#43904)
* check for result['status'] in systemd module

* instead of checking for result['state'], actually check for chroot and warn

* allow systemctl status to work if in a chroot, update warn text

* simply change warning message
2019-01-14 15:45:05 -05:00
Manuel Molina Cuberos
3b5ac77a16 Preventing '/dev/tty not found' problems (#49950)
* Preventing '/dev/tty not found' problems when ' apt_repository` calls GPG in order to import keys.
2019-01-14 15:38:54 -05:00
Jordan Borean
91522bd9c4
test subversion - support Ubuntu 18.04 (#50791) 2019-01-15 06:26:16 +10:00
Sumit Jaiswal
3f70518257
Support for NIOS modules to use environment variables in provider (#49056)
* env var username/paswd support

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* including all env vars of nios doc

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fixing default wapi version in doc-s

* fixing review comment

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* review statement fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-01-14 23:25:24 +05:30
Felix Fontein
bbd2e31e9f Revert "openssl_csr: Allow to use cryptography as backend (#50324)"
This reverts commit 409f8a15bd.
2019-01-14 09:10:38 -08:00
Karsten Jakobsen
53437e80d9 VMware: New module vmware_drs_group_facts (#50649)
* Added new vmware module for gathering facts for DRS groups
* Update lib/ansible/modules/cloud/vmware/vmware_drs_group_facts.py
* Updated doc
* Fixed integration test with mutual exclusive paramteres

Co-Authored-By: karstenjakobsen <karsten@karstenjakobsen.dk>
2019-01-14 21:56:12 +05:30
Karsten Jakobsen
8fa01a22a1 VMware: New module vmware_drs_group (#50650)
* Added new vmware module for creating DRS VM or Host groups in a given cluster
* Fixed typo in module name
* Added better docstrings. Fixed better messaging for existing groups. Added delete example.
* Update doc
* Update lib/ansible/modules/cloud/vmware/vmware_drs_group.py
* Updated logic, so result is populated with correct data even if no changes are made
* Update lib/ansible/modules/cloud/vmware/vmware_drs_group.py
* Improved performance by getting group_obj in init()
* Fixed syntax error and added group_name as required if state is
* Added state= to integration test

Co-Authored-By: karstenjakobsen <karsten@karstenjakobsen.dk>
2019-01-14 21:55:26 +05:30
Abhijeet Kasurde
85dd0a7e74
VMware: vcenter_license fixes (#50794)
* Updated document fragment
* Used PyVmomi Helper class
* Added check for vcenter server

Fixes: #50752

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-01-14 21:50:21 +05:30
Felix Fontein
8dfdd9abf3 Move changelog fragment to correct place. (#50869) 2019-01-14 10:10:19 -05:00
Pilou
f981d3c523 Giving felixfontein supershipit on docker stuff (#50878) 2019-01-14 10:01:03 -05:00
Felix Fontein
409f8a15bd openssl_csr: Allow to use cryptography as backend (#50324)
* Allow to use cryptography as backend for openssl_csr.

* Use different curve.

* Adding changelog.

Includes changelog fragment for #49416, which didn't include one.
2019-01-14 13:33:51 +00:00
Hannes Ljungberg
644057e9ec docker_swarm_service: Documentation fixes (#50861)
* Describe labels and container_labels correctly

* Clarify reserve_memory and limit_memory docs

* Remove default from container_labels doc

* Remove trailing whitespace

* Document min api version for configs and secrets

* Add changelog fragment

* Specify type on labels and container_labels

* Consolidate required API version descriptions

* Update reserve and limit memory docs

* Use correct power-of-two units

* Remove description about limit_memory minimum 4mb
2019-01-14 13:32:03 +00:00
Ricardo Carrillo Cruz
d28bf14c67
Fix checkpoint access rule facts example (#50870) 2019-01-14 13:57:37 +01:00
rnsc
226ba90619 azure_rm_virtualmachine - adding support for StandardSSD_LRS (#46676)
StandardSSD_LRS have been introduced (generally available) in June 2018.
This change will add support for this.
2019-01-14 11:29:38 +00:00
Ricardo Carrillo Cruz
18370419a3
Add forgotten checkpoint unit tests (#50858)
I forgot to do a git add on a couple unit tests it seems
2019-01-14 12:07:48 +01:00
Marcin
e7b91f331b fix use_proxy option in icinga2_host (#47671) 2019-01-14 12:03:36 +01:00
Rich Wareham
fd32760d7a docker_swarm_service: use exact name match when finding services (#50665)
* docker_swarm_service: use exact name match when finding services

The Docker API's filtering support allows filtering for substring
matches which means that when we filter the list of running services we
may accidentally match a service called "foobar" when looking for a
service named "foo".

Fix this by filtering the list of services returned from the Docker API
so that name matches are exact. It is still worth passing the filter
parameter to the Docker API because it reduces the number of results
passed back which may be important for remote Docker connections.

Closes 50654.

* add changelog fragment for #50654
2019-01-14 12:00:34 +01:00
Hannes Ljungberg
cde292cc43 docker_swarm_service: Don’t add difference when update_order is None (#50655)
* Don’t add difference when update_order is None

* Add changelog fragment
2019-01-14 11:58:05 +01:00
Trishna Guha
fc0f20a35e
Add missing parameters in get_config vyos (#50855)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-01-14 15:13:43 +05:30
abirami-n
6c47594388 Fix_facts (#50597) 2019-01-14 14:23:11 +05:30
abirami-n
063c2f9d59 fix_dellos6_config (#50599) 2019-01-14 14:05:34 +05:30
Yuwei Zhou
eaf9da4dff Support curated return value for network interface and refine test (#50482) 2019-01-14 14:17:31 +08:00
Diane Wang
955e960f45 VMware: add new module vmware_guest_video (#50590) 2019-01-12 11:37:14 +05:30
Matt Clay
d59bc9ae48 Move unrelated connection test to separate target. 2019-01-11 15:27:06 -08:00
branen
88029a73d6 Correct docsite typos: it's -> its (#50812) 2019-01-11 15:49:54 -05:00
Felix Fontein
0e7a9a2771 docker_volume: revert #47390 (#50663)
* Revert "Fix option change detection / force support for docker_volume. (#47390)"

This reverts commit 8ef994fbc5.

* Update changelog.

* Adjusting tests.
2019-01-11 14:41:37 -06:00
Matt Clay
fd56788a14 Fix dpkg_selections integration test.
Download package from S3 since the previous location no longer exists.
2019-01-11 09:39:27 -08:00
Alan Rominger
be5b7889f9 Do not load user kube config if path specified (#49952) 2019-01-11 17:26:53 +00:00
hyperized
64bacb0e02 Setup TLS integration test for RabbitMQ (#50363)
* Make TLS available for RabbitMQ

* Use correct path

* Include cleanup

* Also remove unused package

* Don't generate a TLS cert every time if one already has been generated

* Add newlines, clean up repository and clarify block purpose

* One too many new lines :)

* Make TLS certs static
2019-01-11 17:25:04 +00:00
Roberto Polli
caa0c9d4cc Fixes #25725: strip quotes from lsb_release and distribution description. (#31143) 2019-01-11 12:07:26 -05:00
Abhijeet Kasurde
af914695e6
VMware: Fix vmware_vm_inventory (#50592)
* Added documentation around using vmware dynamic inventory plugin
* Fixed bug for populating host_ip in hostvars for given inventory host
* VMware: Add properties in vmware_vm_inventory

Fixes: #50249

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-01-11 21:33:14 +05:30
Abhijeet Kasurde
db8702cdb8 Close all open filehandle (#50544)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-01-11 10:14:08 -05:00
Dhanuka
94a1d86d70 redfish_utils: fix reference to local variable 'systems_service' (#50298)
* fixes issue 50296

* fixes the indentation of the return statement

* Adds a conditional test into `_find_systems_resource()` to check the existence
of the Members of System resource

* updates the error message

* harden the conditional test

* Add a changelog
2019-01-11 14:16:20 +00:00
James E. King III
1ae365c112 azure_rm_managed_disk: properly handle os_type on creation and update (#49385) 2019-01-11 22:09:26 +08:00
Ricardo Carrillo Cruz
22c1c5ffcb
Add docstrings (#49934) 2019-01-11 12:45:59 +01:00
Ricardo Carrillo Cruz
577765592a
Checkpoint task facts (#49932)
* Add docstrings

* Fix pep8
2019-01-11 12:33:06 +01:00
getjack
d8d1ddc35d Added Ansible UTM Module for managing network/interface_address objects. (#49864)
* Added Ansible UTM Module for managing network/interface_address objects.

* - Fix sanity checks
  - Fixed documentation trailing whitespaces
  - Added missing documentation

* - Fix sanity checks
  - Removed duplicate documentation
2019-01-11 11:27:41 +00:00
Ricardo Carrillo Cruz
8ec69e4464
Checkpoint host facts (#49935)
* Add checkpoint_host_facts module

* Rebase with devel and add docstrings
2019-01-11 11:36:09 +01:00
Ricardo Carrillo Cruz
12e0da4f20
Checkpoint access rule facts (#49933)
* Add checkpoint access rule facts module

* Add docstrings and rebase with devel

* Add ANSIBLE_METADATA
2019-01-11 11:36:02 +01:00
Satyajit Bulage
13d94ed681 Update filter documentation (#50255)
Added documentation for following filters -

* Product
* human_readable
* human_to_bytes

Signed-off-by: Satyajit Bulage <sbulage@redhat.com>
2019-01-11 15:09:42 +05:30
traittinen
d3107d9915 Improve panos_commit module (#50451)
* Added description, admin commit and VSYS commit features.

* pep8 fixing

* Ansible pylint fixing + module.fail on commit fail

* Ported from lxml.etree to xml.etree. Changed username to fall back to admin if nothing else defined.

* Fixed documentation for username defaults.
2019-01-11 04:26:40 -05:00
Brian Coca
91d8383898 added missing docs for option in acl module (#50775)
* added missing docs for option in acl module
* remove acl from ignore
2019-01-11 09:49:43 +01:00
Yuwei Zhou
0f6252baf3 dns zone enhancement and return curated value (#50740) 2019-01-11 16:38:29 +08:00